Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-19 Thread Guangya Liu
> On 一月 19, 2016, 11:34 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 676 > > > > > > I see several places where you overwrite changes from this review in > > the subsequent two. Did

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/#review115279 --- Is there some reason why you've split up these reviews into three p

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 14, 2016, 12:44 p.m.) Review request for mesos, Ben Mahler, Artem H

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-13 Thread Guangya Liu
> On 一月 14, 2016, 5:14 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 732-737 > > > > > > Update the comments to list cases, for example: > > 1. if new `reserved.stateless` > old, pa

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-13 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/#review114394 --- src/master/allocator/mesos/hierarchical.cpp (line 677)

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 13, 2016, 12:58 p.m.) Review request for mesos, Ben Mahler, Artem H

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 13, 2016, 2:53 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

2016-01-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 13, 2016, 2:37 a.m.) Review request for mesos, Ben Mahler, Artem Ha