[GitHub] [spark] luhenry commented on a change in pull request #32253: [SPARK-35150][ML] Accelerate fallback BLAS with dev.ludovic.netlib

2021-04-20 Thread GitBox
luhenry commented on a change in pull request #32253: URL: https://github.com/apache/spark/pull/32253#discussion_r617003887 ## File path: graphx/pom.xml ## @@ -60,9 +60,8 @@ guava - com.github.fommil.netlib - core - ${netlib.java.version} +

[GitHub] [spark] SparkQA commented on pull request #32260: [SPARK-35152][SQL] ANSI mode: IntegralDivide throws exception on overflow

2021-04-20 Thread GitBox
SparkQA commented on pull request #32260: URL: https://github.com/apache/spark/pull/32260#issuecomment-823591112 **[Test build #137696 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137696/testReport)** for PR 32260 at commit [`9ade940`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32260: [SPARK-35152][SQL] ANSI mode: IntegralDivide throws exception on overflow

2021-04-20 Thread GitBox
SparkQA removed a comment on pull request #32260: URL: https://github.com/apache/spark/pull/32260#issuecomment-823410583 **[Test build #137696 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137696/testReport)** for PR 32260 at commit [`9ade940`](https://gi

[GitHub] [spark] srowen commented on a change in pull request #32253: [SPARK-35150][ML] Accelerate fallback BLAS with dev.ludovic.netlib

2021-04-20 Thread GitBox
srowen commented on a change in pull request #32253: URL: https://github.com/apache/spark/pull/32253#discussion_r617024314 ## File path: graphx/pom.xml ## @@ -60,9 +60,8 @@ guava - com.github.fommil.netlib - core - ${netlib.java.version} +

[GitHub] [spark] AmplabJenkins commented on pull request #32260: [SPARK-35152][SQL] ANSI mode: IntegralDivide throws exception on overflow

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32260: URL: https://github.com/apache/spark/pull/32260#issuecomment-823598378 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137696/ -- This

[GitHub] [spark] sigmod commented on pull request #32247: [SPARK-35075][SQL] Add traversal pruning for subquery related rules

2021-04-20 Thread GitBox
sigmod commented on pull request #32247: URL: https://github.com/apache/spark/pull/32247#issuecomment-823598987 @hvanhovell @gengliangwang @dbaliafroozeh @maryannxue this PR is ready for review. Let me know if you have any questions. -- This is an automated message from the Apache Git S

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32260: [SPARK-35152][SQL] ANSI mode: IntegralDivide throws exception on overflow

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32260: URL: https://github.com/apache/spark/pull/32260#issuecomment-823598378 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137696/ -

[GitHub] [spark] viirya commented on pull request #32256: [SPARK-31225][SQL][2.4] Override sql method of OuterReference

2021-04-20 Thread GitBox
viirya commented on pull request #32256: URL: https://github.com/apache/spark/pull/32256#issuecomment-823602006 Seems there is still other error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] SparkQA commented on pull request #32210: [SPARK-32634][SQL] Introduce sort-based fallback for shuffled hash join (non-code-gen path)

2021-04-20 Thread GitBox
SparkQA commented on pull request #32210: URL: https://github.com/apache/spark/pull/32210#issuecomment-823601974 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42231/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32210: [SPARK-32634][SQL] Introduce sort-based fallback for shuffled hash join (non-code-gen path)

2021-04-20 Thread GitBox
SparkQA commented on pull request #32210: URL: https://github.com/apache/spark/pull/32210#issuecomment-823604204 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42231/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #32210: [SPARK-32634][SQL] Introduce sort-based fallback for shuffled hash join (non-code-gen path)

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32210: URL: https://github.com/apache/spark/pull/32210#issuecomment-823604225 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42231/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32210: [SPARK-32634][SQL] Introduce sort-based fallback for shuffled hash join (non-code-gen path)

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32210: URL: https://github.com/apache/spark/pull/32210#issuecomment-823604225 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42231/

[GitHub] [spark] SparkQA commented on pull request #32260: [SPARK-35152][SQL] ANSI mode: IntegralDivide throws exception on overflow

2021-04-20 Thread GitBox
SparkQA commented on pull request #32260: URL: https://github.com/apache/spark/pull/32260#issuecomment-823606444 **[Test build #137697 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137697/testReport)** for PR 32260 at commit [`64f1431`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32260: [SPARK-35152][SQL] ANSI mode: IntegralDivide throws exception on overflow

2021-04-20 Thread GitBox
SparkQA removed a comment on pull request #32260: URL: https://github.com/apache/spark/pull/32260#issuecomment-823449102 **[Test build #137697 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137697/testReport)** for PR 32260 at commit [`64f1431`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #32260: [SPARK-35152][SQL] ANSI mode: IntegralDivide throws exception on overflow

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32260: URL: https://github.com/apache/spark/pull/32260#issuecomment-823607395 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137697/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32260: [SPARK-35152][SQL] ANSI mode: IntegralDivide throws exception on overflow

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32260: URL: https://github.com/apache/spark/pull/32260#issuecomment-823607395 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137697/ -

[GitHub] [spark] SparkQA commented on pull request #32082: [SPARK-34981][SQL] Implement V2 function resolution and evaluation

2021-04-20 Thread GitBox
SparkQA commented on pull request #32082: URL: https://github.com/apache/spark/pull/32082#issuecomment-823608149 **[Test build #137699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137699/testReport)** for PR 32082 at commit [`b08c814`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32082: [SPARK-34981][SQL] Implement V2 function resolution and evaluation

2021-04-20 Thread GitBox
SparkQA removed a comment on pull request #32082: URL: https://github.com/apache/spark/pull/32082#issuecomment-823449486 **[Test build #137699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137699/testReport)** for PR 32082 at commit [`b08c814`](https://gi

[GitHub] [spark] tgravescs commented on pull request #32195: [SPARK-35093] [SQL] AQE now respects supportsColumnar when attempting to reuse exchanges

2021-04-20 Thread GitBox
tgravescs commented on pull request #32195: URL: https://github.com/apache/spark/pull/32195#issuecomment-823625374 so I was looking at this today and I think its fairly easy fix to just to change it to store the plan after its been through all the rules. `val queryStage = context.

[GitHub] [spark] AmplabJenkins commented on pull request #32082: [SPARK-34981][SQL] Implement V2 function resolution and evaluation

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32082: URL: https://github.com/apache/spark/pull/32082#issuecomment-823628524 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137699/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32082: [SPARK-34981][SQL] Implement V2 function resolution and evaluation

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32082: URL: https://github.com/apache/spark/pull/32082#issuecomment-823628524 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137699/ -

[GitHub] [spark] SparkQA commented on pull request #32263: [SPARK-35044][SQL][FOLLOWUP][test-hadoop2.7] Fix hadoop 2.7 test due to diff between hadoop 2.7 and hadoop 3

2021-04-20 Thread GitBox
SparkQA commented on pull request #32263: URL: https://github.com/apache/spark/pull/32263#issuecomment-823630116 **[Test build #137700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137700/testReport)** for PR 32263 at commit [`47e1e90`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32263: [SPARK-35044][SQL][FOLLOWUP][test-hadoop2.7] Fix hadoop 2.7 test due to diff between hadoop 2.7 and hadoop 3

2021-04-20 Thread GitBox
SparkQA removed a comment on pull request #32263: URL: https://github.com/apache/spark/pull/32263#issuecomment-823488994 **[Test build #137700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137700/testReport)** for PR 32263 at commit [`47e1e90`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #32263: [SPARK-35044][SQL][FOLLOWUP][test-hadoop2.7] Fix hadoop 2.7 test due to diff between hadoop 2.7 and hadoop 3

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32263: URL: https://github.com/apache/spark/pull/32263#issuecomment-823631135 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137700/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32263: [SPARK-35044][SQL][FOLLOWUP][test-hadoop2.7] Fix hadoop 2.7 test due to diff between hadoop 2.7 and hadoop 3

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32263: URL: https://github.com/apache/spark/pull/32263#issuecomment-823631135 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137700/ -

[GitHub] [spark] luhenry commented on a change in pull request #32253: [SPARK-35150][ML] Accelerate fallback BLAS with dev.ludovic.netlib

2021-04-20 Thread GitBox
luhenry commented on a change in pull request #32253: URL: https://github.com/apache/spark/pull/32253#discussion_r617071851 ## File path: graphx/pom.xml ## @@ -60,9 +60,8 @@ guava - com.github.fommil.netlib - core - ${netlib.java.version} +

[GitHub] [spark] luhenry commented on a change in pull request #32253: [SPARK-35150][ML] Accelerate fallback BLAS with dev.ludovic.netlib

2021-04-20 Thread GitBox
luhenry commented on a change in pull request #32253: URL: https://github.com/apache/spark/pull/32253#discussion_r617071851 ## File path: graphx/pom.xml ## @@ -60,9 +60,8 @@ guava - com.github.fommil.netlib - core - ${netlib.java.version} +

[GitHub] [spark] SparkQA commented on pull request #32262: [SPARK-35153][SQL] Make textual representation of ANSI interval operators more readable

2021-04-20 Thread GitBox
SparkQA commented on pull request #32262: URL: https://github.com/apache/spark/pull/32262#issuecomment-823638600 **[Test build #137701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137701/testReport)** for PR 32262 at commit [`9bdfe66`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32262: [SPARK-35153][SQL] Make textual representation of ANSI interval operators more readable

2021-04-20 Thread GitBox
SparkQA removed a comment on pull request #32262: URL: https://github.com/apache/spark/pull/32262#issuecomment-823488960 **[Test build #137701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137701/testReport)** for PR 32262 at commit [`9bdfe66`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32247: [SPARK-35075][SQL] Add traversal pruning for subquery related rules

2021-04-20 Thread GitBox
SparkQA commented on pull request #32247: URL: https://github.com/apache/spark/pull/32247#issuecomment-823640565 **[Test build #137702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137702/testReport)** for PR 32247 at commit [`801bcde`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32247: [SPARK-35075][SQL] Add traversal pruning for subquery related rules

2021-04-20 Thread GitBox
SparkQA removed a comment on pull request #32247: URL: https://github.com/apache/spark/pull/32247#issuecomment-823489145 **[Test build #137702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137702/testReport)** for PR 32247 at commit [`801bcde`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #32262: [SPARK-35153][SQL] Make textual representation of ANSI interval operators more readable

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32262: URL: https://github.com/apache/spark/pull/32262#issuecomment-823656510 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137701/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32247: [SPARK-35075][SQL] Add traversal pruning for subquery related rules

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32247: URL: https://github.com/apache/spark/pull/32247#issuecomment-823656509 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137702/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32247: [SPARK-35075][SQL] Add traversal pruning for subquery related rules

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32247: URL: https://github.com/apache/spark/pull/32247#issuecomment-823656509 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137702/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32262: [SPARK-35153][SQL] Make textual representation of ANSI interval operators more readable

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32262: URL: https://github.com/apache/spark/pull/32262#issuecomment-823656510 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137701/ -

[GitHub] [spark] luhenry commented on pull request #30810: [SPARK-33882][ML] Add a vectorized BLAS implementation

2021-04-20 Thread GitBox
luhenry commented on pull request #30810: URL: https://github.com/apache/spark/pull/30810#issuecomment-823660970 > > Late LGTM. > > BTW, I am not familiar with the new vector api, is it possible to apply it in BLAS for sparse vec/mat? > > This vector API provides access to hardwar

[GitHub] [spark] luhenry edited a comment on pull request #30810: [SPARK-33882][ML] Add a vectorized BLAS implementation

2021-04-20 Thread GitBox
luhenry edited a comment on pull request #30810: URL: https://github.com/apache/spark/pull/30810#issuecomment-823660970 > > Late LGTM. > > BTW, I am not familiar with the new vector api, is it possible to apply it in BLAS for sparse vec/mat? > > This vector API provides access to

[GitHub] [spark] srowen closed pull request #32227: [SPARK-35132][BUILD][CORE] Upgrade netty-all to 4.1.63.Final

2021-04-20 Thread GitBox
srowen closed pull request #32227: URL: https://github.com/apache/spark/pull/32227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] srowen commented on pull request #32227: [SPARK-35132][BUILD][CORE] Upgrade netty-all to 4.1.63.Final

2021-04-20 Thread GitBox
srowen commented on pull request #32227: URL: https://github.com/apache/spark/pull/32227#issuecomment-823665244 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [spark] SparkQA commented on pull request #32247: [SPARK-35075][SQL] Add traversal pruning for subquery related rules

2021-04-20 Thread GitBox
SparkQA commented on pull request #32247: URL: https://github.com/apache/spark/pull/32247#issuecomment-823665537 **[Test build #137703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137703/testReport)** for PR 32247 at commit [`c6b97c4`](https://github.co

[GitHub] [spark] srowen commented on a change in pull request #32253: [SPARK-35150][ML] Accelerate fallback BLAS with dev.ludovic.netlib

2021-04-20 Thread GitBox
srowen commented on a change in pull request #32253: URL: https://github.com/apache/spark/pull/32253#discussion_r617099199 ## File path: mllib/pom.xml ## @@ -142,20 +142,20 @@ test + + dev.ludovic.netlib + blas + + + dev.ludovic.netlib

[GitHub] [spark] SparkQA removed a comment on pull request #32247: [SPARK-35075][SQL] Add traversal pruning for subquery related rules

2021-04-20 Thread GitBox
SparkQA removed a comment on pull request #32247: URL: https://github.com/apache/spark/pull/32247#issuecomment-823529270 **[Test build #137703 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137703/testReport)** for PR 32247 at commit [`c6b97c4`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #32247: [SPARK-35075][SQL] Add traversal pruning for subquery related rules

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32247: URL: https://github.com/apache/spark/pull/32247#issuecomment-823678277 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137703/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32247: [SPARK-35075][SQL] Add traversal pruning for subquery related rules

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32247: URL: https://github.com/apache/spark/pull/32247#issuecomment-823678277 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137703/ -

[GitHub] [spark] maropu commented on a change in pull request #31010: [SPARK-33976][SQL][DOCS] Add a SQL doc page for a TRANSFORM clause

2021-04-20 Thread GitBox
maropu commented on a change in pull request #31010: URL: https://github.com/apache/spark/pull/31010#discussion_r617111765 ## File path: docs/sql-ref-syntax-qry-select-transform.md ## @@ -0,0 +1,235 @@ +--- +layout: global +title: TRANSFORM +displayTitle: TRANSFORM +license: |

[GitHub] [spark] hiboyang commented on pull request #31876: [SPARK-34942][API][CORE] Abstract Location in MapStatus to enable support for custom storage

2021-04-20 Thread GitBox
hiboyang commented on pull request #31876: URL: https://github.com/apache/spark/pull/31876#issuecomment-823679907 Thanks @Ngone51 for the change with ExecutorLocation/HostLocation. It looks great to me! -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [spark] HyukjinKwon commented on pull request #32258: [SPARK-35120][INFRA][FOLLOW-UP] Try catch an error to show the correct guidance

2021-04-20 Thread GitBox
HyukjinKwon commented on pull request #32258: URL: https://github.com/apache/spark/pull/32258#issuecomment-823679882 cc @gengliangwang too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32261: [SPARK-35151][BUILD] Add compile arg to suppress `symbol literal is deprecated` compilation warnings in Scala 2.13

2021-04-20 Thread GitBox
HyukjinKwon commented on a change in pull request #32261: URL: https://github.com/apache/spark/pull/32261#discussion_r617113210 ## File path: pom.xml ## @@ -3369,6 +3369,7 @@ -Wconf:msg=Auto-application to \`\(\)\` is deprecated:s -Wconf:m

[GitHub] [spark] HyukjinKwon closed pull request #32263: [SPARK-35044][SQL][FOLLOWUP][test-hadoop2.7] Fix hadoop 2.7 test due to diff between hadoop 2.7 and hadoop 3

2021-04-20 Thread GitBox
HyukjinKwon closed pull request #32263: URL: https://github.com/apache/spark/pull/32263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [spark] HyukjinKwon commented on pull request #32263: [SPARK-35044][SQL][FOLLOWUP][test-hadoop2.7] Fix hadoop 2.7 test due to diff between hadoop 2.7 and hadoop 3

2021-04-20 Thread GitBox
HyukjinKwon commented on pull request #32263: URL: https://github.com/apache/spark/pull/32263#issuecomment-823681119 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [spark] HyukjinKwon commented on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
HyukjinKwon commented on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823681401 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823027364 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [spark] HyukjinKwon commented on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
HyukjinKwon commented on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823681640 @hddong can you retrigger https://github.com/hddong/spark/actions/runs/766140297? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] maropu commented on a change in pull request #32239: [SPARK-34639][SQL][3.1] RelationalGroupedDataset.alias should not create UnresolvedAlias

2021-04-20 Thread GitBox
maropu commented on a change in pull request #32239: URL: https://github.com/apache/spark/pull/32239#discussion_r617114599 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3596,6 +3596,9 @@ class SQLQuerySuite extends QueryTest with SharedS

[GitHub] [spark] SparkQA commented on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
SparkQA commented on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823682380 **[Test build #137704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137704/testReport)** for PR 32248 at commit [`cec327b`](https://github.com

[GitHub] [spark] maropu commented on pull request #32239: [SPARK-34639][SQL][3.1] RelationalGroupedDataset.alias should not create UnresolvedAlias

2021-04-20 Thread GitBox
maropu commented on pull request #32239: URL: https://github.com/apache/spark/pull/32239#issuecomment-823682733 Merged to branch-3.1. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] maropu closed pull request #32239: [SPARK-34639][SQL][3.1] RelationalGroupedDataset.alias should not create UnresolvedAlias

2021-04-20 Thread GitBox
maropu closed pull request #32239: URL: https://github.com/apache/spark/pull/32239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] github-actions[bot] closed pull request #30374: [WIP][SPARK-33444][ML] Added support for Initial model in Gaussian Mixture Model in ML

2021-04-20 Thread GitBox
github-actions[bot] closed pull request #30374: URL: https://github.com/apache/spark/pull/30374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [spark] c21 commented on a change in pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

2021-04-20 Thread GitBox
c21 commented on a change in pull request #32242: URL: https://github.com/apache/spark/pull/32242#discussion_r617125855 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala ## @@ -87,6 +87,18 @@ class RowBasedHashMapGene

[GitHub] [spark] c21 commented on a change in pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

2021-04-20 Thread GitBox
c21 commented on a change in pull request #32242: URL: https://github.com/apache/spark/pull/32242#discussion_r617126392 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -687,40 +725,59 @@ case class HashAggregateExec(

[GitHub] [spark] c21 commented on a change in pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

2021-04-20 Thread GitBox
c21 commented on a change in pull request #32242: URL: https://github.com/apache/spark/pull/32242#discussion_r617126530 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -687,40 +725,59 @@ case class HashAggregateExec(

[GitHub] [spark] c21 commented on a change in pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

2021-04-20 Thread GitBox
c21 commented on a change in pull request #32242: URL: https://github.com/apache/spark/pull/32242#discussion_r617128576 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -687,40 +725,59 @@ case class HashAggregateExec(

[GitHub] [spark] c21 commented on a change in pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

2021-04-20 Thread GitBox
c21 commented on a change in pull request #32242: URL: https://github.com/apache/spark/pull/32242#discussion_r617126392 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -687,40 +725,59 @@ case class HashAggregateExec(

[GitHub] [spark] SethTisue commented on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-04-20 Thread GitBox
SethTisue commented on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-823698612 > If the language import feature for symbol literal will be always there As I understand it, the language import was added to give the Spark project extra time to migrat

[GitHub] [spark] SparkQA commented on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
SparkQA commented on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823698806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] AmplabJenkins commented on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823700901 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42232/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823700901 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42232/

[GitHub] [spark] SparkQA commented on pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

2021-04-20 Thread GitBox
SparkQA commented on pull request #32242: URL: https://github.com/apache/spark/pull/32242#issuecomment-823701221 **[Test build #137705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137705/testReport)** for PR 32242 at commit [`917e7bb`](https://github.com

[GitHub] [spark] WeichenXu123 commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-20 Thread GitBox
WeichenXu123 commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r617131553 ## File path: python/pyspark/ml/tests/test_algorithms.py ## @@ -115,6 +115,7 @@ def test_output_columns(self): model = ovr.fit(df)

[GitHub] [spark] SparkQA commented on pull request #32177: [SPARK-34999][PYTHON] Consolidate PySpark testing utils

2021-04-20 Thread GitBox
SparkQA commented on pull request #32177: URL: https://github.com/apache/spark/pull/32177#issuecomment-823701287 **[Test build #137706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137706/testReport)** for PR 32177 at commit [`4be5e72`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31993: [SPARK-34897][SQL] Support reconcile schemas based on index after nested column pruning

2021-04-20 Thread GitBox
SparkQA commented on pull request #31993: URL: https://github.com/apache/spark/pull/31993#issuecomment-823701348 **[Test build #137707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137707/testReport)** for PR 31993 at commit [`6112c9d`](https://github.com

[GitHub] [spark] WeichenXu123 commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-20 Thread GitBox
WeichenXu123 commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r617131801 ## File path: python/pyspark/ml/tests/test_algorithms.py ## @@ -115,6 +115,7 @@ def test_output_columns(self): model = ovr.fit(df)

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-20 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r617135442 ## File path: python/pyspark/ml/tests/test_algorithms.py ## @@ -115,6 +115,7 @@ def test_output_columns(self): model = ovr.fit(df) output

[GitHub] [spark] c21 commented on a change in pull request #32198: [SPARK-26164][SQL] Allow concurrent writers for writing dynamic partitions and bucket table

2021-04-20 Thread GitBox
c21 commented on a change in pull request #32198: URL: https://github.com/apache/spark/pull/32198#discussion_r617137223 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala ## @@ -247,34 +290,168 @@ class DynamicPartitionD

[GitHub] [spark] c21 commented on a change in pull request #32198: [SPARK-26164][SQL] Allow concurrent writers for writing dynamic partitions and bucket table

2021-04-20 Thread GitBox
c21 commented on a change in pull request #32198: URL: https://github.com/apache/spark/pull/32198#discussion_r617137444 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatDataWriter.scala ## @@ -247,34 +290,168 @@ class DynamicPartitionD

[GitHub] [spark] ulysses-you commented on pull request #31653: [SPARK-33832][SQL] v2. move OptimzieSkewedJoin to query stage preparation

2021-04-20 Thread GitBox
ulysses-you commented on pull request #31653: URL: https://github.com/apache/spark/pull/31653#issuecomment-823707302 We found the same issue about failed to optimize skewed join due to the extra shuffle. Before submit a ticket, I just found this PR and [#30829](https://github.com/apache/sp

[GitHub] [spark] Yikun commented on pull request #32246: [SPARK-35143][ML] Simplify Python for loop code

2021-04-20 Thread GitBox
Yikun commented on pull request #32246: URL: https://github.com/apache/spark/pull/32246#issuecomment-823709270 @ChenDou2021 Hi, thanks for the contributions, as mentioned from @HyukjinKwon , the changes in your patch are all coding style preference (also, there were some pros and cons disc

[GitHub] [spark] ChenDou2021 commented on pull request #32246: [SPARK-35143][ML] Simplify Python for loop code

2021-04-20 Thread GitBox
ChenDou2021 commented on pull request #32246: URL: https://github.com/apache/spark/pull/32246#issuecomment-823709828 ok,I know,thanks -- 原始邮件 -- 发件人: "Yikun ***@***.***>; 发送时间: 2021年4月21日(星期三) 上午9:30 收件人: ***@***.***>; 抄送: ***@

[GitHub] [spark] SparkQA commented on pull request #32177: [SPARK-34999][PYTHON] Consolidate PySpark testing utils

2021-04-20 Thread GitBox
SparkQA commented on pull request #32177: URL: https://github.com/apache/spark/pull/32177#issuecomment-823710538 **[Test build #137706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137706/testReport)** for PR 32177 at commit [`4be5e72`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #32177: [SPARK-34999][PYTHON] Consolidate PySpark testing utils

2021-04-20 Thread GitBox
SparkQA removed a comment on pull request #32177: URL: https://github.com/apache/spark/pull/32177#issuecomment-823701287 **[Test build #137706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137706/testReport)** for PR 32177 at commit [`4be5e72`](https://gi

[GitHub] [spark] Yikun commented on pull request #32246: [SPARK-35143][ML] Simplify Python for loop code

2021-04-20 Thread GitBox
Yikun commented on pull request #32246: URL: https://github.com/apache/spark/pull/32246#issuecomment-823713170 > @ChenDou2021 ok,I know,thanks And much thanks your first step in Spark community, feel free to open the next PR if you find to other improvements. -- This is an automat

[GitHub] [spark] Yikun edited a comment on pull request #32246: [SPARK-35143][ML] Simplify Python for loop code

2021-04-20 Thread GitBox
Yikun edited a comment on pull request #32246: URL: https://github.com/apache/spark/pull/32246#issuecomment-823713170 > @ChenDou2021 ok,I know,thanks And much thanks your first step in Spark community, feel free to open the next PR if you find some other improvements. -- This is a

[GitHub] [spark] SparkQA commented on pull request #31993: [SPARK-34897][SQL] Support reconcile schemas based on index after nested column pruning

2021-04-20 Thread GitBox
SparkQA commented on pull request #31993: URL: https://github.com/apache/spark/pull/31993#issuecomment-823715879 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42235/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32177: [SPARK-34999][PYTHON] Consolidate PySpark testing utils

2021-04-20 Thread GitBox
SparkQA commented on pull request #32177: URL: https://github.com/apache/spark/pull/32177#issuecomment-823716835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [spark] SparkQA commented on pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

2021-04-20 Thread GitBox
SparkQA commented on pull request #32242: URL: https://github.com/apache/spark/pull/32242#issuecomment-823717076 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42233/ -- This

[GitHub] [spark] SparkQA commented on pull request #31993: [SPARK-34897][SQL] Support reconcile schemas based on index after nested column pruning

2021-04-20 Thread GitBox
SparkQA commented on pull request #31993: URL: https://github.com/apache/spark/pull/31993#issuecomment-823717509 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42235/ -- This is an automated message from the A

[GitHub] [spark] HyukjinKwon removed a comment on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
HyukjinKwon removed a comment on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823681401 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [spark] HyukjinKwon commented on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
HyukjinKwon commented on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823717673 cc @wangyum FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins commented on pull request #32177: [SPARK-34999][PYTHON] Consolidate PySpark testing utils

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32177: URL: https://github.com/apache/spark/pull/32177#issuecomment-823719173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31993: [SPARK-34897][SQL] Support reconcile schemas based on index after nested column pruning

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #31993: URL: https://github.com/apache/spark/pull/31993#issuecomment-823719172 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42235/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32242: URL: https://github.com/apache/spark/pull/32242#issuecomment-823719171 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42233/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32177: [SPARK-34999][PYTHON] Consolidate PySpark testing utils

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32177: URL: https://github.com/apache/spark/pull/32177#issuecomment-823719173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #32242: [SPARK-35141][SQL] Support two level of hash maps for final hash aggregation

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #32242: URL: https://github.com/apache/spark/pull/32242#issuecomment-823719171 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42233/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #31993: [SPARK-34897][SQL] Support reconcile schemas based on index after nested column pruning

2021-04-20 Thread GitBox
AmplabJenkins commented on pull request #31993: URL: https://github.com/apache/spark/pull/31993#issuecomment-823719172 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42235/ -- T

[GitHub] [spark] SparkQA commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-20 Thread GitBox
SparkQA commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-823720317 **[Test build #137708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137708/testReport)** for PR 32245 at commit [`b6fabb3`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-20 Thread GitBox
AmplabJenkins removed a comment on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-823066628 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [spark] wangyum commented on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

2021-04-20 Thread GitBox
wangyum commented on pull request #32248: URL: https://github.com/apache/spark/pull/32248#issuecomment-823721949 Yes. We already have `-S` mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] sandeep-katta edited a comment on pull request #32194: [SPARK-35096][SQL] SchemaPruning should adhere spark.sql.caseSensitive config

2021-04-20 Thread GitBox
sandeep-katta edited a comment on pull request #32194: URL: https://github.com/apache/spark/pull/32194#issuecomment-823261848 @dongjoon-hyun @viirya , can this PR be merged ?. If not, I am happy to address review comments if there are any -- This is an automated message from the Apache

[GitHub] [spark] AngersZhuuuu commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

2021-04-20 Thread GitBox
AngersZh commented on pull request #32259: URL: https://github.com/apache/spark/pull/32259#issuecomment-823724205 > Could you add comments about ANSI types like > > https://github.com/apache/spark/blob/0945baf90660a101ae0f86a39d4c91ca74ae5ee3/sql/catalyst/src/main/scala/org/apach

[GitHub] [spark] SparkQA commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

2021-04-20 Thread GitBox
SparkQA commented on pull request #32259: URL: https://github.com/apache/spark/pull/32259#issuecomment-823724338 **[Test build #137709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137709/testReport)** for PR 32259 at commit [`ac51cf6`](https://github.com

<    1   2   3   4   5   6   >