xianyinxin commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for
DataSource V2
URL: https://github.com/apache/spark/pull/25626#issuecomment-533959893
Ok, it looks a nice plan. I'll update the code soon.
This is
xianyinxin commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for
DataSource V2
URL: https://github.com/apache/spark/pull/25626#issuecomment-531479558
@rdblue , thank you very much for your valuable comments.
> Implementations that call into Spark would not share code (or,
xianyinxin commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for
DataSource V2
URL: https://github.com/apache/spark/pull/25626#issuecomment-530662601
@rdblue, JDBC is the most important use case for this API I've seen. The
building of this API for JDBC is not started yet, as
xianyinxin commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for
DataSource V2
URL: https://github.com/apache/spark/pull/25626#issuecomment-530425287
Seems the test failure is not introduced by this pr.
This is
xianyinxin commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for
DataSource V2
URL: https://github.com/apache/spark/pull/25626#issuecomment-529989458
Thank you very much @rdblue . What you comments are exactly right, here the
API is just a kind of "push-down" API. We also c
xianyinxin commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for
DataSource V2
URL: https://github.com/apache/spark/pull/25626#issuecomment-527759665
> @xianyinxin, can you explain the required semantics for your proposed API?
>
> ```
> void updateWhere(Map sets, Fi
xianyinxin commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for
DataSource V2
URL: https://github.com/apache/spark/pull/25626#issuecomment-527123585
> The test coverage is not good enough. For example, all the test cases are
just updating a single column? Try to check the t
xianyinxin commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for
DataSource V2
URL: https://github.com/apache/spark/pull/25626#issuecomment-526436021
cc @cloud-fan @rdblue
This is an automated message from the