Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16736
BTW, you need to update the PR title and description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16736
Overall, looks good to me. cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72183/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72183/testReport)**
for PR 16736 at commit
[`9614ff3`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72183/testReport)**
for PR 16736 at commit
[`9614ff3`](https://github.com/apache/spark/commit/96
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72158/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72158 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72158/testReport)**
for PR 16736 at commit
[`6f9a2db`](https://github.com/apache/spark/commit/6
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/16736
tests passed for the default `maxSize = 1000`
now let's test against `maxSize = 1`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72158 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72158/testReport)**
for PR 16736 at commit
[`6f9a2db`](https://github.com/apache/spark/commit/6f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72151/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72151 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72151/testReport)**
for PR 16736 at commit
[`f361ff9`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72151 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72151/testReport)**
for PR 16736 at commit
[`f361ff9`](https://github.com/apache/spark/commit/f3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72150/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72150 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72150/testReport)**
for PR 16736 at commit
[`b988bf4`](https://github.com/apache/spark/commit/b
Github user lw-lin commented on the issue:
https://github.com/apache/spark/pull/16736
@gatorsmile fairly good point and thanks for the clarification!
- [Guava checks that maxSize >= 0 must
holds](https://github.com/google/guava/blob/v14.0.1/guava/src/com/google/common/cache/CacheBu
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72150 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72150/testReport)**
for PR 16736 at commit
[`b988bf4`](https://github.com/apache/spark/commit/b9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72146/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16736
Sorry, I might not explain it clearly. When the the cache size is set to
zero, -1, and 1, what happened to our metadata cache system in each case? Does
it work well? Will we get an error message
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72146/testReport)**
for PR 16736 at commit
[`9486b90`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72146/testReport)**
for PR 16736 at commit
[`9486b90`](https://github.com/apache/spark/commit/94
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72139/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72139 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72139/testReport)**
for PR 16736 at commit
[`ffb56d1`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72145 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72145/testReport)**
for PR 16736 at commit
[`44276c8`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16736
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72145/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72145/testReport)**
for PR 16736 at commit
[`44276c8`](https://github.com/apache/spark/commit/44
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16736
Also need to handle the illegal cases and add the test cases to verify it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16736
**[Test build #72139 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72139/testReport)**
for PR 16736 at commit
[`ffb56d1`](https://github.com/apache/spark/commit/ff
34 matches
Mail list logo
