[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2015-02-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2015-01-07 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-69116580 I would recommend that we close this PR for now until we file a corresponding JIRA that describes the issue. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-12-10 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-66516901 I see. I think the complexity in merging multiple properties file arises when you have the same configs declared in two properties files. What is the expected

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-12-09 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-66398025 I agree. Would you mind closing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-12-09 Thread lvsoft
Github user lvsoft commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-66404194 Sorry for late reply. I'll explain the use cases for multiple properties files. Currently I'm working on a benchmark utility for spark. It'll be nature to

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-12-09 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-66404521 In your case, why don't just add common properties into private config and set a seperate propertiy file for each workload? Why would the tmp conf file be

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-12-09 Thread lvsoft
Github user lvsoft commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-66405387 Well, that's called separated property files, not *common* properties. It'll be hard to adjust common properties and easy to make mistakes. Delete tmp files

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-12-09 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-66408350 As Patrick said, this will make confiugration more complex than more elegant. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-12-09 Thread lvsoft
Github user lvsoft commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-66414770 Well, I can't understand what's the complexity of this PR. I've reviewed the SPARK-3779 marked as related and didn't find something related to this patch. And, this

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-11-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-64916925 Hi @lvsoft - it was not in the design of this component to support multiple files, and I'd prefer not to do it. It makes it very hard to reason about the effective

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-11-26 Thread lvsoft
GitHub user lvsoft opened a pull request: https://github.com/apache/spark/pull/3490 spark-submit with accept multiple properties-files and merge the values Current ```spark-submit``` accepts only one properties-file, and use ```spark-defaults.conf``` if unspecified. A more

[GitHub] spark pull request: spark-submit with accept multiple properties-f...

2014-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3490#issuecomment-64739092 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your