Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r99075673
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -810,13 +825,43 @@ private[spark] class HiveExternalCatalog(co
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r98327471
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -810,13 +825,43 @@ private[spark] class HiveExternalCatalog(c
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15797
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r87356512
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -231,7 +231,7 @@ class InMemoryCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r87336535
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -810,13 +825,44 @@ private[spark] class HiveExternalCatalog(c
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r87141007
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -810,13 +825,44 @@ private[spark] class HiveExternalCatalog(c
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86946976
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -591,25 +673,25 @@ abstract class ExternalCa
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86936905
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -171,6 +171,10 @@ case class CatalogTable(
th
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86936775
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala
---
@@ -591,25 +673,25 @@ abstract class ExternalC
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86935972
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -451,51 +444,6 @@ object PartitioningUtils {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86908704
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala
---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to th
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86906444
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -810,13 +840,37 @@ private[spark] class HiveExternalCatalog(co
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86906239
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -810,13 +840,37 @@ private[spark] class HiveExternalCatalog(co
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86866556
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -355,25 +355,30 @@ class InMemoryCatalog(
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86872012
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -810,13 +840,37 @@ private[spark] class HiveExternalCatalog(conf:
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86868525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -423,33 +424,35 @@ class InMemoryCatalog(
re
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86871542
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -810,13 +840,37 @@ private[spark] class HiveExternalCatalog(conf:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15797#discussion_r86806933
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -226,106 +208,139 @@ private[spark] class HiveExternalCatalog(
18 matches
Mail list logo
