Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104550722
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsConfSuite.scala
---
@@ -1,64 +0,0 @@
-/*
- * Licensed t
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104550347
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -773,14 +773,20 @@ case class Local
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104550119
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -752,14 +752,14 @@ case class Globa
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104546713
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -773,14 +773,20 @@ case class Local
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104526617
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/BasicStatsEstimationSuite.scala
---
@@ -0,0 +1,121 @@
+/*
+ *
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104281417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -773,14 +773,20 @@ case class LocalLimit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104281282
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -773,14 +773,20 @@ case class LocalL
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104280684
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsConfSuite.scala
---
@@ -1,64 +0,0 @@
-/*
- * Licensed to the
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104280554
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -773,14 +773,20 @@ case class LocalLimit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104232961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -773,14 +773,20 @@ case class LocalL
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104223997
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsConfSuite.scala
---
@@ -1,64 +0,0 @@
-/*
- * Licensed t
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104116975
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsConfSuite.scala
---
@@ -1,64 +0,0 @@
-/*
- * Licensed to the
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104116520
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104116400
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
@@ -116,22 +116,22 @@ class StatisticsCollectionSuite extends
Stat
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104101253
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ---
@@ -116,22 +116,22 @@ class StatisticsCollectionSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104101031
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Lice
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r104100931
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsConfSuite.scala
---
@@ -1,64 +0,0 @@
-/*
- * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r99837596
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -717,7 +717,8 @@ object Limit {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r99838684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -727,37 +728,18 @@ case class GlobalL
Github user ron8hu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r99474494
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala
---
@@ -18,12 +18,41 @@
package org.apach
Github user ron8hu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r98776491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -727,37 +728,18 @@ case class GlobalLimi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r98146358
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -727,37 +728,18 @@ case class GlobalLimi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r98002931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -727,37 +728,18 @@ case class GlobalLimi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97933241
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala
---
@@ -18,12 +18,41 @@
package org.a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97933222
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala
---
@@ -18,12 +18,41 @@
package org.a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97933132
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala
---
@@ -48,6 +77,14 @@ class StatsConfSuit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97933053
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala
---
@@ -48,6 +77,14 @@ class StatsConfSuit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97932867
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/StatsEstimationSuite.scala
---
@@ -18,12 +18,41 @@
package org.a
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97932053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -727,37 +728,18 @@ case class Global
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97932007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -727,37 +728,18 @@ case class Global
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97931646
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -791,12 +773,14 @@ case class Sample
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97931570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -29,6 +31,8 @@ object Esti
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16696#discussion_r97928605
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -727,37 +728,18 @@ case class GlobalLimi
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/16696
[SPARK-19350] [SQL] Cardinality estimation of Limit and Sample
## What changes were proposed in this pull request?
Before this pr, LocalLimit/GlobalLimit/Sample propagates the same row count
35 matches
Mail list logo
