[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-24 Thread xguo27
Github user xguo27 closed the pull request at: https://github.com/apache/spark/pull/9603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-24 Thread xguo27
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159191082 OK, I will close it. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-24 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159190700 I think this message is complete useless. I'd just remove it rather than spending time bickering about the wording. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-23 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159088257 Beyond that, the message is actually somewhat misleading. The "Stopping" message occurs in `stop()`, which is responsible for stopping the messageScheduler, eventPr

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159083050 I just don't see any value. It's obvious that the scheduler is starting / stopping. I just can't imagine anyone finding this message useful. --- If your project is s

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-23 Thread xguo27
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159079918 @andrewor14 What is your take on Jacek's comment? I don't think it's a bad idea to make it more consistent with a matching log message. Please let me know. Thx! --- If

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-17 Thread jaceklaskowski
Github user jaceklaskowski commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-157309968 I don't agree with @andrewor14. It does add a value of being consistent with how Spark informs about its status - if it says "Stopping..." at INFO it should be co

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-16 Thread xguo27
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-157219217 I agree it is trivial, just thought I could quickly add a log statement. If Jacek agrees, I can close those PR. --- If your project is set up for it, you can reply to th

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-12 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-156274315 Meh, I don't really think this is worth doing. It doesn't add any value or fix anything. --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-12 Thread xguo27
Github user xguo27 commented on a diff in the pull request: https://github.com/apache/spark/pull/9603#discussion_r44728655 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -506,6 +506,7 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAl

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-12 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/9603#discussion_r44723534 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -506,6 +506,7 @@ class SparkContext(config: SparkConf) extends Logging with Ex

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-18543 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-10 Thread xguo27
GitHub user xguo27 opened a pull request: https://github.com/apache/spark/pull/9603 [SPARK-11631][Scheduler] Adding 'Starting DAGScheduler' log You can merge this pull request into a Git repository by running: $ git pull https://github.com/xguo27/spark SPARK-11631 Alternative