Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23236
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23236
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23236
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23236
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23159
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23159
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23230
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23232
**[Test build #99716 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99716/testReport)**
for PR 23232 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/23234
cc @cloud-fan @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/23234
[SPARK-26233][SQL][BACKPORT-2.2] CheckOverflow when encoding a decimal value
## What changes were proposed in this pull request?
When we encode a Decimal from external source we don't
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23120
The PR https://github.com/apache/spark/pull/23235 updates the sql migration
guide
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23236
**[Test build #99721 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99721/testReport)**
for PR 23236 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99701/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23207
**[Test build #99722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99722/testReport)**
for PR 23207 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99700/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22683
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23235#discussion_r239049825
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -35,6 +35,8 @@ displayTitle: Spark SQL Upgrading Guide
- Since Spark 3.0, CSV
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23236
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99725/
Test FAILed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23236
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23236
**[Test build #99724 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99724/testReport)**
for PR 23236 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23236
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r239060606
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLShuffleMetricsReporter.scala
---
@@ -95,3 +96,59 @@ private[spark] object
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/22952
@gaborgsomogyi @steveloughran
OK. I'll change the approach to just check against final path for each
moving. As @steveloughran stated, it may bring performance hit for each
checking when
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23236
**[Test build #99727 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99727/testReport)**
for PR 23236 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23218
Ah OK, so all of them were a JVM crash. It would probably be a good idea to
update the JVM on all the workers as _60 is over 3 years old. It's probably not
as simple as it sounds but WDYT
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/23223#discussion_r239070925
--- Diff:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
---
@@ -114,13 +116,20 @@ class
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/23223#discussion_r239059997
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -612,11 +612,14 @@ private[yarn] class
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/23223#discussion_r239052799
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -612,11 +612,14 @@ private[yarn] class
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23222
Jenkins passes, which means the previously added end-to-end test can't not
show the benefit of this rule. We should update it.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23224
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99711/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23224
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r239090244
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLShuffleMetricsReporter.scala
---
@@ -95,3 +96,59 @@ private[spark] object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99707/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23163
**[Test build #99708 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99708/testReport)**
for PR 23163 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23227
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23227
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23227
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23159
**[Test build #99715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99715/testReport)**
for PR 23159 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23159
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23196
**[Test build #99734 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99734/testReport)**
for PR 23196 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23196
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23237
**[Test build #99730 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99730/testReport)**
for PR 23237 at commit
Github user seancxmao closed the pull request at:
https://github.com/apache/spark/pull/22184
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23213
But whole stage codegen will not test `GenerateUnsafeProject`,
`GenerateMutableProject`, etc., right?
---
-
To unsubscribe,
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22184
@srowen Sorry for the late reply! I'd like to close this PR and file a new
one since our SQL doc has changed a lot. Thank you all for your comments and
time!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23163
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/23231
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/23227
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23231
Then let me close this now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23227
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99719/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23223
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23159
jenkins, retest this, please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23223
**[Test build #99733 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99733/testReport)**
for PR 23223 at commit
Github user stczwd commented on a diff in the pull request:
https://github.com/apache/spark/pull/22575#discussion_r239109280
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/SQLStreamingSink.scala
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99713/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23233
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23238
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23196
**[Test build #99714 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99714/testReport)**
for PR 23196 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23196
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99714/
Test PASSed.
---
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/23223#discussion_r239110361
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -612,11 +612,14 @@ private[yarn] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23238
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r239069014
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLShuffleMetricsReporter.scala
---
@@ -95,3 +96,59 @@ private[spark] object
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23229
Agree, this isn't worthwhile.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23228
**[Test build #4453 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4453/testReport)**
for PR 23228 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/23213
yea, I think they're not totally the same..., but I'm not sure that the
test run (`wholeStage=false, factoryMode=CODE_ONLY`) is worth the time cost.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23237
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23237
**[Test build #99730 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99730/testReport)**
for PR 23237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23234
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99718/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23234
**[Test build #99718 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99718/testReport)**
for PR 23234 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/23222
Shall we add a SQL tag to the title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23231
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23213
`wholeStage=false, factoryMode=CODE_ONLY` and `wholeStage=false,
factoryMode=NO_CODEGEN` should have more complete test coverage for
`GenerateUnsafeProject`, `GenerateMutableProject`, etc.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23231
Ok. Maybe we can add few words in ml migration guide to clearly announce
this.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23227
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23227
**[Test build #99731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99731/testReport)**
for PR 23227 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23227
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23233
**[Test build #99717 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99717/testReport)**
for PR 23233 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/23223
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23238
**[Test build #99732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99732/testReport)**
for PR 23238 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23223
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22957
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23238
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/23223
the approach here makes sense. Are you seeing actual issues with this
blacklisting when it shouldn't? I could see that possible there and if so we
should move this to defect and make sure it
Github user stczwd commented on a diff in the pull request:
https://github.com/apache/spark/pull/22575#discussion_r239113033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -631,6 +631,33 @@ object SQLConf {
.intConf
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23238
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99732/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23238
**[Test build #99732 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99732/testReport)**
for PR 23238 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23196
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23237
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user seancxmao opened a pull request:
https://github.com/apache/spark/pull/23237
[SPARK-26279][CORE] Remove unused method in Logging
## What changes were proposed in this pull request?
The method `Logging.isTraceEnabled` is not used anywhere. We should remove
it to avoid
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/23231
It is because we have such claim in ml migration guide that said we will
keep OneHotEncoderEstimator as an alias. I'm fine if we have consensus now that
we can avoid such alias.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23224
**[Test build #99711 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99711/testReport)**
for PR 23224 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23237
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23237
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99730/
Test FAILed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23213
If we look at test coverage, `wholeStage=false, factoryMode=CODE_ONLY` will
go through code paths that wholeStageCodegen doesn't cover. Or did I miss
something?
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23231
I'm not seeing it in the migration guide, maybe I'm missing it. In any
event, I dont' think we need to keep this for 3.0.
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23231
**[Test build #99707 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99707/testReport)**
for PR 23231 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23163
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99708/
Test PASSed.
---
201 - 300 of 614 matches
Mail list logo