Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89452656
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -289,7 +289,6 @@ object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89452852
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1274,7 +1274,7 @@ class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89452891
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1283,7 +1283,7 @@ class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89453245
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2354,7 +2354,7 @@ private[spark] object Utils extends Logging {
* A spark
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89453582
--- Diff: project/SparkBuild.scala ---
@@ -745,7 +745,10 @@ object Unidoc {
"-tag", """example:a:Examp
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89454154
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1283,7 +1283,7 @@ class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89454232
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1283,7 +1283,7 @@ class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89455106
--- Diff: core/src/main/scala/org/apache/spark/SSLOptions.scala ---
@@ -150,8 +150,8 @@ private[spark] object SSLOptions extends Logging
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89456806
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -804,13 +804,13 @@ object DistributedLDAModel extends
MLReadable
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15999
Oh thank you! Will double check and change the title tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89579476
--- Diff:
core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala ---
@@ -238,7 +238,9 @@ class JavaSparkContext(val sc: SparkContext
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89579725
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -239,8 +239,8 @@ class DataFrameReader private[sql](sparkSession
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15999#discussion_r89580586
--- Diff:
core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala ---
@@ -270,7 +272,9 @@ class JavaSparkContext(val sc: SparkContext
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15999
I just double-checked and I think it is ready. Thank you @srowen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/16013
[WIP][SPARK-3359][DOCS] Make javadoc8 working for unidoc/genjavadoc
compatibility in API Java documentation
## What changes were proposed in this pull request?
This PR make `sbt
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16013
cc @srowen, this PR finally resolves the issue and makes `sbt unidoc`
working fine with Java 8! Let me try to double check and leave some comments.
---
If your project is set up for it, you
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89664911
--- Diff: core/src/main/scala/org/apache/spark/Accumulator.scala ---
@@ -26,7 +26,7 @@ package org.apache.spark
*
* An accumulator is created
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89664921
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -262,8 +262,9 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89664964
--- Diff: core/src/main/scala/org/apache/spark/Accumulator.scala ---
@@ -26,7 +26,7 @@ package org.apache.spark
*
* An accumulator is created
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89665095
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2063,6 +2063,7 @@ class SparkContext(config: SparkConf) extends Logging
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89665558
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -155,7 +155,7 @@ class DoubleRDDFunctions(self: RDD[Double]) extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89674331
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -155,7 +155,7 @@ class DoubleRDDFunctions(self: RDD[Double]) extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675432
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala ---
@@ -103,7 +103,8 @@ class JavaRDD[T](val rdd: RDD[T])(implicit val
classTag
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675600
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -750,8 +751,10 @@ abstract class RDD[T: ClassTag
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675629
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1184,8 +1187,13 @@ abstract class RDD[T: ClassTag](
*
* @note This
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675738
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -422,8 +422,13 @@ private[spark] object UIUtils extends Logging {
* the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675774
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1674,7 +1674,11 @@ private[spark] object Utils extends Logging
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675791
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1674,7 +1674,11 @@ private[spark] object Utils extends Logging
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675782
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1688,7 +1692,11 @@ private[spark] object Utils extends Logging
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675794
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1688,7 +1692,11 @@ private[spark] object Utils extends Logging
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675830
--- Diff:
core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala ---
@@ -108,14 +111,22 @@ private[spark] object SamplingUtils
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675837
--- Diff:
core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala ---
@@ -108,14 +111,22 @@ private[spark] object SamplingUtils
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675866
--- Diff:
core/src/main/scala/org/apache/spark/util/random/StratifiedSamplingUtils.scala
---
@@ -35,13 +35,14 @@ import org.apache.spark.rdd.RDD
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675897
--- Diff:
core/src/main/scala/org/apache/spark/util/random/StratifiedSamplingUtils.scala
---
@@ -160,12 +161,21 @@ private[spark] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89675965
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -206,8 +206,13 @@ class LogisticRegression @Since
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676002
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -78,7 +79,7 @@ private[feature] trait CountVectorizerParams
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676038
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala ---
@@ -32,9 +32,11 @@ import org.apache.spark.sql.types.StructType
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676034
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala ---
@@ -32,9 +32,11 @@ import org.apache.spark.sql.types.StructType
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676109
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -165,32 +165,64 @@ object ParamValidators {
s" of unexp
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676113
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -165,32 +165,64 @@ object ParamValidators {
s" of unexp
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676116
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -165,32 +165,64 @@ object ParamValidators {
s" of unexp
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676123
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -165,32 +165,64 @@ object ParamValidators {
s" of unexp
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676132
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -165,32 +165,64 @@ object ParamValidators {
s" of unexp
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676156
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -131,10 +131,12 @@ private[regression] trait
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676193
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -118,8 +118,11 @@ class LinearRegression @Since("
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676269
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/EigenValueDecomposition.scala
---
@@ -32,7 +32,10 @@ private[mllib] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676289
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala ---
@@ -49,8 +49,18 @@ class LBFGS(private var gradient: Gradient
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676299
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/NNLS.scala ---
@@ -53,8 +53,11 @@ private[spark] object NNLS {
* projected
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676340
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -44,7 +44,9 @@ final class DataFrameStatFunctions private[sql
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676335
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -44,7 +44,9 @@ final class DataFrameStatFunctions private[sql
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676381
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -474,7 +474,9 @@ object functions {
/**
* Aggregate function
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676398
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1048,9 +1052,12 @@ object functions {
* within each partition in
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676409
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1066,9 +1073,12 @@ object functions {
* within each partition in
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676419
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -40,9 +40,14 @@ case class JdbcType(databaseTypeDefinition
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676433
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -216,10 +216,13 @@ abstract class BaseRelation
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676437
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -216,10 +216,13 @@ abstract class BaseRelation
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676461
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -57,9 +57,17 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676506
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1184,8 +1187,13 @@ abstract class RDD[T: ClassTag](
*
* @note This
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676519
--- Diff:
core/src/main/scala/org/apache/spark/util/random/StratifiedSamplingUtils.scala
---
@@ -160,12 +161,20 @@ private[spark] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676716
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -41,7 +41,10 @@ private[spark] class JdbcPartition(idx: Int, val lower:
Long
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676728
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -151,7 +154,10 @@ object JdbcRDD {
* The RDD takes care of closing the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676738
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -191,7 +197,10 @@ object JdbcRDD {
* The RDD takes care of closing the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676784
--- Diff:
core/src/main/scala/org/apache/spark/util/random/SamplingUtils.scala ---
@@ -67,20 +67,23 @@ private[spark] object SamplingUtils
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89676820
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -165,32 +165,56 @@ object ParamValidators {
s" of unexp
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16013
@srowen, this PR become unintentionally bigger than I thought. I am happy
to split this into multiple ones if you think so. I left some comments on the
changes where the output images might be
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89677052
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -191,7 +197,10 @@ object JdbcRDD {
* The RDD takes care of closing the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16013
@srowen, this PR become unintentionally bigger than I thought. I am happy
to split this into multiple ones if you think so. I left some comments on the
changes where the output images might be
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16021
I am fine with this in terms of the change I proposed in the PR before
except that the comment above.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89691484
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -152,10 +152,12 @@ class DoubleRDDFunctions(self: RDD[Double
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16013
@srowen Thank you for your comments. I will try to handle them at my best.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89691656
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -152,10 +152,12 @@ class DoubleRDDFunctions(self: RDD[Double
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16021
Actually @dongjoon-hyun, this is a rather a question. Should we include
other JIRAs in the title which this PR includes to backport?
---
If your project is set up for it, you can reply to this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16021
( I was just curious as I just remember tracking down with the blame
button. It is no strong opinion.)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15848
This is actually what I was worried of initially. So, you mean you are
going to fix the failure tests here in this PR at the end?
---
If your project is set up for it, you can reply to this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15848
In my personal opinion, I think we should fix here together. Maybe we could
- Run the tests with `--fail-never` flag in the maven in order to list up
the failed tests. If they are few
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15848#discussion_r89705936
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -1244,7 +1244,15 @@ public void testCountByValue
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15848
I saw several PRs time to time to run automatic Jenkins tests. So, I
_think_ it is fine to keep this open and push some commits/run some tests to
detect the failure tests if you are proceeding
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89718720
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -57,9 +57,17 @@ import
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16013
Let me leave some images that I changed and some comments to double check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89719223
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -152,10 +152,10 @@ class DoubleRDDFunctions(self: RDD[Double
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89719290
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -41,7 +41,10 @@ private[spark] class JdbcPartition(idx: Int, val lower:
Long
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89719600
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala ---
@@ -32,9 +32,11 @@ import org.apache.spark.sql.types.StructType
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89719801
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/NNLS.scala ---
@@ -53,8 +53,13 @@ private[spark] object NNLS {
* projected
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89724422
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDDCheckpointData.scala
---
@@ -23,7 +23,8 @@ import org.apache.spark.Partition
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89726626
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -153,11 +153,9 @@ class DoubleRDDFunctions(self: RDD[Double]) extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727120
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -41,9 +41,9 @@ private[spark] class JdbcPartition(idx: Int, val lower:
Long, val
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727059
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala ---
@@ -33,9 +33,9 @@ import org.apache.spark.sql.types.StructType
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727091
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -422,13 +422,8 @@ private[spark] object UIUtils extends Logging {
* the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727185
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDDCheckpointData.scala
---
@@ -24,9 +24,7 @@ import org.apache.spark.Partition
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727297
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala ---
@@ -41,7 +41,7 @@ private[ml] trait VectorIndexerParams extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727420
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -40,14 +40,9 @@ case class JdbcType(databaseTypeDefinition
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16013
I think it is ready to be reviewed - @srowen. Thank you for your close look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15994#discussion_r89737784
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -130,6 +130,13 @@ final class DataFrameNaFunctions private[sql
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15994#discussion_r89741302
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -130,6 +130,13 @@ final class DataFrameNaFunctions private[sql
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89744913
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/rdd/SlidingRDD.scala
---
@@ -42,8 +42,8 @@ class SlidingRDDPartition[T](val idx: Int, val prev
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89772073
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2061,9 +2061,8 @@ class SparkContext(config: SparkConf) extends Logging
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16013
Thank you so much @srowen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13988
I will try to split this into two PRs for read path and write path. Would
that sound okay to you both @rxin and @hvanhovell?
---
If your project is set up for it, you can reply to this email
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r89918782
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/Spark18601Suite.scala ---
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/16050
[SPARK-18615][DOCS] Switch to multi-line doc to avoid a genjavadoc bug for
backticks
## What changes were proposed in this pull request?
Currently, single line comment does not mark
1201 - 1300 of 12634 matches
Mail list logo
