Re: [sage-devel] Re: reviewer role on github

2023-02-10 Thread David Roe
On Fri, Feb 10, 2023 at 11:50 AM Kwankyu Lee wrote: > On Friday, February 10, 2023 at 7:33:51 PM UTC+9 Martin R wrote: > In which repository? > > Here: https://github.com/sagemath/sage/issues > > Does this mean that researchers cannot become reviewers immediately > anymore? > > You first become a

[sage-devel] Re: reviewer role on github

2023-02-10 Thread Kwankyu Lee
On Friday, February 10, 2023 at 7:33:51 PM UTC+9 Martin R wrote: In which repository? Here: https://github.com/sagemath/sage/issues Does this mean that researchers cannot become reviewers immediately anymore? You first become a member of sage organization, and then be promoted to Triage team (

Re: [sage-devel] reviewer role on github

2023-02-10 Thread 'Martin R' via sage-devel
On Friday, 10 February 2023 at 11:44:53 UTC+1 David Roe wrote: I think the interface only allows reviewers for PRs, and not for issues (though you could always make a comment on an issue declaring your intention to review any resulting PR). For PRs, you have a couple options: 1. At the top rig

Re: [sage-devel] Re: reviewer role on github

2023-02-10 Thread David Roe
Permission-wise, I think the only required permissions to review are Read permissions, so I don't think it should be technically restricted. David On Fri, Feb 10, 2023 at 11:33 AM 'Martin R' via sage-devel < sage-devel@googlegroups.com> wrote: > In which repository? > > Does this mean that resear

Re: [sage-devel] reviewer role on github

2023-02-10 Thread David Roe
I think the interface only allows reviewers for PRs, and not for issues (though you could always make a comment on an issue declaring your intention to review any resulting PR). For PRs, you have a couple options: 1. At the top right of the PR, there's a "Reviewers" box, with a gear icon next to i

[sage-devel] Re: reviewer role on github

2023-02-10 Thread 'Martin R' via sage-devel
In which repository? Does this mean that researchers cannot become reviewers immediately anymore? I am very puzzled. Martin On Friday, 10 February 2023 at 11:18:18 UTC+1 Kwankyu Lee wrote: > I suggest this procedure: > > You open an issue: "promote me to a reviewer". Then if you get enough > h

[sage-devel] Re: reviewer role on github

2023-02-10 Thread Kwankyu Lee
I suggest this procedure: You open an issue: "promote me to a reviewer". Then if you get enough hearts from other reviewers, an admin promotes you. On Friday, February 10, 2023 at 7:07:04 PM UTC+9 Martin R wrote: I was unable to find out how I declare myself as reviewer in the new workflow. T

[sage-devel] reviewer role on github

2023-02-10 Thread 'Martin R' via sage-devel
I was unable to find out how I declare myself as reviewer in the new workflow. This question applies to * pull requests without issue (I'm not sure yet how they work: given a number like #35053, how can I see issue and pull request associated to it? * issues without pull requests. Martin --