Re: [PATCH] remove redundant initialization of volatile fields with default values

2020-08-13 Thread Сергей Цыпанов
Cool, thanks! Do you know anyone who could sponsor this and create a web-review against the patch? Regards, Sergeyt Tsypanov 13.08.2020, 19:22, "Sean Mullan" : > On 8/13/20 9:04 AM, Сергей Цыпанов wrote: >>  Hi, >> >>  I don't have account in JBS, so I cannot file an issue. >> >>  Previously

Re: RFR JDK-8250839: Improve test template SSLEngineTemplate with SSLContextTemplate

2020-08-13 Thread Xuelei Fan
All good catches! I will update accordingly. Thanks, Xuelei On 8/13/2020 11:13 AM, Anthony Scarpino wrote: On 8/11/20 9:44 AM, Xuelei Fan wrote: ping ... On 7/30/2020 11:26 AM, Xuelei Fan wrote: Hi, May I get the following test code update reviewed?

Re: RFR JDK-8250839: Improve test template SSLEngineTemplate with SSLContextTemplate

2020-08-13 Thread Anthony Scarpino
On 8/11/20 9:44 AM, Xuelei Fan wrote: ping ... On 7/30/2020 11:26 AM, Xuelei Fan wrote: Hi, May I get the following test code update reviewed? http://cr.openjdk.java.net/~xuelei/8250839/webrev.00/ SSLEngineTemplate is a template used for SSLEngine testing, which depends on binary key

Re: Fix for Javadoc errors in java.base

2020-08-13 Thread Sean Mullan
On 8/13/20 1:21 PM, Jonathan Gibbons wrote: --- old/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java 2020-07-25 23:46:21.233726447 +0530 +++ new/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java 2020-07-25 23:46:20.721720857 +0530 @@ -96,8 +96,6 @@

Re: [PATCH] remove redundant initialization of volatile fields with default values

2020-08-13 Thread Sean Mullan
On 8/13/20 9:04 AM, Сергей Цыпанов wrote: Hi, I don't have account in JBS, so I cannot file an issue. Previously when I submitted patches via core-libs-dev mailing list previleged users filed the issues and created web-reviews. I think this should be a subtask of

Re: Fix for Javadoc errors in java.base

2020-08-13 Thread Jonathan Gibbons
On 8/13/20 10:13 AM, Sean Mullan wrote: On 8/13/20 11:05 AM, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to

Re: Fix for Javadoc errors in java.base

2020-08-13 Thread Sean Mullan
On 8/13/20 11:05 AM, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to have a look. Bug:

Re: Fix for Javadoc errors in java.base

2020-08-13 Thread Daniel Fuchs
Hi Vipin, Julia, On 13/08/2020 16:05, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to have a look. Changes to

Re: Fix for Javadoc errors in java.base

2020-08-13 Thread Julia Boes
Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to have a look. Bug: https://bugs.openjdk.java.net/browse/JDK-8251542 Webrev:

Re: [PATCH] remove redundant initialization of volatile fields with default values

2020-08-13 Thread Сергей Цыпанов
Hi, I don't have account in JBS, so I cannot file an issue. Previously when I submitted patches via core-libs-dev mailing list previleged users filed the issues and created web-reviews. I think this should be a subtask of https://bugs.openjdk.java.net/browse/JDK-6736490, there's already one

Re: [PATCH] remove redundant initialization of volatile fields with default values

2020-08-13 Thread Sean Mullan
On 8/13/20 7:04 AM, Сергей Цыпанов wrote: Hello, previously I've sent an email regarding removal of redundant assignments if default values to volatile fields, see https://mail.openjdk.java.net/pipermail/security-dev/2020-June/022137.html There was a concern whether it's completely safe to

[PATCH] remove redundant initialization of volatile fields with default values

2020-08-13 Thread Сергей Цыпанов
Hello, previously I've sent an email regarding removal of redundant assignments if default values to volatile fields, see https://mail.openjdk.java.net/pipermail/security-dev/2020-June/022137.html There was a concern whether it's completely safe to remove those assignments from JMM point of