Re: RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

2016-09-20 Thread Dmitry Dmitriev
Dmitry, Sergeui, thank you for the review! For the record, webrev.02: http://cr.openjdk.java.net/~ddmitriev/8150758/webrev.02/ Dmitry On 20.09.2016 13:39, Dmitry Samersoff wrote: Dmitry, Looks good for me! Minor formatting

Re: RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

2016-09-20 Thread serguei.spit...@oracle.com
Hi Dmitry, The fix looks good, thank you for the update. Thumbs up. Thanks, Serguei On 9/20/16 03:17, Dmitry Dmitriev wrote: Serguei, Dmitry, Thank you for the feedback! Here is an updated webrev.01; http://cr.openjdk.java.net/~ddmitriev/8150758/webrev.01/

Re: RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

2016-09-20 Thread Dmitry Samersoff
Dmitry, Looks good for me! Minor formatting nits: libMAAClassFileLoadHook.c 103: missed space after , libMAAClassFileLoadHook.c: 266: extra semicolon -Dmitry On 2016-09-20 13:17, Dmitry Dmitriev wrote: > Serguei, Dmitry, > > Thank you for the feedback! Here is an updated webrev.01; >

Re: RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

2016-09-20 Thread Dmitry Dmitriev
Serguei, Dmitry, Thank you for the feedback! Here is an updated webrev.01; http://cr.openjdk.java.net/~ddmitriev/8150758/webrev.01/ Dmitry On 20.09.2016 12:48, Dmitry Samersoff wrote: Dmitry, Please, also change !strcmp(...) to

Re: RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

2016-09-20 Thread Dmitry Samersoff
Dmitry, Please, also change !strcmp(...) to strcmp(...) == 0 because semantically strcmp result is not a boolean false. -Dmitry On 2016-09-20 06:38, serguei.spit...@oracle.com wrote: > Hi Dmitry, > > > Thanks a lot for this additional test coverage and discovering new bug: >

Re: RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

2016-09-19 Thread serguei.spit...@oracle.com
Hi Dmitry, Thanks a lot for this additional test coverage and discovering new bug: https://bugs.openjdk.java.net/browse/JDK-8165681 The tests look pretty good to me. A couple of minor comments. Dots are missed in the .c files comments.

RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

2016-09-19 Thread Dmitry Dmitriev
Hello, Please review new tests for module aware agents. There are 3 tests: 1) MAAClassFileLoadHook.java - verifies ClassFileLoadHook event with different combinations of can_generate_early_vmstart and can_generate_early_class_hook_events JVMTI capabilities. Expects to find(or not) class from