Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

2016-03-03 Thread Daniel D. Daugherty
On 3/3/16 12:56 PM, Andreas Eriksson wrote: On 2016-03-03 18:29, Daniel D. Daugherty wrote: > Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/ test/com/sun/jdi/RedefineAddPrivateMethod.sh L38: System.out.println("@1 breakpoint"); L39: System.out.println("@2

Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

2016-03-03 Thread Andreas Eriksson
On 2016-03-03 18:29, Daniel D. Daugherty wrote: > Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/ test/com/sun/jdi/RedefineAddPrivateMethod.sh L38: System.out.println("@1 breakpoint"); L39: System.out.println("@2 breakpoint"); With these tests, thi

Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

2016-03-03 Thread Daniel D. Daugherty
> Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/ test/com/sun/jdi/RedefineAddPrivateMethod.sh L38: System.out.println("@1 breakpoint"); L39: System.out.println("@2 breakpoint"); With these tests, this is usually done like this: System.out.pr

Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

2016-03-03 Thread Andreas Eriksson
Thanks Serguei. I'll go ahead and push this now, since I believe this change is small enough. - Andreas On 2016-03-03 17:54, serguei.spit...@oracle.com wrote: Hi Andreas, Good++ Thanks, Serguei On 3/3/16 06:35, Dmitry Samersoff wrote: Andreas, Looks good for me. -Dmitry On 2016-03-03

Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

2016-03-03 Thread serguei.spit...@oracle.com
Hi Andreas, Good++ Thanks, Serguei On 3/3/16 06:35, Dmitry Samersoff wrote: Andreas, Looks good for me. -Dmitry On 2016-03-03 17:05, Andreas Eriksson wrote: Hi, Can I please have a review of this fix for 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently https://bugs.o

Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

2016-03-03 Thread Andreas Eriksson
Thanks. - Andreas On 2016-03-03 15:35, Dmitry Samersoff wrote: Andreas, Looks good for me. -Dmitry On 2016-03-03 17:05, Andreas Eriksson wrote: Hi, Can I please have a review of this fix for 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently https://bugs.openjdk.java.net

Re: RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

2016-03-03 Thread Dmitry Samersoff
Andreas, Looks good for me. -Dmitry On 2016-03-03 17:05, Andreas Eriksson wrote: > Hi, > > Can I please have a review of this fix for > 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently > https://bugs.openjdk.java.net/browse/JDK-8151064 > > Webrev: http://cr.openjdk.java.ne

RFR (XS): 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently

2016-03-03 Thread Andreas Eriksson
Hi, Can I please have a review of this fix for 8151064: com/sun/jdi/RedefineAddPrivateMethod.sh fails intermittently https://bugs.openjdk.java.net/browse/JDK-8151064 Webrev: http://cr.openjdk.java.net/~aeriksso/8151064/webrev/ Still not sure why it only fails sometimes, but after this change th