Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-27 Thread Coleen Phillimore
On 8/27/14, 3:33 PM, Daniel D. Daugherty wrote: On 8/27/14 12:41 PM, serguei.spit...@oracle.com wrote: On 8/27/14 6:54 AM, Daniel D. Daugherty wrote: On 8/27/14 5:40 AM, serguei.spit...@oracle.com wrote: On 8/20/14 3:45 PM, Daniel D. Daugherty wrote: On 8/20/14 2:01 PM, Coleen Phillimore wr

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-27 Thread Daniel D. Daugherty
On 8/27/14 12:41 PM, serguei.spit...@oracle.com wrote: On 8/27/14 6:54 AM, Daniel D. Daugherty wrote: On 8/27/14 5:40 AM, serguei.spit...@oracle.com wrote: On 8/20/14 3:45 PM, Daniel D. Daugherty wrote: On 8/20/14 2:01 PM, Coleen Phillimore wrote: On 8/20/14, 3:49 PM, serguei.spit...@oracle.

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-27 Thread serguei.spit...@oracle.com
On 8/27/14 6:54 AM, Daniel D. Daugherty wrote: On 8/27/14 5:40 AM, serguei.spit...@oracle.com wrote: On 8/20/14 3:45 PM, Daniel D. Daugherty wrote: On 8/20/14 2:01 PM, Coleen Phillimore wrote: On 8/20/14, 3:49 PM, serguei.spit...@oracle.com wrote: If an EMCP method is not running, should we

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-27 Thread Daniel D. Daugherty
On 8/27/14 5:40 AM, serguei.spit...@oracle.com wrote: On 8/20/14 3:45 PM, Daniel D. Daugherty wrote: On 8/20/14 2:01 PM, Coleen Phillimore wrote: On 8/20/14, 3:49 PM, serguei.spit...@oracle.com wrote: If an EMCP method is not running, should we save it on a previous version list anyway so t

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-27 Thread serguei.spit...@oracle.com
On 8/20/14 3:45 PM, Daniel D. Daugherty wrote: On 8/20/14 2:01 PM, Coleen Phillimore wrote: On 8/20/14, 3:49 PM, serguei.spit...@oracle.com wrote: If an EMCP method is not running, should we save it on a previous version list anyway so that we can make it obsolete if it's redefined and made

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-27 Thread serguei.spit...@oracle.com
Dan, Sorry for the big delay in reply... It is because I did not have my arguments ready. :( Please, see below. On 8/20/14 3:37 PM, Daniel D. Daugherty wrote: On 8/20/14 9:54 AM, Coleen Phillimore wrote: Hi, it appears that my code is wrong and maybe the existing code is wrong also. I have

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-20 Thread Coleen Phillimore
On 8/20/14, 6:45 PM, Daniel D. Daugherty wrote: On 8/20/14 2:01 PM, Coleen Phillimore wrote: On 8/20/14, 3:49 PM, serguei.spit...@oracle.com wrote: If an EMCP method is not running, should we save it on a previous version list anyway so that we can make it obsolete if it's redefined and mad

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-20 Thread Coleen Phillimore
On 8/20/14, 6:37 PM, Daniel D. Daugherty wrote: On 8/20/14 9:54 AM, Coleen Phillimore wrote: Hi, it appears that my code is wrong and maybe the existing code is wrong also. I have a spec question below. Rely embedded below... Also embedded reply but I cut some stuff out. ... If an EMCP

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-20 Thread Daniel D. Daugherty
On 8/20/14 2:01 PM, Coleen Phillimore wrote: On 8/20/14, 3:49 PM, serguei.spit...@oracle.com wrote: If an EMCP method is not running, should we save it on a previous version list anyway so that we can make it obsolete if it's redefined and made obsolete? I hope, Dan will catch me if I'm wro

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-20 Thread Daniel D. Daugherty
On 8/20/14 9:54 AM, Coleen Phillimore wrote: Hi, it appears that my code is wrong and maybe the existing code is wrong also. I have a spec question below. Rely embedded below... On 8/19/14, 7:52 PM, serguei.spit...@oracle.com wrote: On 8/19/14 3:53 PM, Daniel D. Daugherty wrote: On 8/

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-20 Thread Daniel D. Daugherty
On 8/20/14 9:29 AM, Coleen Phillimore wrote: Dan, Thanks for taking the time to review this! No problem. More responses below... On 8/19/14, 5:39 PM, Daniel D. Daugherty wrote: On 8/15/14 2:18 PM, Coleen Phillimore wrote: Summary: Use scratch_class to find EMCP methods for breakpoints if

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-20 Thread Coleen Phillimore
On 8/20/14, 3:49 PM, serguei.spit...@oracle.com wrote: If an EMCP method is not running, should we save it on a previous version list anyway so that we can make it obsolete if it's redefined and made obsolete? I hope, Dan will catch me if I'm wrong... I think, we should not. An EMCP method

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-20 Thread serguei.spit...@oracle.com
On 8/20/14 8:54 AM, Coleen Phillimore wrote: Hi, it appears that my code is wrong and maybe the existing code is wrong also. I have a spec question below. On 8/19/14, 7:52 PM, serguei.spit...@oracle.com wrote: On 8/19/14 3:53 PM, Daniel D. Daugherty wrote: On 8/19/14 3:39 PM, Daniel D. Da

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-20 Thread Coleen Phillimore
Hi, it appears that my code is wrong and maybe the existing code is wrong also. I have a spec question below. On 8/19/14, 7:52 PM, serguei.spit...@oracle.com wrote: On 8/19/14 3:53 PM, Daniel D. Daugherty wrote: On 8/19/14 3:39 PM, Daniel D. Daugherty wrote: On 8/15/14 2:18 PM, Coleen Phi

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-20 Thread Coleen Phillimore
Dan, Thanks for taking the time to review this! On 8/19/14, 5:39 PM, Daniel D. Daugherty wrote: On 8/15/14 2:18 PM, Coleen Phillimore wrote: Summary: Use scratch_class to find EMCP methods for breakpoints if the old methods are still running See bug for more details. This fix also includes

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-19 Thread serguei.spit...@oracle.com
On 8/19/14 3:53 PM, Daniel D. Daugherty wrote: On 8/19/14 3:39 PM, Daniel D. Daugherty wrote: On 8/15/14 2:18 PM, Coleen Phillimore wrote: Summary: Use scratch_class to find EMCP methods for breakpoints if the old methods are still running See bug for more details. This fix also includes a

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-19 Thread Daniel D. Daugherty
On 8/19/14 3:39 PM, Daniel D. Daugherty wrote: On 8/15/14 2:18 PM, Coleen Phillimore wrote: Summary: Use scratch_class to find EMCP methods for breakpoints if the old methods are still running See bug for more details. This fix also includes a change to nmethod::metadata_do() to not walk th

Re: RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-19 Thread Daniel D. Daugherty
On 8/15/14 2:18 PM, Coleen Phillimore wrote: Summary: Use scratch_class to find EMCP methods for breakpoints if the old methods are still running See bug for more details. This fix also includes a change to nmethod::metadata_do() to not walk the _method multiple times (the _method is added t

RFR 8055008: Clean up code that saves the previous versions of redefined classes

2014-08-15 Thread Coleen Phillimore
Summary: Use scratch_class to find EMCP methods for breakpoints if the old methods are still running See bug for more details. This fix also includes a change to nmethod::metadata_do() to not walk the _method multiple times (the _method is added to the metadata section of the nmethod), and an