Re: svn commit: r335042 - head/usr.bin/top

2018-06-14 Thread Warner Losh
On Thu, Jun 14, 2018 at 6:10 AM, Eitan Adler wrote: > > I do see some people adding their Copyright on some commits but overall > > we haven't done that as a project and I am curious if we should change > > in that regard. > > The rule of them is about 25% of the file, right? > The law that

Re: svn commit: r335042 - head/usr.bin/top

2018-06-14 Thread Eitan Adler
On 13 June 2018 at 17:01, Bryan Drewery wrote: > On 6/13/2018 1:52 AM, Eitan Adler wrote: >> Author: eadler >> Date: Wed Jun 13 08:52:19 2018 >> New Revision: 335042 >> URL: https://svnweb.freebsd.org/changeset/base/335042 >> >> Log: >> top(1): add myself to authors >> >> At this point I've

Re: svn commit: r335042 - head/usr.bin/top

2018-06-13 Thread Alexey Dokuchaev
On Wed, Jun 13, 2018 at 05:01:35PM -0700, Bryan Drewery wrote: > ... > Also I really abhor rewriting anything that's not broken as it causes > merge conflict pain downstream and just adds regression risk. +1. I'm still having mixed feelings about top(1) de-contrib and rewrite. At the very least,

Re: svn commit: r335042 - head/usr.bin/top

2018-06-13 Thread Bryan Drewery
On 6/13/2018 1:52 AM, Eitan Adler wrote: > Author: eadler > Date: Wed Jun 13 08:52:19 2018 > New Revision: 335042 > URL: https://svnweb.freebsd.org/changeset/base/335042 > > Log: > top(1): add myself to authors > > At this point I've mucked enough with top(1) that all bugs should be >

svn commit: r335042 - head/usr.bin/top

2018-06-13 Thread Eitan Adler
Author: eadler Date: Wed Jun 13 08:52:19 2018 New Revision: 335042 URL: https://svnweb.freebsd.org/changeset/base/335042 Log: top(1): add myself to authors At this point I've mucked enough with top(1) that all bugs should be blamed on me rather than William LeFebvre. Modified: