Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-19 Thread Yuri Nesterenko
Indeed. I tried it myself, and it is yellow for me, too... but, on a snapshot and with my nose to the screen:-) I approve the test as it is but some other color perhaps could be more visible. I know the RED is taken but maybe green or orange? Anyway, +1. -yan On 08/19/2016 02:37 PM, Rajeev Chamy

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-19 Thread Rajeev Chamyal
Hello Yuri, I have attached a snapshot of button in JBS. The button icon border is Yellow. https://bugs.openjdk.java.net/browse/JDK-8163160 Regards, Rajeev Chamyal -Original Message- From: Yuri Nesterenko Sent: 19 August 2016 16:38 To: Rajeev Chamyal; Sergey Bylokhov; Alexander Scherba

Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java

2016-08-19 Thread Yuri Nesterenko
Hi Rajeev, I tried this version of the test on two Ubuntu 16.04 systems with Unity and a promoted b132. Now, the Launcher icon is blue with yellow border around it -- but the icon on the frame with label "Test" is blue with gray border. I think you should either change instructions even more or l

Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

2016-08-19 Thread Alexandr Scherbatiy
On 8/19/2016 2:25 AM, Philip Race wrote: OK .. I do not know enough about how modelToView is used by Swing to know what is really needed here. Someone with a bit more Swing background needs to chime in. I was encouraged that the *API* surface of the changes was much smaller than it had seemed fro

Re: [9] Review request for 8164032 JViewport backing store image is not scaled on HiDPI display

2016-08-19 Thread Alexandr Scherbatiy
On 8/18/2016 3:05 PM, Alexandr Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8164032/webrev.02 The backing store image is recreated for the case where scaled sizes are changed. A version where a VolatileImage is used as a backing store