Re: [systemd-devel] [PATCH] use #pragma once instead of foo*foo #define guards

2012-07-18 Thread Cristian Rodríguez
El 18/07/12 07:31, Lucas De Marchi escribió: > On Wed, Jul 18, 2012 at 7:47 AM, Kay Sievers wrote: >> On Wed, Jul 18, 2012 at 12:39 PM, Lennart Poettering >> wrote: >>> On Tue, 17.07.12 17:14, Shawn Landden (shawnland...@gmail.com) wrote: >> >>> Hmm, so I am not completely opposed to this (though

Re: [systemd-devel] Newbie systemd-related question - how to run a service w/o anything but network?

2012-08-21 Thread Cristian Rodríguez
El 26/07/12 06:09, Peter Lemenkov escribió: > Hello All. > I'm trying to write a systemd service for epmd (Erlang Port Mapper > Daemon, if someone is curious). its only purpose is to open a TCP port > 4369 at 0.0.0.0 and act as a simple messaging (very simple actually) > bus between erlang nodes. I

Re: [systemd-devel] Which distro is the reference Linux for testing systemd?

2014-10-11 Thread Cristian Rodríguez
El 11/10/14 a las #4, 황재영 escribió: Hello, guys I'm working enhancing systemd on v216 and almost finished the work. So I wanna test in reference Linux distro, Which is reference distro? Try Fedora or Arch. ___ systemd-devel mailing list systemd-dev

Re: [systemd-devel] Timers without matching units?

2014-10-22 Thread Cristian Rodríguez
El 22/10/14 a las #4, Ivan Shapovalov escribió: > Hi, > > The systemd.timer(5) manpage states: > > "For each timer file, a matching unit file must exist, describing the unit to > activate when the timer elapses." > I guess for now you can create a dummy unit that executes /bin/true to workaroun

Re: [systemd-devel] I wonder… why systemd provokes this amount of polarity and resistance

2014-10-22 Thread Cristian Rodríguez
El 22/10/14 a las #4, Rob Owens escribió: > It is your ML, so I will oblige. But I think it is a mistake to not consider > a broader view of your project than just the strictly technical aspects. It is not *his* mailing list..but it is the place where *technical* discussions about the systemd p

[systemd-devel] [PATCH] missing: Correct and extend getrandom syscall defines

2014-10-29 Thread Cristian Rodríguez
Add syscall numbers for 32 bit x86 and arm and Correct the system call number for x86_64 (it is 318 not 278) --- src/shared/missing.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/shared/missing.h b/src/shared/missing.h index 00e0287..7fd259a 100644 --- a/src/shared/

Re: [systemd-devel] [PATCH] missing: Correct and extend getrandom syscall defines

2014-10-29 Thread Cristian Rodríguez
El 29/10/14 a las #4, Lennart Poettering escribió: On Wed, 29.10.14 14:29, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: Add syscall numbers for 32 bit x86 and arm and Correct the system call number for x86_64 (it is 318 not 278) Hmm? I did my testing on x86_64 3.18rc2, 278 is what

Re: [systemd-devel] [PATCH] missing: Correct and extend getrandom syscall defines

2014-10-29 Thread Cristian Rodríguez
El 30/10/14 a las #4, Cristian Rodríguez escribió: El 29/10/14 a las #4, Lennart Poettering escribió: On Wed, 29.10.14 14:29, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: Add syscall numbers for 32 bit x86 and arm and Correct the system call number for x86_64 (it is 318 not 278) Hmm

Re: [systemd-devel] Switch root slowness

2014-10-30 Thread Cristian Rodríguez
El 30/10/14 a las #4, Lennart Poettering escribió: In absence of that we can just fallback to /dev/urandom on EAGAIN I guess, and always pass GRND_NONBLOCK. Before you made this commit, I had a local patch that did exactly that..currently this is the best solution. I suggest to give up on an

[systemd-devel] [PATCH] buildsys: test-util needs -lm for fabs()

2014-11-04 Thread Cristian Rodríguez
--- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index ff5f61b..3686103 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1543,6 +1543,7 @@ test_util_SOURCES = \ src/test/test-util.c test_util_LDADD = \ + -lm \ libsystemd-core.la

Re: [systemd-devel] [BUG] too many rfkill services

2014-11-20 Thread Cristian Rodríguez
El 20/11/14 a las 15:40, Lukasz Stelmach escribió: > > $ ls /sys/class/rfkill/ > rfkill41 rfkill42 > $ systemctl -t device | grep rfkill > sys-devices-pci:00-:00:1a.0-usb3-3\x2d1-3\x2d1:1.0-bluetooth-hci0-rfkill42.device > > sys-devices-pci:00-:00:1a.7-usb1-1\x2d3-1

Re: [systemd-devel] [PATCH v2] build-sys: remove --gc-sections to fix debugging

2014-11-26 Thread Cristian Rodríguez
El 26/11/14 a las 15:31, Peter Wu escribió: [1]: https://sourceware.org/bugzilla/show_bug.cgi?id=17639 https://bugs.freedesktop.org/show_bug.cgi?id=8 --- v2:removed -ffunction-sections and -fdata-sections too, mention that binutils fixed the bug. --- -1 Just fix the linke

[systemd-devel] [PATCH] timesync: remove square(), use pow instead

2014-12-23 Thread Cristian Rodríguez
In any case, the compiler generates the same code inline and never actually calls the library function. --- src/timesync/timesyncd-manager.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c index ef5854d..1

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Cristian Rodríguez
El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. ___ systemd-devel mailing list systemd-devel@lists.freed

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Cristian Rodríguez
El 07/01/15 a las 22:55, Nikolai Zhubr escribió: 08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. Ok. So

Re: [systemd-devel] Second (erroneous) check of rootfs?

2015-01-07 Thread Cristian Rodríguez
El 07/01/15 a las 22:55, Nikolai Zhubr escribió: 08.01.2015 4:12, Cristian Rodríguez: El 07/01/15 a las 21:43, Lennart Poettering escribió: Maybe suse forgot to include this service file in the initrd or so? Correct. It appears to be a bug in the dracut package. I wonder why .. Ok. So

[systemd-devel] [PATCH 1/2] machinectl: use GNU basename, not the XPG version

2015-01-11 Thread Cristian Rodríguez
--- src/machine/machinectl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c index 749170e..980fba1 100644 --- a/src/machine/machinectl.c +++ b/src/machine/machinectl.c @@ -32,7 +32,7 @@ #include #include #include - +#un

[systemd-devel] [PATCH] sysv-generator: only allow regular files in enumerate_sysv()

2015-01-13 Thread Cristian Rodríguez
Otherwise, if the directory contains other directories we fail at fopen in load_sysv() with EISDIR. --- src/sysv-generator/sysv-generator.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index 2f2

Re: [systemd-devel] [PATCH] sysv-generator: only allow regular files in enumerate_sysv()

2015-01-14 Thread Cristian Rodríguez
El 14/01/15 a las 09:21, Colin Guthrie escribió: Cristian Rodríguez wrote on 14/01/15 05:51: Otherwise, if the directory contains other directories we fail at fopen in load_sysv() with EISDIR. -if (hidden_file(de->d_name)) -conti

[systemd-devel] [PATCH 1/2] remove unneeded libgen.h includes

2015-01-14 Thread Cristian Rodríguez
--- src/core/mount-setup.c| 1 - src/journal/catalog.c | 1 - src/test/test-namespace.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/core/mount-setup.c b/src/core/mount-setup.c index bd3a035..eb9641f 100644 --- a/src/core/mount-setup.c +++ b/src/core/mount-setup.c @@ -24,7 +24,

Re: [systemd-devel] [PATCH] sysv-generator: only allow regular files in enumerate_sysv()

2015-01-14 Thread Cristian Rodríguez
El 14/01/15 a las 10:39, Colin Guthrie escribió: Cristian Rodríguez wrote on 14/01/15 13:34: El 14/01/15 a las 09:21, Colin Guthrie escribió: If I read the dirent_ensure_type and dirent_is_file code properly, this would mean that symlinks to valid sysvinit scripts are now skipped

[systemd-devel] [PATCH 3/3] remove RUN_WITH_LOCALE et all, use extended locale functions instead

2015-01-14 Thread Cristian Rodríguez
There were two callers, one can use strtod_l() and the other strptime_l() --- src/import/curl-util.c | 38 +++--- src/shared/util.c | 18 +- src/shared/util.h | 26 -- 3 files changed, 36 insertions(+), 46 deletions(

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Cristian Rodríguez
El 15/01/15 a las 09:38, Nikolai Zhubr escribió: Hi all, Is it true that readahead collector defaults to only collect files within root filesystem? If so, is it possible to instruct it to also collect for e.g. /home (mounted on a separate media)? This is not mentioned anywhere in the docs. It

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Cristian Rodríguez
El 15/01/15 a las 10:40, Nikolai Zhubr escribió: Hi, 15.01.2015 16:07, Cristian Rodríguez: The readahead collector is no longer included in systemd. Hm. It is still there in not-very-old opensuse 13.2 ... for whatever reason, current openSUSE releases have systemd 210.. that's

Re: [systemd-devel] systemd build process, stripped ELF flags (MIPS)

2015-01-19 Thread Cristian Rodríguez
El 19/01/15 a las 05:47, Manuel Lauss escribió: The systemd build process manages to create binaries without this .MIPS.abiflags section, and this leads the 3.18 kernel to refuse to load it: Nope, the build process does no such thing, your toolchain is buggy, wild guess is that --gc-sections

[systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-22 Thread Cristian Rodríguez
--- src/sysv-generator/sysv-generator.c | 8 1 file changed, 8 insertions(+) diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index b8b77aa..d6e4dfa 100644 --- a/src/sysv-generator/sysv-generator.c +++ b/src/sysv-generator/sysv-generator.c @@ -775,6

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Cristian Rodríguez
El 23/01/15 a las 10:31, Lennart Poettering escribió: The rc-local generator only exists to add compat support for those systems where it never was a sysvinit script anyway... They are not init scripts though. but plain shell scripts with no dependency information. they are installed in /etc

[systemd-devel] [PATCH] mount-setup: Do not bother with /proc/bus/usb

2015-01-23 Thread Cristian Rodríguez
Current systemd requires kernel >= 3.7 per the README file but CONFIG_USB_DEVICEFS disappeared from the kernel in upstream commit fb28d58b72aa9215b26f1d5478462af394a4d253 (kernel 3.5-rc1) --- src/core/mount-setup.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/mount-setup.c b/src/c

[systemd-devel] [PATCH] build-sys: lookup for sulogin, it might not be in /sbin

2015-01-23 Thread Cristian Rodríguez
--- Makefile.am | 1 + configure.ac | 2 ++ units/console-shell.service.m4.in | 2 +- units/emergency.service.in| 2 +- units/rescue.service.in | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Cristian Rodríguez
El 23/01/15 a las 14:52, Lennart Poettering escribió: On Fri, 23.01.15 12:27, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: El 23/01/15 a las 10:31, Lennart Poettering escribió: The rc-local generator only exists to add compat support for those systems where it never was a sysvinit

[systemd-devel] [PATCH] build-sys: use -fno-semantic-interposition if available

2015-01-25 Thread Cristian Rodríguez
GCC5 introduces -fno-semantic-interposition allowing better code generation in shared libraries at the cost of making interposition of exported symbols impossible (i.e, a 3rd party shared library overriding sd_notify() will not work) Using this particular feature with systemd is not supported and c

[systemd-devel] crash after commit core: make setting the shutdown watchdog configuration via dbus work

2015-01-29 Thread Cristian Rodríguez
hi: systemd crashes after that commit with gdb --args ./systemd Failed to create root cgroup hierarchy: Permission denied Failed to allocate manager object: Permission denied Program received signal SIGSEGV, Segmentation fault. 0x55574ec4 in main (argc=1, argv=0x7fffdac8) at src/

Re: [systemd-devel] [PATCH] timesyncd: Make saving clock to disk on NTP fix optional

2015-02-01 Thread Cristian Rodríguez
El 01/02/2015 06:36, "Kay Sievers" escribió: > > On Feb 1, 2015 5:34 AM, "Zbigniew Jędrzejewski-Szmek" wrote: > > > > Kay, Lennart, > > comments? > > Sounds like overkill to me for such an exotic requirement. Just link the file to /dev/null and be done? Yeah, I do not see the point on providing

Re: [systemd-devel] [PATCH] timesyncd: tighten unit file

2015-02-01 Thread Cristian Rodríguez
El 27/01/15 a las 21:18, Lennart Poettering escribió: On Tue, 27.01.15 15:12, Cameron Norman (camerontnor...@gmail.com) wrote: Lennart: if you really want to test the profile, you just need to spin up an OpenSuSE, Ubuntu, or Debian VM (on debian you need to install and enable apparmor, which ta

[systemd-devel] [PATCH] cryptsetup: Do not warn If the key is /dev/*random

2015-02-02 Thread Cristian Rodríguez
Using /dev/urandom as a key is valid for swap, do not warn if this devices are world readable. --- src/cryptsetup/cryptsetup.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/cryptsetup/cryptsetup.c b/src/cryptsetup/cryptsetup.c index e6b37ac..38930ae 100644 --- a/src

Re: [systemd-devel] [PATCH] cryptsetup: Do not warn If the key is /dev/*random

2015-02-02 Thread Cristian Rodríguez
El 02/02/15 a las 12:42, Lennart Poettering escribió: I'd prefer if we'd change the check instead to only apply to S_ISREG() files. This way we wouldn't have to list all RNG device nodes. Yeah.. the other version I had did a !S_ISCHR check but S_ISREG is more adequate in this case. ___

[systemd-devel] [PATCH 3/3] core: remove unneeded include

2015-02-09 Thread Cristian Rodríguez
execute.c only uses basename (the GNU version in ) --- src/core/execute.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/execute.c b/src/core/execute.c index 874cdc7..7b071e8 100644 --- a/src/core/execute.c +++ b/src/core/execute.c @@ -40,8 +40,6 @@ #include #include #include

[systemd-devel] [PATCH 4/4] Always use recvmsg with MSG_CMSG_CLOEXEC

2015-02-10 Thread Cristian Rodríguez
--- src/libsystemd-network/sd-dhcp-client.c | 2 +- src/libsystemd-network/sd-dhcp-server.c | 2 +- src/libsystemd/sd-rtnl/rtnl-message.c | 4 ++-- src/libudev/libudev-monitor.c | 2 +- src/machine/machine-dbus.c | 2 +- src/resolve/resolved-manager.c | 2 +- src/

Re: [systemd-devel] [PATCH 3/3] core: remove unneeded include

2015-02-11 Thread Cristian Rodríguez
El 11/02/15 a las 14:26, Lennart Poettering escribió: On Wed, 11.02.15 18:21, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: So, hmm, so if I got this right: a) The good basame() is in strings.h b) The bad basename() is in libgen.h c) The only other call in libgen.h is dirname() The

[systemd-devel] [PATCH 5/5] sd-bus: add missing format attribute

2015-02-15 Thread Cristian Rodríguez
--- src/systemd/sd-bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/systemd/sd-bus.h b/src/systemd/sd-bus.h index 2420d0c..ca2d83e 100644 --- a/src/systemd/sd-bus.h +++ b/src/systemd/sd-bus.h @@ -371,7 +371,7 @@ int sd_bus_error_setf(sd_bus_error *e, const char *name,

[systemd-devel] [PATCH] build-sys: Lookup for the location of agetty

2015-02-16 Thread Cristian Rodríguez
May be in /sbin or /usr/sbin --- Makefile.am | 1 + configure.ac | 2 ++ units/console-getty.service.m4.in| 2 +- units/container-ge...@.service.m4.in | 2 +- units/getty@.service.m4 | 2 +- units/serial-getty@.service.m4 | 2

[systemd-devel] [PATCH] timesync: Use UINT64_C for OFFSET_1900_1970

2015-02-16 Thread Cristian Rodríguez
So it matches what the comment says in both 32 and 64 bit systems. --- src/timesync/timesyncd-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c index 223671c..73ac7ee 100644 --- a/src/timesync/timesyncd

Re: [systemd-devel] [PATCH] build-sys: Lookup for the location of agetty

2015-02-16 Thread Cristian Rodríguez
El 16/02/15 a las 14:46, "Jóhann B. Guðmundsson" escribió: On 02/16/2015 05:40 PM, Lennart Poettering wrote: On Mon, 16.02.15 17:39, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 02/16/2015 03:42 PM, Cristian Rodríguez wrote: May be in /sbin or /usr/sbin You might want t

[systemd-devel] [PATCH] units: add ConditionKernelCommandLine=resume

2015-02-16 Thread Cristian Rodríguez
If there is no resume= ..it is not possible to hubrid-sleep or hibernate --- units/systemd-hibernate.service.in| 1 + units/systemd-hybrid-sleep.service.in | 1 + 2 files changed, 2 insertions(+) diff --git a/units/systemd-hibernate.service.in b/units/systemd-hibernate.service.in index 29d9b

[systemd-devel] /run conf_file_dirs are never created

2015-02-17 Thread Cristian Rodríguez
Hi: It appears that with the exception of /run/tmpfiles.d , the rest of the volatile conf_file_dirs are never created at boot. Is this intentional ? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailma

[systemd-devel] tmpfiles.d specifier support on "argument" when operating on files

2015-02-17 Thread Cristian Rodríguez
HI: In openSUSE, we have per *running kernel* sysctl snippets, currently implemented as patch on systemd-sysctl.. I 'm currently attempting to replace it for something sane..like d /run/sysctl.d L/run/sysctl.d/00-sysctl.conf-%v ---- /boot/sysctl.conf-%v BUt "argument" does

Re: [systemd-devel] tmpfiles.d specifier support on "argument" when operating on files

2015-02-17 Thread Cristian Rodríguez
El 17/02/15 a las 15:38, Cristian Rodríguez escribió: HI: In openSUSE, we have per *running kernel* sysctl snippets, currently implemented as patch on systemd-sysctl.. I 'm currently attempting to replace it for something sane..like d /run/sysctl.d L/run/sysctl.d/00-sysctl.co

Re: [systemd-devel] tmpfiles.d specifier support on "argument" when operating on files

2015-02-18 Thread Cristian Rodríguez
El 18/02/15 a las 07:10, Lennart Poettering escribió: On Tue, 17.02.15 17:35, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: Please fix this for all arguments, not just symlinks. Thanks for taking a look, I will post a complete version later

[systemd-devel] [PATCH] build-sys: add configure option to disable LTO/gold

2015-02-18 Thread Cristian Rodríguez
LTO may be unreliable, does not work properly in several archs It may crash or produce wrong code. Compiler developers also said we should not provide production RPM packages with LTO enabled. GOLD also does not work everywhere. --- configure.ac | 15 ++- 1 file changed, 10 insertion

Re: [systemd-devel] [PATCH] build-sys: add configure option to disable LTO/gold

2015-02-18 Thread Cristian Rodríguez
El 18/02/15 a las 15:58, Lennart Poettering escribió: On Wed, 18.02.15 15:45, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: LTO may be unreliable, does not work properly in several archs It may crash or produce wrong code. Well, that's something to fix in the LTO code. Com

Re: [systemd-devel] tmpfiles.d specifier support on "argument" when operating on files

2015-02-18 Thread Cristian Rodríguez
El 18/02/15 a las 07:10, Lennart Poettering escribió: On Tue, 17.02.15 17:35, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: Please fix this for all arguments, not just symlinks. diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index c948d4d..1b35b8e 100644 --- a/src

[systemd-devel] [PATCH] shared: fix wrong assertion in barrier_set_role()

2015-02-20 Thread Cristian Rodríguez
assert(b->pipe[0] >= 0 && b->pipe[0] >= 0); Test the same condition twice, pretty sure we mean assert(b->pipe[0] >= 0 && b->pipe[1] >= 0); --- src/shared/barrier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/barrier.c b/src/shared/barrier.c index f65363a..b7d

[systemd-devel] [PATCH 8/9] shared: AFS is also a network filesystem

2015-02-20 Thread Cristian Rodríguez
--- src/shared/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/util.c b/src/shared/util.c index dc65280..6729461 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -1692,6 +1692,7 @@ bool chars_intersect(const char *a, const char *b) { bool fstype_is_network(const c

Re: [systemd-devel] feature request: dlopen

2015-02-22 Thread Cristian Rodríguez
El 22/02/15 a las 23:08, Luke Kenneth Casson Leighton escribió: the problem, zbigniew, is that the intended use of this "silent noop" feature - to make it *possible* to have an alternative PID1 - *hasn't happened*. any upstream software developer who has added in support for systemd has done

Re: [systemd-devel] feature request: dlopen

2015-02-22 Thread Cristian Rodríguez
El 22/02/15 a las 22:37, Luke Kenneth Casson Leighton escribió: well, you could provide hints in the documentation (and force them to be read by deliberately changing the API) Wow.. so what you want is even nuttier than I thought.. that would be a good place to start, showing people how t

Re: [systemd-devel] tmpfiles.d specifier support on "argument" when operating on files

2015-03-01 Thread Cristian Rodríguez
On Wed, Feb 18, 2015 at 6:17 PM, Cristian Rodríguez wrote: > Is the attached version cool for you ? Ping ? Any comments about this one ? note that implementing the specifier expansion in all cases for "argument" does not make sense to me unless I am miss

[systemd-devel] [PATCH] journal: fix Inappropriate ioctl for device on ext4

2015-03-01 Thread Cristian Rodríguez
Logs constantly show systemd-journald[395]: Failed to set file attributes: Inappropriate ioctl for device This is because ext4 does not support FS_NOCOW_FL. --- src/journal/journal-file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/journal/journal-file.c b/src/journ

Re: [systemd-devel] Proposal: Add Drive Enclosure/Slot mapping to systemd

2015-03-02 Thread Cristian Rodríguez
On Mon, Mar 2, 2015 at 12:48 PM, Jordan Hargrave wrote: > It would be nice if systemd could discover and display enclosure/bay slot > mappings for drives in the system. The /dev/disk/by-path method doesn't > quite work, for SAS drives the ID can change on hotplug. The slot mapping > also doesn't

Re: [systemd-devel] [PATCH] hwdb: ship ids-update.pl & sdio.ids in the release tarballs.

2015-03-20 Thread Cristian Rodríguez
On Fri, Mar 20, 2015 at 3:02 AM, Michael Biebl wrote: > Are you saying https://pci-ids.ucw.cz/v2.2/pci.ids is wrong in adding > a license header? Just like the timezone database this file collects facts (hardware X by manufacturer Y has ID Z) into a machine readable form.. this is non-copyright

Re: [systemd-devel] Check if systems is container in "systemd-remount-fs.service"

2015-04-08 Thread Cristian Rodríguez
On Wed, Apr 8, 2015 at 6:55 PM, Lennart Poettering wrote: > On Tue, 17.03.15 10:54, Peter Paule (systemd-de...@fedux.org) wrote: > >> Hi, >> >> does it make sense to check if the system is started as a container in >> "systemd-remount-fs.service" and only start the service if the system is NOT >>

Re: [systemd-devel] SD_BUS_VTABLE_CAPABILITY

2015-04-17 Thread Cristian Rodríguez
On Fri, Apr 17, 2015 at 7:51 AM, Lennart Poettering wrote: > Groups *suck* as authentication scheme. If you add one group for each > privilege you want, then you'll have a huge number of groups, and > that's hardly desirable. It's pretty close to being unmanagable with > user/group editors. Also,

Re: [systemd-devel] Adopt processes spawned before /lib/systemd/systemd takes over as PID 1?

2015-04-17 Thread Cristian Rodríguez
On Fri, Apr 17, 2015 at 4:06 PM, Matt Hoosier wrote: > On Fri, Apr 17, 2015 at 12:22 PM, Lennart Poettering > wrote: >> >> On Fri, 17.04.15 09:00, Matt Hoosier (matt.hoos...@gmail.com) wrote: >> >> > Hi, >> > >> > I'm writing to see whether there's a "best" way to allow systemd to >> > inherit >>

[systemd-devel] [PATCH] tree-wide: Introduce a dup_cloexec inline helper

2015-04-22 Thread Cristian Rodríguez
- Nicer & easier to remember than fcntl(fd, F_DUPFD_CLOEXEC, 3) - Update CODING_STYLE - Use it tree-wide --- CODING_STYLE | 6 +++--- src/import/curl-util.c | 2 +- src/import/importd.c | 4 ++-- src/journal/cat.c| 2 +- src

[systemd-devel] [PATCH] po: Remove src/fsckd/fsckd.c from filelist

2015-05-05 Thread Cristian Rodríguez
Otherwise make check ends in failed state. --- po/POTFILES.in | 1 - 1 file changed, 1 deletion(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index 70e7594..b4c1121 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -5,4 +5,3 @@ src/locale/org.freedesktop.locale1.policy.in src/login/org.freed

[systemd-devel] [PATCH] buildsys: *_la_CPPFLAGS takes $(AM_CPPFLAGS) not $(AM_CFLAGS)

2015-05-09 Thread Cristian Rodríguez
--- Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index 1ec1e77..e4d00a8 100644 --- a/Makefile.am +++ b/Makefile.am @@ -6333,7 +6333,7 @@ libsystemd_journal_la_SOURCES = \ src/compat-libs/libsystemd-journal.sym libsyste

[systemd-devel] [PATCH] sd-bus: fix memory leak in test-bus-chat

2015-05-09 Thread Cristian Rodríguez
Building with address sanitizer enabled on GCC 5.1.x a memory leak is reported because we never close the bus, fix it by using cleanup variable attribute. --- src/libsystemd/sd-bus/test-bus-chat.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libsystemd/sd-bus/test-bus

[systemd-devel] [PATCH] shared: Use O_EXCL with O_TMPFILE in open_tmpfile

2015-05-11 Thread Cristian Rodríguez
In this usecase, the file will never be materialized with linkat(). --- src/shared/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/util.c b/src/shared/util.c index c5c1b0c..f295edb 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -4838,7 +4838,7 @@ in

[systemd-devel] [PATCH] modules-load: fix memory leak

2015-05-11 Thread Cristian Rodríguez
= ==64281==ERROR: LeakSanitizer: detected memory leaks Direct leak of 32 byte(s) in 1 object(s) allocated from: #0 0x7f623c961c4a in malloc (/usr/lib64/libasan.so.2+0x96c4a) #1 0x5651f79ad34e in malloc_multiply (/home/crrodri

[systemd-devel] resolved crashes on SIGTERM

2015-05-11 Thread Cristian Rodríguez
resolved crashes on SIGTERM with ... = ==33557==ERROR: AddressSanitizer: heap-use-after-free on address 0x60c0bd60 at pc 0x556098c5 bp 0x7fffde70 sp 0x7fffde68 READ of size 8 at 0x60c0bd60 thread T0 #0 0x556

[systemd-devel] [PATCH] core: fix memory leak in manager_run_generators()

2015-05-11 Thread Cristian Rodríguez
If systemd is built with GCC address sanitizer or leak sanitizer the following memory leak ocurs: May 12 02:02:46 linux.site systemd[326]: = May 12 02:02:46 linux.site systemd[326]: ==326==ERROR: LeakSanitizer: detected memory leaks

Re: [systemd-devel] [PATCH] sd-bus: fix memory leak in test-bus-chat

2015-05-13 Thread Cristian Rodríguez
On Wed, May 13, 2015 at 8:01 AM, Daniel Mack wrote: > We should still keep this flush, right? > >> -sd_bus_unref(bus); >> } >> The cleanup function already does : static inline void sd_bus_close_unrefp(sd_bus **bus) { if (*bus) { sd_bus_flush(*bus)

[systemd-devel] [PATCH] sd-bus: fix potential UB in bus_socket_auth_verify_client()

2015-05-13 Thread Cristian Rodríguez
When built with GCC undefined behaviour sanitizer the following problem surfaces: src/libsystemd/sd-bus/bus-socket.c:180:11: runtime error: null pointer passed as argument 1, which is declared to never be null Indeed, calling memmem where b->rbuffer == NULL is undefined behaviour. Fix that by re

[systemd-devel] [PATCH] timedate: fix memory leak in timedated

2015-05-15 Thread Cristian Rodríguez
$ /usr/lib/systemd/systemd-timedated (wait until auto-exit) = ==396==ERROR: LeakSanitizer: detected memory leaks Direct leak of 928 byte(s) in 1 object(s) allocated from: #0 0x7f782f788db1 in __interceptor_calloc (/usr/lib64/liba

[systemd-devel] [PATCH] buildsys: Remove X_SERVER from AM_CPPFLAGS

2015-05-16 Thread Cristian Rodríguez
It is a leftover from multi-seat-x wrapper which is long gone. --- Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 211ce6a..4639b2f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -203,7 +203,6 @@ AM_CPPFLAGS = \ -DSYSTEM_SLEEP_PATH=\"$(systemsl

Re: [systemd-devel] resolved crashes on SIGTERM

2015-05-18 Thread Cristian Rodríguez
On Mon, May 18, 2015 at 6:25 PM, Lennart Poettering wrote: > Fixed in git. Please verify. It is OK now.. Thank you. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Reduce unit-loading time

2015-05-19 Thread Cristian Rodríguez
On Mon, May 18, 2015 at 7:24 AM, cee1 wrote: > 2015-05-17 17:45 GMT+08:00 Martin Pitt : >> Hello cee, >> >> cee1 [2015-05-16 0:46 +0800]: >>> Thanks for the suggestion, it was other processes running in parallel >>> which presumably consuming lots of IO, after sending SIGSTOP at the >>> first (an

Re: [systemd-devel] Reduce unit-loading time

2015-05-19 Thread Cristian Rodríguez
On Tue, May 19, 2015 at 5:39 PM, Cristian Rodríguez wrote: > On Mon, May 18, 2015 at 7:24 AM, cee1 wrote: >> 2015-05-17 17:45 GMT+08:00 Martin Pitt : >>> Hello cee, >>> >>> cee1 [2015-05-16 0:46 +0800]: >>>> Thanks for the suggestion, it wa

[systemd-devel] [PATCH] buildsys: remove always true autoconf checks

2015-05-19 Thread Cristian Rodríguez
All this checks are always true in any modernish linux system. --- configure.ac | 11 --- 1 file changed, 11 deletions(-) diff --git a/configure.ac b/configure.ac index 3efee22..cd6375b 100644 --- a/configure.ac +++ b/configure.ac @@ -1293,17 +1293,6 @@ AC_CHECK_HEADERS_ONCE([valgrind/mem

Re: [systemd-devel] [PATCH] buildsys: remove always true autoconf checks

2015-05-21 Thread Cristian Rodríguez
On Thu, May 21, 2015 at 11:39 AM, Lennart Poettering wrote: > On Tue, 19.05.15 20:17, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: > >> All this checks are always true in any modernish linux system. >> --- >> configure.ac | 11 --- >> 1 file chang

[systemd-devel] [PATCH] core: if PR_SET_CHILD_SUBREAPER fails, log_error instead of warning

2015-05-23 Thread Cristian Rodríguez
It was a warning when we still supported kernel < 3.4. current minimum version is 3.7. --- src/core/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/core/main.c b/src/core/main.c index c39815b..3bebc98 100644 --- a/src/core/main.c +++ b/src/core/main.c @@ -1608,9 +

Re: [systemd-devel] How to wait for specific interface/IP?

2015-05-23 Thread Cristian Rodríguez
On Sat, May 23, 2015 at 1:03 PM, Ian Pilcher wrote: > Is there a simple way to make a service require that a specific network > interface/IP address be active? You have to wait for the *link* to be active, not for the interface.. > I have a manually set up bridge and dnsmasq configuration for my

Re: [systemd-devel] systemctl as non-root

2015-05-28 Thread Cristian Rodríguez
On Thu, May 28, 2015 at 9:21 PM, wrote: > Brandon Philips wrote on 05/28/2015 05:10:33 PM: >> Access to the system dbus is controlled by dbus policies. You will >> need to write a policy for giving this user access to the systemd1 object. >> > > I compiled systemd without dbus support (--disable

Re: [systemd-devel] Performance of systemctl status tab completion

2015-06-02 Thread Cristian Rodríguez
On Tue, Jun 2, 2015 at 1:18 PM, Chris Morgan wrote: > Hi all. > > systemd 216 here on an embedded arm system, 1ghz with a load of 60% or > more. I enabled tab completion, because I really don't like to type, > and quickly found out that something like: > > systemctl status xx What shell are you u

Re: [systemd-devel] Why we need to read/save random seed?

2015-06-14 Thread Cristian Rodríguez
El jun. 14, 2015 10:21, "cee1" escribió: > > Hi all, > > Why we need to read/save random seed? Can it be read from /dev/random each time? Because the kernel is borked and still is needs to be fed of entropy at system startup by user space. Please read the random man page. I agree we shouldn't ha

Re: [systemd-devel] Why we need to read/save random seed?

2015-06-14 Thread Cristian Rodríguez
On Sun, Jun 14, 2015 at 1:43 PM, Greg KH wrote: > On Sun, Jun 14, 2015 at 12:49:55PM -0300, Cristian Rodríguez wrote: >> >> El jun. 14, 2015 10:21, "cee1" escribió: >> > >> > Hi all, >> > >> > Why we need to read/save random seed? Ca

Re: [systemd-devel] Why we need to read/save random seed?

2015-06-14 Thread Cristian Rodríguez
On Sun, Jun 14, 2015 at 6:45 PM, Greg KH wrote: > On Sun, Jun 14, 2015 at 02:11:53PM -0300, Cristian Rodríguez wrote: >> On Sun, Jun 14, 2015 at 1:43 PM, Greg KH wrote: >> > On Sun, Jun 14, 2015 at 12:49:55PM -0300, Cristian Rodríguez wrote: >> >> >> >>

Re: [systemd-devel] Why we need to read/save random seed?

2015-06-15 Thread Cristian Rodríguez
On Mon, Jun 15, 2015 at 12:33 PM, cee1 wrote: > Hi, > > I maybe got confused. > > First, systemd-random-seed.service will save a "seed" from > /dev/urandom when shutdown, and load that "seed" to /dev/urandom when > next boot up. > > My questions are: > 1. Can we not save a seed, but load a seed th

Re: [systemd-devel] Weird udev issue: char device replaced by regular file on suspend

2015-06-25 Thread Cristian Rodríguez
On Thu, Jun 25, 2015 at 4:15 PM, Johannes Bauer wrote: > Hi list, > > I'm seeing a very odd issue with udev and I'm not really sure which > component could/would be responsible -- udev is pretty much my only hope. > Probably GregKH can assist you with this problem, udev is not at fault because it

Re: [systemd-devel] SysVInit service migration to systemd

2015-06-29 Thread Cristian Rodríguez
On Mon, Jun 29, 2015 at 10:58 AM, Lesley Kimmel wrote: > Jonathan; > > Thanks for the background and information. Since you clearly seem to have a > grasp of systemd please humour me with a few more questions (some of them > slightly ignorant): > > a) Why are PID bad? Because they pretend to work

Re: [systemd-devel] 3.7s for systemd-logind.service starting

2015-07-02 Thread Cristian Rodríguez
On Fri, Jul 3, 2015 at 2:05 AM, RayBloodworth wrote: > Hi, everyone > > I'm optimizing booting performance of my system. > > systemd version: 208 > platform: freescale i.MX6D Cortex-A9 Please test again with a current release, I doubt anyone here will help if you are using an older re

Re: [systemd-devel] 3.7s for systemd-logind.service starting

2015-07-03 Thread Cristian Rodríguez
On Fri, Jul 3, 2015 at 5:00 AM, RayBloodworth wrote: > From this boot chart, dbus.service starts after systemd-logind.service, but > dbus.service takes littile time for launching. This is a bug, fixed in v209.. commit 8f9c6fe5ff1d59001aecbf3fbf9ca0ed7ff28ba7

[systemd-devel] [PATCH] build: change tcpwrappers support to disabled by default

2014-03-20 Thread Cristian Rodríguez
The underlying components have not seen any upstream activity since 1997 and are not particulary nice either. Those interested in computer archeology can explicitly use --enable-tcpwrap --- configure.ac | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/co

Re: [systemd-devel] [PATCH] build: change tcpwrappers support to disabled by default

2014-03-20 Thread Cristian Rodríguez
El 20/03/14 16:29, Lennart Poettering escribió: On Thu, 20.03.14 12:49, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: The underlying components have not seen any upstream activity since 1997 and are not particulary nice either. Those interested in computer archeology can explicitly use

Re: [systemd-devel] [PATCH] build: change tcpwrappers support to disabled by default

2014-03-24 Thread Cristian Rodríguez
El 24/03/14 16:16, Lennart Poettering escribió: However, I figure this doesn't have to stop us from killing it in systemd though, which I now did. This doesn't mean much however, since people who want tcpwrap support can actually easily restore it by plugging tcpd into systemd, the same way is t

Re: [systemd-devel] failed to store sound card state

2014-03-27 Thread Cristian Rodríguez
El 27/03/14 20:21, Felix Miata escribió: I see this repeated often during reboot attempts that do not proceed as expected to swiftly do the deed. It seems to be prerequisite to shutdown/reboot. I can't recall ever seeing anything like it when sysvinit was employed. Why does rebooting require the

[systemd-devel] [PATCH] tests: fix test-rtnl-manual.c compile failure

2014-03-31 Thread Cristian Rodríguez
Needs KMOD_CFLAGS --- Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/Makefile.am b/Makefile.am index 6c7d6e5..77495a4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1399,6 +1399,10 @@ test_ipcrm_LDADD = \ libsystemd-shared.la \ -lrt +test_rtnl_manual_CFLAGS =

[systemd-devel] [PATCH] run systemd-tmpfiles-clean only when we have AC power

2014-04-03 Thread Cristian Rodríguez
While it is cool to be neat and clean all the time, this task can wait if we are on battery. --- units/systemd-tmpfiles-clean.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/units/systemd-tmpfiles-clean.service.in b/units/systemd-tmpfiles-clean.service.in index a5b5acb..06bb21f 100

Re: [systemd-devel] Netconsole NG

2014-04-06 Thread Cristian Rodríguez
El 06/04/14 12:59, poma escribió: /usr/lib/systemd/system/netconsole.service: [Unit] Description=Adds the netconsole module with the configured parameters After=network.target [Service] EnvironmentFile=/etc/sysconfig/netconsole Type=simple RemainAfterExit=yes ExecStart=/usr/sbin/modprobe netco

Re: [systemd-devel] Netconsole NG

2014-04-06 Thread Cristian Rodríguez
El 06/04/14 13:42, Cristian Rodríguez escribió: Hrmm.. a systemd-netconsole.service that could setup this is a clean race-free fashion will be a cool addition to the stack ;) The question is.. as a separate tool or an extension to networkd, which seems to be a more suitable place

Re: [systemd-devel] Four special object test files

2014-04-07 Thread Cristian Rodríguez
El 07/04/14 15:15, Kevin Wilson escribió: What it the reason for this concatenation? automake "subdir-objects" does this.. -- Cristian Team PITA ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailma

<    1   2   3   4   >