Re: Apache::TestMB error

2004-09-11 Thread David Wheeler
On Sep 11, 2004, at 10:19 AM, William McKee wrote: I'm liking Module::Build more and more ;). Me, too. Scroll down a bit more to see the Build.PL example I added. Oops, I hadn't realized that you updated that page after you released Apache::TestMB. Thanks for your work on integrating

Re: Apache::TestMB error

2004-09-11 Thread William McKee
On Fri, Sep 10, 2004 at 04:07:35PM -0700, David Wheeler wrote: > >I'm getting an error when trying to use Stas' template[1] with your > >module. Basically, the filter_args() method is generating an error. I > >am > >calling it like this: > > > >

Re: Apache::TestMB error

2004-09-10 Thread David Wheeler
On Sep 10, 2004, at 3:00 PM, William McKee wrote: I'm getting an error when trying to use Stas' template[1] with your module. Basically, the filter_args() method is generating an error. I am calling it like this: Apache::TestMB::filter_args(); You don't need to do that. Apache:

Apache::TestMB error

2004-09-10 Thread William McKee
Hi David, I'm getting an error when trying to use Stas' template[1] with your module. Basically, the filter_args() method is generating an error. I am calling it like this: Apache::TestMB::filter_args(); My build seems to work fine with this method commented out. However, I'

Re: Apache::TestMB returns 1

2004-07-06 Thread David Wheeler
On Jul 6, 2004, at 12:56 AM, Stas Bekman wrote: Committed, should there be a log in Changes? Yep, thanks. David

Re: Apache::TestMB returns 1

2004-07-06 Thread Stas Bekman
David Wheeler wrote: On Jul 5, 2004, at 11:09 AM, David Wheeler wrote: Can't locate object method "generate_script" via package "Apache::TestMB" at Build.PL line 62. Oh, sorry, it's generate_test_script(). And I have no idea why it is, since it's generate_scr

Re: Apache::TestMB returns 1

2004-07-05 Thread David Wheeler
On Jul 5, 2004, at 11:53 AM, William McKee wrote: OK, that worked. Why is it named differently from the format used by Apache::TestMM? Nevermind, I see your follow-up message. That works for me! Probably do to some overly-aggressive find and replace or something. Sorry about that! David

Re: Apache::TestMB returns 1

2004-07-05 Thread William McKee
On Mon, Jul 05, 2004 at 11:09:47AM -0700, David Wheeler wrote: > >When I try running generate_smoke, I get the following output: Now I'm doing it! That should have been generate_script. > Oh, sorry, it's generate_test_script(). OK, that worked. Why is it named differently from the format used b

Re: Apache::TestMB returns 1

2004-07-05 Thread David Wheeler
On Jul 5, 2004, at 11:09 AM, David Wheeler wrote: Can't locate object method "generate_script" via package "Apache::TestMB" at Build.PL line 62. Oh, sorry, it's generate_test_script(). And I have no idea why it is, since it's generate_script in the other A::

Re: Apache::TestMB returns 1

2004-07-05 Thread David Wheeler
cript. Yeah, I was just following the example in the synopsis of the Module::Build docs. Either is fine with me, too. What do others prefer? You can use Apache::TestMB->generate_script, however; will that work? When I try running generate_smoke, I get the following output: Can't l

Re: Apache::TestMB returns 1

2004-07-05 Thread William McKee
On Fri, Jul 02, 2004 at 09:51:32AM -0700, David Wheeler wrote: > Oh, quite right. My fault. This patch fixes the docs: > > --- TestMB.pm.~1.2.~ Fri Jun 25 18:55:53 2004 > +++ TestMB.pm Fri Jul 2 09:49:40 2004 > @@ -180,7 +180,7 @@ >my $build_pkg = eval { requ

Re: Apache::TestMB returns 1

2004-07-02 Thread David Wheeler
On Jul 2, 2004, at 9:34 AM, William McKee wrote: Hi all, Sorry about that false start. Lemme try this again! As I was saying, David, thanks for adding support for Module::Build. I'm trying to replace one of my existing projects using the Apache::TestMB module. It works fine unless I try

Re: Apache::TestMB returns 1

2004-07-02 Thread David Wheeler
On Jul 2, 2004, at 9:19 AM, William McKee wrote: Thanks for your efforts in adding support Glad it works for you! This reminds me: --- Test.pm.~1.84.~ Fri Jun 25 18:55:53 2004 +++ Test.pm Fri Jul 2 09:27:18 2004 @@ -807,7 +807,8 @@ exports a number of useful functions for sending request to the

Apache::TestMB returns 1

2004-07-02 Thread William McKee
Hi all, Sorry about that false start. Lemme try this again! As I was saying, David, thanks for adding support for Module::Build. I'm trying to replace one of my existing projects using the Apache::TestMB module. It works fine unless I try to do something with the return value from the exa

Apache::TestMB returns 1

2004-07-02 Thread William McKee
Hi David, Thanks for your efforts in adding support -- Knowmad Services Inc. http://www.knowmad.com

Re: Apache::TestMB

2004-06-24 Thread Geoffrey Young
David Wheeler wrote: > On Jun 23, 2004, at 1:26 PM, Geoffrey Young wrote: > >> sure, I'll try to wrap up a candidate tomorrow. > > > Sweet, thanks! ok, I did this a few hours ago, but the announcement email hasn't made it through. testing... --Geoff

Re: Apache::TestMB

2004-06-24 Thread David Wheeler
On Jun 23, 2004, at 10:02 AM, Stas Bekman wrote: Now committed with a few minor tweaks, please test it since I don't know how to test it. Thanks David. Here's a quick documentation patch, essentially, for the unimplemented cmodules actions: --- lib/Apache/TestMB.pm.~1.1.~ Wed Jun 23 09:51:15 200

Re: Apache::TestMB

2004-06-24 Thread David Wheeler
On Jun 23, 2004, at 1:26 PM, Geoffrey Young wrote: sure, I'll try to wrap up a candidate tomorrow. Sweet, thanks! David

Re: Apache::TestMB

2004-06-23 Thread Stas Bekman
Geoffrey Young wrote: [...] Geoff, if you have no objections, can you handle this release? I'm on the road and not the most suitable person to do the release at the moment. sure, I'll try to wrap up a candidate tomorrow. Thanks Geoff! --

Re: Apache::TestMB

2004-06-23 Thread Geoffrey Young
Stas Bekman wrote: > David Wheeler wrote: > >> On Jun 23, 2004, at 9:02 AM, Stas Bekman wrote: >> >>> Now committed with a few minor tweaks, please test it since I don't >>> know how to test it. Thanks David. >> >> >> >> Cool, thanks. What do you need to be able to feel comfortable/ready to >> r

Re: Apache::TestMB

2004-06-23 Thread David Wheeler
On Jun 23, 2004, at 9:19 AM, Stas Bekman wrote: As I mentioned I don't know how to test it, so if you think it's good, then nothing stops us from doing that. We ought to post a release candidate and 24 later go on CPAN. That works for me. As I said, I'll release MasonX::Interp::WithCallbacks

Re: Apache::TestMB

2004-06-23 Thread Stas Bekman
David Wheeler wrote: On Jun 23, 2004, at 9:02 AM, Stas Bekman wrote: Now committed with a few minor tweaks, please test it since I don't know how to test it. Thanks David. Cool, thanks. What do you need to be able to feel comfortable/ready to release it? As I mentioned I don't know how to test i

Re: Apache::TestMB

2004-06-23 Thread David Wheeler
On Jun 23, 2004, at 9:02 AM, Stas Bekman wrote: Now committed with a few minor tweaks, please test it since I don't know how to test it. Thanks David. Cool, thanks. What do you need to be able to feel comfortable/ready to release it? It's a well kept secret :) existing committers need to vote fi

Re: Apache::TestMB

2004-06-23 Thread Stas Bekman
David Wheeler wrote: Now committed with a few minor tweaks, please test it since I don't know how to test it. Thanks David. Moreover, I think it's time to give you commit access to A-T if you wish to. Do you have an account at apache.org? I don't. How do I get one? A quick look around www.apach

Re: Apache::TestMB

2004-06-23 Thread Stas Bekman
Ken Williams wrote: On Jun 22, 2004, at 5:15 PM, Stas Bekman wrote: David Wheeler wrote: I figured. I like my style, too (mainly just cperl-mode style). ;-) pretty much the same here, cperl-mode too :) For HTML::Mason we found it helpful to add the following as the first line of source files: #

Re: Apache::TestMB

2004-06-23 Thread Ken Williams
On Jun 22, 2004, at 5:15 PM, Stas Bekman wrote: David Wheeler wrote: I figured. I like my style, too (mainly just cperl-mode style). ;-) pretty much the same here, cperl-mode too :) For HTML::Mason we found it helpful to add the following as the first line of source files: # -*- cperl-indent-leve

Re: [Module::Build] Re: Apache::TestMB

2004-06-22 Thread Stas Bekman
Randy Kobes wrote: On Tue, 22 Jun 2004, David Wheeler wrote: On Jun 22, 2004, at 7:32 AM, Randy Kobes wrote: Right now the Makefile is generated by methods within Apache/TestConfigC.pm, which generally consists of calling the apxs utility to compile the module (as well as implementing a 'clean' t

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
On Jun 22, 2004, at 3:34 PM, David Wheeler wrote: I doubt so. Just make it die with the appropriate message, so that if someone needs it they will know that it'll be added in the future. Okay, done. Uh, and here it is. Regards, David

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
hat +1 and thank you, David. I've tried it with MasonX::Interp::WithCallbacks, which I will release with the Build.PL as soon as Apache::Test is released with Apache::TestMB. Moreover, I think it's time to give you commit access to A-T if you wish to. Do you have an account at

Re: Apache::TestMB

2004-06-22 Thread Stas Bekman
ill always log things, whereas debug() won't. So for example in your case you could use the notice() func. Apache::TestTrace really mimicks the LogLevel from Apache. Are you suggesting that it be used inside Apache::TestMB? There's only one print statement, in generate_script(), and there I

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
r changes the default, traces: emerg alert crit error warning notice info will always log things, whereas debug() won't. So for example in your case you could use the notice() func. Apache::TestTrace really mimicks the LogLevel from Apache. Are you suggesting that it be used inside Apache::Test

Re: Apache::TestMB

2004-06-22 Thread Stas Bekman
David Wheeler wrote: How are you going to avoid that? I mean your users need to be able to run certain features of Apache-Test, which are beyond 'make test'. May be you want to always create t/TEST, but run 'make test' without invoking t/TEST? I meant that I wanted to avoid dealing with it. ;-)

Re: [Module::Build] Re: Apache::TestMB

2004-06-22 Thread David Wheeler
On Jun 22, 2004, at 12:19 PM, Randy Kobes wrote: Sure, it should be relatively straightforward ... But I'd like to get, especially, Stas' opinion on this - adding this in will necessarily introduce a few branches in the Apache/TestConfigC.pm code related to, first of all, whether to write a Makefil

Re: [Module::Build] Re: Apache::TestMB

2004-06-22 Thread Randy Kobes
On Tue, 22 Jun 2004, David Wheeler wrote: > On Jun 22, 2004, at 7:32 AM, Randy Kobes wrote: > > > Right now the Makefile is generated by methods within > > Apache/TestConfigC.pm, which generally consists of calling > > the apxs utility to compile the module (as well as > > implementing a 'clean' t

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
On Jun 22, 2004, at 11:05 AM, Stas Bekman wrote: ah, yes, it tries to figure out where it is and move out of t/, as per your request earlier. Feel free to suggest a way to work it out. That particular code could be made into a subclassable method, which your subclass could implement differently.

Re: Apache::TestMB

2004-06-22 Thread Stas Bekman
David Wheeler wrote: On Jun 22, 2004, at 10:33 AM, Stas Bekman wrote: Absolutely. It's really just: MyTest->new->run(@ARGV); where MyTest is a subclass of Apache::TestRunPerl I tried that, but it didn't work. I'm not sure why. The first problem was this code: $0 = File::Spec->rel2abs($0);

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
Oops, sorry for the dupe. David

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
On Jun 22, 2004, at 10:33 AM, Stas Bekman wrote: Absolutely. It's really just: MyTest->new->run(@ARGV); where MyTest is a subclass of Apache::TestRunPerl I tried that, but it didn't work. I'm not sure why. The first problem was this code: $0 = File::Spec->rel2abs($0); if (-e $0) {

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
On Jun 22, 2004, at 10:33 AM, Stas Bekman wrote: Absolutely. It's really just: MyTest->new->run(@ARGV); where MyTest is a subclass of Apache::TestRunPerl I tried that, but it didn't work. I'm not sure why. The first problem was this code: $0 = File::Spec->rel2abs($0); if (-e $0) {

Re: Apache::TestMB

2004-06-22 Thread Stas Bekman
David Wheeler wrote: On Jun 21, 2004, at 6:12 PM, David Wheeler wrote: Here's a new subclass for Module::Build, Apache::TestMB, which allows modules that use Module::Build to run tests using Apache::Test. Let me make a few comments on my "XXX" comments in the source code, and a

Re: [Module::Build] Re: Apache::TestMB

2004-06-22 Thread David Wheeler
On Jun 22, 2004, at 7:32 AM, Randy Kobes wrote: Right now the Makefile is generated by methods within Apache/TestConfigC.pm, which generally consists of calling the apxs utility to compile the module (as well as implementing a 'clean' target). In principle I think this could be done via Module::Bui

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
On Jun 22, 2004, at 6:23 AM, Ken Williams wrote: ./Build help should work already. ./Build help $newaction should work automatically if you add documentation for each action - it searches for docs using the regex /^=item\s+\Q$action\E\b/ . Ah, I had "=item C". I'll remove the C<>. Thanks, David

Re: Apache::TestMB

2004-06-22 Thread Randy Kobes
On Mon, 21 Jun 2004, David Wheeler wrote: [ ... ] > * This isn't commented in the code I sent you, but I'll > note it: I didn't implement "cmodules" or "cmodules_clean" > actions. They appear simple, but they seem to depend on > `make` rather than Module::Build. Stas, are these just > that simple

Re: Apache::TestMB

2004-06-22 Thread Ken Williams
On Jun 22, 2004, at 12:18 AM, David Wheeler wrote: * Ken, how do I add code so that ./Build help lists the new actions, and ./Build help $new_action prints out some documentation for the action? ./Build help should work already. ./Build help $newaction should work automatically if you add docu

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
On Jun 21, 2004, at 6:12 PM, David Wheeler wrote: Here's a new subclass for Module::Build, Apache::TestMB, which allows modules that use Module::Build to run tests using Apache::Test. Let me make a few comments on my "XXX" comments in the source code, and aske a couple of q

Re: Apache::TestMB

2004-06-22 Thread David Wheeler
On Jun 21, 2004, at 8:29 PM, Ken Williams wrote: I see - so the author would design their tests so they could be run either with or without a live server? I'm guessing many authors would want to require a live server, and thus rely on Apache::TestMB. Most module authors design their tes

Re: Apache::TestMB

2004-06-22 Thread Ken Williams
On Jun 21, 2004, at 8:12 PM, David Wheeler wrote: Hi All, Here's a new subclass for Module::Build, Apache::TestMB, which allows modules that use Module::Build to run tests using Apache::Test. My assumption is that it would be distributed with Apache::Test; therefore its use is something

Apache::TestMB

2004-06-22 Thread David Wheeler
Hi All, Here's a new subclass for Module::Build, Apache::TestMB, which allows modules that use Module::Build to run tests using Apache::Test. My assumption is that it would be distributed with Apache::Test; therefore its use is something like this: use Module::Build; my $build_pkg =