Re: [Viking-devel] Request for comment for Bing maps support

2011-02-13 Thread Robert Norris
> Date: Sun, 13 Feb 2011 11:27:50 -0800 > From: miker...@lacklustre.net > To: viking-devel@lists.sourceforge.net > Subject: Re: [Viking-devel] Request for comment for Bing maps support > > Quickie: the copyright notice is displayed twice if you enable > aut

Re: [Viking-devel] Request for comment for Bing maps support

2011-02-13 Thread Mike Ryan
Quickie: the copyright notice is displayed twice if you enable auto-downloading of maps after you add the layer. To reproduce: 1) add a new bing map layer 2) copyright notice appears, click OK 3) right click map, go to properties 4) check "autodownload maps", click OK 5) copyright notice reappear

[Viking-devel] Request for comment for Bing maps support

2011-02-13 Thread Guilhem Bonnefille
Hi, As you certainly noticed, I sent some patches to the mailing list. These patches are my work for Bing maps support in viking. I think this work is quite complete: maps appear, logo and copyright are displayed. So I'm ready to commit them on master branch. Nevertheless, I took some shortcuts i

[Viking-devel] [PATCH 3/3] Add support for Bing maps

2011-02-13 Thread Guilhem Bonnefille
Add support for Bing maps. This implementation is quite rude as: * logo is built-in, while a right solution would be to download the logo and caching the result in viking's cache. * attributions are downloaded at starting time, while a right solution would be to cache the file in viking's cach

[Viking-devel] [PATCH 2/3] Add support for dynamic copyright

2011-02-13 Thread Guilhem Bonnefille
Some providers use different copyright at different zoom levels or different world region. This is an initial implementation. By some aspect it is a rude patch. Currently, VikViewport asks VikMapsLayer which asks VikMapSouce which calls back VikViewport via function callback. This seems the simple

[Viking-devel] [PATCH 1/3] Add logo support

2011-02-13 Thread Guilhem Bonnefille
Add support for logo, displayed in viewport. Signed-off-by: Guilhem Bonnefille --- src/vikmapslayer.c|4 src/vikmapsource.c| 14 ++ src/vikmapsource.h|2 ++ src/vikmapsourcedefault.c | 18 +- src/vikviewport.c | 44 ++