On 03/02/2016 05:24 PM, Fabiano Fidêncio wrote:
> On Wed, Mar 2, 2016 at 8:05 PM, Eduardo Lima (Etrunko)
> wrote:
>> On 03/02/2016 02:46 PM, Eduardo Lima (Etrunko) wrote:
>>> On 03/02/2016 12:23 PM, Fabiano Fidêncio wrote:
>>>> Let's take advantage of GRes
r-app.c
> @@ -36,9 +36,6 @@
> #include
> #include
>
> -#include
> -#include
> -
> #ifdef HAVE_SYS_SOCKET_H
> #include
> #endif
>
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com
__
On 03/11/2016 11:44 AM, Fabiano Fidêncio wrote:
[snip]
>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>> new file mode 100644
>> index 000..470733b
>> --- /dev/null
>> +++ b/tests/Makefile.am
>> @@ -0,0 +1,30 @@
>> +NULL =
>> +
>> +AM_CPPFLAGS =
libvirt-viewer.la \
>> $(NULL)
>> endif
>> @@ -205,6 +218,7 @@ remote_viewer_CFLAGS = \
>> $(SPICE_CONTROLLER_CFLAGS) \
>> $(NULL)
>> remote_viewer_LDADD = \
>> + libvirt-view
On 11/11/2015 09:09 AM, Eduardo Lima (Etrunko) wrote:
> On 11/11/2015 05:11 AM, Pavel Grunt wrote:
>> Hi Eduardo,
>>
>> these warnings were introduced after spice-gtk v0.30 release, virt-viewer
>> currently depends on spice-gtk v0.29.35. You can make the code condition
Wcpp]
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-display-spice.c | 2 +-
src/virt-viewer-display-spice.h | 3 +--
src/virt-viewer-session-spice.c | 5 +
src/virt-viewer-session-spice.h | 3 +--
4 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/virt-viewer-displa
Also, remove unecessary AC_SUBST calls
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index 6d8475b..ee9dc73 100644
--- a/configure.ac
+++ b/configure.ac
@@ -102,10 +102,8
On 03/15/2016 11:08 AM, Pavel Grunt wrote:
> On Tue, 2016-03-15 at 10:57 -0300, Eduardo Lima (Etrunko) wrote:
>> On 11/11/2015 09:09 AM, Eduardo Lima (Etrunko) wrote:
>>>
>>> On 11/11/2015 05:11 AM, Pavel Grunt wrote:
>>>>
>>>> Hi Eduardo,
>&
On 03/22/2016 07:57 AM, Pavel Grunt wrote:
> Hi,
>
> you need to bump spice-gtk dependency to v0.31, because these headers
> are not in v0.30 and virt-viewer currently depends on v0.30.
>
Oh, I missed that. Thanks for the note, I will send a new version with
the new dependency.
--
Eduardo de B
On 03/22/2016 08:02 AM, Pavel Grunt wrote:
> Hi,
>
> imo with the change the line is too long
>
> About the AC_SUBST calls - iirc they are defined automatically when
> pkg-config is >= 0.24 (not the case of rhel6).
> Or is it about something else (why just _LIBS and not _CFLAGS) ?
>
About line
On 03/22/2016 10:42 AM, Eduardo Lima (Etrunko) wrote:
> On 03/22/2016 08:02 AM, Pavel Grunt wrote:
>> Hi,
>>
>> imo with the change the line is too long
>>
>> About the AC_SUBST calls - iirc they are defined automatically when
>> pkg-config is >= 0.24
[-Wcpp]
This patch also bumps spice version requirement to 0.31, to ensure
those files are available.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac| 2 +-
src/virt-viewer-display-spice.c | 2 +-
src/virt-viewer-display-spice.h | 3 +--
src/virt-viewer-session-sp
Also, remove unecessary AC_SUBST calls, as {GLIB2,GTK}_LIBS are never
touched.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/configure.ac b/configure.ac
index 115ad81..4f7087e 100644
--- a/configure.ac
+++ b
On 06/14/2016 06:40 PM, Fabiano Fidêncio wrote:
> This call was added as hack during the GApplication's port, as the
> remote-viewer window was closed as soon as the connection happened.
>
> This behaviour hapened because we didn't chain-up to the parent's
> window_added() method, which already ca
On 06/14/2016 06:40 PM, Fabiano Fidêncio wrote:
> GApplication's resource base path is based on the application-id, for
> instamce:
type (instance)
> - virt-viewer's resource base path: /org/virt-manager/virt-viewer, as
>the virt-viewer's application id is: org.virt-manager.virt-viewer.
>
On 06/15/2016 07:20 PM, Jim Fehlig wrote:
> On 06/15/2016 06:42 AM, Pavel Grunt wrote:
>> Hi,
>>
>> On Tue, 2016-06-14 at 23:40 +0200, Fabiano Fidêncio wrote:
>>> These small series has as objective start "preparing the ground" for
>>> the work Sagar Huge has been done on re-design/re-write virt-vi
On 06/21/2016 05:04 PM, Fabiano Fidêncio wrote:
> Since commit 1f6f1a48 the resource path for icons has been broken.
> The reason is that when moving the .ui files to $(srcdir)/resources/ui,
> the define used for the resources was changed to reflect the new
> directory. However, this change wasn't
On 06/21/2016 05:04 PM, Fabiano Fidêncio wrote:
> GtkRevealer was intrudced in Gtk+ 3.10 and, combined with Gtk Overlay
> (intoduced in Gtk+ 3.2), can provide a more sustainably implementation
> of the AutoDrawer functionality.
>
> This approach is completely based on the approach taken by virt-ma
b/src/virt-viewer-util.c
> @@ -50,8 +50,9 @@ virt_viewer_error_quark(void)
> GtkBuilder *virt_viewer_util_load_ui(const char *name)
> {
> GtkBuilder *builder;
> -gchar *resource = g_strdup_printf("%s/%s",
> +gchar *resource = g_strdup_printf("%s/%s/%s",
M
On 06/21/2016 05:04 PM, Fabiano Fidêncio wrote:
> diff --git a/src/view/virt-viewer-timed-revealer.c
> b/src/view/virt-viewer-timed-revealer.c
> new file mode 100644
> index 000..bba363c
> --- /dev/null
> +++ b/src/view/virt-viewer-timed-revealer.c
> @@ -0,0 +1,224 @@
> +/*
> + * Virt Viewer:
On 06/21/2016 05:50 PM, Fabiano Fidêncio wrote:
> On Tue, Jun 21, 2016 at 10:39 PM, Eduardo Lima (Etrunko)
> wrote:
>> On 06/21/2016 05:04 PM, Fabiano Fidêncio wrote:
>>> GtkRevealer was intrudced in Gtk+ 3.10 and, combined with Gtk Overlay
>>> (intoduced in
This is not actually necessary as of C99. You only need to initialize
any field of a structure to get all other fields initialized too.
On 06/22/2016 03:17 AM, Pavel Grunt wrote:
> ---
> src/virt-viewer-display-spice.c | 2 +-
> src/virt-viewer-display-vnc.c | 2 +-
> src/virt-viewer-window.c
This patch is a preparation for a upcoming UI change that will present
the ISO list in a separate dialog, instead of a submenu.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 26 --
src/resources/ui/virt-viewer.ui | 8
2 files
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 9b552eb..959804d 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -465,10
On 06/22/2016 05:16 PM, Pavel Grunt wrote:
> On Wed, 2016-06-22 at 14:59 -0300, Eduardo Lima (Etrunko) wrote:
>> This is not actually necessary as of C99. You only need to initialize
>> any field of a structure to get all other fields initialized too.
>
> yes, I was just a
On 06/23/2016 10:26 AM, Pavel Grunt wrote:
> On Thu, 2016-06-23 at 10:15 -0300, Eduardo Lima (Etrunko) wrote:
>> On 06/22/2016 05:16 PM, Pavel Grunt wrote:
>>> On Wed, 2016-06-22 at 14:59 -0300, Eduardo Lima (Etrunko) wrote:
>>>> This is not actually necessa
This patch is a preparation for a upcoming UI change that will present
the ISO list in a separate dialog, instead of a submenu.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 23 +++
src/resources/ui/virt-viewer.ui | 8
2 files changed
s: hwdata
> -BuildRequires: msitools >= 0.95-4
> +BuildRequires: msitools >= 0.95-5
>
> BuildArch: noarch
>
>
Acked-by: Eduardo Lima (Etrunko)
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru...@redhat.com
On 06/23/2016 01:36 PM, Christophe Fergeau wrote:
> On Thu, Jun 23, 2016 at 10:13:25AM -0300, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/ovirt-foreign-menu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
was about.
Okay fixed.
>
> Christophe
>
> On Thu, Jun 23, 2016 at 11:23:11AM -0300, Eduardo Lima (Etrunko) wrote:
>> This patch is a preparation for a upcoming UI change that will present
>> the ISO list in a separate dialog, instead of a submenu.
>>
>> Signed-
In this version:
- Rebase to latest master
- Better commit messages
- Additional debug message if returning NULL in patch 2
Eduardo Lima (Etrunko) (2):
Get ovirt foreign menu item from UI file
Use more accurate debug messages for foreign menu
src/ovirt-foreign-menu.c| 3 ++-
src
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 9b552eb..2d286fb 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -465,10
of a submenu.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer.c | 23 +++
src/resources/ui/virt-viewer.ui | 8
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 71723cf..6d29bf2
On 06/24/2016 04:16 AM, Christophe Fergeau wrote:
> Hey,
>
> On Fri, Jun 24, 2016 at 02:44:07AM +0200, Fabiano Fidêncio wrote:
>> On Thu, Jun 23, 2016 at 7:15 PM, Eduardo Lima (Etrunko)
>> wrote:
>>> In this version:
>>> - Rebase to latest master
>>
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276
Signed-off-by: Eduardo Lima (Etrunko)
---
As a result of commit cc455b7f916110d7cfae6b7af753349e070c9494, setting
custom color for background does not work anymore on my Fedora 23
system. The status label still rendered with white color
On 06/28/2016 07:21 AM, Fabiano Fidêncio wrote:
> On Tue, Jun 28, 2016 at 12:08 PM, Pavel Grunt wrote:
>> Hi Eduardo,
>>
>> On Mon, 2016-06-27 at 18:00 -0300, Eduardo Lima (Etrunko) wrote:
>>> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276
>>>
&
Let's just stick with default theme colors.
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276
Signed-off-by: Eduardo Lima (Etrunko)
---
src/virt-viewer-notebook.c | 13 ++---
src/virt-viewer-window.c | 10 --
2 files changed, 2 insertions(+), 21 deletions(-)
On 06/28/2016 12:16 PM, Fabiano Fidêncio wrote:
> On Tue, Jun 28, 2016 at 5:10 PM, Pavel Grunt wrote:
>> Create toolbar widget in the loop
>
> NACK from my side.
> There is any gain on re-factoring a code that will be removed as soon
> as we do the release.
> Actually, it just makes my life harde
On 06/29/2016 05:08 AM, Pavel Grunt wrote:
> Hi,
>
> Imo the commit message should say that there are issues with the font /
> background colour since commit ... in some gtk versions - like you said in the
> comment for v1, because that is the reason for this patch. Getting rid of
> deprecated fun
On 06/29/2016 10:36 AM, Fabiano Fidêncio wrote:
> The "grab-notify" signal lets us know when our widget becomes
> shadowed by a Gtk+ grab on another widget, or when it becomes unshadowed
> due to a grab being removed.
>
> That's exactly the case we face when dealing with "usb-redirection" and
> "c
: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 2d286fb..33ff4f1 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -797,7 +797,7 @@ static void
On 06/30/2016 09:03 AM, Fabiano Fidêncio wrote:
> On Thu, Jun 30, 2016 at 2:01 PM, Eduardo Lima (Etrunko)
> wrote:
>> This is a temporary solution, as discussed in the bug. We will adjust
>> the timer to refresh the ISO list from 15 seconds to 5 minutes (300
>> seconds), w
programming the whole UI manually.
Eduardo Lima (Etrunko) (11):
ovirt-foreign-menu: Rework states logic
ovirt-foreign-menu: Use g_clear_pointer/g_clear_object
ovirt-foreign-menu: Remove timer used to refresh iso list
ovirt-foreign-menu: Add accessors for current iso and iso list
ovirt
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 24b5af2..75154bb 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -428,12
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 49 ++--
src/ovirt-foreign-menu.h | 5 -
2 files changed, 39 insertions(+), 15 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index b071e27
Signed-off-by: Eduardo Lima (Etrunko)
---
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 115 +++
src/remote-viewer-iso-list-dialog.h| 58 ++
src/resources/ui/remote-viewer-iso-list.ui | 174
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 68
1 file changed, 16 insertions(+), 52 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index b0b8fec..889e7bc 100644
--- a/src/ovirt-foreign
Use switch/case instead of lots of conditional blocks
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 76 +++-
1 file changed, 36 insertions(+), 40 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
we make it acessible via property to avoid interdependency between
objects.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c | 20 +++-
src/remote-viewer-iso-list-dialog.h | 3
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c
With the new ISO dialog, the user triggers the refresh manually.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 23 +++
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 889e7bc
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 1 +
src/virt-viewer-window.c| 29 +
2 files changed, 30 insertions(+)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index ee23ba5..e27ee77 100644
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 57 +++--
1 file changed, 21 insertions(+), 36 deletions(-)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index 6e3c5ad..ee23ba5 100644
--- a/src
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c| 149 +
src/resources/ui/remote-viewer-iso-list.ui | 4 +-
2 files changed, 152 insertions(+), 1 deletion(-)
diff --git a/src/remote-viewer-iso-list-dialog.c
b/src/remote-viewer
On 07/18/2016 09:14 AM, Pavel Grunt wrote:
> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote:
>> With the new ISO dialog, the user triggers the refresh manually.
>
> This should come after the dialog is introduced>
Well, I have no plans in merging an
On 07/18/2016 06:15 AM, Pavel Grunt wrote:
> Hi Eduardo,
>
> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote:
>> Use switch/case instead of lots of conditional blocks
> Yes, it is more readable
>>
>> Signed-off-by: Eduardo Lima (Etrunko)
>> -
Use switch/case instead of lots of conditional blocks
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 41 +++--
1 file changed, 15 insertions(+), 26 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index
On 07/18/2016 11:58 AM, Pavel Grunt wrote:
> On Mon, 2016-07-18 at 10:22 -0300, Eduardo Lima (Etrunko) wrote:
>> On 07/18/2016 06:15 AM, Pavel Grunt wrote:
>>>
>>> Hi Eduardo,
>>>
>>> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote:
On 07/19/2016 12:46 PM, Christophe Fergeau wrote:
> Your glade seems to have added unrelated changes to that commit. If
> newer versions of glade are always going to make these changes, we can
> commit them separately.
>
Dunno why all those changes got in, most likely because of different
version
On 07/19/2016 12:11 PM, Christophe Fergeau wrote:
> On Mon, Jul 18, 2016 at 10:18:14AM -0300, Eduardo Lima (Etrunko) wrote:
>> On 07/18/2016 09:14 AM, Pavel Grunt wrote:
>>> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote:
>>>> With the new ISO dialog,
On 07/19/2016 12:43 PM, Christophe Fergeau wrote:
> On Sun, Jul 17, 2016 at 11:13:05PM -0300, Eduardo Lima (Etrunko) wrote:
>> With this commit, we finish cleaning up ovirt foreign menu code, which
>> only deals with data, leaving the UI bits to be handled properly in the
>>
On 07/19/2016 12:43 PM, Christophe Fergeau wrote:
> Why?
>
Because with the dialog, every time the Refresh button is pressed, we
clear the ISO list and it will only be populated again when it receives
the notify::files signal.
--
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etru.
On 07/19/2016 01:13 PM, Christophe Fergeau wrote:
> On Sun, Jul 17, 2016 at 11:13:08PM -0300, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/Makefile.am| 3 +
>> src/remote-viewer-iso
On 07/19/2016 12:57 PM, Christophe Fergeau wrote:
>> +
>> +self = REMOTE_VIEWER_ISO_LIST_DIALOG(dialog);
>> +self->priv->foreign_menu = foreign_menu;
>
> I'd g_object_ref it if you need to have it around (together with
> g_clear_object
> in dispose/finalize).
Okay, fixed.
>> +
>> +#ifde
On 07/19/2016 02:54 PM, Eduardo Lima (Etrunko) wrote:
> On 07/19/2016 12:57 PM, Christophe Fergeau wrote:
>>> +
>>> +self = REMOTE_VIEWER_ISO_LIST_DIALOG(dialog);
>>> +self->priv->foreign_menu = foreign_menu;
>>
>> I'd g_objec
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
we make it acessible via property to avoid interdependency between
objects.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c | 25 -
src/remote-viewer-iso-list-dialog.h
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index 6e3c5ad..af3ae46 100644
--- a/src/resources/ui/virt-viewer.ui
On 07/19/2016 12:32 PM, Christophe Fergeau wrote:
> On Sun, Jul 17, 2016 at 11:13:04PM -0300, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko)
>> ---
>> src/ovirt-foreign-menu.c | 49
>> ++--
>&g
It seems to give more modern look to the dialog, but it requires Gtk+
3.12, thus I will am keeping this commit separated.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac| 4 ++--
src/remote-viewer-iso-list-dialog.c | 33 -
2 files
With the new ISO dialog, the user triggers the refresh manually.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 23 +++
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index a51f2c9
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index 6e3c5ad..af3ae46 100644
--- a/src/resources/ui/virt-viewer.ui
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c| 157 -
src/resources/ui/remote-viewer-iso-list.ui | 5 +-
2 files changed, 158 insertions(+), 4 deletions(-)
diff --git a/src/remote-viewer-iso-list-dialog.c
b/src/remote-viewer
Signed-off-by: Eduardo Lima (Etrunko)
Acked-by: Christophe Fergeau
---
src/ovirt-foreign-menu.c | 68
1 file changed, 16 insertions(+), 52 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 03dfbe7..a51f2c9
Use switch/case instead of lots of conditional blocks
Signed-off-by: Eduardo Lima (Etrunko)
Acked-by: Pavel Grunt
---
src/ovirt-foreign-menu.c | 46 --
1 file changed, 20 insertions(+), 26 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src
, making it more robust in case of errors.
Eduardo Lima (Etrunko) (12):
ovirt-foreign-menu: Rework states logic
ovirt-foreign-menu: Use g_clear_pointer/g_clear_object
ovirt-foreign-menu: Remove timer used to refresh iso list
ovirt-foreign-menu: Add accessors for current iso and iso list
ovirt
When user presses the Refresh button in ISO dialog, the list is cleared, and
currently, the only way it is informed of the new list is by the notify signal.
The same applies when an error occurs while trying to change the current ISO.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 112 +
src/remote-viewer-iso-list-dialog.h| 58 +++
src/resources/ui
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 49 ++--
src/ovirt-foreign-menu.h | 5 -
2 files changed, 39 insertions(+), 15 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 565ef22
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 1 +
src/virt-viewer-window.c| 24
2 files changed, 25 insertions(+)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index af3ae46..e9609ec 100644
--- a
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
we make it acessible via property to avoid interdependency between
objects.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c | 31 +++
src/remote-viewer-iso-list
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 49 ++--
src/ovirt-foreign-menu.h | 5 -
2 files changed, 39 insertions(+), 15 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 565ef22
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 1 +
src/virt-viewer-window.c| 24
2 files changed, 25 insertions(+)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index af3ae46..e9609ec 100644
--- a
With this commit, we finish cleaning up ovirt foreign menu code, which
only deals with data, leaving the UI bits to be handled properly in the
new ISO list dialog.
This patch also updates remote-viewer to reflect the change.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
we make it acessible via property to avoid interdependency between
objects.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c | 31 +++
src/remote-viewer-iso-list
With the new ISO dialog, the user triggers the refresh manually.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign-menu.c | 23 +++
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index a51f2c9
Signed-off-by: Eduardo Lima (Etrunko)
---
src/resources/ui/virt-viewer.ui | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui
index 6e3c5ad..af3ae46 100644
--- a/src/resources/ui/virt-viewer.ui
When user presses the Refresh button in ISO dialog, the list is cleared, and
currently, the only way it is informed of the new list is by the notify signal.
The same applies when an error occurs while trying to change the current ISO.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/ovirt-foreign
toggle
- Removed "Select ISO" label and alignment in header bar patch.
Eduardo Lima (Etrunko) (10):
ovirt-foreign-menu: Remove timer used to refresh iso list
ovirt-foreign-menu: Add accessors for current iso and iso list
ovirt-foreign-menu: Remove GtkMenu related functions
ovi
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c| 180 -
src/resources/ui/remote-viewer-iso-list.ui | 5 +-
2 files changed, 181 insertions(+), 4 deletions(-)
diff --git a/src/remote-viewer-iso-list-dialog.c
b/src/remote-viewer
s gone too.
Signed-off-by: Eduardo Lima (Etrunko)
---
configure.ac | 4 +-
src/remote-viewer-iso-list-dialog.c| 31 +--
src/resources/ui/remote-viewer-iso-list.ui | 87 +++---
3 files changed, 60 insertions(+), 62 deletions(-)
di
Signed-off-by: Eduardo Lima (Etrunko)
---
po/POTFILES.in | 2 +
src/Makefile.am| 3 +
src/remote-viewer-iso-list-dialog.c| 106
src/remote-viewer-iso-list-dialog.h| 58 +++
src/resources/ui
On 08/02/2016 01:17 PM, Christophe Fergeau wrote:
> On Fri, Jul 29, 2016 at 06:40:23PM -0300, Eduardo Lima (Etrunko) wrote:
>> I have pushed the first two patches of the series because they were
>> already acknowledged and were pretty much self-contained.
>>
>> I trie
On 08/09/2016 12:44 PM, Christophe Fergeau wrote:
> On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote:
>> Just connect to the signal
>
> I'm tempted to ask "why?". I think it's recommended (more efficient) to
> just override the vfunc directly when you can (ie when you derive a new
> wid
On 08/10/2016 07:41 AM, Pavel Grunt wrote:
> On Tue, 2016-08-09 at 17:44 +0200, Christophe Fergeau wrote:
>> On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote:
>>>
>>> Just connect to the signal
>>
>> I'm tempted to ask "why?". I think it's recommended (more efficient) to
>> just override
On 09/05/2016 09:15 AM, Christophe Fergeau wrote:
> On Tue, Aug 02, 2016 at 06:17:31PM +0200, Christophe Fergeau wrote:
>>> Eduardo Lima (Etrunko) (10):
>>> ovirt-foreign-menu: Remove timer used to refresh iso list
>>> ovirt-foreign-menu: Add accessors for curren
On 08/04/2016 12:09 AM, Xiaodai Wang wrote:
> - Original Message -
>> From: "Fabiano Fidêncio"
>> To: "Eduardo Lima (Etrunko)"
>> Cc: "Christophe Fergeau" , "virt"
>>
>> Sent: Wednesday, August 3, 2016 10:36:07
On 10/10/16 12:05, Daniel P. Berrange wrote:
> On Mon, Oct 10, 2016 at 04:26:29PM +0200, Fabiano Fidêncio wrote:
>> On Mon, Oct 10, 2016 at 2:38 PM, Daniel P. Berrange
>> wrote:
>>> The 4.0 release was in June, and there have not been very many changes
>>> since then, but there are a couple of si
From: Christophe Fergeau
Signed-off-by: Eduardo Lima (Etrunko)
---
I tweaked your patch a bit with a proper dialog for showing error if it
happens, this is going to be reused for the case of fetching the ISO
list as well.
---
src/ovirt-foreign-menu.c| 41
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and
we make it acessible via property to avoid interdependency between
objects.
Signed-off-by: Eduardo Lima (Etrunko)
---
src/remote-viewer-iso-list-dialog.c | 31 +++
src/remote-viewer-iso-list
101 - 200 of 429 matches
Mail list logo
