On Tue, Oct 20, 2009 at 1:56 PM, Adam Barth wrote:
> 1) Epic uber bugs that are incomprehensible. For example:
>
> [...]
> https://bugs.webkit.org/show_bug.cgi?id=3749
@_@ Whoops, didn't realize that these patches are still active. All ruby
work went to https://bugs.webkit.org/show_bug.cgi?id
On Mon, Oct 19, 2009 at 8:54 PM, Adam Barth wrote:
> On Mon, Oct 19, 2009 at 8:39 PM, David Kilzer wrote:
>> Why are there 17 patches with review+ that never get landed?
>>
>> This has bothered me in the past, but I wasn't sure if it was the same group
>> of patches or not.
>
> It's not the same
On Mon, Oct 19, 2009 at 8:39 PM, David Kilzer wrote:
> Why are there 17 patches with review+ that never get landed?
>
> This has bothered me in the past, but I wasn't sure if it was the same group
> of patches or not.
It's not the same group of patches. Sometimes there are patches with
review+
Why are there 17 patches with review+ that never get landed?
This has bothered me in the past, but I wasn't sure if it was the same group of
patches or not.
Dave
On Mon, October 19, 2009 at 7:08:50 PM, Adam Barth wrote:
> WebKit, you are awesome. We're down to our usual 17 now.
>
> Thanks e
On Mon, Oct 19, 2009 at 18:03, Oliver Hunt wrote:
> On Oct 19, 2009, at 5:18 PM, Erik Arvidsson wrote:
>
>> I'm trying to clean up some inconsistencies with when keypress events
>> are dispatched.
>>
>> WebKit's key event model is modeled to be compatible with Internet
>> Explorer and Internet Exp
WebKit, you are awesome. We're down to our usual 17 now.
Thanks everyone!
Adam
On Mon, Oct 19, 2009 at 3:27 PM, Eric Seidel wrote:
> We're back down to 25 after Yong's epic cq+ing this morning. The
> queue had a record 13 patch backlog for a while. Thank you Yong for
> cleaning the pending-c
On Mon, Oct 19, 2009 at 6:03 PM, Oliver Hunt wrote:
> The real issue is whether application shortcuts get precedence over DOM
> event handlers, currently on mac the DOM event handlers get precedence (and
> thus the ability to override/prevent application shortcuts) and on windows
> they don't. T
On Oct 19, 2009, at 5:18 PM, Erik Arvidsson wrote:
I'm trying to clean up some inconsistencies with when keypress events
are dispatched.
WebKit's key event model is modeled to be compatible with Internet
Explorer and Internet Explorer does not fire keypress for Ctrl+key [1]
The key event mode
I'm trying to clean up some inconsistencies with when keypress events
are dispatched.
WebKit's key event model is modeled to be compatible with Internet
Explorer and Internet Explorer does not fire keypress for Ctrl+key [1]
Safari Win does not fire any keypress events when ctrl is held down
Safar
We're back down to 25 after Yong's epic cq+ing this morning. The
queue had a record 13 patch backlog for a while. Thank you Yong for
cleaning the pending-commit list!
Still 25 to go. All of which require manual attention from committers.
-eric
On Mon, Oct 19, 2009 at 11:52 AM, Eric Seidel wr
On Mon, Oct 19, 2009 at 1:58 PM, Joe Mason wrote:
> Perhaps the browser should have "Copy text" and "Copy all objects"
> options (in which case either WebKit needs to support both modes, or
> the browser would need to filter the copied data).
Yes, that could help. Filed crbug.com/25239.
PK
__
On Mon, Oct 19, 2009 at 1:55 PM, Pam Greene wrote:
> On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting wrote:
>
>> On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher wrote:
>>
>>> I think there is a good use case for copying a selection of HTML from any
>>> web page and pasting that into the rich text e
On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting wrote:
> On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher wrote:
>
>> I think there is a good use case for copying a selection of HTML from any
>> web page and pasting that into the rich text editor of a web mail program.
>>
>
> I agree, but that case
On Oct 19, 2009, at 1:43 PM, Peter Kasting wrote:
Note that within Chrome we put in ctrl-shift-v to "paste as plain
text" precisely because of issues like this. Most other programs
don't have that option though (and even in Chrome it's hard to
discover).
I guess it isn't exactly what you
On Oct 19, 2009, at 1:43 PM, Peter Kasting wrote:
Note that within Chrome we put in ctrl-shift-v to "paste as plain
text" precisely because of issues like this. Most other programs
don't have that option though (and even in Chrome it's hard to
discover).
On Mac we call this "Paste and Ma
On Mon, Oct 19, 2009 at 1:45 PM, David Hyatt wrote:
> On Oct 19, 2009, at 3:37 PM, Peter Kasting wrote:
>
> The only time non-text should be copied is when it is part of a rich text
> area. In that case copying rich content makes sense.
>
>
> Ok, well we fundamentally disagree on this point, so
On Mon, Oct 19, 2009 at 1:43 PM, Peter Kasting wrote:
> On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher wrote:
>
>> I think there is a good use case for copying a selection of HTML from any
>> web page and pasting that into the rich text editor of a web mail program.
>>
>
> I agree, but that case
On Oct 19, 2009, at 3:37 PM, Peter Kasting wrote:
On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt wrote:
You aren't only selecting text on a page though. For example,
copying can be of all the HTML content. This includes tables,
images, plugins, etc. If you don't highlight that content, th
On Mon, Oct 19, 2009 at 1:40 PM, Darin Fisher wrote:
> I think there is a good use case for copying a selection of HTML from any
> web page and pasting that into the rich text editor of a web mail program.
>
I agree, but that case does not degrade badly when you only copy the text,
whereas if th
On Mon, Oct 19, 2009 at 1:37 PM, Peter Kasting wrote:
> On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt wrote:
>
>> You aren't only selecting text on a page though. For example, copying can
>> be of all the HTML content. This includes tables, images, plugins, etc.
>> If you don't highlight that c
On Mon, Oct 19, 2009 at 1:31 PM, David Hyatt wrote:
> You aren't only selecting text on a page though. For example, copying can
> be of all the HTML content. This includes tables, images, plugins, etc.
> If you don't highlight that content, then you're lying about what gets
> copied.
>
No, you
On Oct 19, 2009, at 3:27 PM, Peter Kasting wrote:
On Mon, Oct 19, 2009 at 1:21 PM, David Hyatt wrote:
On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote:
I'm not quite sure what you mean. Do you just mean it looks
visually confusing, but when you copy/paste you get the right text?
Or are yo
On Mon, Oct 19, 2009 at 1:21 PM, David Hyatt wrote:
> On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote:
> I'm not quite sure what you mean. Do you just mean it looks visually
> confusing, but when you copy/paste you get the right text? Or are you
> saying that it's actually selecting the wrong
On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote:
On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt wrote:
I can get how editing in text fields you might feel a desire to
match the platform (where ragged selection may be the convention),
but once you get into rich text selection (images, floats,
On Oct 19, 2009, at 3:19 PM, Peter Kasting wrote:
On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt wrote:
I can get how editing in text fields you might feel a desire to
match the platform (where ragged selection may be the convention),
but once you get into rich text selection (images, floats,
On Mon, Oct 19, 2009 at 1:13 PM, Ben Goodger wrote:
> To me, it looks ugly to have a ragged edge if you can avoid it. Dave
> did a great job making it look nice in WebKit. I don't have a strong
> feeling on Linux so if people feel strongly there whatever. But on
> Windows Chrome I want to retain t
On Mon, Oct 19, 2009 at 1:10 PM, David Hyatt wrote:
> I can get how editing in text fields you might feel a desire to match the
> platform (where ragged selection may be the convention), but once you get
> into rich text selection (images, floats, tables, columns, etc.), there
> really is no plat
To me, it looks ugly to have a ragged edge if you can avoid it. Dave
did a great job making it look nice in WebKit. I don't have a strong
feeling on Linux so if people feel strongly there whatever. But on
Windows Chrome I want to retain the solid edge. Maybe there are ways
the solid edge can be imp
On Oct 19, 2009, at 3:03 PM, Ben Goodger wrote:
I agree. I would like to retain this mode of selection in Windows
Chrome at least. I think it's only ragged in most apps because people
don't take the time to make it look nice.
-Ben
Yeah, when it comes to complex Web page selection, I don't thi
FYI, this was filed some time ago:
http://code.google.com/p/chromium/issues/detail?id=3527
https://bugs.webkit.org/show_bug.cgi?id=21960
On Mon, Oct 19, 2009 at 1:03 PM, Ben Goodger wrote:
> I agree. I would like to retain this mode of selection in Windows
> Chrome at least. I think it's only ra
I agree. I would like to retain this mode of selection in Windows
Chrome at least. I think it's only ragged in most apps because people
don't take the time to make it look nice.
-Ben
On Mon, Oct 19, 2009 at 12:57 PM, David Hyatt wrote:
> On Oct 16, 2009, at 7:07 PM, Evan Martin wrote:
>
>> When
On Oct 16, 2009, at 7:07 PM, Evan Martin wrote:
When you select multiple lines of text in WebKit, the highlight paints
over whitespace on the right margin.
This is correct behavior for Mac, but not for Windows or Linux.
I would suggest making it be controlled by a Setting rather than
#ifdef
On Sun, Oct 18, 2009 at 11:34 PM, Adam Barth wrote:
> 2) If you see a patch on the list that's ready to land (almost all of
> them), you can mark it commit-queue+ to have the commit bot land it.
> When you do this, please be sure to watch the tree for regressions,
> just like you would if you type
I'm able to do it now. Thanks.
-Yong
- Original Message -
From: "Eric Seidel"
To: "Yong Li"
Cc: "Adam Barth" ;
Sent: Monday, October 19, 2009 11:33 AM
Subject: Re: [webkit-dev] Calling all committers: The pending-commit list
isoverflowing
yong...@torchmobile.com did not have "E
- Original Message -
From: "Adam Barth"
To:
Sent: Monday, October 19, 2009 3:21 AM
Subject: Re: [webkit-dev] Calling all committers: The pending-commit list
isoverflowing
If you're a committer, you can help drive that number to zero. Here's
what you can do:
1) If you have a patc
Mark correctly points out that I meant:
http://webkit.org/pending-commit
(webblaze.org is my server for running experiments.)
Adam
On Sun, Oct 18, 2009 at 11:34 PM, Adam Barth wrote:
> We have 43 patches that have been reviewed and are waiting to land:
>
> http://webblaze.org/pending-commit
>
36 matches
Mail list logo
