Re: [webkit-dev] Lots of “BREW” patches up for review

2010-01-14 Thread KwangYul Seo
I will check the issue as soon as possible and let you know the result. In case there is a legal problem with BREW with regard to NDA, BREW MP can be used instead because BREW MP is an open platform. On Thu, Jan 14, 2010 at 6:27 AM, Holger Freyther wrote: > On Wednesday 13 January 2010 18:23:21

Re: [webkit-dev] Lots of “BREW” patches up for review

2010-01-14 Thread KwangYul Seo
Okay. I will add a new wiki page for the BREW port. Thanks. Regards, Kwang Yul Seo On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat wrote: >> This is not a one-time code drop. We want to maintain the BREW port >> ongoing and will do everything that are required to keep the BREW port >> up and runn

[webkit-dev] webkit.org/pending-review

2010-01-14 Thread Eric Seidel
Oliver Hunt mentioned this evening that he found the webkit.org/pending-review page confusing because it lists both commit-queue? patches and review? patches. I agreed. I filed https://bugs.webkit.org/show_bug.cgi?id=33656 to track updating /pending-review to more modern review URL and made some

Re: [webkit-dev] Remove underscore check in check-webkit-style?

2010-01-14 Thread Kenneth Christiansen
In Qt we only allow underscored in methods that start with qt_ and they are used for private API, such as for the DRT and for API that we havent had the time to API review, but are still needed by some other software products. Kenneth On Wed, Jan 13, 2010 at 9:32 PM, Darin Fisher wrote: > On We

Re: [webkit-dev] Lots of “BREW” patches up for review

2010-01-14 Thread KwangYul Seo
I created a wiki for the BREW port of WebKit. https://trac.webkit.org/wiki/BREW Currently it contains preliminary information. I will add more contents gradually. Thanks, Kwang Yul Seo On Thu, Jan 14, 2010 at 9:22 AM, Ariya Hidayat wrote: >> This is not a one-time code drop. We want to mainta

Re: [webkit-dev] webkit.org/pending-review

2010-01-14 Thread Maciej Stachowiak
On Jan 14, 2010, at 12:25 AM, Eric Seidel wrote: Oliver Hunt mentioned this evening that he found the webkit.org/pending-review page confusing because it lists both commit-queue? patches and review? patches. I agreed. I filed https://bugs.webkit.org/show_bug.cgi?id=33656 to track updating /pe

[webkit-dev] Video feature request

2010-01-14 Thread Zack S
Hi all, There's a feature that I would find useful that's not as far as I know a part of HTML5/Javascript in Webkit based browsers. Namely, I'd like to be able to open a video from within Javascript without necessarily wanting to play it, but rather I want to be able to extract frames out

Re: [webkit-dev] Video feature request

2010-01-14 Thread Oliver Hunt
On Jan 14, 2010, at 9:00 AM, Zack S wrote: > Hi all, > > There's a feature that I would find useful that's not as far as I know a part > of HTML5/Javascript in Webkit based browsers. > > Namely, I'd like to be able to open a video from within Javascript without > necessarily wanting to pl

Re: [webkit-dev] webkit.org/pending-review

2010-01-14 Thread David Kilzer
I'm pretty sure it's set up as a redirect in the Apache config for webkit.org. $ curl -I http://webkit.org/pending-review HTTP/1.1 301 Moved Permanently Date: Thu, 14 Jan 2010 17:19:39 GMT Server: Apache/2.2.14 (Unix) mod_ssl/2.2.14 OpenSSL/0.9.8l DAV/2 mod_python/3.3.1 Python/2.5.4 Location: ht

Re: [webkit-dev] webkit.org/pending-review

2010-01-14 Thread William Siegrist
Yes, it is in the apache configs. Just email me or assign the bug to me when you've figured out where you want it to go. -Bill On Jan 14, 2010, at 9:23 AM, David Kilzer wrote: > I'm pretty sure it's set up as a redirect in the Apache config for webkit.org. > > $ curl -I http://webkit.org/pe

Re: [webkit-dev] Video feature request

2010-01-14 Thread Chris Marrin
On Jan 14, 2010, at 9:23 AM, Oliver Hunt wrote: > > On Jan 14, 2010, at 9:00 AM, Zack S wrote: > >> Hi all, >> >> There's a feature that I would find useful that's not as far as I know a >> part of HTML5/Javascript in Webkit based browsers. >> >> Namely, I'd like to be able to open a vid

Re: [webkit-dev] Video feature request

2010-01-14 Thread Oliver Hunt
On Jan 14, 2010, at 10:06 AM, Chris Marrin wrote: > > On Jan 14, 2010, at 9:23 AM, Oliver Hunt wrote: > >> >> On Jan 14, 2010, at 9:00 AM, Zack S wrote: >> >>> Hi all, >>> >>> There's a feature that I would find useful that's not as far as I know a >>> part of HTML5/Javascript in Webkit b

Re: [webkit-dev] Did I break the build?

2010-01-14 Thread Eric Seidel
We've seen some remarkable progress towards greener bots in the last week! I've seen all of the bots roll green straight across 3 times in the last 24 hours! Small achievement, but better than before. :) Still a huge number of flakey tests to de-flake though: https://bugs.webkit.org/showdependen

Re: [webkit-dev] Video feature request

2010-01-14 Thread Adam Barth
On Thu, Jan 14, 2010 at 10:06 AM, Chris Marrin wrote: > On Jan 14, 2010, at 9:23 AM, Oliver Hunt wrote: >> On Jan 14, 2010, at 9:00 AM, Zack S wrote: >>> There's a feature that I would find useful that's not as far as I know a >>> part of HTML5/Javascript in Webkit based browsers. >>> >>> Namely,

Re: [webkit-dev] Lots of “BREW” patches up for review

2010-01-14 Thread Adam Treat
You have a complete port of BREW already? Interesting. Can you point to the complete sources so potential reviewers can have a look at what the state is? On Thursday 14 January 2010 07:02:24 am KwangYul Seo wrote: > I created a wiki for the BREW port of WebKit. > > https://trac.webkit.org/wiki/

Re: [webkit-dev] support for WebKit

2010-01-14 Thread Darin Adler
Didn’t you already report this a month ago as ? Wasn’t this fixed in ? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/

Re: [webkit-dev] global new/delete operator in WebKit

2010-01-14 Thread Darin Adler
On Jan 13, 2010, at 6:25 PM, Yong Li wrote: > Sorry for my English. "does" should be "will". I think your question is unclear. The WebKit project will not “ban” use of a global new/delete operator. -- Darin ___ webkit-dev mailing list webkit-dev@

Re: [webkit-dev] Video feature request

2010-01-14 Thread Ian Hickson
On Thu, 14 Jan 2010, Adam Barth wrote: > > I'm not sure if we've implemented it yet, but we could let video > providers opt out of these protections using CORS. That will be specified in HTML5 around the same time that the cross-site subtitle stuff is added (since that has the same problem). --

Re: [webkit-dev] Remove underscore check in check-webkit-style?

2010-01-14 Thread Chris Jerdonek
> Date: Wed, 13 Jan 2010 15:49:05 -0800 > From: David Levin > > 3) Stop checking code in gtk/qt platform directories for underscores? > > I think there are several other checks that code in some of these > directories typically fail due to various issues (public api that should > follow the standa

Re: [webkit-dev] Database in Worker context

2010-01-14 Thread Darin Adler
My main feedback on this plan would be to land and review the work in pieces that are as small as possible. For example, factoring out the database bits into a separate database manager class should be done in an initial first pass that does not make other changes. I’m also not sure I like clas

Re: [webkit-dev] Database in Worker context

2010-01-14 Thread Eric Uhrhane
Trying again; webkit-dev doesn't seem to like my @google.com address. On Thu, Jan 14, 2010 at 2:31 PM, Eric Uhrhane wrote: > Dmitry requested that I not pull stuff out into DatabaseManager at > all, so that step got skipped. > The first changelist [currently in review] does a bunch of refactoring

Re: [webkit-dev] Database in Worker context

2010-01-14 Thread Darin Adler
On Jan 14, 2010, at 2:35 PM, Eric Uhrhane wrote: > I think it would have been hard to break this chunk any smaller. Any time you have a chunk and you’re wondering how it could be broken up smaller, please feel free to ask that question after cc'ing me on a bug. Maciej and I, in particular, have

Re: [webkit-dev] Database in Worker context

2010-01-14 Thread Dmitry Titov
+1 to small patches. I've reviewed a couple of iterations of the patch in https://bugs.webkit.org/show_bug.cgi?id=22725 and it was so far manageable, although it could be split in 2 at least (inheritance change and WorkerThread termination change). For future patches, definitely lets split into sm

Re: [webkit-dev] Lots of “BREW” patches up for review

2010-01-14 Thread KwangYul Seo
Sure. I will open a public Git repository for potential reviewers. I need to clean up the code before opening the complete source code because some device-specific information is from a phone manufacturer under NDA. I think it will take one or two days.Third party libraries with BREW specific patch

Re: [webkit-dev] Lots of “BREW” patches up for r eview

2010-01-14 Thread Eric Seidel
I don't feel like this question was ever answered. Folks seem to be moving forward with setting up infrastructure for a real port (which is good), but at least this question still remains. Also, does the BREW port already have a DumpRenderTree implementation? When should we expect such? -eric

Re: [webkit-dev] Lots of “BREW” patches up for r eview

2010-01-14 Thread Eric Seidel
Most of the BREW patches look fine. I'm happy to review them once there is consensus on the list that WebKit is ready and willing to accept a BREW port. -eric On Thu, Jan 14, 2010 at 5:26 PM, Eric Seidel wrote: > I don't feel like this question was ever answered. > > Folks seem to be moving for

[webkit-dev] questions about allow-tabs

2010-01-14 Thread Chris Jerdonek
I have some background questions about the "allow-tabs" property. I imagine it pre-dates check-webkit-style by quite a while. (1) What's the reason and history behind our use of the property? (2) What component actually does the pre-commit check? I didn't find a reference to "allow-tabs" in Web

[webkit-dev] MathML Patch - Current Code

2010-01-14 Thread Alex Milowski
I've create a new patch that contains all the current code that I have on MathML at: https://bugs.webkit.org/show_bug.cgi?id=33703 I don't expect anyone to review this patch (unless they want to do so). Since I can't create a branch, I'm using this patch to store the current working copy of m

Re: [webkit-dev] MathML Patch - Current Code

2010-01-14 Thread Jeremy Orlow
On Thu, Jan 14, 2010 at 8:23 PM, Alex Milowski wrote: > I've create a new patch that contains all the current code that I have > on MathML at: > > https://bugs.webkit.org/show_bug.cgi?id=33703 > > I don't expect anyone to review this patch (unless they want to do so). > Since > I can't create

Re: [webkit-dev] MathML Patch - Current Code

2010-01-14 Thread Alex Milowski
On Thu, Jan 14, 2010 at 8:27 PM, Jeremy Orlow wrote: > On Thu, Jan 14, 2010 at 8:23 PM, Alex Milowski wrote: >> >> I've create a new patch that contains all the current code that I have >> on MathML at: >> >>   https://bugs.webkit.org/show_bug.cgi?id=33703 >> >> I don't expect anyone to review th

Re: [webkit-dev] questions about allow-tabs

2010-01-14 Thread David Kilzer
On Thu, January 14, 2010 at 6:59:17 PM, Chris Jerdonek wrote: > I have some background questions about the "allow-tabs" property. I > imagine it pre-dates check-webkit-style by quite a while. > > (1) What's the reason and history behind our use of the property? The allow-tabs property (and the

[webkit-dev] MathML Project Contact etc.

2010-01-14 Thread Alex Milowski
I'm presenting my MathML in WebKit work tomorrow at the Joint AMS/MAA meeting here in San Francisco. After looking through my slides I feel that I'm unsatisfied with what I'm telling people about where to go for more information or to contribute to the project. I'd like a better way for: * Ma

Re: [webkit-dev] support for svg handler element

2010-01-14 Thread Dean Jackson
On 10/01/2010, at 1:27 AM, nagarjuna atluri wrote: > Hai all, > > Is handler element for svg supported in webkit.. > can anyone help me out.. If you're talking about the XML Events element that is mentioned in SVG 1.2, then the answer is no - it isn't supported. Dean