Re: [webkit-dev] 194 bugs in pending-commit

2011-06-17 Thread Adam Barth
On Fri, Jun 17, 2011 at 11:13 PM, Peter Kasting wrote: > On Fri, Jun 17, 2011 at 10:56 PM, Adam Barth wrote: >> 2) Mark the patch as obsolete / clear the review flag if we're not >> going to land the patch. > > Does the slash mean "do both"?  I > have https://bugs.webkit.org/show_bug.cgi?id=47036

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-17 Thread Peter Kasting
On Fri, Jun 17, 2011 at 10:56 PM, Adam Barth wrote: > 2) Mark the patch as obsolete / clear the review flag if we're not > going to land the patch. Does the slash mean "do both"? I have https://bugs.webkit.org/show_bug.cgi?id=47036 on that list and the only r+ed patch on it is already marked o

[webkit-dev] 194 bugs in pending-commit

2011-06-17 Thread Adam Barth
There are a 194 open bugs with an R+ patches attached to them: https://bugs.webkit.org/buglist.cgi?query_format=advanced&short_desc_type=notregexp&short_desc=%5C%5BS60%5C%5D&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&keywords_type=allwords&keywords=&bug_stat

Re: [webkit-dev] Making WebKit on ubuntu 10.10 looks for xcodebuild?

2011-06-17 Thread Darin Adler
Figuring out how to get WebKit to build is a topic for webkit-help, not webkit-dev. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Making WebKit on ubuntu 10.10 looks for xcodebuild?

2011-06-17 Thread Tom Smith
Hello, I'm trying to install Webkit on ubuntu 10.10. When I run the make file I get an "xcodebuild: not found" error. So I tried using the autogen.sh to use automake but when m4 is executed it doesn't like the argument "--gnu" specifically the error is: "unrecognized option '--gnu'. The gnuM

Re: [webkit-dev] Compiling SVG lighting filters for ARM NEON

2011-06-17 Thread Martin Robinson
On Fri, Jun 17, 2011 at 5:04 AM, itisravi wrote: > Hello, > 1.Could someone give inputs on what specific project files are to be > modified in a webkit-gtk build if I add new sources to the tree? > > 2.I was trying to build the FELighting Filters for NEON; the build fails > with the following mes

Re: [webkit-dev] Feeling stuck on preparing next patches for CSSRegions/CSSExclusions

2011-06-17 Thread Eric Seidel
You should also feel welcome to land test suites which entirely/mostly fail, and then later land the code changes which make them pass. We used this method with great success for the HTML parser re-write. This can be useful in cases where your individual tests have larger coverage than any indivi

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Eric Seidel
Given how many desktop applications do this, I think we're well off into the land of wishes and fairy tales. :) But it's also possible that libraries like jquery or Google's closure could do this... but again, I'm skeptical. Then again, if we don't expose information like this, they don't ever ha

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Darin Fisher
I think there are web app developers that would do things differently if they knew their user was running on battery power. An app might scale back its CPU usage, or run a timer at a lower frequency. Crazy idea: Maybe an advertising network could be "nice" and not show animated ads to such users?

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Eric Seidel
My 2¢: I'm confused by who the client of this API would be. It seems that "web sites" don't really need to know my battery state. But "web applications" that are on mobile phone (like WebOS, or Apple's original vision for iPhone apps) would want battery state information, but would want *more* in

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Greg Simon
We ran into this problem on webOS with orientation where we did not want to have the UI drawn "wrong" the first time and then (eventually) re-layed out and painted at the correct device orientation. It looked VERY sloppy and web-page-ish, not what we were trying to accomplish. Sure we could have ga

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Darin Fisher
On Fri, Jun 17, 2011 at 10:27 AM, Andrei Popescu wrote: > On Fri, Jun 17, 2011 at 4:21 PM, Darin Fisher wrote: > > > > > > On Fri, Jun 17, 2011 at 4:11 AM, Anssi Kostiainen > > wrote: > >> > >> Hi, > >> > >> On 16.6.2011, at 19.02, ext Darin Fisher wrote: > >> > > >> > On Thu, Jun 16, 2011 at 5

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Andrei Popescu
On Fri, Jun 17, 2011 at 4:21 PM, Darin Fisher wrote: > > > On Fri, Jun 17, 2011 at 4:11 AM, Anssi Kostiainen > wrote: >> >> Hi, >> >> On 16.6.2011, at 19.02, ext Darin Fisher wrote: >> > >> > On Thu, Jun 16, 2011 at 5:12 AM, Anssi Kostiainen >> > wrote: >> > >> > On 15.6.2011, at 21.29, ext Dari

Re: [webkit-dev] Feeling stuck on preparing next patches for CSSRegions/CSSExclusions

2011-06-17 Thread Simon Fraser
I made some comments in the bugs. Simon On Jun 17, 2011, at 9:38 AM, Darin Adler wrote: > On Jun 17, 2011, at 1:58 AM, Mihnea-Vlad Ovidenie wrote: > >> We have seen some patterns for handling properties and we are not sure which >> one to follow. > > It would be helpful if you were more speci

Re: [webkit-dev] Feeling stuck on preparing next patches for CSSRegions/CSSExclusions

2011-06-17 Thread Darin Adler
On Jun 17, 2011, at 1:58 AM, Mihnea-Vlad Ovidenie wrote: > We have seen some patterns for handling properties and we are not sure which > one to follow. It would be helpful if you were more specific here. What were the patterns you have seen? If you give a specific bug number or revision number

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Darin Fisher
On Fri, Jun 17, 2011 at 4:11 AM, Anssi Kostiainen < anssi.kostiai...@nokia.com> wrote: > Hi, > > On 16.6.2011, at 19.02, ext Darin Fisher wrote: > > > > On Thu, Jun 16, 2011 at 5:12 AM, Anssi Kostiainen < > anssi.kostiai...@nokia.com> wrote: > > > > On 15.6.2011, at 21.29, ext Darin Fisher wrote:

Re: [webkit-dev] Compiling SVG lighting filters for ARM NEON

2011-06-17 Thread itisravi
itisravi wrote: > > > itisravi wrote: >> >> Hello all, >> >> Referring to >> https://lists.webkit.org/pipermail/webkit-help/2011-June/002150.html this >> , >> >> I'm trying to cross compile webkit 1.4 (gtk port) for ARM with NEON flags >> enabled for the SVG lighting filters.Though both -m

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

2011-06-17 Thread Anssi Kostiainen
Hi, On 16.6.2011, at 19.02, ext Darin Fisher wrote: > > On Thu, Jun 16, 2011 at 5:12 AM, Anssi Kostiainen > wrote: > > On 15.6.2011, at 21.29, ext Darin Fisher wrote: > > > There should probably be a way to poll the current state. Much as you can > > poll the document.readyState and respond

[webkit-dev] Feeling stuck on preparing next patches for CSSRegions/CSSExclusions

2011-06-17 Thread Mihnea-Vlad Ovidenie
Hello, Part of our efforts towards enabling CSSRegions/CSSExclusions support in WebKit, we have submitted 2 patches last week: [61726][CSSExclusions]Parse wrap shape property [61730][CSSRegions]Parse flow property In addition to these patches, we would like to prepare more patches. However, we fe