Re: [webkit-dev] "Magic Iframe" removal proposed

2012-03-20 Thread Aaron Boodman
I actually do know of at least one WebKit-only application under development at Google that may be using this feature (I recently suggested it to them). Oh well. - a On Tue, Mar 20, 2012 at 8:07 AM, Adam Barth wrote: > Yeah, normally I would have waited longer, but the patch fixed a crash in >

Re: [webkit-dev] "Magic Iframe" removal proposed

2012-03-20 Thread Adam Barth
Yeah, normally I would have waited longer, but the patch fixed a crash in WebKit2 that was making the bots red. There was a discussion in another bug (sorry, don't have the link handy) where folks graciously held off fixing the crash, and I didn't want them to wait any longer than necessary. Adam

Re: [webkit-dev] "Magic Iframe" removal proposed

2012-03-20 Thread Maciej Stachowiak
I'm ok with removing this feature for the reasons you described. I concur with others who think we should update the spec. I am also skeptical of state sharing features that work via newer, less tested API surface instead of latching onto existing features. That seems like a more risky strategy

Re: [webkit-dev] "Magic Iframe" removal proposed

2012-03-19 Thread Geoffrey Garen
I have no immediate objection to removing the shared iframe feature since, as you say, it's a source of problems, very few apps use it, and no apps require it. It's great that we did this feature through a pre-existing web technology, so we discovered its problems, and can now remove it, without

Re: [webkit-dev] "Magic Iframe" removal proposed

2012-03-19 Thread Ryosuke Niwa
I support the removal. I've seen quite a few security bugs caused by this feature. Please make sure the spec changes as Geoff pointed out. - Ryosuke On Mon, Mar 19, 2012 at 5:51 PM, Dmitry Titov wrote: > Hi, > > There is a patch posted for > rem

Re: [webkit-dev] "Magic Iframe" removal proposed

2012-03-19 Thread Dmitry Titov
On Mon, Mar 19, 2012 at 6:09 PM, Geoffrey Garen wrote: > Hi Dmitry. > > Two thoughts on this: > > (1) If we remove this feature, are Chromium/GMail developers going to > re-request the other "shared document" features that this feature subsumed? > Or are y'all now convinced that "shared document"

Re: [webkit-dev] "Magic Iframe" removal proposed

2012-03-19 Thread Geoffrey Garen
Hi Dmitry. Two thoughts on this: (1) If we remove this feature, are Chromium/GMail developers going to re-request the other "shared document" features that this feature subsumed? Or are y'all now convinced that "shared document" is, in general, not a good idea? The reason I ask this is that, g

[webkit-dev] "Magic Iframe" removal proposed

2012-03-19 Thread Dmitry Titov
Hi, There is a patch posted for removal of the 'magic iframe' feature. This is the ability to move 'live' iframe from one page to another w/o unloading it. If you have interest or ideas about this feature, please reply. HISTORY This feature was adde