Re: Latest Git Fails tools/install

2010-03-26 Thread Marcus Meissner
On Fri, Mar 26, 2010 at 12:48:06PM -0700, chris ahrendt wrote: > > > Compiling Wine. Grab a lunch or two, rent a video, or whatever, > > in the meantime... > > > > config.status: executing Makefile commands > > cat: Make.tmp: No such file or directory > > config.status: error: could not create Mak

Re: Warnings on ignored returned values

2010-03-22 Thread Marcus Meissner
On Mon, Mar 22, 2010 at 03:28:17PM +0200, Octavian Voicu wrote: > On Mon, Mar 22, 2010 at 3:21 PM, Nate Gallaher > wrote: > > Should --enable-maintainer-mode be purged then, or should some additional > > flag magic be added?  I ran into this a long time ago as well and made the > > assumption that

Re: [patch] DNS_SD bridge, v2

2010-03-17 Thread Marcus Meissner
On Tue, Mar 16, 2010 at 04:41:02PM -0600, C.W. Betts wrote: > Excuse my ignorance, but what would happen if it didn't find the library > dynamically? You would check this condition (like NULL handle or NULL function pointer) in every wrapped function and return an error condition in that case. O

Re: [patch] DNS_SD bridge, v2

2010-03-16 Thread Marcus Meissner
On Mon, Mar 15, 2010 at 04:36:32AM -0600, C.W. Betts wrote: > The following is an updated patch that actually builds and links. > The patch does patch configure and config.h.in, both of which were generated > with an older version of autoconf and autoheader. You can and should leave out both conf

Re: winemp3.acm on the mac

2010-03-12 Thread Marcus Meissner
On Thu, Mar 11, 2010 at 08:46:27PM -0600, Aric Stewart wrote: > Hello all, > > So I have been hacking on winemp3.acm on the mac to make use of > CoreAudio for mp3 decoding and I have just gotten it working. So now > I am faced with a questions. > > Do I setup winemp3.acm with #ifdefs to pick b

Re: Another distro with 64-bit Wine by default

2010-03-06 Thread Marcus Meissner
On Fri, Mar 05, 2010 at 05:56:58PM -0700, Vitaliy Margolen wrote: > On 03/05/2010 02:34 PM, Marcus Meissner wrote: > > On Fri, Mar 05, 2010 at 10:11:59PM +0100, Marcus Meissner wrote: > >> On Fri, Mar 05, 2010 at 08:17:15AM -0700, Vitaliy Margolen wrote: > >>> It seem

Re: Another distro with 64-bit Wine by default

2010-03-05 Thread Marcus Meissner
On Fri, Mar 05, 2010 at 10:11:59PM +0100, Marcus Meissner wrote: > On Fri, Mar 05, 2010 at 08:17:15AM -0700, Vitaliy Margolen wrote: > > It seems that another distro, SuSE 11.x, has Wine-64 compiled by default for > > x86_64 platforms. That explains all the issues people been

Re: Another distro with 64-bit Wine by default

2010-03-05 Thread Marcus Meissner
On Fri, Mar 05, 2010 at 08:17:15AM -0700, Vitaliy Margolen wrote: > It seems that another distro, SuSE 11.x, has Wine-64 compiled by default for > x86_64 platforms. That explains all the issues people been having on SuSE > lately. > > Marcus, could you please create a separate package wine-64 inst

Re: [PATCH] winemp3.acm: always dynamically load libmpg123 stuff

2010-02-28 Thread Marcus Meissner
On Sun, Feb 28, 2010 at 03:11:22PM -0800, Chris Robinson wrote: > On Sunday 28 February 2010 1:13:44 pm Marcus Meissner wrote: > > Hi, > > > > Copy in the mpg123.h header from the library so we do not need it for > > building. (it is also LPGL) > > > &g

Re: [PATCH] shell32: replace strcpy by memcpy due to slightly undefined struct handling

2010-02-15 Thread Marcus Meissner
On Mon, Feb 15, 2010 at 06:46:06PM +0200, Paul Chitescu wrote: > > -strcpy(pData->u.network.szNames, "Entire Network"); > > +memcpy(pData->u.network.szNames, "Entire Network", sizeof("Entire > Network")+1); > > Please use a const buffer as "Entire Network" is a string literal, not

Re: [PATCH] shell32: handle bad menu handle (Coverity)

2010-01-09 Thread Marcus Meissner
On Sat, Jan 09, 2010 at 07:18:18PM +0300, Nikolay Sivov wrote: > On 1/9/2010 16:59, Marcus Meissner wrote: > >Hi, > > > >handle "invalid menu" return -1. Now with test. > > > >Ciao, Marcus > >--- > > dlls/shell32/shlmenu.c

Re: Less than 300 Coverity errors !!

2010-01-08 Thread Marcus Meissner
On Fri, Jan 08, 2010 at 10:17:59AM -0600, Austin English wrote: > On Fri, Jan 8, 2010 at 2:42 AM, Paul Vriens > wrote: > > Hi, > > > > Just wanted to mention the fact that Marcus (almost single-handedly for the > > last months) got the number of issues below 300. > > Thanks Marcus! No worries.

Re: crypt32: check for NULL target pointers (Coverity)

2010-01-07 Thread Marcus Meissner
IGNORE already, as Windows also shows inconsistent behaviour... I would try this patch, although I am not sure I matched your indent style, it is a bit strange: >From d5d8f81fe7b0b7b9e91ae97611e4929821e9a564 Mon Sep 17 00:00:00 2001 From: Marcus Meissner Date: Tue, 22 Dec 2009 10:20:25 +0100 Subjec

Re: [PATCH] kernel32: GetPrivateProfileSectionNamesA error checking (Coverity)

2010-01-06 Thread Marcus Meissner
On Wed, Jan 06, 2010 at 01:34:28PM +0100, Alexandre Julliard wrote: > Marcus Meissner writes: > > > buffer and size need to be either 0 at the same time or not, > > otherwise this breaks up. Windows is inconsistent (either crashes > > or returns invalids), so we can ju

Re: [PATCH 6/7] urlmon: Report redirected URL to object created by BindToObject.

2009-12-17 Thread Marcus Meissner
On Wed, Dec 16, 2009 at 08:06:32PM +0100, Jacek Caban wrote: > On 12/16/09 7:50 PM, Marcus Meissner wrote: > >On Wed, Dec 16, 2009 at 07:30:22PM +0100, Paul Vriens wrote: > >>On 12/15/2009 09:16 PM, Jacek Caban wrote: > >>>--- > >>>dlls/urlmon/binding.c |

Re: [PATCH 6/7] urlmon: Report redirected URL to object created by BindToObject.

2009-12-16 Thread Marcus Meissner
On Wed, Dec 16, 2009 at 07:30:22PM +0100, Paul Vriens wrote: > On 12/15/2009 09:16 PM, Jacek Caban wrote: >> --- >> dlls/urlmon/binding.c | 6 + >> dlls/urlmon/tests/url.c | 58 ++ >> 2 files changed, 44 insertions(+), 20 deletions(-) >> > > Hi Jacek, >

Re: Building and packaging Wine Gecko

2009-12-11 Thread Marcus Meissner
On Fri, Dec 11, 2009 at 10:11:59PM +0200, Anssi Hannula wrote: > Hi all! > > I see that Wine has recently started to always request installation of > Gecko, and that it is recommended to use a distribution provided package. > > We do not yet provide a wine-gecko package in Mandriva, but we'd like

Re: My script for doing testing

2009-11-25 Thread Marcus Meissner
On Wed, Nov 25, 2009 at 05:21:30PM -0500, Steven Edwards wrote: > On Wed, Nov 25, 2009 at 12:08 PM, Austin English > wrote: > > The other neat thing is that it will run git fetch in a loop every 30 > > minutes (again, overridable), so that you can run it in the morning > > while waiting for AJ to

Re: Someone please update the german translation of Ubuntu download page

2009-11-22 Thread Marcus Meissner
On Sat, Nov 21, 2009 at 09:16:52PM -0600, Scott Ritchie wrote: > My German is inadequate and there are no instructions for Karmic users > there at the moment. I sent one just now. Also updated de/download.template Ciao, Marcus

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Marcus Meissner
On Mon, Nov 16, 2009 at 11:29:51PM +0100, Ove Kaaven wrote: > Jacek Caban skrev: > > Well, I hope that a side effect of installation during wineprefix > > creation is that it will force packagers to package gecko > > You can't *force* the creation of packages which would likely fail to > meet the

Re: today's git broke winetricks gecko :-(

2009-11-16 Thread Marcus Meissner
On Mon, Nov 16, 2009 at 05:08:21PM +0100, Jacek Caban wrote: > Well, I hope that a side effect of installation during wineprefix > creation is that it will force packagers to package gecko The > brutal true is that we had a very bad situation for a long time. I > can see three types of Wine users:

Re: [PATCH] winex11.drv: check for org = NULL (Coverity)

2009-11-16 Thread Marcus Meissner
gic to arrive here and in > case of wglsharelists it also performs the filtering. Do I understand right that this is actually something we should mark as FALSE or IGNORE in Coverity? Ciao, Marcus > Roderick > > On Sun, Nov 15, 2009 at 7:28 PM, Marcus Meissner > wrot

Re: Working on avifil32, sudden "non enough memory" error

2009-11-16 Thread Marcus Meissner
On Mon, Nov 16, 2009 at 10:52:04AM +0100, Julius Schwartzenberg wrote: > Dan Kegel wrote: > >Julius wrote: > >>With one file however (GOODTIME.AVI from the win95 cd) I get this > >>error after about a second: > >>err:heap:HEAP_ValidateInUseArena Heap 0x11: in-use arena 0x184420 > >>next block h

Re: What's the use of volatile in Wine code?

2009-11-11 Thread Marcus Meissner
On Wed, Nov 11, 2009 at 11:13:06AM +0100, joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > AJ wrote in > http://www.winehq.org/pipermail/wine-devel/2009-November/079575.html > >If there is proper synchronization you don't need > >volatile, and if there isn't volatile won't magically fix it. >

Re: [Fwd: 64bit wine]

2009-11-10 Thread Marcus Meissner
On Wed, Nov 11, 2009 at 11:05:49AM +1100, Ben Klein wrote: > 2009/11/11 Michael Stefaniuc : > > For fedora it will not be possible to do a special 32bit compile on the > > x86_64 > > arch. > > Wait ... no gcc -m32 on Fedora x86_64? > > > Hence the only way is to have the default x86_32 version a

Re: Infinite loop with translation DLL

2009-11-10 Thread Marcus Meissner
On Mon, Nov 09, 2009 at 04:53:31PM +0100, Uwe Bonnes wrote: > > "Henri" == Henri Verbeet writes: > > Henri> 2009/11/9 Uwe Bonnes : > >> Can anybody help with the flaw in my implementation? Or did anything > >> change in wine? > >> > Henri> I'm not sure if anything changed

Re: Another virus-in-wine story

2009-10-26 Thread Marcus Meissner
On Sun, Oct 25, 2009 at 06:14:34PM -0700, Scott Ritchie wrote: > Stefan Dösinger wrote: > > > > Am 25.10.2009 um 10:57 schrieb Scott Ritchie: > >> Many apps don't need to view the user folder for documents but also > >> employ programmable scripting engines - a good example are games. It > >> wou

Re: oledb32: Implement CanConvert.

2009-09-21 Thread Marcus Meissner
On Mon, Sep 21, 2009 at 02:46:25PM +0100, Huw Davies wrote: > On Mon, Sep 21, 2009 at 03:36:21PM +0200, Marcus Meissner wrote: > > On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > > > +if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return >

Re: oledb32: Implement CanConvert.

2009-09-21 Thread Marcus Meissner
On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > --- > dlls/oledb32/convert.c | 231 > +- > dlls/oledb32/tests/convert.c | 10 -- > 2 files changed, 228 insertions(+), 13 deletions(-) > diff --git a/dlls/oledb32/convert.c b/dlls/oledb3

Re: Wineconf drumbeat - don't sleep on the streets!

2009-09-10 Thread Marcus Meissner
On Thu, Sep 10, 2009 at 04:48:24PM -0500, Jeremy White wrote: > Hi Folks, > > It's now close enough to November that you can't blow > this email off . > > We've got all the info here: > http://wiki.winehq.org/WineConf2009 > > Our challenge this year is that we're managing the booking, > so we

Re: CPPCheck Sept 8 GIT

2009-09-08 Thread Marcus Meissner
On Tue, Sep 08, 2009 at 07:21:03PM -0700, chris ahrendt wrote: > [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) > Deallocating a deallocated pointer: stream2 > [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource > leak: stream3 > [/home/cahrendt/wine-git/dlls

Re: CPP Run for Sept 3

2009-09-04 Thread Marcus Meissner
On Fri, Sep 04, 2009 at 11:20:08AM -0700, chris ahrendt wrote: > [../wine-git/dlls/wineoss.drv/mmaux.c:150]: (error) Resource leak: mixer > [../wine-git/dlls/wineoss.drv/mmaux.c:211]: (error) Resource leak: mixer Is a bug, patch sent. > [../wine-git/programs/oleview/pane.c:152]: (error) Possible

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread Marcus Meissner
On Fri, Aug 28, 2009 at 02:16:40PM -0700, chris ahrendt wrote: > Ok CPPCheck guys have repired the false positive but now get this: > > $ ./cppcheck -q -a ../wine/wine/dlls/wineoss.drv/mixer.c > ../wine/wine/dlls/wineoss.drv/mixer.c:576: (error) Resource leak: mixer > ../wine/wine/dlls/wineoss.dr

Re: mp3 update

2009-08-14 Thread Marcus Meissner
On Fri, Aug 14, 2009 at 12:52:48PM +0200, Michael Stefaniuc wrote: > Alexandre Julliard wrote: > > Marcus Meissner writes: > > > >> On Thu, Aug 13, 2009 at 09:07:29PM +0200, Alexandre Julliard wrote: > >>> Austin English writes: > >>> > &g

Re: mp3 update

2009-08-13 Thread Marcus Meissner
On Thu, Aug 13, 2009 at 09:07:29PM +0200, Alexandre Julliard wrote: > Austin English writes: > > > On Thu, Aug 13, 2009 at 1:41 PM, Juan Lang wrote: > >>> All the more reason to use the existing libmpg123 instead of trying to > >>> maintain our own version, IMO. > >> > >> Aric already explained t

Re: cppcheck run against 1.27

2009-08-08 Thread Marcus Meissner
On Fri, Aug 07, 2009 at 06:36:36PM -0700, chris ahrendt wrote: > > [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd I do not fully understand the code (keep fd open to have to lock existing?), but it is in a fatal exit path. > [../wine-git/tools/fnt2bdf.c:219]: (error) Resource l

Re: Question about the gphoto2.ds resources

2009-07-30 Thread Marcus Meissner
On Thu, Jul 30, 2009 at 10:24:50AM +0200, Marcus Meissner wrote: > On Thu, Jul 30, 2009 at 10:17:37AM +0200, Paul Vriens wrote: > > Hi Marcus, > > > > I've noticed some strange output with transl: > > > > http://source.winehq.org/transl/resource.php?lang=013

Re: Question about the gphoto2.ds resources

2009-07-30 Thread Marcus Meissner
On Thu, Jul 30, 2009 at 10:17:37AM +0200, Paul Vriens wrote: > Hi Marcus, > > I've noticed some strange output with transl: > > http://source.winehq.org/transl/resource.php?lang=013%3A00&resfile=dlls%2Fgphoto2.ds&type=5&id=1025&compare= > > When I look at the defined resources for the first dialog

Re: Howto put a new rpm package on sourceforge ?

2009-07-05 Thread Marcus Meissner
On Sun, Jul 05, 2009 at 11:20:54AM +0200, marco wrote: > Hin-Tak Leung schreef: >> --- On Sat, 4/7/09, marco wrote: >> >> >>> Hi all, >>> >>> I make the mandriva packages and put them on sourceforge. >>> >>> But sourceforge changed there layout and now I can not >>> longer find the >>> button t

Re: [PATCH] wined3d: mirror d3dresourcetype

2009-06-14 Thread Marcus Meissner
On Sun, Jun 14, 2009 at 05:29:39PM +0200, Stefan Dösinger wrote: > > Here: > > /home/marcus/projects/wine/dlls/d3d9/device.c: In > > Funktion »reset_enum_callback«: > Does the attached patch fix the issue? Yes it does. Ciao, Marcus

Re: [PATCH] wined3d: mirror d3dresourcetype

2009-06-14 Thread Marcus Meissner
On Sun, Jun 14, 2009 at 04:30:30PM +0200, Stefan Dösinger wrote: > Am Sonntag, 14. Juni 2009 14:26:53 schrieb Marcus Meissner: > > Hi, > > > > gcc 4.5trunk warned that we do not handle case 7 (D3DRTYPE_INDEXBUFFER), > > so add it here too. > There's a reason w

Re: [PATCH] winhttp: avoid NULL ptr dereference (Coverity 927)

2009-05-20 Thread Marcus Meissner
On Tue, May 19, 2009 at 01:46:31PM +0200, Paul Vriens wrote: > Marcus Meissner wrote: >> +lend2: >> TRACE("%d <--\n", bSuccess); >> return bSuccess; >> } > Hi Marcus, > > After AJ's remark you marked this Coverity one as "

Re: DIB Engine : Almost 100% working

2009-05-11 Thread Marcus Meissner
On Mon, May 11, 2009 at 12:56:28PM +0200, Joerg Mayer wrote: > Hello (mostly wine package maintainers), > > On Sun, May 10, 2009 at 05:07:55PM +0200, Massimo Del Fedele wrote: > > James McKenzie ha scritto: > >> Good work. Have you started to think about how to get this into Wine > >> where AJ wi

Re: Suppressing the screen saver in a full screen game

2009-04-16 Thread Marcus Meissner
On Thu, Apr 16, 2009 at 11:44:30AM -0700, Scott Ritchie wrote: > Ubuntu 9.04's new notification system is really nice and non obtrusive, > however it can still get in the way if you need the entire screen. > Accordingly, the notifications system has been designed to not draw > notifications when

Re: Added PulseAudio sound driver

2009-04-08 Thread Marcus Meissner
On Wed, Apr 08, 2009 at 09:16:17PM +0200, remi.assai...@free.fr wrote: > Hi all, > > I'm submitting the PulseAudio patch from Arthur Talyor. > As most distros have PulseAudio by default Wine should provide upstream > support. > Both Fedora and Mandriva have included this work and it is reporte

Re: Unicode error

2009-03-22 Thread Marcus Meissner
On Sun, Mar 22, 2009 at 08:45:18PM +1000, Robert Lunnon wrote: > I get this error under solaris building wine. > Any clues would be welcome (Things have probably changed a lot since I last > hacked on Wine) > > make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32' > ../../tool

Re: Wine download page usability problem

2009-02-20 Thread Marcus Meissner
On Fri, Feb 20, 2009 at 11:02:16PM +0100, Rolf Kalbermatter wrote: > On Fri, Feb 20, 2009 at 7:40 PM, Dan Kegel wrote: > > Please try http://kegel.com/wine/distro.html and let me know if it > > detects your distro properly, I'll fix it up as needed.You're running > > Firefox 3 on an unknown dis

Re: Wine download page usability problem

2009-02-20 Thread Marcus Meissner
On Fri, Feb 20, 2009 at 11:47:16AM -0600, Rosanne DiMesio wrote: > On Fri, 20 Feb 2009 09:24:09 -0800 > Dan Kegel wrote: > > > > > Can we add in a line at the top saying > > "Stable version 1.0.1 of Wine can usually be installed > > just like any other Linux application using your > > package

Re: Wine & viruses

2009-02-18 Thread Marcus Meissner
On Wed, Feb 18, 2009 at 09:33:01PM +1100, Ben Klein wrote: > 2009/2/18 IneedAname : > > Why not make Wine honor the noexe flag on the mount? > > This might not be a bad idea, if it's possible. Make Wine refuse to > run apps on noexec filesystems. Likely will break installing all DVD/CD Software ;

Wine talk on FOSDEM

2009-02-15 Thread Marcus Meissner
Hi, A week ago I went to Bruessel / Bruxelles in Belgium to the largest opensource developer conference in Europa, FOSDEM 2009. openSUSE has a developer room there the last years and we fill our time by holding talks, mostly concerning openSUSE and stuff that we do for the distribution and what o

Re: Updated cebit presentation. Looking for ideas...

2009-02-15 Thread Marcus Meissner
On Sat, Feb 14, 2009 at 04:49:03PM -0800, Dan Kegel wrote: > I've been slowly finishing my cebit presentation. The current draft is at > http://kegel.com/cebit/ > > It now talks briefly about winetricks, > and uses firefox and safari as examples > of installing and running platinum and bronze >

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Marcus Meissner
On Wed, Feb 11, 2009 at 09:35:26AM -0500, Steve Brown wrote: > On Tue, 10 Feb 2009, Vitaliy Margolen wrote: > > > Ben Klein wrote: > >> This is not a problem with Wine, this is OpenSUSE breaking the > >> environment when sudo is called. Remember, Wine is not the only X11 > >> app out there. Others

ioports.c change -> buffer overflow ... bug?

2009-02-08 Thread Marcus Meissner
Hi Florian, You are calling get_timer_val(3) in ioports.c (if (chan == 3) ... going down to get_timer_val(chan)) Howver, tmr_8253 is just a 3 element array, so [3] will run over the end, Is your code right? The change comes from this commit: commit edbd4885542e4545439906df950a68dc48e70

Re: [PATCH] mshtml: Fixed last argument to MBtoWC

2009-02-05 Thread Marcus Meissner
On Thu, Feb 05, 2009 at 03:53:04PM +, Rob Shearman wrote: > 2009/2/4 Marcus Meissner : > > @@ -442,7 +442,7 @@ static LPWSTR get_url(void) > > > > if(size > sizeof(httpW) && !memcmp(url, httpW, sizeof(httpW))) { > > strcatW(url, v_formatW); &

Re: [PATCH] mshtml: fixed second buffer argument to MultiByteToWideChar

2009-02-04 Thread Marcus Meissner
On Wed, Feb 04, 2009 at 02:15:04PM -0600, Austin English wrote: > On Wed, Feb 4, 2009 at 2:11 PM, Marcus Meissner wrote: > > Hi, > > > > Targetbuffer length must not be -1. > > > > Ciao, Marcus > > --- > > dlls/mshtml/editor.c |2 +- >

Re: Simple but awesome demos of Wine?

2009-02-01 Thread Marcus Meissner
On Sun, Feb 01, 2009 at 09:48:01AM -0800, Dan Kegel wrote: > I'm going to be giving a Wine presentation at > Cebit next month. You can see a draft of the > presentation at > http://kegel.com/wine/cebit2009/talk.html > (I will say lots more than is written there; the > slides are kept simple on pu

Re: [PATCH] winspool.drv: Check return value of EnumPrintersA

2009-02-01 Thread Marcus Meissner
On Sun, Feb 01, 2009 at 03:25:43PM +0100, Detlef Riekenberg wrote: > On Sa, 2009-01-31 at 11:09 +0100, Marcus Meissner wrote: > > -EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 5, NULL, 0, &needed, > > &num); > > -if(needed) { > > +if (EnumPrintersA(P

Re: A basic implementation for increased security in wine proposal

2009-02-01 Thread Marcus Meissner
On Sun, Feb 01, 2009 at 10:41:25AM +0100, Guillaume SH wrote: > Hi Paul, > > You asked me to actually describe the security I am concerned about, so I am > going for it : > > Imagine an ill-intentioned people, call it the attackers. By the mean of > simply creating the following C application (ba

request for windows test: GetPrivateProfileSectionNamesA

2009-01-30 Thread Marcus Meissner
Hi, Could someone please test those, I want to see if the second or third crash on Windows to handle those borderline cases. Ciao & Thanks, Marcus --- dlls/kernel32/tests/profile.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/profile.c b/d

Re: New Coverity run

2009-01-24 Thread Marcus Meissner
On Sat, Jan 24, 2009 at 12:22:33PM +0100, Paul Vriens wrote: > Dan Kegel wrote: >> On Fri, Jan 23, 2009 at 2:47 PM, Marcus Meissner >> wrote: >>> There are actually more ... 815 - 870 (ca 57), and other types too. >> >> Whoops, right, I only got the first pa

help with coverity spotted problem in region.c::CreatePolyPolygonRgn

2009-01-24 Thread Marcus Meissner
Hi, Coverity says something about array indices in CreatePolyPolygonRgn and I see some code that looks bad: if (((nbpolygons == 1) && ((*Count == 4) || ((*Count == 5) && (Pts[4].x == Pts[0].x) && (Pts[4].y == Pts[0].y))) && (((Pts[0].y == Pts[1].y) && (Pts[1].x == Pts

Re: New Coverity run

2009-01-23 Thread Marcus Meissner
On Fri, Jan 23, 2009 at 01:42:38PM -0800, Dan Kegel wrote: > ... and here are the new issues since the last run, all of type FORWARD_NULL. > If you don't have coverity access, see > http://scan.coverity.com/devfaq.html#account > for how to get it. > > 595 CryptDecodeObjectEx dlls/crypt32/d

Re: New Coverity run

2009-01-23 Thread Marcus Meissner
On Fri, Jan 23, 2009 at 09:44:45PM +0100, Paul Vriens wrote: > Hi, > > I've been in touch with David Maxwell and he looked into the 'lack' of > reports since the end of October. And there is now Run 278 :) Ciao, Marcus

Re: LWN Timeline for 2008: Wine 1.0 made it!

2009-01-22 Thread Marcus Meissner
On Thu, Jan 22, 2009 at 08:28:07AM +, David Gerard wrote: > 2009/1/22 Austin English : > > > I wrote an article on common myths/mistruths > > (http://lwn.net/Articles/315071/), went in today's release (will be > > free to public in a week). > > Looks like the editors went with the first draft,

Re: Does this D-Bus change affect us? (Fwd: New D-Bus Uploaded)

2009-01-21 Thread Marcus Meissner
On Wed, Jan 21, 2009 at 10:56:24AM +0200, Damjan Jovanovic wrote: > On Wed, Jan 21, 2009 at 10:36 AM, Marcus Meissner > wrote: > > On Wed, Jan 21, 2009 at 12:31:58AM -0800, Scott Ritchie wrote: > >> This email was just sent to the Ubuntu developer list about a change to &

Re: Does this D-Bus change affect us? (Fwd: New D-Bus Uploaded)

2009-01-21 Thread Marcus Meissner
On Wed, Jan 21, 2009 at 12:31:58AM -0800, Scott Ritchie wrote: > This email was just sent to the Ubuntu developer list about a change to > D-Bus security in 9.04 -- do I need to create a D-Bus .conf file for > Wine, or will the default policy suffice for us? Sinc we are not receiving dbus events i

Re: Wine being targeted for adware

2009-01-14 Thread Marcus Meissner
On Wed, Jan 14, 2009 at 05:08:50PM +1100, Jeff Zaroyko wrote: > http://philosecurity.org/2009/01/12/interview-with-an-adware-author > > In an interesting interview, former adware author Matt Knox mentions > that he was able to run his adware client on Wine: > > S: In your professional opinion, ho

Re: running msys under wine

2009-01-09 Thread Marcus Meissner
On Fri, Jan 09, 2009 at 06:39:27PM +, Luke Kenneth Casson Leighton wrote: > http://bugs.winehq.org/show_bug.cgi?id=13606 > > folks, hi, > > am running a configure script under wine, and it's _literally_ one to > two seconds per sh.exe instance. i started running ./configure over > two hours

Re: Does preloader attempt to fix ASR?

2009-01-09 Thread Marcus Meissner
On Thu, Jan 08, 2009 at 10:14:10PM -0500, Nicholas LaRoche wrote: > On a standard installation of Fedora 10 address space randomization is > enabled by default. The base address of a process started by wine seems > to change.. and it is easy to see when loading Dlls and checking their > base add

Re: [PATCH] Compile fix on Linux 2.6.28 / x86

2009-01-03 Thread Marcus Meissner
On Sat, Jan 03, 2009 at 08:36:07PM +0100, Pavel Troller wrote: > Hi! > Due to changes in Linux kernel include file structure, the following patch > is necessary to compile wine with the 2.6.28 kernel: > > --- wine/dlls/ntdll/serial.c.old 2009-01-03 19:31:17.0 +0100 > +++ wine/dlls/n

Re: Build wine with gcc-4.3 and ssp

2009-01-03 Thread Marcus Meissner
On Sat, Jan 03, 2009 at 07:52:10PM +0100, Stefan Reimer wrote: > > On Fri, Jan 02, 2009 at 11:14:52PM +0100, Stefan Reimer wrote: > I am using gentoo hardened: > > gcc (Gentoo Hardened 4.3.2-r7 p1.5, ssp, fortify, pie-10.2.0) 4.3.2 glibc 2.8 > > Using gcc -v gives: > > /usr/libexec/gcc/x86_64-p

Re: Packagers: consider not packaging wine-1.1.12, or cherrypicking fixes

2009-01-03 Thread Marcus Meissner
On Sat, Jan 03, 2009 at 10:11:23AM -0800, Dan Kegel wrote: > wine-1.1.12 has a couple regressions in it: > http://bugs.winehq.org/show_bug.cgi?id=16754 > http://bugs.winehq.org/show_bug.cgi?id=16732 > http://bugs.winehq.org/show_bug.cgi?id=16708 > > Please consider either cherrypicking the fixes,

Re: Build wine with gcc-4.3 and ssp

2009-01-02 Thread Marcus Meissner
On Fri, Jan 02, 2009 at 11:14:52PM +0100, Stefan Reimer wrote: > Hi, > to build wine using gcc 4.3 with enabled ssp (stack-smashing-protector) > the following patch must be applied to loader/preloader.c > > see gcc source ./gcc/config/i386/i386.c around line 24391 > > /* For 32-bit code we can sa

Re: Ouch.

2008-12-31 Thread Marcus Meissner
On Wed, Dec 31, 2008 at 10:21:29AM +0100, Kai Blin wrote: > On Tuesday 30 December 2008 23:55:56 Dan Kegel wrote: > > http://enquiringmimes.com/wp/2008/12/30/a-rumor-we-hope-is-true/ > > said > > "WINE is the famous, this-would-be-so-cool-if-it-only-actually-worked > > way of running Windows on oth

Re: Windows version autodetection

2008-12-21 Thread Marcus Meissner
On Sun, Dec 21, 2008 at 11:19:35AM +0200, Damjan Jovanovic wrote: > Hi > > There are some older applications out there, which don't install or > run correctly unless Wine is emulating the correct Windows version > (eg. Windows 9x). > > At least Windows XP has the ability to use certain heuristics

Re: include/wine: Header only implementation of generic redblack binary search tree.

2008-12-20 Thread Marcus Meissner
On Sat, Dec 20, 2008 at 07:30:53PM +0200, Pauli Nieminen wrote: > This implementation provides easy access to rb-tree which should be used > instead of hashmap > if number of entries changes a lot of over time of execution. > It should be simple to write hashtree based on this which uses hash valu

Re: Canonical and wine

2008-12-11 Thread Marcus Meissner
> It would be useful to have winetricks distributed in a deb/rpm > package, so that you could install it easily to have it > updated/managed by the package manager. This would provide the core > support for installing applications run on wine via deb/rpm packages > (that would depend on winetricks

Re: Package repository discussion

2008-12-04 Thread Marcus Meissner
On Thu, Dec 04, 2008 at 05:45:21AM -0800, Dan Kegel wrote: > Ubuntu is having a meeting next week to discuss > how to more easily grant users access to third > party repositories (like wine's, perhaps). > > I've got a meeting wiki up at > http://wiki.winehq.org/TrustingThirdPartyRepositories > It

Re: Coverity Telco coming up

2008-12-02 Thread Marcus Meissner
On Tue, Dec 02, 2008 at 06:58:37PM +0100, Kai Blin wrote: > Hi folks, > > Coverity is hosting a telco tomorrow about some new technology they're going > to roll out to projects. I'm planning to attend, and would like to bring up > any issues we're currently having in the Q&A session. > > Issues

Re: today's git does not compile with yesterday's new gcc -- regression test results

2008-11-30 Thread Marcus Meissner
On Sun, Nov 30, 2008 at 10:24:56AM -0500, Susan Cragin wrote: > I did the regression test. But how legitimate are the results if the problem > is the new gcc that I downloaded recently, and not wine? > gcc (Ubuntu 4.3.2-2ubuntu5) 4.3.3 20081129 (prerelease) > > [EMAIL PROTECTED]:~/wine$ git bise

Re: spec file syntax for VARIANT parameter

2008-11-19 Thread Marcus Meissner
On Wed, Nov 19, 2008 at 01:11:05PM -0800, Jeremy Drake wrote: > In order to implement OleLoadPictureFile and OleLoadPictureFileEx, it will > be necessary to change their entries in oleaut32.spec from stub to > stdcall. The stdcall syntax wants a list of parameter types, which puts > these function

Re: dlls/cabinet: fix dead stores (llvm/clang)

2008-11-18 Thread Marcus Meissner
On Tue, Nov 18, 2008 at 03:11:52PM +0800, Dmitry Timoshkov wrote: > "ricardo filipe" <[EMAIL PROTECTED]> wrote: > > > --- a/dlls/cabinet/fci.c > > +++ b/dlls/cabinet/fci.c > > @@ -462,7 +462,7 @@ static cab_ULONG fci_get_checksum(const void *pv, UINT > > cb, CHECKSUM seed) > > case 2: > >

Re: Grumble. Kernel lockup in Intrepid.

2008-11-16 Thread Marcus Meissner
On Sun, Nov 16, 2008 at 12:20:37PM -0800, Dan Kegel wrote: > Wonder why patchwatcher was down for 12 hours? It > seems to have been a kernel problem. > > This is on an Ubuntu 8.10 32 bit Core 2 Duo system > on a P5K Pro motherboard, with a PCI-E NVidia card. > I have the proprietary Nvidia driver

Re: tools/fnt2bdf: fix a few compiler warnings (1/10)

2008-11-16 Thread Marcus Meissner
On Wed, Nov 12, 2008 at 10:28:37AM +0100, Michael Stefaniuc wrote: > Austin English wrote: > > This series of patches fixes most of the new warnings generated in gcc > > 4.3.2. There's one issue left, but I'm not quite sure what should be > > done on that one. > > diff --git a/tools/fnt2bdf.c b/too

Re: Wine support for win64

2008-11-04 Thread Marcus Meissner
On Tue, Nov 04, 2008 at 02:36:02PM +0100, Stefan Dösinger wrote: > > This summer Maarten Lankhorst did some basic work on win64 support but > > for the rest no work has been done it for a long time. I'm not sure > > what Maarten exactly did but but there is a lot of work to be done > > before it wi

Re: General script for installing Wine build dependencies

2008-11-02 Thread Marcus Meissner
On Sun, Nov 02, 2008 at 10:31:11AM -0600, Evil Jay wrote: > I can see where this would be useful for building on some platforms, but > doesn't "sudo apt-get build-dep wine" work fine (for the most part) for > Ubuntu? > > The last time I compiled on a fresh *buntu, I recall using build-dep and > th

Re: wine users forum registration issue

2008-10-22 Thread Marcus Meissner
On Wed, Oct 22, 2008 at 07:19:46AM -0500, Jeremy White wrote: > > Right. So the forum software is broken, and all of the Wine devs would > > rather > > fix Wine than the forums? Sounds like a good case for ditching the forums. > > I disagree violently. The case for the forums is clear; users pr

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-22 Thread Marcus Meissner
On Wed, Oct 22, 2008 at 10:41:00AM +0200, Hans Leidekker wrote: > On Tuesday 21 October 2008 19:06:20 Juan Lang wrote: > > > But you don't check whether those conditions are true, and you march > > ahead and install the certificate into the root store whether or not > > they are true. I'm sorry,

SourceForge community awards ... we won ... ;)

2008-10-15 Thread Marcus Meissner
Hi, We won in the SourceForge.net2008 Community Choice Awards https://sourceforge.net/community/cca08/ in the Category: "Most Likely to Be Ambiguously and Baselessly Accused of Patent Violation" :) Ciao, Marcus

Re: Fix to exceptions in ddtest

2008-10-12 Thread Marcus Meissner
On Sun, Oct 12, 2008 at 09:52:06PM -0400, Chris Ahrendt wrote: > Ok I have threaded through ddraw_test adding as I had them fail a check > and a fix in dsurface.c test. The test now fails when the CreateSurface > fails. Before this there were several point in the test where the return > status

Re: [PATCH] also remove backbuffer flags in the v1 DDRAW interface

2008-10-06 Thread Marcus Meissner
On Sun, Oct 05, 2008 at 05:41:31PM -0500, Austin English wrote: > On Sun, Oct 5, 2008 at 2:26 PM, Marcus Meissner <[EMAIL PROTECTED]> wrote: > > Hi, > > > > This fixes http://bugs.winehq.org/show_bug.cgi?id=9008 > > by also filtering out the backbuffer flag. >

request for windows test ddraw/dsurface

2008-10-05 Thread Marcus Meissner
Hi, I am suspecting that in IDirectDraw1 the behaviour regarding backbuffer creation might change if we have a just created frontbuffer of the same size. (This is similar to behaviour shown by bulanci.exe of http://bugs.winehq.org/show_bug.cgi?id=9008 ) Can someone please try this on Windows ple

Marcus pictures

2008-10-01 Thread Marcus Meissner
Hi, http://gallery.kuschelt.net/main.php?g2_view=core.ShowItem&g2_itemId=163676&g2_page=3 has my pictures of Wine Conf. Ciao, Marcus

make test .. monthcal new failure

2008-09-30 Thread Marcus Meissner
Hi, I get these new errors after todays git update: monthcal.c:677: Test failed: Expected 65542, got 65536 monthcal.c:677: Test failed: Expected 65542, got 65536 monthcal.c:677: Test failed: Expected 65542, got 65536 monthcal.c:677: Test failed: Expected 65542, got 65536 monthcal.c:677: Test fail

Re: [PATCH 1/2] gdiplus: Allocate enough space for BITMAPINFO in GdipCreateTextureIA.

2008-09-28 Thread Marcus Meissner
On Sun, Sep 28, 2008 at 01:26:37PM -0700, Lei Zhang wrote: > On Sun, Sep 28, 2008 at 12:53 PM, Nikolay Sivov <[EMAIL PROTECTED]> wrote: > > Lei Zhang wrote: > >> @@ -512,8 +512,11 @@ GpStatus WINGDIPAPI GdipCreateTextureIA(GpImage > >> *image, > >> IPicture_get_CurDC(image->picture, &hdc); >

Re: RFC: Adding annotations to function declarations to improve static analysis

2008-09-27 Thread Marcus Meissner
On Sun, Sep 28, 2008 at 12:08:22AM +0100, Rob Shearman wrote: > Hi all, > > This will be talked about in more detail at WineConf tomorrow, but I > just thought I'd throw this out there as a bit of background to any > discussions. > > Adding annotations to function declarations allows Prefast to p

Re: configure.ac: add -Werror to default compiler options

2008-09-19 Thread Marcus Meissner
On Fri, Sep 19, 2008 at 04:35:45PM +0200, Alexandre Julliard wrote: > "Dan Kegel" <[EMAIL PROTECTED]> writes: > > > Agreed, to an extent. A user who is trying to compile with a really > > whacky toolchain (say, a C compiler on an Amiga, a mainframe, or a > > wristwatch) > > should expect some e

Re: [PATCH] annotate more with buffer size

2008-09-12 Thread Marcus Meissner
On Fri, Sep 12, 2008 at 11:08:20AM +0200, Alexandre Julliard wrote: > Marcus Meissner <[EMAIL PROTECTED]> writes: > > > @@ -91,11 +91,11 @@ typedef HRESULT (STDMETHODCALLTYPE > > MAPILOGONEX)(ULONG_PTR,LPSTR,LPSTR,ULONG,LPMA > > typedef MAPILOGONEX *LPMAPILOGONEX

Re: [PATCH] static buffer overflow checking

2008-09-10 Thread Marcus Meissner
On Wed, Sep 10, 2008 at 10:50:42PM +0200, Michael Karcher wrote: > Am Mittwoch, den 10.09.2008, 22:38 +0200 schrieb Marcus Meissner: > > I just tested some code with -O0 and the functioncall still gets > > optimized away. This is with gcc 4.1 and gcc 4.3. gcc 2.95 does not. &

Re: [PATCH] static buffer overflow checking

2008-09-10 Thread Marcus Meissner
On Wed, Sep 10, 2008 at 10:27:06PM +0200, Michael Karcher wrote: > Am Mittwoch, den 10.09.2008, 22:12 +0200 schrieb Marcus Meissner: > > This approach will not work with -O0, which might be a problem. > If I were to decide, that would kill the patch. I really like to > recompil

<    1   2   3   4   5   6   7   8   9   >