Re: [3/4] kernel32/tests: Add 0-length read tests for a pipe.

2013-09-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2250 Your paranoid

Re: [3/4] imm32: use thread data from target HWND

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2256 Your paranoid

Re: [3/4] ws2_32: Filter invalid socket parameters and return the appropriate error

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2228 Your paranoid

Re: [3/4] ws2_32: Filter invalid socket parameters and return the appropriate error

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2237 Your paranoid

Re: [3/4] gdi32: IntersectClipRect should update actual clipping region for a EMF DC.

2013-02-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24396 Your paranoid

Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23710 Your paranoid

Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.

2013-01-02 Thread Dmitry Timoshkov
Vincent Povirk madewokh...@gmail.com wrote: +hr = IWICBitmap_Lock(bitmap, NULL, WICBitmapLockWrite, lock); +if (SUCCEEDED(hr)) +{ +UINT buffersize; +BYTE *buffer; + +hr = IWICBitmapLock_GetDataPointer(lock, buffersize, buffer); +

Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.

2013-01-02 Thread Vincent Povirk
On Wed, Jan 2, 2013 at 11:42 PM, Dmitry Timoshkov dmi...@baikal.ru wrote: It's better to actually check return value of IWICBitmapLock_GetDataPointer before memecpy(), or if that's not supposed to fail drop 'hr' assignment. Whoops, good catch. (I don't think it can fail, but I didn't mean to

Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.

2013-01-02 Thread Dmitry Timoshkov
Vincent Povirk madewokh...@gmail.com wrote: I guess I prefer to keep interfaces as simple as possible even if it means writing more code? I'd consider writing a helper function, but none of the other methods would use it. Is there any hurry with CreateBitmapFromMemory implementation, or you

Re: [3/4] comctl32: fix notifications and return value when collapsing already collapsed node (rebased)

2012-10-15 Thread Nikolay Sivov
Hi, Daniel. You forgot a patch.

Re: [3/4] comctl32: fix notifications and return value when collapsing already collapsed node (rebased)

2012-10-15 Thread Daniel Jelinski
Hello, Nikolay. Thanks for reminder. Attached it now. 2012/10/15 Nikolay Sivov bungleh...@gmail.com: Hi, Daniel. You forgot a patch.

Re: [3/4] shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.

2012-10-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22056 Your paranoid

Re: [3/4] dxgi: Avoid division by zero. Based on patch by Eduard - Gabriel Munteanu.

2012-09-24 Thread Henri Verbeet
On 23 September 2012 22:40, Ričardas Barkauskas rbarkaus...@codeweavers.com wrote: +static UINT dxgi_rational_to_uint(DXGI_RATIONAL *rational) rational should be const.

Re: [3/4] windowscodecs: Implement Image Descriptor metadata reader.

2012-09-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21584 Your paranoid

Re: [3/4] gdiplus: Destination points passed to GdipDrawImagePointsRect should be in device units.

2012-08-07 Thread Dmitry Timoshkov
Dmitry Timoshkov dmi...@baikal.ru wrote: +scale_x = units_scale(srcUnit, graphics-unit, graphics-xres); +scale_y = units_scale(srcUnit, graphics-unit, graphics-yres); This depends on a not yet sent series which introduces units_scale(), please ignore for now, I'll resend it a bit

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.

2012-07-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=100 Your paranoid

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.

2012-07-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.dolphin/JobDetails.pl?Key=158 Your paranoid

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.

2012-07-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19764 Your paranoid

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.

2012-07-04 Thread Dmitry Timoshkov
Marvin test...@testbot.winehq.org wrote: === WINEBUILD (build) === Patch failed to apply Either the testbot needs to reset its incoming queue once a day, or mail delivery problems for patch batches in winehq should be fixed. -- Dmitry.

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.

2012-06-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19594 Your paranoid

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.

2012-06-27 Thread Dmitry Timoshkov
Marvin test...@testbot.winehq.org wrote: === W7PROX64 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed: 3: expected property size 20 or 0, got 28 ===

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.

2012-06-27 Thread Dmitry Timoshkov
Dmitry Timoshkov dmi...@baikal.ru wrote: Marvin test...@testbot.winehq.org wrote: === W7PROX64 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed:

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.

2012-06-27 Thread Ben Peddell
On 27/06/2012 7:35 PM, Dmitry Timoshkov wrote: Marvin test...@testbot.winehq.org wrote: === W7PROX64 (64 bit image) === image.c:2811: Test failed: 0: expected property size 17 or 36, got 44 image.c:2811: Test failed: 2: expected property size 144 or 0, got 152 image.c:2811: Test failed:

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem.

2012-06-27 Thread Dmitry Timoshkov
Ben Peddell klightsp...@netspace.net.au wrote: Looks like testbot picked up wrong e-mail sequence. It looks like an e-mail delivery problem in the mailing list software, and it is getting pretty annoying. The winehq.org mailserver only allows one SMTP connection per relaying IP, so

Re: [3/4] server: Perform an access check for kernel objects without a security descriptor using access rights of the owner'

2012-04-17 Thread Dmitry Timoshkov
Marvin test...@testbot.winehq.org wrote: === WVISTAADM (32 bit sync) === sync.c:923: Test failed: DeleteTimerQueueTimer This failure has nothing to do with that patch. -- Dmitry.

Re: [3/4] server: Perform an access check for kernel objects without a security descriptor using access rights of the owner'

2012-04-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17911 Your paranoid

Re: [3/4] ddraw: Set correct HEL and HAL color models

2012-01-17 Thread Stefan Dösinger
Am Samstag, 10. Dezember 2011, 22:26:34 schrieb Stefan Dösinger: This looks strange. The system doesn't support hardware d3d, since the CreateDevice calls for HAL and HW TL HAL calls fail, but it still enumerates them. I guess adding a broken() is the way to go. I'll send a patch next week. I

Re: [3/4] ddraw: Set correct HEL and HAL color models

2011-12-10 Thread Saulius Krasuckas
Stefan, it looks like your patch http://source.winehq.org/git/wine.git/commitdiff/9e0baa55cec232656048c972e94a9dc2a15ec30b has introduced 2 failures on one virtual w2k3-vmware machine: http://test.winehq.org/data/e7bbb4ef1e95396b72a58f813b4346d9abccb699/2003_wtb-w2k3r2sex64-32/ddraw:d3d.html

Re: [3/4] ddraw: Set correct HEL and HAL color models

2011-12-10 Thread Stefan Dösinger
Am Samstag, 10. Dezember 2011, 18:44:32 schrieb Saulius Krasuckas: Stefan, it looks like your patch http://source.winehq.org/git/wine.git/commitdiff/9e0baa55cec232656048c972e94 a9dc2a15ec30b has introduced 2 failures on one virtual w2k3-vmware machine:

Re: [3/4] winemaker: Be less picky when detecting the target type (try 2)

2011-11-20 Thread André Hentschel
Am 19.11.2011 20:18, schrieb Vitaliy Margolen: On 11/19/2011 11:42 AM, André Hentschel wrote: this catches more than one 0 after the space and possible 0s after the x +if (/[[:space:]]0+x0*101$/) { For more then one you should use + not *. * means any number, including 0.

Re: [3/4] winemaker: Be less picky when detecting the target type (try 2)

2011-11-19 Thread Vitaliy Margolen
On 11/19/2011 11:42 AM, André Hentschel wrote: this catches more than one 0 after the space and possible 0s after the x +if (/[[:space:]]0+x0*101$/) { For more then one you should use + not *. * means any number, including 0. Vitaliy

Re: [3/4] ddraw: Add more tests and fixes for SetSurfaceDesc

2011-11-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15326 Your paranoid

Re: [3/4] msxml3: Add IDispatchEx support for IXMLDOMNamedNodeMap

2011-11-04 Thread Jacek Caban
Hi Nikolay, On 11/04/11 16:46, Nikolay Sivov wrote: +if(This-data-vtbl This-data-vtbl-invoke) { +hres = This-data-vtbl-invoke(This-outer, id, lcid, wFlags, pdp, pvarRes, pei); +if (hres != E_NOTIMPL) return hres; +} Using E_NOTIMPL for special meaning here seems

Re: [3/4] msxml3: Add IDispatchEx support for IXMLDOMNamedNodeMap

2011-11-04 Thread Nikolay Sivov
On 11/4/2011 20:00, Jacek Caban wrote: Hi Nikolay, On 11/04/11 16:46, Nikolay Sivov wrote: +if(This-data-vtbl This-data-vtbl-invoke) { +hres = This-data-vtbl-invoke(This-outer, id, lcid, wFlags, pdp, pvarRes, pei); +if (hres != E_NOTIMPL) return hres; +} Using

Re: [3/4] msxml3: Add IDispatchEx support for IXMLDOMNamedNodeMap

2011-11-04 Thread Jacek Caban
On 11/04/11 17:11, Nikolay Sivov wrote: On 11/4/2011 20:00, Jacek Caban wrote: Hi Nikolay, On 11/04/11 16:46, Nikolay Sivov wrote: +if(This-data-vtbl This-data-vtbl-invoke) { +hres = This-data-vtbl-invoke(This-outer, id, lcid, wFlags, pdp, pvarRes, pei); +if (hres !=

Re: [3/4] msxml3: Add IDispatchEx support for IXMLDOMNamedNodeMap

2011-11-04 Thread Nikolay Sivov
On 11/4/2011 20:21, Jacek Caban wrote: On 11/04/11 17:11, Nikolay Sivov wrote: On 11/4/2011 20:00, Jacek Caban wrote: Hi Nikolay, On 11/04/11 16:46, Nikolay Sivov wrote: +if(This-data-vtbl This-data-vtbl-invoke) { +hres = This-data-vtbl-invoke(This-outer, id, lcid, wFlags, pdp,

Re: [3/4] d3d9/tests: Test partial block locks

2011-10-31 Thread Henri Verbeet
On 31 October 2011 20:03, Stefan Dösinger ste...@codeweavers.com wrote: +case D3DPOOL_SCRATCH: +case D3DPOOL_SYSTEMMEM: +hr = IDirect3DDevice9_CreateOffscreenPlainSurface(device, 128, 128, formats[i].fmt, +

Re: [3/4] d3d9/tests: Test partial block locks

2011-10-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=15192 Your paranoid

Re: [3/4] d3d9/tests: Test partial block locks

2011-10-31 Thread Stefan Dösinger
On Monday 31 October 2011 21:10:41 Henri Verbeet wrote: On 31 October 2011 20:03, Stefan Dösinger ste...@codeweavers.com wrote: +case D3DPOOL_SCRATCH: +case D3DPOOL_SYSTEMMEM: +hr = IDirect3DDevice9_CreateOffscreenPlainSurface(device,

Re: [3/4] wined3d: reject ffp blits if the destination is not fbo attachable

2011-10-12 Thread Henri Verbeet
On 11 October 2011 22:30, Stefan Dösinger ste...@codeweavers.com wrote: +if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) +{ +if (!((dst_format-flags WINED3DFMT_FLAG_FBO_ATTACHABLE) || (dst_usage WINED3DUSAGE_RENDERTARGET))) +return FALSE; +} +

Re: [3/4] msxml3: Add error code defines (resend)

2010-11-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6690 Your paranoid

Re: [3/4] ddraw: fix DDSCAPS_3DDEVICE surfaces always setting DDSCAPS_VISIBLE

2010-10-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6460 Your paranoid

Re: [3/4]strmbase: implement OLE registration in AMovieDllRegisterServer2

2010-10-20 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: HRESULT WINAPI AMovieDllRegisterServer2(BOOL bRegister) { HRESULT hr; int i; IFilterMapper2 *pIFM2 = NULL; +HMODULE psapi; +fnGetModuleFileNameExW pFunc; +WCHAR szFileName[MAX_PATH]; + +psapi =

Re: [3/4] msxml3: Fix IXMLDOMNode::get_namespaceURI() for empty URIs

2010-09-13 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5208 Your paranoid

Re: [3/4] msxml3/tests: Some tests for ::get_ownerDocument() returned document instance

2010-09-06 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5061 Your paranoid

Re: [3/4] oleaut32/olepicture: Fix ::get_hPal() behaviour for certain picture types

2010-08-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4737 Your paranoid

Re: [3/4] shdocvw: Add and use AdviseSinkInerface for IE

2010-07-27 Thread Jacek Caban
On 7/27/10 1:25 PM, Alexander Nicolaysen Sørnes wrote: This will be used to change the address bar URL when navigating to new pages +*ppvoid = NULL; +if(IsEqualGUID(IID_IAdviseSink, riid)) You also need to handle IUnknown. +{ +*ppvoid = iface; +

Re: [3\4] d3d9: Partially implement GetAdapterDisplayModeEx

2010-07-20 Thread Chris Robinson
On Tuesday, July 20, 2010 2:28:44 pm Louis Lenders wrote: +TRACE(iface %p, adapter %u, mode %p.\n, iface, adapter, mode); +TRACE(iface %p, adapter %u, mode %p, rotation %p\n, iface, adapter, mode, rotation); This doesn't look right. You probably only need the second TRACE statement,

Re: 3/4 wined3d: add color_fill to blit_shader [try 2]

2010-03-26 Thread Henri Verbeet
That's more reasonable, but you still have a NULL function pointer in arbfp_blit for color_fill(), and blit_operation is unused.

Re: 3/4 wined3d: add color_fill to blit_shader

2010-03-25 Thread Henri Verbeet
On 25 March 2010 23:04, Roderick Colenbrander thunderbir...@gmail.com wrote: This patch adds a first part of the new blit_shader infrastructure. In a few days I plan to submit more parts of it which will extend the blit_shader and rewrite parts in the end. This is patch is pretty hacky.

Re: [3/4] d3d9: Remove the double unlock test

2010-03-17 Thread Henri Verbeet
On 17 March 2010 11:56, Stefan Dösinger ste...@codeweavers.com wrote: Windows 7 returns a different value than the test expects, and since its a todo_wine it seems no game depends on it. http://bugs.winehq.org/show_bug.cgi?id=19862 depends on that.

Re: [3/4] jscript: Fix various memory and reference count leaks.

2009-12-31 Thread Rob Shearman
2009/12/30 Jacek Caban ja...@codeweavers.com: Hi Rob, Thanks for your work on jscript. Unfortunately fixing Valgrind on jscript is not going to be easy. Most of your fixes are good, except clear_global part and jscript: Fix a circular reference caused by object and function objects being

Re: [3/4] jscript: Fix various memory and reference count leaks.

2009-12-31 Thread Jacek Caban
On 12/31/09 1:17 PM, Rob Shearman wrote: 2009/12/30 Jacek Cabanja...@codeweavers.com: Hi Rob, Thanks for your work on jscript. Unfortunately fixing Valgrind on jscript is not going to be easy. Most of your fixes are good, except clear_global part and jscript: Fix a circular reference

Re: [3/4] jscript: Fix various memory and reference count leaks.

2009-12-30 Thread Jacek Caban
Hi Rob, Thanks for your work on jscript. Unfortunately fixing Valgrind on jscript is not going to be easy. Most of your fixes are good, except clear_global part and jscript: Fix a circular reference caused by object and function objects being able to have properties that are objects and

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Henri Verbeet
2009/12/28 Matteo Bruni matteo.myst...@gmail.com: Why do you need the fake parser? Can't you just not support those shader versions yet? There's also (in general) not much of a point in adding structure fields that aren't used yet. +/* This file needs the original d3d9 definitions. The bwriter

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Alexandre Julliard
Matteo Bruni matteo.myst...@gmail.com writes: + +%option reentrant bison-bridge These won't work on old flex versions, and will get you in trouble with the flex police (aka Michael Stefaniuc ;-) -- Alexandre Julliard julli...@winehq.org

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Matteo Bruni
2009/12/29 Henri Verbeet hverb...@gmail.com: 2009/12/28 Matteo Bruni matteo.myst...@gmail.com: Why do you need the fake parser? Can't you just not support those shader versions yet? There's also (in general) not much of a point in adding structure fields that aren't used yet. I added the

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Matteo Bruni
2009/12/29 Alexandre Julliard julli...@winehq.org: Matteo Bruni matteo.myst...@gmail.com writes: + +%option reentrant bison-bridge These won't work on old flex versions, and will get you in trouble with the flex police (aka Michael Stefaniuc ;-) Alexandre, now you have another person on

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Henri Verbeet
2009/12/29 Matteo Bruni matteo.myst...@gmail.com: I added the fake parser for two reasons: because I have to initialize an asm_parser structure anyway in the create__parser functions (and I prefer to use parser_fake for the unimplemented shader versions instead of parser_vs_3) and I want

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Michael Stefaniuc
On 12/29/2009 04:54 PM, Matteo Bruni wrote: 2009/12/29 Alexandre Julliardjulli...@winehq.org: Matteo Brunimatteo.myst...@gmail.com writes: + +%option reentrant bison-bridge These won't work on old flex versions, and will get you in trouble with the flex police (aka Michael Stefaniuc ;-)

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Matteo Bruni
2009/12/29 Henri Verbeet hverb...@gmail.com: 2009/12/29 Matteo Bruni matteo.myst...@gmail.com: I added the fake parser for two reasons: because I have to initialize an asm_parser structure anyway in the create__parser functions (and I prefer to use parser_fake for the unimplemented shader

Re: [3/4] user32/cursoricon.c: Multiple Fixes/Improvements for DrawIconEx

2009-09-26 Thread Juan Lang
Hi Wilfried, minor comment on this patch: hBitTemp = SelectObject( hMemDC, hXorBits ); + +UINT bltFlag = 0; C89 doesn't allow you to mix code and declarations like this. You'll have to declare bltFlag at the top of the block. --Juan

Re: [3/4] user32/cursoricon.c: Multiple Fixes/Improvements for DrawIconEx

2009-09-26 Thread Vitaliy Margolen
Wilfried Pasquazzo wrote: Best regards, Subject: Make DrawIconEx 2 additional tests (now passes all tests) Subject: Make DrawIconEx pass a test You should really combine these 2 patches. You are modifying the same exact code and breaking it between patches (for some programs). Vitaliy.

Re: [3/4] WineD3D: Perform the srgb copy with fbo_blit if possible

2009-09-10 Thread Henri Verbeet
2009/9/10 Stefan Dösinger ste...@codeweavers.com: +if (context-current_fbo) { +context_bind_fbo(context, GL_FRAMEBUFFER_EXT, context-current_fbo-id); +} else { +context_bind_fbo(context, GL_FRAMEBUFFER_EXT, NULL); +} This shouldn't be needed. +/* Need FBOs

Re: [3/4] d3d10: Implement ID3D10Effect::GetVariableByIndex.

2009-08-24 Thread Henri Verbeet
2009/8/21 Rico Schüller kgbric...@web.de: +if( index This-local_buffer_variable_count ) Please use consistent style. +for (i = 0; i This-local_buffer_count; ++i) +{ +struct d3d10_effect_local_buffer *l = This-local_buffers[i]; +unsigned int j; +

Re: [3/4]winemaker: add workspace-parse function

2009-03-28 Thread Francois Gouget
This one is wrapped also (which is only logical). There are two other problems: * there's the same case sensitivity issue as in the project parsing code. Using search_from() in the same way should fix it. * also it assumes that the project file is in the current directory. In other

Re: [3/4]

2008-12-09 Thread Henri Verbeet
2008/12/8 Stefan Dösinger [EMAIL PROTECTED]: Does the patch have any other advantages besides making the fixed function state handlers somewhat simpler though? I'm not sure if introducing a dependency on the state tracker in the shader backend is worth this. (I've got a better way to avoid

RE: [3/4]

2008-12-09 Thread Stefan Dösinger
The patch essentially adds a version to the constants and throws them in a queue. The disadvantage is that setting a constant becomes a bit more expensive, and cache usage becomes a bit worse if you have to load constants from deeper in the tree, but it still gives me about 10 extra fps in

Re: [3/4]

2008-12-08 Thread Henri Verbeet
2008/12/8 Stefan Dösinger [EMAIL PROTECTED]: +/* TODO: If we're called by shader_glsl_select, we know that both we get past both checks. + * is it cheaper to have a wrapper function check those? Inline some common code? Extra + * parameter? + */ if (!prog) {

Re: [3/4]

2008-12-08 Thread Henri Verbeet
2008/12/8 Stefan Dösinger [EMAIL PROTECTED]: I don't think that would work well. We would need some shader model specific private data in each context(e.g. last vertexshader and last vertexdeclaration) to allow the shader backend to find out what to do, since the dirty state information won't

Re: [3/4]

2008-12-08 Thread Henri Verbeet
2008/12/8 Stefan Dösinger [EMAIL PROTECTED]: If you're going to introduce a dependency on state management in the shader backends anyway, you don't need to export constant loading functions from the shader backends at all. You might as well just call shader_select(), and let that figure out if

RE: [3/4]

2008-12-08 Thread Stefan Dösinger
If you're going to introduce a dependency on state management in the shader backends anyway, you don't need to export constant loading functions from the shader backends at all. You might as well just call shader_select(), and let that figure out if it needs to change the shader or load any

RE: [3/4]

2008-12-08 Thread Stefan Dösinger
I don't think that would work well. We would need some shader model specific private data in each context(e.g. last vertexshader and last vertexdeclaration) to allow the shader backend to find out what to do, since the dirty state information won't suffice if the shader backend doesn't know

RE: [3/4]

2008-12-08 Thread Stefan Dösinger
I would expect the relevant state to be dirty, but you say this depends on where the function is called from? States are marked clean before the application function is called. This is needed to handle e.g. the relationship between the vertex declaration and the lighting enable state. What I

Re: [3/4]

2008-12-08 Thread Henri Verbeet
2008/12/8 Stefan Dösinger [EMAIL PROTECTED]: I would expect the relevant state to be dirty, but you say this depends on where the function is called from? States are marked clean before the application function is called. This is needed to handle e.g. the relationship between the vertex

RE: [3/4]

2008-12-08 Thread Stefan Dösinger
Does the patch have any other advantages besides making the fixed function state handlers somewhat simpler though? I'm not sure if introducing a dependency on the state tracker in the shader backend is worth this. (I've got a better way to avoid redundant constant loads). The double loading

Re: [3/4] ntdll: Implement the timer queue thread.

2008-07-23 Thread Rob Shearman
Hi Dan, 2008/7/23 Dan Hipschman [EMAIL PROTECTED]: This isn't the most efficient implementation, but it works, and it should not be difficult to tweak. Hence, I'd rather get this version in and add the optimizations one at a time, in little patches. Get it working first... Yes, I think

Re: [3/4] ntdll: Implement the timer queue thread.

2008-07-23 Thread Alexandre Julliard
Rob Shearman [EMAIL PROTECTED] writes: 2008/7/23 Dan Hipschman [EMAIL PROTECTED]: This isn't the most efficient implementation, but it works, and it should not be difficult to tweak. Hence, I'd rather get this version in and add the optimizations one at a time, in little patches. Get it

Re: [3/4] user32: Set the vkey value to VK_PROCESSKEY when IME process key.

2008-04-24 Thread Aric Stewart
Thank you for these investigations This is really nice. I support those patches. I just wanted to also communicate a bit of additional information from my investigations just in case someone asks. I placed hooks on both WH_KEYBOARD_LL and WH_KEYBOARD. Even when the IME is active both of

Re: [3/4].Wbemprox.dll. Main modules for then library.

2008-02-25 Thread Robert Shearman
Ivan Sinitsin wrote: --- /dev/null 2007-03-10 18:36:24 +0300 +++ Makefile.in 2008-02-21 15:57:24 +0300 @@ -0,0 +1,23 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../.. +SRCDIR= @srcdir@ +VPATH = @srcdir@ +MODULE= wbemprox.dll +IMPORTLIB = libwbemprox.$(IMPLIBEXT) +IMPORTS

Re: [3/4] WineX11: Ignore the alpha if all pixels are 0x00

2007-12-12 Thread Juan Lang
Hi Stefan, a few minor nits: + * one pixel has alpha != 0x00, and the mask ignored as described in the Do you mean, the mask is ignored..., or the AND mask is ignored... ? + * written at 8 / 16 bpp times do not knwow about the 32 bit alpha, so s/knwow/know/ +for (y = 0; y

Re: [3/4] msxml: Implement removeAttribute

2007-11-15 Thread Mikołaj Zalewski
A problem with this patch is that the user may have an IXMLDOMNode * reference to the attribute node being removed. The xmlFreeProp will free the xmlnode so accessing the IXMLDOMNode could result in memory corruption. Under MSXML it's possible to access such node and even reconnect it e.g.

Re: [3/4] msxml: Implement removeAttribute

2007-11-15 Thread Alistair Leslie-Hughes
Mikołaj Zalewski wrote: A problem with this patch is that the user may have an IXMLDOMNode * reference to the attribute node being removed. The xmlFreeProp will free the xmlnode so accessing the IXMLDOMNode could result in memory corruption. Under MSXML it's possible to access such node

Re: 3/4 setupapi: Correctly handle an empty filename in SetupGetSourceFileLocationA.

2007-05-18 Thread James Hawkins
On 5/18/07, Hans Leidekker [EMAIL PROTECTED] wrote: -Hans Changelog Correctly handle an empty filename in SetupGetSourceFileLocationA. Please add a test case. -- James Hawkins

Re: 3/4 setupapi: Correctly handle an empty filename in SetupGetSourceFileLocationA.

2007-05-18 Thread Hans Leidekker
On Friday 18 May 2007 11:43:29 James Hawkins wrote: Correctly handle an empty filename in SetupGetSourceFileLocationA. Please add a test case. The BITS installer was enough of a test case for me here, but since you ask, I'll see what I can do. -Hans

Re: [3/4] WineD3D: Store the pixel format in the texture

2007-03-21 Thread H. Verbeet
Shouldn't this be done for volume textures as well?

Re: [3/4] WineD3D: Store the pixel format in the texture

2007-03-21 Thread Stefan Dösinger
Am Mittwoch 21 März 2007 17:53 schrieb H. Verbeet: Shouldn't this be done for volume textures as well? It is done, unless I missed something: @@ -896,6 +898,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateVolumeTexture(IWineD3DDevice *ifa object-width = Width; object-height =

Re: [3/4] WineD3D: Blit the offscreen texture into the drawable if needed

2007-03-07 Thread Stefan Dösinger
Am Mittwoch 07 März 2007 02:43 schrieb Stefan Dösinger: Do not apply this patch yet. Cube textures aren't that easy pgpJyUMrUXycs.pgp Description: PGP signature

Re: [3/4 revised] msi: Add partial, expandable OLE automation support.

2007-02-25 Thread James Hawkins
On 2/25/07, Misha Koshelev [EMAIL PROTECTED] wrote: This patch adds OLE automation support to MSI. It does this by creating a wrapper class, which implements any of the OLE automation classes as long as a function is given which is called from within the wrapper classes invoke method after

Re: 3/4 patches for compilation of ATL MFC

2004-03-11 Thread Alexandre Julliard
Boaz Harrosh [EMAIL PROTECTED] writes: +#define _I64_MIN(-9223372036854775807i64 - 1) +#define _I64_MAX 9223372036854775807i64 +#define _UI64_MAX 0xui64 The i64 suffix is not portable. --- include/msvcrt/math.h 2 Sep 2003 00:58:21 - 1.1 +++