Hi guys,
I am about to push the pfacet code (as a Xmas present) but before I wanted to
discuss the following:
1) The utils module is massive and I suggest that we move everything related
to cylinder, grids and pfacets in a new file, e.g. gridpfacet_utils.py. Are you
happy if I chance this?
2)
Hi Klaus,
2015-12-08 7:30 GMT+01:00 Klaus Thoeni :
> 1) The utils module is massive and I suggest that we move everything
> related
> to cylinder, grids and pfacets in a new file, e.g. gridpfacet_utils.py.
> Are you
> happy if I chance this?
>
I am fine with that.
Best regards
Anton
__
On 08/12/15 07:30, Klaus Thoeni wrote:
> Hi guys,
>
> I am about to push the pfacet code (as a Xmas present) but before I wanted to
> discuss the following:
>
> 1) The utils module is massive and I suggest that we move everything related
> to cylinder, grids and pfacets in a new file, e.g. gridpf
Hi Klaus,
1) no problem
2) the logic is that the original author Jan Elias made polyhedra_utils.py
file and then I made modifications of utils.py, adding sphere() like
function for polyhedra. I was thinkink about creating special file just for
different shapes (sphere, facet, polyhedra, box, wall.
Hi Jan,
thanks for you comments.
add 2): I think a file for every shape is probably an overkill. Or anyone
disagrees? I would keep general stuff like sphere, facet, box, wall in utils.py
and use separate modules for polyhedra and gridpfacet as they are very
specific. Regarding the latter, I th
Hi Klaus,
I think a file for every shape is probably an overkill
definitely :-) I meant to put all such functions in one file, called
sometinh liek shapes.py and imported in utils..
But I have nothing against any other solution, e.g. like you proposed. Just
let me know if you do it or I should
Klaus, could you provide a script for the third point of your original
message ?
Grid and Chained Cylinders have slightly different implementations, and I
think ChainedCylinders are likely more buggy.
Then I plan to traduct the ChainedCylinders examples into Grid logic and
drop the code.
Thx
2015-
7 matches
Mail list logo
