[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239141#comment-16239141
]
Jian He commented on YARN-7371:
---
failed test not related, will commit
> NPE in ServiceMaster
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238825#comment-16238825
]
Hadoop QA commented on YARN-7371:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238734#comment-16238734
]
Chandni Singh commented on YARN-7371:
-
[~subru] I think there maybe some fixes in trun
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238663#comment-16238663
]
Subru Krishnan commented on YARN-7371:
--
Thanks [~csingh] for addressing my feedback. I
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238651#comment-16238651
]
Hadoop QA commented on YARN-7371:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238508#comment-16238508
]
Jian He commented on YARN-7371:
---
lgtm, will commit after jenkins reports
> NPE in ServiceMas
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236524#comment-16236524
]
Jian He commented on YARN-7371:
---
there are some flaky tests, most of the time, if it can pass
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236501#comment-16236501
]
Chandni Singh commented on YARN-7371:
-
[~jianhe] Sounds good. Will make the changes you
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236488#comment-16236488
]
Jian He commented on YARN-7371:
---
Patch looks good to me overall, some comments:
- This method
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236473#comment-16236473
]
Hadoop QA commented on YARN-7371:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234878#comment-16234878
]
Chandni Singh commented on YARN-7371:
-
I have made changes to include allocationRequest
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225841#comment-16225841
]
Subru Krishnan commented on YARN-7371:
--
[~csingh]/[~billie.rinaldi], I am *not* in fav
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225713#comment-16225713
]
Billie Rinaldi commented on YARN-7371:
--
Thanks for the patch, [~csingh]! The patch loo
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223177#comment-16223177
]
Hadoop QA commented on YARN-7371:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222925#comment-16222925
]
Hadoop QA commented on YARN-7371:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222714#comment-16222714
]
Chandni Singh commented on YARN-7371:
-
[~jianhe] [~billie.rinaldi] I have attached a pa
[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217796#comment-16217796
]
Chandni Singh commented on YARN-7371:
-
Added some logging and looks like the {{allocati
17 matches
Mail list logo