Re: [OpenJDK 2D-Dev] RFR: 8234393 [macos] printing ignores printer tray

[Vipin Mv1]

Hi,

May I ask for a status on this please.  


-Vipin Mv1/India/IBM wrote: -
To: Philip Race 
From: Vipin Mv1/India/IBM
Date: 08/31/2020 05:52PM
Cc: 2d-dev@openjdk.java.net
Subject: Re: [EXTERNAL] Re: [OpenJDK 2D-Dev] RFR: 8234393 [macos] printing 
ignores printer tray

Hi Philip,

Thanks for the review comments. The testcase 
test/jdk/java/awt/print/PrinterJob/TestMediaTraySelection.java seems to be 
intended to test only the MediaTray functionality. Also, it doesn't seems to 
have anything that is Linux specific.

Rather than having a new testcase wouldn't it be fine to have os.family == 
"mac" change alone to the existing one.?

Regarding the testing, the patch was already tested by our customer using a 
multi tray printer and was found to be working. Owing to WFH factor due to 
COVID19, multi tray printer is not accessible to us at this point of time.

May I request if the community can help us do further testing with the multi 
tray printer.

Thanks & Regards
Vipin MV

-Philip Race  wrote: -
To: Vipin Mv1 
From: Philip Race 
Date: 08/30/2020 10:02PM
Cc: 2d-dev@openjdk.java.net
Subject: [EXTERNAL] Re: [OpenJDK 2D-Dev] RFR: 8234393 [macos] printing ignores 
printer tray

PS there is an existing manual regression test but it is currently 
geared towards Linux and in fact is set to run only on Linux
test/jdk/java/awt/print/PrinterJob/TestMediaTraySelection.java
So you still may find it easier to create a new test rather than modify 
this one to avoid breaking what it tests.

-phil


On 8/29/20, 11:10 AM, Philip Race wrote:
> PS, there's a test case in the bug. Seems like it could be used as the 
> basis for a manual regression test.
>
> Make sure you use @requires printer  as well as adding the manual and 
> headful keywords
> and next you'll have to check for an installed printer with multiple 
> trays
>
> -phil
>
> On 8/27/20, 11:36 AM, Philip Race wrote:
>> This looks reasonable but we need to test it first before approving it.
>>
>> -phil.
>>
>> On 8/27/20, 6:16 AM, Vipin Mv1 wrote:
>>> Hi,
>>>
>>> Please find below a patch for the following issue.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8234393 
>>>
>>>
>>> http://cr.openjdk.java.net/~aleonard/8234393/webrev.00 
>>>
>>> Thanks&  Regards
>>> Vipin MV
>>>
>>>

Re: [OpenJDK 2D-Dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

[skodanda]

On Tue, 22 Sep 2020 03:00:20 GMT, Sergey Bylokhov  wrote:

>> Marked as reviewed by prr (Reviewer).
>
> Since you remove the @headful keyword, did you check that the test works fine 
> via mach5? It will now select a
> completely different set of test systems.

Dear Sergey,

I did test my changes via mach5. It runs successfully on all the 3
platforms.

Please find below the result link after running the test using mach5

https://mach5.us.oracle.com/mdash/jobs/skodanda-open-20200902-1336-13932582

Best Regards,
K Suman Rajkumaar

On 22/09/2020 08:30, Sergey Bylokhov wrote:
>
> Since you remove the @headful
> 
> keyword, did you check that the test works fine via mach5? It will now
> select a completely different set of test systems.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> ,
> or unsubscribe
> .
>

-

PR: https://git.openjdk.java.net/jdk/pull/255

Re: [OpenJDK 2D-Dev] RFR: 8252195: AWT Accessibility API nested classes rely on default constructors

[Sergey Bylokhov]

On Mon, 21 Sep 2020 20:17:36 GMT, Phil Race  wrote:

> https://bugs.openjdk.java.net/browse/JDK-8252195
> is another one of the issues adding missing explicit no-args constructors in 
> the desktop module.
> 
> As well as being nested, these are all concrete, but protected, classes and 
> so the constructors
> are protected.
> 
> CSR here https://bugs.openjdk.java.net/browse/JDK-8253450 needs a reviewer 
> too.

src/java.desktop/share/classes/java/LS line 1:

> 1: -rw-r--r--   1 prrace  staff   22640 Sep 21 12:12 CheckboxMenuItem.java

This extra file seems accidentally added

-

PR: https://git.openjdk.java.net/jdk/pull/288

Re: [OpenJDK 2D-Dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

[Sergey Bylokhov]

On Fri, 18 Sep 2020 23:01:57 GMT, Phil Race  wrote:

>> Hello All,
>> 
>> Could you please review a TEST_BUG fix for the JDK 16?
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8248352
>> 
>> Problem description: The test 
>> test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially 
>> leave the
>> frame open if it fails. If it were not for the frame, the test could be 
>> headless. So probably, we can remove the call
>> to showText() from the test and make it headless..  Fix: An argument is 
>> added to the test. If "-show" is passed, the
>> test will show UI for visual inspection.
>
> Marked as reviewed by prr (Reviewer).

Since you remove the @headful keyword, did you check that the test works fine 
via mach5? It will now select a
completely different set of test systems.

-

PR: https://git.openjdk.java.net/jdk/pull/255

Re: [OpenJDK 2D-Dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

[Phil Race]

On Fri, 18 Sep 2020 17:05:42 GMT, skodanda 
 wrote:

> Hello All,
> 
> Could you please review a TEST_BUG fix for the JDK 16?
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8248352
> 
> Problem description: The test 
> test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially 
> leave the
> frame open if it fails. If it were not for the frame, the test could be 
> headless. So probably, we can remove the call
> to showText() from the test and make it headless..  Fix: An argument is added 
> to the test. If "-show" is passed, the
> test will show UI for visual inspection.

Marked as reviewed by prr (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/255

[OpenJDK 2D-Dev] RFR: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

[skodanda]

Hello All,

Could you please review a TEST_BUG fix for the JDK 16?

Bug: https://bugs.openjdk.java.net/browse/JDK-8248352

Problem description: The test 
test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially 
leave the
frame open if it fails. If it were not for the frame, the test could be 
headless. So probably, we can remove the call
to showText() from the test and make it headless..

Fix: An argument is added to the test. If "-show" is passed, the test will show 
UI for visual inspection.

-

Commit messages:
 - Update ArabicDiacriticTest.java

Changes: https://git.openjdk.java.net/jdk/pull/255/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=255=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8248352
  Stats: 11 lines in 1 file changed: 2 ins; 4 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/255.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/255/head:pull/255

PR: https://git.openjdk.java.net/jdk/pull/255

[OpenJDK 2D-Dev] RFR: 8252195: AWT Accessibility API nested classes rely on default constructors

[Phil Race]

https://bugs.openjdk.java.net/browse/JDK-8252195
is another one of the issues adding missing explicit no-args constructors in 
the desktop module.

As well as being nested, these are all concrete, but protected, classes and so 
the constructors
are protected.

CSR here https://bugs.openjdk.java.net/browse/JDK-8253450 needs a reviewer too.

-

Commit messages:
 - 8252195: AWT Accessibility API nested classes rely on default constructors
 - 8252195: AWT Accessibility API nested classes rely on default constructors

Changes: https://git.openjdk.java.net/jdk/pull/288/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=288=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252195
  Stats: 117 lines in 19 files changed: 117 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/288.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/288/head:pull/288

PR: https://git.openjdk.java.net/jdk/pull/288