Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]
On Thu, 5 Nov 2020 17:52:19 GMT, Phil Race wrote: >> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an >> OpenType text shaping library >> >> https://bugs.openjdk.java.net/browse/JDK-8247872 >> >> This has passed building and headless and headful automated tests on all >> platforms. > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8247872: Upgrade HarfBuzz to the latest 2.7.2 Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/993
Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]
On Thu, 5 Nov 2020 17:52:53 GMT, Phil Race wrote: >> @mrserb Good catch! Yes indeed, it looks like `range-loop-analysis` needs to >> be disabled for clang for Xcode 12 to not complain. > > I added that to the disabled warnings .. now I suppose the actions will > re-run but I don't see any sign of it yet. > Just that the results that were there are now gone. > A few thoughts on this > - github sends so many messages that it is easy to miss the important ones > - using the default for github we are at the whim of when ever they switch > and if this change >had been pushed 6 weeks ago likely it would have passed until the day > github upgraded. > - it also means passing a github build does not guarantee it will pass on the > "official" toolchains. @prrace I agree, the github actions are a double-edged sword -- at best. At worst, it's a clear regression in terms of how we work. :-( We might need to take a step back and rethink this. Anyway, your changes looks good from a build PoV now. - PR: https://git.openjdk.java.net/jdk/pull/993
Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]
On Thu, 5 Nov 2020 13:36:18 GMT, Magnus Ihse Bursie wrote: >> Looks like the build on macOS via GitHub will be broken by this fix? > > @mrserb Good catch! Yes indeed, it looks like `range-loop-analysis` needs to > be disabled for clang for Xcode 12 to not complain. I added that to the disabled warnings .. now I suppose the actions will re-run but I don't see any sign of it yet. Just that the results that were there are now gone. A few thoughts on this - github sends so many messages that it is easy to miss the important ones - using the default for github we are at the whim of when ever they switch and if this change had been pushed 6 weeks ago likely it would have passed until the day github upgraded. - it also means passing a github build does not guarantee it will pass on the "official" toolchains. - PR: https://git.openjdk.java.net/jdk/pull/993
Re: [OpenJDK 2D-Dev] RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v3]
> This upgrades JDK to import the current 2.7.2 version of harfbuzz - an > OpenType text shaping library > > https://bugs.openjdk.java.net/browse/JDK-8247872 > > This has passed building and headless and headful automated tests on all > platforms. Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8247872: Upgrade HarfBuzz to the latest 2.7.2 - Changes: - all: https://git.openjdk.java.net/jdk/pull/993/files - new: https://git.openjdk.java.net/jdk/pull/993/files/1f47957b..3d172716 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=993&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=993&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/993.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/993/head:pull/993 PR: https://git.openjdk.java.net/jdk/pull/993
