Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline [v2]

2021-03-31 Thread Jayathirth D V 
> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state 
> information because of which we ignore clip parameters set in rect clip and 
> shape clip. We need to query and use encoders from EncoderManager to honour 
> clip states in copyArea.

Jayathirth D V has updated the pull request incrementally with one additional 
commit since the last revision:

  Add comment on usage of MTLRenderCommandEncoder

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3283/files
  - new: https://git.openjdk.java.net/jdk/pull/3283/files/d72f9490..3e1ba4c9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3283&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3283&range=00-01

  Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3283.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3283/head:pull/3283

PR: https://git.openjdk.java.net/jdk/pull/3283

Re: [OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline [v2]

2021-03-31 Thread Ajit Ghaisas 
On Wed, 31 Mar 2021 15:03:54 GMT, Jayathirth D V  wrote:

>> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state 
>> information because of which we ignore clip parameters set in rect clip and 
>> shape clip. We need to query and use encoders from EncoderManager to honour 
>> clip states in copyArea.
>
> Jayathirth D V has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add comment on usage of MTLRenderCommandEncoder

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.m line 
821:

> 819:  * performing copyArea, thats why we need to query encoder 
> with
> 820:  * appropriate state from EncoderManager and not use
> 821:  * direct MTLBlitCommandEncoder for texture mapping.

Minor : "texture mapping" should be "texture copy" as MTLBlitCommandEncoder 
cannot be used for texture mapping anyway.

-

PR: https://git.openjdk.java.net/jdk/pull/3283