Re: touch optimized ksnapshot

[Marco Martin]

On Thursday 17 January 2013, Sebastian Kügler wrote:
> On Sunday, January 13, 2013 17:22:04 Thomas Pfeiffer wrote:
> > Another idea: I'd love to see "Take Screenshot" built into SLC "like" by
> > default, available in every application. If I like what I see on the
> > screen, I  can preserve it as a screenshot.
> 
> Should that not be "If I want to share what I see ..."? So a usecase for
> share, not for like? Otherwise, yes, cool idea. :)

that probably if it would already publish it somewhere, that would mean an 
extra entry for every supported service?
like would be just savng it on disk, then once saved you can share what you 
previously liked

-- 
Marco Martin
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Sebastian Kügler]

On Sunday, January 13, 2013 17:22:04 Thomas Pfeiffer wrote:
> Another idea: I'd love to see "Take Screenshot" built into SLC "like" by 
> default, available in every application. If I like what I see on the screen,
> I  can preserve it as a screenshot.

Should that not be "If I want to share what I see ..."? So a usecase for 
share, not for like? Otherwise, yes, cool idea. :)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Aaron J. Seigo]

On Sunday, January 13, 2013 22:03:23 Michael Bohlender wrote:
> SLC + name + save thing:
> Looks like a problem which needs to be solved for every app that produces
> some content.  would it make sense to  build a generic "dialog" like "Save
> as.. " for  that ?

in the case that the file already has a save location on disk, this is easy 
enough: the application just saves it to disk.

when there is no file name already in use, then it becomes tricky. for sharing, 
it would be possible to save it to a temporary location in that case.

this does not work for like or connect, however, as they require a more 
permenant location. so SLC may need to have a simple "given this thing a name, 
please" and pass that back to application to use as a save file name.

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Thomas Pfeiffer]

On 13.01.2013 19:18, Marco Martin wrote:

Another idea: I'd love to see "Take Screenshot" built into SLC "like" by
default, available in every application. If I like what I see on the
screen, I can preserve it as a screenshot.


interesting idea; would be easy to launch (touchified) ksnapshot from an
SLC plugin.


I must say I so much like the idea ;)


but, *what* would you "like"?
in this case would be something just added to the applet ui i guess, since
there wouldn't be any "url" to like, just the snapshot of the screen?
(regardless if the current window exports an url or not)



Yes, there would be no URL. I know it would be an exception to the usual 
SLC behavior, but one that would make sense from a user's perspective 
(and they don't care about URLs in that case anyway ;) )


___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Thomas Pfeiffer]

On 13.01.2013 18:57, Aaron J. Seigo wrote:

Another idea: I'd love to see "Take Screenshot" built into SLC "like" by
default, available in every application. If I like what I see on the screen,
I can preserve it as a screenshot.


interesting idea; would be easy to launch (touchified) ksnapshot from an SLC
plugin.

that might lead to a potentially odd circular workflow though?

* Like -> Snapshot screen
* snapshot UI comes up
* Share -> On Google+

hm.. no, that actually seems to work out alright once i actually say it.

was that kind of what you were thinking?


Yes, that was what I was thinking. To be clear: The KSnapshot UI should 
come up with the screenshot already taken, then the user can decide to 
save or share it (or take a new one if the current one isn't good 
enough). That way we only need one SLC option for screenshots in other 
applications, the rest is done in KSnapshot.

___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Michael Bohlender]

SLC + name + save thing:
Looks like a problem which needs to be solved for every app that produces
some content.  would it make sense to  build a generic "dialog" like "Save
as.. " for  that ?  If so, lets open another thread.

About KSnapshot:
Thanks for the feedback Thomas!

# Spinner:
   will be there once the widget is ready

# SLC integration:
  yes, I will try to do this

# SLC "like" plugin:
   sounds like a nice idea. i might look into this.

# Backgrounds:
   +1 for consistency, version 1.) it is.

# Actually getting a working Application
  This is not as easy as i thought. ( I have no experience with C++ nor Qt)

# Contributing a patch.
   When i did one JJ for kTp I just made a diff and posted it on
bugs.kde.org.  Then I changed it according to feedback till my patch
was accepted. How does it work for plasma active? Since this is not a
single feature but a small application, should I wait until it all works
reasonably well and then drop a huge diff or should I contribute small
peaces once they are reasonably ready (like the UI files) ?

Anyway,  thanks for making me feel so welcome. Have a great week!

cheers

Mike
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Marco Martin]

On Sunday 13 January 2013, Aaron J. Seigo wrote:
> On Sunday, January 13, 2013 17:22:04 Thomas Pfeiffer wrote:
> > > perhaps we could even extend the new confirmation dialog component to
> > > allow
> > > user text input so when you hit 'Save' it would popup, pointing at the
> > > Save
> > > button, and have a lineedit in it for you to enter a name for it.
> > 
> > I have a different idea: Since we'd need a filename for sending/sharing
> > as well, why not putting the lineedit directly on the main UI (above the
> > Save button)?
> 
> really nice idea imho...
> 
> > Another idea: I'd love to see "Take Screenshot" built into SLC "like" by
> > default, available in every application. If I like what I see on the
> > screen, I can preserve it as a screenshot.
> 
> interesting idea; would be easy to launch (touchified) ksnapshot from an
> SLC plugin.

I must say I so much like the idea ;)


but, *what* would you "like"?
in this case would be something just added to the applet ui i guess, since 
there wouldn't be any "url" to like, just the snapshot of the screen? 
(regardless if the current window exports an url or not)



Cheers,
Marco Martin
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Aaron J. Seigo]

On Saturday, January 12, 2013 21:46:35 Michael Bohlender wrote:
> 1.  http://postimage.org/image/czufr6jar/

this is the "correct" way around, following other applications we have such as 
the file browser: content goes on the light grey, controls on a "further back" 
hatched background.

it took me a few minutes to get used to it the first time around, but it realy 
works nicely. and keeping consistency is preferred.

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Aaron J. Seigo]

On Sunday, January 13, 2013 17:22:04 Thomas Pfeiffer wrote:
> > perhaps we could even extend the new confirmation dialog component to
> > allow
> > user text input so when you hit 'Save' it would popup, pointing at the
> > Save
> > button, and have a lineedit in it for you to enter a name for it.
> 
> I have a different idea: Since we'd need a filename for sending/sharing as
> well, why not putting the lineedit directly on the main UI (above the Save
> button)?

really nice idea imho... 

> Another idea: I'd love to see "Take Screenshot" built into SLC "like" by
> default, available in every application. If I like what I see on the screen,
> I can preserve it as a screenshot.

interesting idea; would be easy to launch (touchified) ksnapshot from an SLC 
plugin.

that might lead to a potentially odd circular workflow though?

* Like -> Snapshot screen
* snapshot UI comes up
* Share -> On Google+

hm.. no, that actually seems to work out alright once i actually say it.

was that kind of what you were thinking?

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Thomas Pfeiffer]

Hi Michael,
sorry for not replying earlier, this was a busy weekend...
First of all: Great that you're doing this, this is the true FOSS spirit!
Now for detailed feedback (I'll just paste quotes from various mails in the 
read into this mail for convenience):

On Saturday 12 January 2013 17:07:48 Michael Bohlender wrote:
> I had to use ksnapshot today and it wasn't a pleasure to use on a
> touchscreen so I decided to improve that.
> Here is my UI mockup; http://postimage.org/image/dq2xwnl2t/ .
> Feedback would be welcome. The wiki seems to be down so i couldn't check if
> it's HIG compliant.

The only thing not compliant with the HIG would be the number spinner, but as 
Aaron and Marco point out, there is no standard component for it yet, and we 
absolutely need one.
Thanks, Aaron, for looking into this!
So as soon as the component is available, please use it.

(from Aaron):
> +1 .. though "Save to Device" seems a little verbose; "Save" should be
> enough?

Yes, just "Save", please.

> perhaps we could even extend the new confirmation dialog component to allow
> user text input so when you hit 'Save' it would popup, pointing at the Save
> button, and have a lineedit in it for you to enter a name for it.

I have a different idea: Since we'd need a filename for sending/sharing as 
well, why not putting the lineedit directly on the main UI (above the Save 
button)? Thereby users can give it a name and _then_ decide whether they want 
to just save it, or send it, or share it on the social web, put it on Flickr 
or whatever, all directly via SLC directly from KSnapshot. 
It would ideally already have an automatically generated default name in it, 
so that people who don't care about the file name (since PA browsers i,ages by 
thumbnail instead of name anyway) could just use the default.

And yes, we don't want a browsing dialog for saving, because in PA we hide the 
file system.

> also, Send To should probably be replaced with Share Like Connect (SLC)
> support ... but that means i need to finally add support to SLC to notify
> the
> application to save the content when an SLC request is completed by the
> user.

Yes, please! This is pretty much a no-brainer to me. KSnapshot is an 
application which produces an image. Users should actually _expect_ to be able 
to use all our fancy SLC stuff with it directly from the application.

(from Marco):
> the blue area is usually used as a background behind everything, so the
> shadow should be flipped

I guess what Marco means is what you did in 
http://postimage.org/image/rwbe4z369/
aka blue background behind the main area.


Another idea: I'd love to see "Take Screenshot" built into SLC "like" by 
default, available in every application. If I like what I see on the screen, I 
can preserve it as a screenshot.

Again, I'm really glad you're doing this, keep up the great work!
Thomas
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Michael Bohlender]

Thanks for your feedback!

Here is what I implemented so far:

1.  http://postimage.org/image/czufr6jar/

2. http://postimage.org/image/rwbe4z369/

I am not sure I understand the shadow thing so I made two versions.
Personally I prefer version two but I don't know if that is how it is
supposed to be.

Next is:
# thumbnail background
# make it part of KSnapshot and get it to work
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Martin Gräßlin]

On Saturday 12 January 2013 17:07:48 Michael Bohlender wrote:
> I had to use ksnapshot today and it wasn't a pleasure to use on a
> touchscreen so I decided to improve that.
> Here is my UI mockup; http://postimage.org/image/dq2xwnl2t/ .
> Feedback would be welcome. The wiki seems to be down so i couldn't check if
> it's HIG compliant.
>
> For the delay chooser: i remember a suitable widget for choosing between
> numbers but i couldn't find it.
> Any hints?
>
> I'd  like to make this into a working application for PA if nobody is
> already working on this.
out of interest: will you make it part of the existing KSnapshot source base
or a new application? I'm just asking because KSnapshot will be one of the few
applications which need some love before going to Qt 5. So if you would go for
a complete new app, I would like to talk to you to give you some input what
would be problematic with Qt 5.
>
> Ah and this would be my first contribution to KDE (besides a minor patch)
> so please be patient with me.
pretty cool :-)  welcome to the KDE development team. Starting with KSnapshot
is awesome. I was so impressed when I first touched that code base. It's so
old, but KSnapshot looks so young and has so many well known KDE developers
who have worked on it. Great choice :-)

Cheers
Martin Gräßlin

signature.asc
Description: This is a digitally signed message part.
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Aaron J. Seigo]

On Saturday, January 12, 2013 23:09:01 Shantanu Tushar Jha wrote:
> I think the best way would be just an option "Save To Device" which would
> save the image to ~/Pictures or maybe ~/Pictures/Screenshots

+1 .. though "Save to Device" seems a little verbose; "Save" should be enough?

perhaps we could even extend the new confirmation dialog component to allow 
user text input so when you hit 'Save' it would popup, pointing at the Save 
button, and have a lineedit in it for you to enter a name for it.

also, Send To should probably be replaced with Share Like Connect (SLC) 
support ... but that means i need to finally add support to SLC to notify the 
application to save the content when an SLC request is completed by the user.

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Shantanu Tushar Jha]

On Sat, Jan 12, 2013 at 9:37 PM, Michael Bohlender <
michael.bohlen...@gmail.com> wrote:

> I had to use ksnapshot today and it wasn't a pleasure to use on a
> touchscreen so I decided to improve that.
> Here is my UI mockup; http://postimage.org/image/dq2xwnl2t/ .
> Feedback would be welcome. The wiki seems to be down so i couldn't check
> if it's HIG compliant.
>

Hi Michael,

Thanks for this, it'll be very nice to see a touch friendly KSnapshot. Just
one note, we should not use the "Save As" option there as its a general
idea across Plasma Active not to expose a filesystem from the user apps.

I think the best way would be just an option "Save To Device" which would
save the image to ~/Pictures or maybe ~/Pictures/Screenshots

Cheers,

-- 
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com


> For the delay chooser: i remember a suitable widget for choosing between
> numbers but i couldn't find it.
> Any hints?
>
> I'd  like to make this into a working application for PA if nobody is
> already working on this.
>
> Ah and this would be my first contribution to KDE (besides a minor patch)
> so please be patient with me.
>
> cheers
>
> Mike
>
> ___
> Active mailing list
> Active@kde.org
> https://mail.kde.org/mailman/listinfo/active
>
>



___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Marco Martin]

On Saturday 12 January 2013, Michael Bohlender wrote:
> I had to use ksnapshot today and it wasn't a pleasure to use on a
> touchscreen so I decided to improve that.
> Here is my UI mockup; http://postimage.org/image/dq2xwnl2t/ .
> Feedback would be welcome. The wiki seems to be down so i couldn't check if
> it's HIG compliant.

Good job!
looks really good already!

as where to put it, i agree whith what aaron said previously, i think it 
should ideally be in ksnapshot repository in a branch until is mature enough.

as quick feedback on the ui (yes, we need to adapt the date picker for generic 
spinners ;)

the blue area is usually used as a background behind everything, so the shadow 
should be flipped

maybe, a framesvg aroung the thumbnail "widgets/media-delegate" prefix "image" 
would look good.
(not 100% sure about it, should be tried and compared)

other than that it looks looks very good (i guess there could be some problem 
for the save as... dialog since we don't have any in active, we may want one 
or not, not sure)

again, welcome in the active development ;)

Cheers,
Marco Martin
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

Re: touch optimized ksnapshot

[Aaron J. Seigo]

On Saturday, January 12, 2013 17:07:48 Michael Bohlender wrote:
> I had to use ksnapshot today and it wasn't a pleasure to use on a
> touchscreen so I decided to improve that.
> Here is my UI mockup; http://postimage.org/image/dq2xwnl2t/ .

as mentioned on irc: i think it looks really good already. i'd probably move 
the "Take new snapshot" button to be under the options as the columnar workflow 
probably supports that: set options, take a new shot.

as for where to put it, i'd suggest starting a branch in the ksnapshot 
repository that has this UI in a subdirectory as we did in okular. (perhaps 
even name it the same: "active/"). in there should be a small c++ "starter" 
app, again just as in the okular case, which loads the QML package and 
provides access to the ksnapshot code which actually takes snapshots, etc.

if you have questions on accomplishing that part of it, just ask here or on 
irc :)

and yes, i'd love to see a better touch based UI for this app in Plasma 
Active!

> For the delay chooser: i remember a suitable widget for choosing between
> numbers but i couldn't find it.
> Any hints?

there is a date picker which is sort of like this .. but really we need a 
proper component that can be shared between apps as you noted. should be easy 
enough to create, and would be a touch replacement for spinners as seen on the 
desktop.

i'll try my hand at this over the weekend (unless you want to, of course)

> Ah and this would be my first contribution to KDE (besides a minor patch)
> so please be patient with me.

welcome to KDE and Plasma Active dev! :)

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

touch optimized ksnapshot

[Michael Bohlender]

I had to use ksnapshot today and it wasn't a pleasure to use on a
touchscreen so I decided to improve that.
Here is my UI mockup; http://postimage.org/image/dq2xwnl2t/ .
Feedback would be welcome. The wiki seems to be down so i couldn't check if
it's HIG compliant.

For the delay chooser: i remember a suitable widget for choosing between
numbers but i couldn't find it.
Any hints?

I'd  like to make this into a working application for PA if nobody is
already working on this.

Ah and this would be my first contribution to KDE (besides a minor patch)
so please be patient with me.

cheers

Mike
___
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active