Re: Issue 343 in address-sanitizer: asan_symbolize.py sometimes omits newlines in stack traces

2014-09-19 Thread address-sanitizer


Comment #4 on issue 343 by gli...@chromium.org: asan_symbolize.py sometimes  
omits newlines in stack traces

https://code.google.com/p/address-sanitizer/issues/detail?id=343

Thanks for fixing this!
There aren't other uses of get_symbolized_lines() yet, but I'll pay  
attention to it.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Small improvements to run_spec_clang_asan.sh

2014-09-19 Thread Konstantin Serebryany
On Fri, Sep 19, 2014 at 5:13 AM, 'Evgeniy Stepanov' via
address-sanitizer address-sanitizer@googlegroups.com wrote:
 CLANG=${CLANG:-clang}
 You probably need the same for CLANGXX

 Why are you disabling leak detection? It is on by default, which means
 you are benchmarking not the same thing that users run.
 At least make it an option.

i disable lsan in my local copy of this script because there are leaks
in several benchmarks :)


 I don't understand this LD_LIBRARY_PATH magic, what's its for?



 On Fri, Sep 19, 2014 at 3:26 PM, Alexander Potapenko gli...@google.com 
 wrote:
 CC kcc, eugenis

 On Thu, Sep 18, 2014 at 7:25 PM, Yuri Gribov tetra2...@gmail.com wrote:
 Hi all,

 Here is a small patch for
 https://code.google.com/p/address-sanitizer/source/browse/trunk/spec/run_spec_clang_asan.sh
 which
 * updates docs
 * adds some option verification
 * adds GCC support
 * disables leak detection

 Does the change look sane?

 -Y

 --
 You received this message because you are subscribed to the Google Groups 
 address-sanitizer group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to address-sanitizer+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



 --
 Alexander Potapenko
 Software Engineer
 Google Moscow

 --
 You received this message because you are subscribed to the Google Groups 
 address-sanitizer group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to address-sanitizer+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Small improvements to run_spec_clang_asan.sh

2014-09-19 Thread Yuri Gribov
On Fri, Sep 19, 2014 at 4:13 PM, 'Evgeniy Stepanov' via
address-sanitizer address-sanitizer@googlegroups.com wrote:
 CLANG=${CLANG:-clang}
 You probably need the same for CLANGXX

I do this in the next block (autodetection is different clang and gcc
are different).

 Why are you disabling leak detection? It is on by default, which means
 you are benchmarking not the same thing that users run.
 At least make it an option.

As Kostya mentioned there are numerous leaks in benchmarks which make
analysis harder. I can remove it if necessary.

 I don't understand this LD_LIBRARY_PATH magic, what's its for?

Snap, believe it or not but that's a typo. It should be ASAN_OPTIONS
and the weird expression optionally inserts : in front of added
options (so that user can provide his own ASAN_OPTIONS).

-Y

-- 
You received this message because you are subscribed to the Google Groups 
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Small improvements to run_spec_clang_asan.sh

2014-09-19 Thread Yuri Gribov
On Fri, Sep 19, 2014 at 9:02 PM, Yuri Gribov tetra2...@gmail.com wrote:
 I don't understand this LD_LIBRARY_PATH magic, what's its for?

 Snap, believe it or not but that's a typo. It should be ASAN_OPTIONS
 and the weird expression optionally inserts : in front of added
 options (so that user can provide his own ASAN_OPTIONS).

I meant to say

export 
ASAN_OPTIONS=alloc_dealloc_mismatch=0:detect_leaks=0${ASAN_OPTIONS:+:$ASAN_OPTIONS}

Will test and resend on Monday.

-Y

-- 
You received this message because you are subscribed to the Google Groups 
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.