Re: RFC: Enable core dumps even on 64-bit platforms

2017-07-27 Thread Konstantin Serebryany
Just to make sure: all you are suggesting is to change the default value(s)
of flag(s), right?

I am reluctant to change the defaults here because core dumps are rarely
useful with asan reports and because they will cause more trouble then is
worth it (atexit timeout, disk full, etc)

--kcc

On Wed, Jul 26, 2017 at 11:57 PM, Yuri Gribov  wrote:

> Hi all,
>
> Currently core dumps are disabled on 64-bit platforms. This decisions
> come from old times when 16 TB shadow memory was included in coredump.
> Nowadays we have use_madv_dontdump (enabled by default) which keeps
> size of core file reasonable. Perhaps we can disable disable_coredump
> on all platforms unconditionally? This is causing real usability
> issues (see https://stackoverflow.com/questions/45280910/gcc-
> address-sanitizer-core-dump-on-error).
>
> -I
>
> --
> You received this message because you are subscribed to the Google Groups
> "address-sanitizer" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to address-sanitizer+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: ASan/LSan with a custom allocator

2017-07-27 Thread Kuba Mracek
I think the usual solution is to have an option in the program to disable the 
custom allocator and use system malloc/free instead, and run ASan/LSan in this 
mode.  Far from ideal, but seems to work well in practice.  Does that not fit 
in your scenario?

Kuba

> On 27 Jul 2017, at 13:42, Francis Ricci  wrote:
> 
> Hi all,
> 
> Is there currently a good way to run ASan/LSan on a program using a custom 
> allocator (for example, tcmalloc)? I couldn't find any solutions in the 
> current code other than manually adding some extra interceptors locally (in 
> the tcmalloc case those would be things like tc_malloc and tc_free). I 
> thought about trying to add some API functions to allow users to configure 
> the allocation functions used by the sanitizers, but I don't think this will 
> work since the interception is set up at link time + sanitizer library load 
> time as far as I'm aware.
> 
> Has anyone put any thought into possible ways to handle this? I'd be willing 
> to put in the work if anyone has any ideas on a potential solution.
> 
> Francis
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "address-sanitizer" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to address-sanitizer+unsubscr...@googlegroups.com 
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups 
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


ASan/LSan with a custom allocator

2017-07-27 Thread Francis Ricci
Hi all,

Is there currently a good way to run ASan/LSan on a program using a custom
allocator (for example, tcmalloc)? I couldn't find any solutions in the
current code other than manually adding some extra interceptors locally (in
the tcmalloc case those would be things like tc_malloc and tc_free). I
thought about trying to add some API functions to allow users to configure
the allocation functions used by the sanitizers, but I don't think this
will work since the interception is set up at link time + sanitizer library
load time as far as I'm aware.

Has anyone put any thought into possible ways to handle this? I'd be
willing to put in the work if anyone has any ideas on a potential solution.

Francis

-- 
You received this message because you are subscribed to the Google Groups 
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


RFC: Enable core dumps even on 64-bit platforms

2017-07-27 Thread Yuri Gribov
Hi all,

Currently core dumps are disabled on 64-bit platforms. This decisions
come from old times when 16 TB shadow memory was included in coredump.
Nowadays we have use_madv_dontdump (enabled by default) which keeps
size of core file reasonable. Perhaps we can disable disable_coredump
on all platforms unconditionally? This is causing real usability
issues (see 
https://stackoverflow.com/questions/45280910/gcc-address-sanitizer-core-dump-on-error).

-I

-- 
You received this message because you are subscribed to the Google Groups 
"address-sanitizer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.