Re: [PR] GH-42002: [Java] Update Unit Tests for Vector Module [arrow]

[via GitHub]

lidavidm merged PR #42019:
URL: https://github.com/apache/arrow/pull/42019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

[via GitHub]

michael-o commented on code in PR #141:
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631201984


##
src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java:
##
@@ -26,22 +26,24 @@
 import java.io.OutputStream;
 import java.nio.file.Path;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 
+import 
com.puppycrawl.tools.checkstyle.AbstractAutomaticBean.OutputStreamOptions;

Review Comment:
   Looking into. Let me fix CI errors first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [YUNIKORN-2637] finalizePods should ignore pods like registerPods [yunikorn-k8shim]

[via GitHub]

pbacsko closed pull request #847: [YUNIKORN-2637] finalizePods should ignore 
pods like registerPods
URL: https://github.com/apache/yunikorn-k8shim/pull/847


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] kie-issues#131: Clear error state on CreateGit and CreateGist modal close [incubator-kie-tools]

[via GitHub]

tiagobento merged PR #2411:
URL: https://github.com/apache/incubator-kie-tools/pull/2411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org

[PR] additional sample for log parsing in javascript action. #2238 (hop)

[via GitHub]

bamaer opened a new pull request, #4030:
URL: https://github.com/apache/hop/pull/4030

   **Please** add a meaningful description for your change here
   
   
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] HADOOP-19116. Update to zookeeper client 3.8.4 due to CVE-2024-23944 [hadoop]

[via GitHub]

steveloughran commented on PR #6675:
URL: https://github.com/apache/hadoop/pull/6675#issuecomment-2154836469

   OOM is probably not this prs fault.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Add int8_hnsw backcompat index creation to dev tools scripts [lucene]

[via GitHub]

benwtrent merged PR #13465:
URL: https://github.com/apache/lucene/pull/13465


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Re: [PR] Bump org.mockito:mockito-core from 4.11.0 to 5.12.0 [commons-configuration]

[via GitHub]

dependabot[bot] commented on PR #420:
URL: 
https://github.com/apache/commons-configuration/pull/420#issuecomment-2154832650

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.mockito:mockito-core from 4.11.0 to 5.12.0 [commons-configuration]

[via GitHub]

garydgregory commented on PR #420:
URL: 
https://github.com/apache/commons-configuration/pull/420#issuecomment-2154832567

   Closing for now, requires Java > 8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.mockito:mockito-core from 4.11.0 to 5.12.0 [commons-configuration]

[via GitHub]

garydgregory closed pull request #420: Bump org.mockito:mockito-core from 
4.11.0 to 5.12.0
URL: https://github.com/apache/commons-configuration/pull/420


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Resolve issue #749 (celix)

[via GitHub]

codecov-commenter commented on PR #752:
URL: https://github.com/apache/celix/pull/752#issuecomment-2154831699

   ## 
[Codecov](https://app.codecov.io/gh/apache/celix/pull/752?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 90.20%. Comparing base 
[(`fd4b138`)](https://app.codecov.io/gh/apache/celix/commit/fd4b1385abcf7e58da0e2cea50914080f81230ac?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`2117276`)](https://app.codecov.io/gh/apache/celix/commit/21172764c6599cfb683713056ae28ee39dfc80be?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   
   Additional details and impacted files
   
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #752   +/-   ##
   ===
 Coverage   90.20%   90.20%   
   ===
 Files 225  225   
 Lines   2639326393   
   ===
 Hits2380723807   
 Misses   2586 2586   
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/celix/pull/752?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] HADOOP-19189. ITestS3ACommitterFactory failing [hadoop]

[via GitHub]

steveloughran commented on code in PR #6857:
URL: https://github.com/apache/hadoop/pull/6857#discussion_r1631197156


##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestS3ACommitterFactory.java:
##
@@ -72,121 +85,156 @@ public class ITestS3ACommitterFactory extends 
AbstractCommitITest {
* Parameterized list of bindings of committer name in config file to
* expected class instantiated.
*/
-  private static final Object[][] bindings = {
-  {COMMITTER_NAME_FILE, FileOutputCommitter.class},
-  {COMMITTER_NAME_DIRECTORY, DirectoryStagingCommitter.class},
-  {COMMITTER_NAME_PARTITIONED, PartitionedStagingCommitter.class},
-  {InternalCommitterConstants.COMMITTER_NAME_STAGING,
-  StagingCommitter.class},
-  {COMMITTER_NAME_MAGIC, MagicS3GuardCommitter.class}
+  private static final Object[][] BINDINGS = {
+  {"", "", FileOutputCommitter.class, "Default Binding"},
+  {COMMITTER_NAME_FILE, "", FileOutputCommitter.class, "File committer in 
FS"},
+  {COMMITTER_NAME_PARTITIONED, "", PartitionedStagingCommitter.class,
+  "partitoned committer in FS"},
+  {COMMITTER_NAME_STAGING, "", StagingCommitter.class, "staging committer 
in FS"},
+  {COMMITTER_NAME_MAGIC, "", MagicS3GuardCommitter.class, "magic committer 
in FS"},
+  {COMMITTER_NAME_DIRECTORY, "", DirectoryStagingCommitter.class, "Dir 
committer in FS"},
+  {INVALID_NAME, "", null, "invalid committer in FS"},
+
+  {"", COMMITTER_NAME_FILE, FileOutputCommitter.class, "File committer in 
task"},
+  {"", COMMITTER_NAME_PARTITIONED, PartitionedStagingCommitter.class,
+  "partioned committer in task"},
+  {"", COMMITTER_NAME_STAGING, StagingCommitter.class, "staging committer 
in task"},
+  {"", COMMITTER_NAME_MAGIC, MagicS3GuardCommitter.class, "magic committer 
in task"},
+  {"", COMMITTER_NAME_DIRECTORY, DirectoryStagingCommitter.class, "Dir 
committer in task"},
+  {"", INVALID_NAME, null, "invalid committer in task"},
   };
 
   /**
-   * This is a ref to the FS conf, so changes here are visible
-   * to callers querying the FS config.
+   * Test array for parameterized test runs.
+   *
+   * @return the committer binding for this run.
*/
-  private Configuration filesystemConfRef;
-
-  private Configuration taskConfRef;
+  @Parameterized.Parameters(name = "{3}-fs=[{0}]-task=[{1}]-[{2}]")
+  public static Collection params() {
+return Arrays.asList(BINDINGS);
+  }
 
-  @Override
-  public void setup() throws Exception {
-super.setup();
-jobId = randomJobId();
-attempt0 = "attempt_" + jobId + "_m_00_0";
-taskAttempt0 = TaskAttemptID.forName(attempt0);
+  /**
+   * Name of committer to set in filesystem config. If "" do not set one.
+   */
+  private final String fsCommitterName;
 
-outDir = path(getMethodName());
-factory = new S3ACommitterFactory();
-Configuration conf = new Configuration();
-conf.set(FileOutputFormat.OUTDIR, outDir.toUri().toString());
-conf.set(MRJobConfig.TASK_ATTEMPT_ID, attempt0);
-conf.setInt(MRJobConfig.APPLICATION_ATTEMPT_ID, 1);
-filesystemConfRef = getFileSystem().getConf();
-tContext = new TaskAttemptContextImpl(conf, taskAttempt0);
-taskConfRef = tContext.getConfiguration();
-  }
+  /**
+   * Name of committer to set in job config.
+   */
+  private final String jobCommitterName;
 
-  @Test
-  public void testEverything() throws Throwable {
-testImplicitFileBinding();
-testBindingsInTask();
-testBindingsInFSConfig();
-testInvalidFileBinding();
-testInvalidTaskBinding();
-  }
+  /**
+   * Expected committer class.
+   * If null: an exception is expected
+   */
+  private final Class committerClass;
 
   /**
-   * Verify that if all config options are unset, the FileOutputCommitter
-   *
-   * is returned.
+   * Description from parameters, simply for thread names to be more 
informative.
*/
-  public void testImplicitFileBinding() throws Throwable {
-taskConfRef.unset(FS_S3A_COMMITTER_NAME);
-filesystemConfRef.unset(FS_S3A_COMMITTER_NAME);
-assertFactoryCreatesExpectedCommitter(FileOutputCommitter.class);
-  }
+  private final String description;
 
   /**
-   * Verify that task bindings are picked up.
+   * Create a parameterized instance.
+   * @param fsCommitterName committer to set in filesystem config
+   * @param jobCommitterName committer to set in job config
+   * @param committerClass expected committer class
+   * @param description debug text for thread names.
*/
-  public void testBindingsInTask() throws Throwable {
-// set this to an invalid value to be confident it is not
-// being checked.
-filesystemConfRef.set(FS_S3A_COMMITTER_NAME, "INVALID");
-taskConfRef.set(FS_S3A_COMMITTER_NAME, COMMITTER_NAME_FILE);
-assertFactoryCreatesExpectedCommitter(FileOutputCommitter.class);
-for (Object[] binding : bindings) {
-  

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

[via GitHub]

yuxiqian commented on PR #3404:
URL: https://github.com/apache/flink-cdc/pull/3404#issuecomment-2154831120

   Nevermind, thanks for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] fix: use total ordering in the min & max accumulator for floats [datafusion]

[via GitHub]

westonpace commented on code in PR #10627:
URL: https://github.com/apache/datafusion/pull/10627#discussion_r1631196582


##
datafusion/physical-expr/src/aggregate/min_max.rs:
##
@@ -1103,3 +1117,36 @@ impl Accumulator for SlidingMinAccumulator {
 std::mem::size_of_val(self) - std::mem::size_of_val() + 
self.min.size()
 }
 }
+
+#[cfg(test)]
+mod tests {
+use super::*;
+
+#[test]
+fn float_max_with_nans() {
+let pos_nan = f32::NAN;
+let zero = 0_f32;
+
+let vals_float = Float32Array::from_iter_values([zero, 
pos_nan].iter().copied());
+
+let vals: ArrayRef = Arc::new(vals_float.clone());
+
+// We accumulate the above two rows in two different ways.  First, we 
pass in both as a single batch
+let mut accumulator = 
MaxAccumulator::try_new(::Float32).unwrap();
+accumulator.update_batch(&[vals]).unwrap();
+let single_batch_result = ().unwrap();
+
+// Next we pass the two values in two different batches.
+let vals_a: ArrayRef =
+
Arc::new(Float32Array::from_iter_values([pos_nan].iter().copied()));
+let vals_b: ArrayRef =
+Arc::new(Float32Array::from_iter_values([zero].iter().copied()));
+
+let mut accumulator = 
MaxAccumulator::try_new(::Float32).unwrap();
+accumulator.update_batch(&[vals_a]).unwrap();
+accumulator.update_batch(&[vals_b]).unwrap();
+let split_batch_result = ().unwrap();
+
+assert_eq!(single_batch_result, split_batch_result);

Review Comment:
   Thanks for the suggestions, I have updated the test to check both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Remove expr_fn::sum and replace them with function stub [datafusion]

[via GitHub]

jayzhan211 commented on PR #10816:
URL: https://github.com/apache/datafusion/pull/10816#issuecomment-2154828340

   Thanks @alamb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] MINIFICPP-2394 fix LogAttribute AttributesToLog and AttributesToIgnor… [nifi-minifi-cpp]

[via GitHub]

szaszm commented on code in PR #1810:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1810#discussion_r1631192143


##
extensions/standard-processors/processors/LogAttribute.cpp:
##
@@ -48,98 +49,93 @@ void LogAttribute::onSchedule(core::ProcessContext& 
context, core::ProcessSessio
 
   context.getProperty(MaxPayloadLineLength, max_line_length_);
   logger_->log_debug("Maximum Payload Line Length: {}", max_line_length_);
-}
-// OnTrigger method, implemented by NiFi LogAttribute
-void LogAttribute::onTrigger(core::ProcessContext& context, 
core::ProcessSession& session) {
-  logger_->log_trace("enter log attribute, attempting to retrieve {} flow 
files", flowfiles_to_log_);
-  std::string dashLine = "--";
-  LogAttrLevel level = LogAttrLevelInfo;
-  bool logPayload = false;
 
-  uint64_t i = 0;
-  const auto max = flowfiles_to_log_ == 0 ? UINT64_MAX : flowfiles_to_log_;
-  for (; i < max; ++i) {
-std::shared_ptr flow = session.get();
+  if (auto attributes_to_log_str = context.getProperty(AttributesToLog); 
attributes_to_log_str && !attributes_to_log_str->empty()) {
+if (auto attrs_to_log_vec = utils::string::split(*attributes_to_log_str, 
","); !attrs_to_log_vec.empty())
+  
attributes_to_log_.emplace(std::make_move_iterator(attrs_to_log_vec.begin()), 
std::make_move_iterator(attrs_to_log_vec.end()));
+  }
 
-if (!flow) {
-  break;
-}
+  if (auto attributes_to_ignore_str = context.getProperty(AttributesToIgnore); 
attributes_to_ignore_str && !attributes_to_ignore_str->empty()) {
+if (auto attrs_to_ignore_vec = 
utils::string::split(*attributes_to_ignore_str, ","); 
!attrs_to_ignore_vec.empty())
+  
attributes_to_ignore_.emplace(std::make_move_iterator(attrs_to_ignore_vec.begin()),
 std::make_move_iterator(attrs_to_ignore_vec.end()));
+  }
 
-std::string value;
-if (context.getProperty(LogLevel, value)) {
-  logLevelStringToEnum(value, level);
-}
-if (context.getProperty(LogPrefix, value)) {
-  dashLine = "-" + value + "-";
+  if (auto log_level_str = context.getProperty(LogLevel)) {
+if (auto result = 
magic_enum::enum_cast(*log_level_str)) {
+  log_level_ = *result;
+} else if (*log_level_str == "error") {  // TODO(MINIFICPP-2294) this 
could be avoided if config files were properly migrated

Review Comment:
   Can we change the log level name to "error" instead, without breaking stuff? 
full words > half word here IMO
   Of course that would leave "warning" with the opposite issue, so we'll need 
flow migration if we were to change both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] [Feature] Websocket Support For Triple Protocol [dubbo]

[via GitHub]

oxsean commented on issue #14298:
URL: https://github.com/apache/dubbo/issues/14298#issuecomment-2154828335

   If you are interested in this, please leave a message to participate. 
However, implementing a new communication layer is quite challenging, so it is 
best if you have extensive experience with Netty 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Re: [PR] MINIFICPP-2394 fix LogAttribute AttributesToLog and AttributesToIgnor… [nifi-minifi-cpp]

[via GitHub]

szaszm commented on code in PR #1810:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1810#discussion_r1631192143


##
extensions/standard-processors/processors/LogAttribute.cpp:
##
@@ -48,98 +49,93 @@ void LogAttribute::onSchedule(core::ProcessContext& 
context, core::ProcessSessio
 
   context.getProperty(MaxPayloadLineLength, max_line_length_);
   logger_->log_debug("Maximum Payload Line Length: {}", max_line_length_);
-}
-// OnTrigger method, implemented by NiFi LogAttribute
-void LogAttribute::onTrigger(core::ProcessContext& context, 
core::ProcessSession& session) {
-  logger_->log_trace("enter log attribute, attempting to retrieve {} flow 
files", flowfiles_to_log_);
-  std::string dashLine = "--";
-  LogAttrLevel level = LogAttrLevelInfo;
-  bool logPayload = false;
 
-  uint64_t i = 0;
-  const auto max = flowfiles_to_log_ == 0 ? UINT64_MAX : flowfiles_to_log_;
-  for (; i < max; ++i) {
-std::shared_ptr flow = session.get();
+  if (auto attributes_to_log_str = context.getProperty(AttributesToLog); 
attributes_to_log_str && !attributes_to_log_str->empty()) {
+if (auto attrs_to_log_vec = utils::string::split(*attributes_to_log_str, 
","); !attrs_to_log_vec.empty())
+  
attributes_to_log_.emplace(std::make_move_iterator(attrs_to_log_vec.begin()), 
std::make_move_iterator(attrs_to_log_vec.end()));
+  }
 
-if (!flow) {
-  break;
-}
+  if (auto attributes_to_ignore_str = context.getProperty(AttributesToIgnore); 
attributes_to_ignore_str && !attributes_to_ignore_str->empty()) {
+if (auto attrs_to_ignore_vec = 
utils::string::split(*attributes_to_ignore_str, ","); 
!attrs_to_ignore_vec.empty())
+  
attributes_to_ignore_.emplace(std::make_move_iterator(attrs_to_ignore_vec.begin()),
 std::make_move_iterator(attrs_to_ignore_vec.end()));
+  }
 
-std::string value;
-if (context.getProperty(LogLevel, value)) {
-  logLevelStringToEnum(value, level);
-}
-if (context.getProperty(LogPrefix, value)) {
-  dashLine = "-" + value + "-";
+  if (auto log_level_str = context.getProperty(LogLevel)) {
+if (auto result = 
magic_enum::enum_cast(*log_level_str)) {
+  log_level_ = *result;
+} else if (*log_level_str == "error") {  // TODO(MINIFICPP-2294) this 
could be avoided if config files were properly migrated

Review Comment:
   Can we change the log level name to "error" instead, without breaking stuff? 
full words > half word here IMO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [HUDI-6798] Add record merging mode and implement event-time ordering in the new file group reader [hudi]

[via GitHub]

hudi-bot commented on PR #9894:
URL: https://github.com/apache/hudi/pull/9894#issuecomment-2154824717

   
   ## CI report:
   
   * 3e8bdc41e97141b94a9f60a3450f41ad342fa45e Azure: 
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24271)
 
   
   
   Bot commands
 @hudi-bot supports the following commands:
   
- `@hudi-bot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] [Feature] Websocket Support For Triple Protocol [dubbo]

[via GitHub]

oxsean opened a new issue, #14298:
URL: https://github.com/apache/dubbo/issues/14298

   ### Pre-check
   
   - [X] I am sure that all the content I provide is in English.
   
   
   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no 
similar feature requirement.
   
   
   ### Apache Dubbo Component
   
   Java SDK (apache/dubbo)
   
   ### Descriptions
   
   The Triple protocol is based on HTTP/2 and implements bidirectional 
communication using streams. WebSocket's long connection and event features are 
very suitable for RPC scenarios, so we can consider using WebSocket as the 
communication layer for Triple, giving users more options.
   
   In terms of specific implementation, we do not want to change the existing 
Triple protocol but rather adapt the Triple frame model to WebSocket frames. 
This can be done by referencing the approach used in HTTP/3.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a pull request to fix on your own?
   
   - [ ] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Re: [I] Tracking issues of OpenDAL 0.47.0 Release [opendal]

[via GitHub]

tisonkun commented on issue #4640:
URL: https://github.com/apache/opendal/issues/4640#issuecomment-2154822847

   Vote started at 
https://lists.apache.org/thread/hkmqym3xb5bvcv5lq4z7qb39g4q694bw


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] build(deps): update Arrow/Parquet to `52.0`, object-store to `0.10` [datafusion]

[via GitHub]

waynexia commented on PR #10765:
URL: https://github.com/apache/datafusion/pull/10765#issuecomment-2154822425

   Thanks for reviewing!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

[PR] Use certificate-generator for gRPC integration tests [camel-quarkus]

[via GitHub]

jamesnetherton opened a new pull request, #6167:
URL: https://github.com/apache/camel-quarkus/pull/6167

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] sched/signal: reclaim sigaction [nuttx]

[via GitHub]

xiaoxiang781216 commented on PR #12406:
URL: https://github.com/apache/nuttx/pull/12406#issuecomment-2154821240

   > @xiaoxiang781216, sorry for my late response as I didn't see inline 
comments from `gh` command line.
   > 
   > would you teach a use case where `static-plus-dynamic` approach is 
improper but `never return` approach does a better job?
   
   If the system hit a peak value, it may likely hit again in the future. So, 
it may fine to not return the memory to heap.
   
   > I don't quite understand why we need `never return` designin upstream as 
it gives user apps chances to exhaust the system. If a system wants to avoid 
frequent small sized alloc/free operations from heap, pre-allocation shall help.
   
   but you mayn't know how much memory need be preserved in all case. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] build(deps): update arrow-flight requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] commented on PR #10822:
URL: https://github.com/apache/datafusion/pull/10822#issuecomment-2154819969

   Looks like arrow-flight is up-to-date now, so this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update parquet requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] commented on PR #10825:
URL: https://github.com/apache/datafusion/pull/10825#issuecomment-2154819773

   Looks like parquet is up-to-date now, so this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update parquet requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] closed pull request #10825: build(deps): update parquet 
requirement from 51.0.0 to 52.0.0
URL: https://github.com/apache/datafusion/pull/10825


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update arrow-ipc requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] closed pull request #10823: build(deps): update arrow-ipc 
requirement from 51.0.0 to 52.0.0
URL: https://github.com/apache/datafusion/pull/10823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update arrow-ipc requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] commented on PR #10823:
URL: https://github.com/apache/datafusion/pull/10823#issuecomment-2154819724

   Looks like arrow-ipc is up-to-date now, so this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update arrow-buffer requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] commented on PR #10819:
URL: https://github.com/apache/datafusion/pull/10819#issuecomment-2154819599

   Looks like arrow-buffer is up-to-date now, so this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update arrow-schema requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] closed pull request #10820: build(deps): update arrow-schema 
requirement from 51.0.0 to 52.0.0
URL: https://github.com/apache/datafusion/pull/10820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update arrow-buffer requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] closed pull request #10819: build(deps): update arrow-buffer 
requirement from 51.0.0 to 52.0.0
URL: https://github.com/apache/datafusion/pull/10819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] HADOOP-19114. Upgrade to commons-compress 1.26.1 due to CVEs. (#6636) [hadoop]

[via GitHub]

steveloughran commented on PR #6867:
URL: https://github.com/apache/hadoop/pull/6867#issuecomment-2154818661

   done. FWIW I'm thinking we should push out a 3.3.9 release this summer. 
shall we include this here? doing a full update of those dependencies we can 
upgrade seems wise


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Bump github/codeql-action from 3.25.7 to 3.25.8 [commons-csv]

[via GitHub]

garydgregory merged PR #434:
URL: https://github.com/apache/commons-csv/pull/434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] build(deps): update arrow requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] commented on PR #10821:
URL: https://github.com/apache/datafusion/pull/10821#issuecomment-2154819810

   Looks like arrow is up-to-date now, so this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update arrow requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] closed pull request #10821: build(deps): update arrow 
requirement from 51.0.0 to 52.0.0
URL: https://github.com/apache/datafusion/pull/10821


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update arrow-ord requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] commented on PR #10824:
URL: https://github.com/apache/datafusion/pull/10824#issuecomment-2154819972

   Looks like arrow-ord is up-to-date now, so this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update arrow-flight requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] closed pull request #10822: build(deps): update arrow-flight 
requirement from 51.0.0 to 52.0.0
URL: https://github.com/apache/datafusion/pull/10822


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update arrow-ord requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] closed pull request #10824: build(deps): update arrow-ord 
requirement from 51.0.0 to 52.0.0
URL: https://github.com/apache/datafusion/pull/10824


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Making several configuration ehtods for TestSupport public [camel]

[via GitHub]

JiriOndrusek commented on PR #14421:
URL: https://github.com/apache/camel/pull/14421#issuecomment-2154817513

   @orpiske Pr with changes I need to make cq test support work (using 
AbsractTestSupport). You can see changes in CQ here 
https://github.com/apache/camel-quarkus/commit/dde5815903ef5b3cf327a48721c9b763629a63d9#diff-bc7b68c36f2fcb6de406002f6960cb730abc59ca4d99a439bf1e8f3761972f13


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [bugfix](iceberg)Fix the datafile path error issue [doris]

[via GitHub]

github-actions[bot] commented on PR #35957:
URL: https://github.com/apache/doris/pull/35957#issuecomment-2154817763

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] build(deps): update arrow-schema requirement from 51.0.0 to 52.0.0 [datafusion]

[via GitHub]

dependabot[bot] commented on PR #10820:
URL: https://github.com/apache/datafusion/pull/10820#issuecomment-2154819697

   Looks like arrow-schema is up-to-date now, so this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] [bugfix](iceberg)Fix the datafile path error issue [doris]

[via GitHub]

github-actions[bot] commented on PR #35957:
URL: https://github.com/apache/doris/pull/35957#issuecomment-2154817827

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] build(deps): update Arrow/Parquet to `52.0`, object-store to `0.10` [datafusion]

[via GitHub]

andygrove commented on code in PR #10765:
URL: https://github.com/apache/datafusion/pull/10765#discussion_r1631186375


##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -1545,8 +1545,13 @@ mod tests {
 input_schema,
 )?);
 
-let result =
-common::collect(merged_aggregate.execute(0, 
task_ctx.clone())?).await?;
+// enlarge memory limit in spill mode
+let task_ctx = if spill {
+new_spill_ctx(2, 2600)

Review Comment:
   I hadn't realized that these literal values were just in tests ... thanks 
for the explanation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] build(deps): update Arrow/Parquet to `52.0`, object-store to `0.10` [datafusion]

[via GitHub]

andygrove merged PR #10765:
URL: https://github.com/apache/datafusion/pull/10765


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] GH-41910: [Python] Add support for Pyodide [arrow]

[via GitHub]

joemarshall commented on code in PR #37822:
URL: https://github.com/apache/arrow/pull/37822#discussion_r1631186815


##
docker-compose.yml:
##
@@ -679,6 +680,45 @@ services:
   UBUNTU:
 command: *cpp-command
 
+  ubuntu-cpp-emscripten-python:
+# Usage:
+#   docker-compose build ubuntu-cpp-emscripten-python
+#   docker-compose run --rm ubuntu-cpp-emscripten-python
+# Parameters:
+#   ARCH: amd64, arm64v8, ...
+#   UBUNTU: 22.04
+image: ${REPO}:${ARCH}-ubuntu-22.04-cpp-emscripten
+build:
+  context: .
+  dockerfile: ci/docker/ubuntu-22.04-cpp-emscripten.dockerfile

Review Comment:
   okay, done the conda way



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [fix](multi-catalog)the classpath of custom lib should put back of fe jars [doris]

[via GitHub]

morningman merged PR #35986:
URL: https://github.com/apache/doris/pull/35986


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [I] celery_executor got an unexpected keyword argument 'remove_running' [airflow]

[via GitHub]

potiuk commented on issue #40097:
URL: https://github.com/apache/airflow/issues/40097#issuecomment-2154816673

   Yep.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] HADOOP-19114. Upgrade to commons-compress 1.26.1 due to CVEs. (#6636) [hadoop]

[via GitHub]

steveloughran merged PR #6867:
URL: https://github.com/apache/hadoop/pull/6867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Making several configuration ehtods for TestSupport public [camel]

[via GitHub]

github-actions[bot] commented on PR #14421:
URL: https://github.com/apache/camel/pull/14421#issuecomment-2154816129

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions 
to run
   
   * You can use the command `/component-test (camel-)component-name1 
(camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and 
`test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache 
Camel committers](https://camel.apache.org/community/team/#committers) have 
access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before 
sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] OutOfMemoryException because WatchManager isn't garbage collected (logging-log4j2)

[via GitHub]

ppkarwasz commented on issue #2640:
URL: 
https://github.com/apache/logging-log4j2/issues/2640#issuecomment-2154817253

   This is related to #2255: if hundreds of logger contexts are created, but 
they are not stopped, the application can easily run out of memory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Making several configuration ehtods for TestSupport public [camel]

[via GitHub]

JiriOndrusek opened a new pull request, #14421:
URL: https://github.com/apache/camel/pull/14421

   Follows https://issues.apache.org/jira/browse/CAMEL-20843
   
   I tried to use the `AbstractTestSupport` in CQ project. I found that I was 
missing access to several configuration methods. This PR adds `public` to all 
of them.
   
   
   # Description
   
   
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (note that 
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   
   
   - [ ] I have run `mvn clean install -DskipTests` locally and I have 
committed all auto-generated changes
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [bugfix](paimon)paimon's field length judgment error for 2.1 [doris]

[via GitHub]

morningman merged PR #36049:
URL: https://github.com/apache/doris/pull/36049


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [bugfix](iceberg)Fixed missing type of iceberg table for timetravel for 2.1 [doris]

[via GitHub]

morningman merged PR #36048:
URL: https://github.com/apache/doris/pull/36048


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] [fix](shuffle) fix tablets num calculation in shuffle condition [doris]

[via GitHub]

dataroaring commented on PR #36050:
URL: https://github.com/apache/doris/pull/36050#issuecomment-2154811720

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] Use ibm-semeru-runtimes:open-8u412-b08-jdk-focal (vulnerability fixes). [openwhisk-runtime-java]

[via GitHub]

Luke-Roy-IBM merged PR #163:
URL: https://github.com/apache/openwhisk-runtime-java/pull/163


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [branch-2.1](testcase) fix nereids check on test_mask_function [doris]

[via GitHub]

morningman merged PR #36052:
URL: https://github.com/apache/doris/pull/36052


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] Fix openai 1.32 breaking openai tests [airflow]

[via GitHub]

potiuk commented on PR #40110:
URL: https://github.com/apache/airflow/pull/40110#issuecomment-2154810092

   It turns out we need to add a bit more limits to google and facebook 
provider to make sure the lower-direct limits work (otherwise it attempts to 
build old versions of libraries that fail).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] runs comprehensiveIT w/ FlakyFate and fixes found bug [accumulo]

[via GitHub]

dlmarion commented on code in PR #4646:
URL: https://github.com/apache/accumulo/pull/4646#discussion_r1631177799


##
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/MoveExportedFiles.java:
##
@@ -69,24 +70,27 @@ public Repo call(FateId fateId, Manager manager) 
throws Exception {
 
   Function fileStatusName = fstat -> 
fstat.getPath().getName();
 
-  Set importing = Arrays.stream(exportedFiles).map(fileStatusName)
-  .map(fileNameMappings::get).collect(Collectors.toSet());
+  Set importing =

Review Comment:
   We are already pushing a bunch of things into the Manager, we should 
probably be thinking about memory usage and performance. Each of these stream 
operations is likely creating at least one object which contributes to it being 
slower than it non-streaming version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Fix spelling [openoffice]

[via GitHub]

jbampton opened a new pull request, #216:
URL: https://github.com/apache/openoffice/pull/216

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Re: [PR] api,server: purge expunged resources [cloudstack]

[via GitHub]

blueorangutan commented on PR #8999:
URL: https://github.com/apache/cloudstack/pull/8999#issuecomment-2154813835

   @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] feature: webhooks [cloudstack]

[via GitHub]

blueorangutan commented on PR #8674:
URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2154813754

   @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [fix](Nereids) not do distinct when aggregate with distinct project [doris]

[via GitHub]

morningman commented on PR #36057:
URL: https://github.com/apache/doris/pull/36057#issuecomment-2154807908

   Please check agg_with_distinct_project in p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] feature: webhooks [cloudstack]

[via GitHub]

shwstppr commented on PR #8674:
URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2154811198

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] api,server: purge expunged resources [cloudstack]

[via GitHub]

shwstppr commented on PR #8999:
URL: https://github.com/apache/cloudstack/pull/8999#issuecomment-2154810901

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] SLING-12351 - Create a default implementation for generating the analyser-metadata extension [sling-org-apache-sling-feature-analyser]

[via GitHub]

sonarcloud[bot] commented on PR #46:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/46#issuecomment-2154809596

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=46)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=46=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=46=WONTFIX)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-analyser=46=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [90.5% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=46=new_coverage=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=46=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser=46)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] Schedular going down for 1-2 minute on every 10 minute as increase completed pods in EKS [airflow]

[via GitHub]

ephraimbuddy commented on issue #22612:
URL: https://github.com/apache/airflow/issues/22612#issuecomment-2154809346

   > > @dviru , why would you set the pods not to be deleted? This leads to OOM 
because the pods occupy some space. Just trying to understand your needs and 
see if we should also have another config to check maximum number of completed 
pods that should be allowed to be in the deployment
   > 
   > @ephraimbuddy Some time I want pod should be exist to check the pod logs. 
But I am not seeing this issue in. 2.7.3 even though we have 6000-7000 
completed pods in cluster.
   
   This problem can be solved by using remote logging. It's not right to keep 
7000 completed pods in your cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [fix](mtmv)fix mtmv show partition error when base table dropped (#35… [doris]

[via GitHub]

morningman merged PR #36051:
URL: https://github.com/apache/doris/pull/36051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] feature: webhooks [cloudstack]

[via GitHub]

blueorangutan commented on PR #8674:
URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2154804856

   Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

[via GitHub]

blueorangutan commented on PR #8418:
URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-2154804857

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Rename uniform assignor's internal builders [kafka]

[via GitHub]

chia7712 commented on code in PR #16233:
URL: https://github.com/apache/kafka/pull/16233#discussion_r1631152083


##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogenousAssignmentBuilder.java:
##
@@ -48,7 +48,7 @@
  * The assignment builder prioritizes the properties in the following order:
  *  Balance > Stickiness.
  */
-public class OptimizedUniformAssignmentBuilder {
+public class UniformHomogenousAssignmentBuilder {

Review Comment:
   Could we align the word: `homogenous` or `homogeneous`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [enhancement](Nereids) support 4 phases distinct aggregate with full distribution [doris]

[via GitHub]

morningman merged PR #36016:
URL: https://github.com/apache/doris/pull/36016


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[PR] SLING-12351 - Create a default implementation for generating the analyser-metadata extension [sling-org-apache-sling-feature-analyser]

[via GitHub]

rombert opened a new pull request, #46:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/46

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] Rendered Template Fields missing for some tasks [airflow]

[via GitHub]

raphaelauv opened a new issue, #40118:
URL: https://github.com/apache/airflow/issues/40118

   ### Apache Airflow version
   
   2.9.1
   
   ### If "Other Airflow 2 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   for the exact same task , in success 
   
   for 2 different dag run one have the rendered value store in DB
   
   
![a](https://github.com/apache/airflow/assets/10202690/86fbc0a6-94d0-41f2-aa31-3d8e56aa25a2)
   
   
   and for another nothing and the error in the webserver
   
   
![b](https://github.com/apache/airflow/assets/10202690/19ed5ad7-5854-4a2c-ab63-b3cec6028343)
   
   
   
   ### What you think should happen instead?
   
   _No response_
   
   ### How to reproduce
   
   I didn't saw any difference in the logs , audit log ..
   
   ### Operating System
   
   ubuntu
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Official Apache Airflow Helm Chart
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

[via GitHub]

romani commented on code in PR #141:
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1631174243


##
src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java:
##
@@ -26,22 +26,24 @@
 import java.io.OutputStream;
 import java.nio.file.Path;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 
+import 
com.puppycrawl.tools.checkstyle.AbstractAutomaticBean.OutputStreamOptions;

Review Comment:
   @michael-o , please confirm that you can use 
`OutputStreamOptions.valueOf(outputStreamOptions.name())` workaround.
   if you do not want to take this breaking changes, you can update to 10.9.2, 
but you update is big bump, better to migrate off some deprecations by API. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve](routine-load) optimize routine load job auto resume policy [doris]

[via GitHub]

doris-robot commented on PR #35266:
URL: https://github.com/apache/doris/pull/35266#issuecomment-2154799591

   
   
   ClickBench: Total hot run time: 30.66 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0e639e78d9d94ea8fd8a1245c84717525e87e5fd, 
data reload: false
   
   query1   0.040.030.04
   query2   0.080.030.04
   query3   0.240.040.05
   query4   1.670.070.07
   query5   0.500.490.49
   query6   1.120.720.72
   query7   0.020.010.01
   query8   0.040.040.04
   query9   0.540.480.48
   query10  0.540.550.54
   query11  0.160.120.12
   query12  0.140.120.12
   query13  0.600.590.61
   query14  0.800.790.78
   query15  0.830.820.82
   query16  0.340.370.37
   query17  0.981.030.95
   query18  0.210.250.22
   query19  1.771.701.67
   query20  0.010.010.01
   query21  15.40   0.660.65
   query22  4.457.302.08
   query23  18.22   1.441.27
   query24  2.100.210.22
   query25  0.150.090.09
   query26  0.260.180.17
   query27  0.090.090.09
   query28  13.23   1.021.00
   query29  12.63   3.293.24
   query30  0.270.060.06
   query31  2.860.400.38
   query32  3.270.470.48
   query33  2.922.902.94
   query34  17.18   4.424.40
   query35  4.494.474.47
   query36  0.660.460.48
   query37  0.180.150.15
   query38  0.150.150.15
   query39  0.040.040.03
   query40  0.170.160.15
   query41  0.100.050.05
   query42  0.060.050.05
   query43  0.040.040.05
   Total cold run time: 109.55 s
   Total hot run time: 30.66 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [PR] MINOR: Add fast_commit to ext4 tuning docs [kafka]

[via GitHub]

moscicky commented on PR #15496:
URL: https://github.com/apache/kafka/pull/15496#issuecomment-2154797258

   @mimaison perhaps you could take a look and review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve](routine-load) optimize routine load job auto resume policy [doris]

[via GitHub]

github-actions[bot] commented on PR #35266:
URL: https://github.com/apache/doris/pull/35266#issuecomment-2154795966

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Re: [I] [Question] gremlin-groovy is not an available GremlinScriptEngine [incubator-hugegraph]

[via GitHub]

dosubot[bot] commented on issue #2558:
URL: 
https://github.com/apache/incubator-hugegraph/issues/2558#issuecomment-2154795821

   
   To resolve the `java.lang.AssertionError` indicating that 'gremlin-groovy is 
not an available GremlinScriptEngine' when running `GremlinApiTests` on 
HugeGraph, follow these steps:
   
   1. **Ensure Dependencies**: Add the `gremlin-groovy` dependency to your 
`pom.xml` if you are using Maven:
   
   ```xml
   
   org.apache.tinkerpop
   gremlin-groovy
   3.4.10 
   
   ```
   
   2. **Check Configuration**: Verify that the `gremlin-groovy` script engine 
is correctly configured in your HugeGraph server configuration. Ensure that the 
`gremlin-groovy` script engine is listed in the `scriptEngines` configuration 
in `gremlin-server.yaml`:
   
   ```yaml
   scriptEngines: {
 gremlin-groovy: {
   plugins: {
 org.apache.hugegraph.plugin.HugeGraphGremlinPlugin: {},
 
org.apache.tinkerpop.gremlin.server.jsr223.GremlinServerGremlinPlugin: {},
 org.apache.tinkerpop.gremlin.jsr223.ImportGremlinPlugin: {
   classImports: [
 java.lang.Math,
 org.apache.hugegraph.backend.id.IdGenerator,
 org.apache.hugegraph.type.define.Directions,
 org.apache.hugegraph.type.define.NodeRole,
 
org.apache.hugegraph.traversal.algorithm.CollectionPathsTraverser,
 org.apache.hugegraph.traversal.algorithm.CountTraverser,
 
org.apache.hugegraph.traversal.algorithm.CustomizedCrosspointsTraverser,
 
org.apache.hugegraph.traversal.algorithm.CustomizePathsTraverser,
 
org.apache.hugegraph.traversal.algorithm.FusiformSimilarityTraverser,
 org.apache.hugegraph.traversal.algorithm.HugeTraverser,
 
org.apache.hugegraph.traversal.algorithm.JaccardSimilarTraverser,
 org.apache.hugegraph.traversal.algorithm.KneighborTraverser,
 org.apache.hugegraph.traversal.algorithm.KoutTraverser,
 
org.apache.hugegraph.traversal.algorithm.MultiNodeShortestPathTraverser,
 org.apache.hugegraph.traversal.algorithm.NeighborRankTraverser,
 org.apache.hugegraph.traversal.algorithm.PathsTraverser,
 org.apache.hugegraph.traversal.algorithm.PersonalRankTraverser,
 org.apache.hugegraph.traversal.algorithm.SameNeighborTraverser,
 org.apache.hugegraph.traversal.algorithm.ShortestPathTraverser,
 
org.apache.hugegraph.traversal.algorithm.SingleSourceShortestPathTraverser,
 org.apache.hugegraph.traversal.algorithm.SubGraphTraverser,
 
org.apache.hugegraph.traversal.algorithm.TemplatePathsTraverser,
 org.apache.hugegraph.traversal.algorithm.steps.EdgeStep,
 org.apache.hugegraph.traversal.algorithm.steps.RepeatEdgeStep,
 
org.apache.hugegraph.traversal.algorithm.steps.WeightedEdgeStep,
 org.apache.hugegraph.traversal.optimize.Text,
 org.apache.hugegraph.traversal.optimize.TraversalUtil,
 org.apache.hugegraph.util.DateUtil
   ],
   methodImports: [java.lang.Math#*]
 },
 org.apache.tinkerpop.gremlin.jsr223.ScriptFileGremlinPlugin: {
   files: [scripts/empty-sample.groovy]
 }
   }
 }
   }
   ```
   
   3. **Initialize Script Engine**: Ensure that the script engine is 
initialized properly in your test setup. You might need to explicitly 
initialize the `gremlin-groovy` script engine before running the tests:
   
   ```java
   import 
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine;
   import javax.script.ScriptEngineManager;
   
   public class GremlinApiTest extends BaseApiTest {
   
   static {
   // Initialize the GremlinGroovyScriptEngine
   ScriptEngineManager manager = new ScriptEngineManager();
   manager.registerEngineName("gremlin-groovy", new 
GremlinGroovyScriptEngine());
   }
   
   // Your test methods
   }
   ```
   
   4. **Set Language in GremlinRequest**: Ensure that your `GremlinRequest` 
class in `GremlinAPI` is correctly setting the language to `gremlin-groovy`:
   
   ```java
   public static class GremlinRequest implements Checkable {
   
   @JsonProperty
   private String gremlin;
   @JsonProperty
   private Map bindings = new HashMap<>();
   @JsonProperty
   private String language = "gremlin-groovy";
   @JsonProperty
   private Map aliases = new HashMap<>();
   
   // Other methods...
   }
   ```
   
   By ensuring that the `gremlin-groovy` dependency is included, the script 
engine is 

Re: [PR] [Metal] Enable Debug Label [tvm]

[via GitHub]

tqchen merged PR #17059:
URL: https://github.com/apache/tvm/pull/17059


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [WebGPU] Translate `int8x4` into `u32` [tvm]

[via GitHub]

tqchen commented on PR #17071:
URL: https://github.com/apache/tvm/pull/17071#issuecomment-2154794794

   thank you @Jiawei-Shao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-22296 Rename cluster init options in CLI [ignite-3]

[via GitHub]

PakhomovAlexander merged PR #3891:
URL: https://github.com/apache/ignite-3/pull/3891


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]

[via GitHub]

cchristofr commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-2154794553

   Hi
   A PR is in progress for this.
   See https://github.com/apache/superset/pull/24263
   
   Christophe
   
   Le ven. 7 juin 2024, 14:33, Bara Diaw ***@***.***> a écrit :
   
   > Hello, I've been using superset for 3 months. I want to change the
   > language to french. I added the D3_TIME_FORMAT with my local configuration
   > for superset_config.py but it still doesn't work. Could you help me again.
   > Capture.d.ecran.2024-06-07.122437.png (view on web)
   > 

   >
   > —
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you are subscribed to this thread.Message
   > ID: ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] [WebGPU] Translate `int8x4` into `u32` [tvm]

[via GitHub]

tqchen merged PR #17071:
URL: https://github.com/apache/tvm/pull/17071


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

[via GitHub]

ChengJie1053 closed pull request #3404: [cdc][mysql]Mysql supports modify 
column schema changes
URL: https://github.com/apache/flink-cdc/pull/3404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [cdc][mysql]Mysql supports modify column schema changes [flink-cdc]

[via GitHub]

ChengJie1053 commented on PR #3404:
URL: https://github.com/apache/flink-cdc/pull/3404#issuecomment-2154793728

   Ok, I didn't know that this requirement had been completed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Pipe: Upgraded pipe docs from V1.3.1 to V1.3.3 [iotdb-docs]

[via GitHub]

Caideyipi opened a new pull request, #244:
URL: https://github.com/apache/iotdb-docs/pull/244

   As the title said.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] [Feature] HTTP/3 Support For Triple Protocol In Native [dubbo]

[via GitHub]

oxsean opened a new issue, #14297:
URL: https://github.com/apache/dubbo/issues/14297

   ### Pre-check
   
   - [X] I am sure that all the content I provide is in English.
   
   
   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no 
similar feature requirement.
   
   
   ### Apache Dubbo Component
   
   Java SDK (apache/dubbo)
   
   ### Descriptions
   
   We already have an initial version of HTTP/3. Since the HTTP/3 protocol uses 
JNI, we need to verify if it can work properly in native
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a pull request to fix on your own?
   
   - [ ] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Re: [PR] [WIP][SQL] UTF8 string validation [spark]

[via GitHub]

uros-db commented on code in PR #46845:
URL: https://github.com/apache/spark/pull/46845#discussion_r1631168863


##
sql/core/src/test/resources/sql-tests/inputs/string-functions.sql:
##
@@ -276,3 +276,16 @@ select luhn_check(6017);
 select luhn_check(6018);
 select luhn_check(123.456);
 
+--utf8 string validation
+select is_valid_utf8('');
+select is_valid_utf8('abc');
+select is_valid_utf8(x'80');
+select make_valid_utf8('');
+select make_valid_utf8('abc');
+select make_valid_utf8(x'80');
+select validate_utf8('');
+select validate_utf8('abc');
+select validate_utf8(x'80');
+select try_validate_utf8('');
+select try_validate_utf8('abc');
+select try_validate_utf8(x'80');

Review Comment:
   we have unit tests that cover both interepreted and codegen paths in 
StringExpressionsSuite
   
   these are just e2e sql tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Re: [PR] blog(kaoto): Kaoto 2.0 GA Release [camel-website]

[via GitHub]

apupier commented on code in PR #1190:
URL: https://github.com/apache/camel-website/pull/1190#discussion_r1631167600


##
content/blog/2024/01/kaoto-release-2.0.0/index.md:
##
@@ -0,0 +1,109 @@
+---
+title: "Kaoto v2.0 release"
+date: 2024-06-06
+draft: false
+authors: [lordrip]
+categories: ["Releases", "Tooling", "Kaoto"]
+preview: "Kaoto 2.0 has been released"
+---
+
+
+  
+
+
+After previously releasing 3 technical previews, we are thrilled to finally 
announce the release of Kaoto 2.0, marking the first big release after the 
project aligned to be much closer to Apache Camel.
+
+## What is Kaoto?
+
+Kaoto, short for Kamel Orchestration Tool, is a low-code and no-code 
integration designer that allows users to create and edit integrations based on 
Apache Camel. It is extendable, flexible, and adaptable to various use cases, 
making it a versatile tool for integration projects. You can work both visually 
and also directly access the source code giving you a full round-trip editing 
experience.
+
+## Kaoto in Action
+{{< youtube id="S1WlAMos_64" class="video" >}}
+
+## Where can I get Kaoto?
+
+Our main environment is currently [Visual Studio 
Code](https://code.visualstudio.com/). That means Kaoto has created an 
extension for VS Code, which you can easily install from the VS Code 
marketplace. While you can go for simply installing [the Kaoto 
extension](https://marketplace.visualstudio.com/items?itemName=redhat.vscode-kaoto)
 we still suggest to install [the Extension Pack for Apache 
Camel](https://marketplace.visualstudio.com/items?itemName=redhat.apache-camel-extension-pack)
 which not only comes with Kaoto but also installs additional useful extensions 
like the textual debugger, source code assistance and a couple of other useful 
extensions which makes working with Camel integrations easier. There is also 
[the Camel CLI](https://camel.apache.org/manual/camel-jbang.html) using JBang 
and we strongly recommend installing that as well as it will allow you to 
quickly run your integrations while you are working on it, giving you quick 
results. You want to know more about that? P
 lease read our more comprehensive installation guide.
+
+
+  
+
+
+## Create Routes easily
+
+VS Code provides you with commands to easily create Camel routes, Kamelets, 
Pipes and others. You can filter for these commands when you type “Camel:”, 
which then will show the Camel related commands only. When using these 
commands, we do already provide you with a template to easily get started with 
prototyping. You can configure the steps of the integration by clicking and 
selecting them, which will open up a configuration side panel you can use for 
your changes.

Review Comment:
   ```suggestion
   VS Code Extension pack for Camel provides you with commands to easily create 
Camel routes, Kamelets, Pipes and others. You can filter for these commands 
when you type “Camel:”, which then will show the Camel related commands only. 
When using these commands, we do already provide you with a template to easily 
get started with prototyping. You can configure the steps of the integration by 
clicking and selecting them, which will open up a configuration side panel you 
can use for your changes.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [improve](routine-load) optimize routine load job auto resume policy [doris]

[via GitHub]

doris-robot commented on PR #35266:
URL: https://github.com/apache/doris/pull/35266#issuecomment-2154790328

   
   
   TPC-DS: Total hot run time: 173546 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0e639e78d9d94ea8fd8a1245c84717525e87e5fd, 
data reload: false
   
   query1   927 374 375 374
   query2   6443259723512351
   query3   6626207 205 205
   query4   21038   17832   17421   17421
   query5   3601480 466 466
   query6   250 167 162 162
   query7   4587295 287 287
   query8   321 303 292 292
   query9   8489239923872387
   query10  585 294 289 289
   query11  10607   994010016   9940
   query12  124 90  91  90
   query13  1644379 366 366
   query14  9753784273717371
   query15  241 195 190 190
   query16  7744288 264 264
   query17  1838559 510 510
   query18  1946279 268 268
   query19  189 154 158 154
   query20  90  82  84  82
   query21  205 129 130 129
   query22  4215412140104010
   query23  33712   33527   33458   33458
   query24  11025   292329382923
   query25  622 373 365 365
   query26  1249158 165 158
   query27  3078332 327 327
   query28  7743210520792079
   query29  909 650 596 596
   query30  263 157 159 157
   query31  971 767 773 767
   query32  93  52  55  52
   query33  736 304 276 276
   query34  1010488 494 488
   query35  754 644 624 624
   query36  1147978 964 964
   query37  161 74  72  72
   query38  2972279528242795
   query39  907 863 873 863
   query40  224 126 125 125
   query41  53  52  71  52
   query42  120 108 102 102
   query43  570 514 565 514
   query44  1249726 741 726
   query45  201 160 164 160
   query46  1100714 702 702
   query47  1858175717501750
   query48  373 296 292 292
   query49  845 415 430 415
   query50  778 390 398 390
   query51  6791668167436681
   query52  110 91  92  91
   query53  364 292 295 292
   query54  871 443 439 439
   query55  73  75  73  73
   query56  291 258 270 258
   query57  1108106610471047
   query58  262 249 243 243
   query59  3415332130473047
   query60  301 266 296 266
   query61  123 86  83  83
   query62  621 419 448 419
   query63  316 297 297 297
   query64  8749219917671767
   query65  3571314530793079
   query66  939 326 340 326
   query67  15200   14971   14809   14809
   query68  4592534 551 534
   query69  667 460 391 391
   query70  1171115210991099
   query71  436 277 276 276
   query72  7048548456085484
   query73  762 321 319 319
   query74  5924541653935393
   query75  3475266927012669
   query76  2886984 892 892
   query77  628 306 290 290
   query78  10218   990397429742
   query79  2136507 518 507
   query80  869 475 461 461
   query81  576 219 219 219
   query82  741 100 102 100
   query83  270 168 171 168
   query84  233 88  87  87
   query85  1622272 283 272
   query86  467 320 279 279
   query87  3258305730213021
   query88  4051239423082308
   query89  487 384 374 374
   query90  1724196 190 190
   query91  124 98  95  95
   query92  60  50  50  50
   query93  2320509 508 508
   query94  1090187 184 184
   query95  407 327 320 320
   query96  594 271 264 264
   query97  3171302130113011
   query98  220 202 201 201
   query99  1300821 826 821
   Total cold run time: 272818 ms
   Total hot run time: 173546 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the 

Re: [PR] [WIP][SQL] UTF8 string validation [spark]

[via GitHub]

uros-db commented on code in PR #46845:
URL: https://github.com/apache/spark/pull/46845#discussion_r1631166863


##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -686,6 +686,205 @@ case class EndsWith(left: Expression, right: Expression) 
extends StringPredicate
 newLeft: Expression, newRight: Expression): EndsWith = copy(left = 
newLeft, right = newRight)
 }
 
+/**
+ * A function that checks if a UTF8 string is valid.
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(str) - Returns true if `str` is a valid UTF-8 sequence, 
otherwise returns false.",
+  arguments = """
+Arguments:
+  * str - a string expression
+  """,
+  examples = """
+Examples:
+  > SELECT _FUNC_(x'61');
+   true
+  > SELECT _FUNC_(x'80');
+   false
+  > SELECT _FUNC_(x'61C262');
+   false
+  """,
+  since = "4.0.0",
+  group = "string_funcs")
+case class IsValidUTF8(srcExpr: Expression) extends UnaryExpression with 
ImplicitCastInputTypes
+  with NullIntolerant {
+
+  override def child: Expression = srcExpr
+  override def inputTypes: Seq[AbstractDataType] = Seq(StringTypeAnyCollation)
+  override def dataType: DataType = BooleanType
+  override def nullable: Boolean = true
+
+  override def nullSafeEval(srcEval: Any): Any = {
+srcEval.asInstanceOf[UTF8String].isValidUTF8
+  }
+
+  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+defineCodeGen(ctx, ev, c => s"${ev.value} = $c.isValidUTF8();")
+  }
+
+  override def prettyName: String = "is_valid_utf8"
+
+  override protected def withNewChildInternal(newChild: Expression): 
IsValidUTF8 = {
+copy(srcExpr = newChild)
+  }
+
+}
+
+/**
+ * A function that converts an invalid UTF8 byte sequences to a valid UTF8 
byte sequence,
+ * according to the UNICODE standard rules (Section 3.9-D86). Valid sequences 
stay unchanged.
+ */
+// scalastyle:off
+@ExpressionDescription(
+  usage = "_FUNC_(str) - Returns the original string if `str` is a valid UTF-8 
sequence, " +
+"otherwise returns a new string whose invalid UTF8 bytes sequences are 
replaced using the " +
+"UNICODE replacement character U+FFFD.",
+  arguments = """
+Arguments:
+  * str - a string expression
+  """,
+  examples = """
+Examples:
+  > SELECT _FUNC_(x'61');
+   a
+  > SELECT _FUNC_(x'80');
+   �
+  > SELECT _FUNC_(x'61C262');
+   a�b
+  """,
+  since = "4.0.0",
+  group = "string_funcs")
+// scalastyle:on
+case class MakeValidUTF8(srcExpr: Expression) extends UnaryExpression with 
ImplicitCastInputTypes
+  with NullIntolerant {
+
+  override def child: Expression = srcExpr
+  override def inputTypes: Seq[AbstractDataType] = Seq(StringTypeAnyCollation)
+  override def dataType: DataType = child.dataType
+  override def nullable: Boolean = true
+
+  override def nullSafeEval(srcEval: Any): Any = {
+srcEval.asInstanceOf[UTF8String].makeValidUTF8
+  }
+
+  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+defineCodeGen(ctx, ev, c => s"${ev.value} = $c.makeValidUTF8();")
+  }
+
+  override def prettyName: String = "make_valid_utf8"
+
+  override protected def withNewChildInternal(newChild: Expression): 
MakeValidUTF8 = {
+copy(srcExpr = newChild)
+  }
+
+}
+
+/**
+ * A function that validates a UTF8 string.
+ */
+// scalastyle:off
+@ExpressionDescription(
+  usage = "_FUNC_(str) - Returns the original string if `str` is a valid UTF-8 
sequence, " +
+"otherwise throws an exception.",
+  arguments = """
+Arguments:
+  * str - a string expression
+  """,
+  examples = """
+Examples:
+  > SELECT _FUNC_(x'61');
+   a
+  """,
+  since = "4.0.0",
+  group = "string_funcs")
+// scalastyle:on
+case class ValidateUTF8(srcExpr: Expression) extends UnaryExpression with 
ImplicitCastInputTypes
+  with NullIntolerant {
+
+  override def child: Expression = srcExpr
+  override def inputTypes: Seq[AbstractDataType] = Seq(StringTypeAnyCollation)
+  override def dataType: DataType = child.dataType
+  override def nullable: Boolean = true
+
+  override def nullSafeEval(srcEval: Any): Any = {
+srcEval.asInstanceOf[UTF8String].validateUTF8
+  }
+
+  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+nullSafeCodeGen(ctx, ev, c =>
+  s"""
+if (!$c.isValidUTF8()) {
+  throw new IllegalArgumentException("Invalid UTF-8 string");
+} else {
+  ${ev.value} = $c;
+}
+  """
+)
+  }
+
+  override def prettyName: String = "validate_utf8"
+
+  override protected def withNewChildInternal(newChild: Expression): 
ValidateUTF8 = {
+copy(srcExpr = newChild)
+  }
+
+}
+
+/**
+ * A function that tries to validate a UTF8 string.

Review Comment:
   modified a bit, although some more info is already found in expression 
description / usage



##

[PR] [bug]fix the monitor status is abnormal [hertzbeat]

[via GitHub]

Yanshuming1 opened a new pull request, #2070:
URL: https://github.com/apache/hertzbeat/pull/2070

   fix the monitor status is abnormal


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@hertzbeat.apache.org
For additional commands, e-mail: notifications-h...@hertzbeat.apache.org

Re: [PR] [WIP][SQL] UTF8 string validation [spark]

[via GitHub]

uros-db commented on code in PR #46845:
URL: https://github.com/apache/spark/pull/46845#discussion_r1631166079


##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -686,6 +686,205 @@ case class EndsWith(left: Expression, right: Expression) 
extends StringPredicate
 newLeft: Expression, newRight: Expression): EndsWith = copy(left = 
newLeft, right = newRight)
 }
 
+/**
+ * A function that checks if a UTF8 string is valid.
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(str) - Returns true if `str` is a valid UTF-8 sequence, 
otherwise returns false.",
+  arguments = """
+Arguments:
+  * str - a string expression
+  """,
+  examples = """
+Examples:
+  > SELECT _FUNC_(x'61');
+   true
+  > SELECT _FUNC_(x'80');
+   false
+  > SELECT _FUNC_(x'61C262');
+   false
+  """,
+  since = "4.0.0",
+  group = "string_funcs")
+case class IsValidUTF8(srcExpr: Expression) extends UnaryExpression with 
ImplicitCastInputTypes
+  with NullIntolerant {
+
+  override def child: Expression = srcExpr
+  override def inputTypes: Seq[AbstractDataType] = Seq(StringTypeAnyCollation)
+  override def dataType: DataType = BooleanType
+  override def nullable: Boolean = true
+
+  override def nullSafeEval(srcEval: Any): Any = {
+srcEval.asInstanceOf[UTF8String].isValidUTF8
+  }
+
+  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+defineCodeGen(ctx, ev, c => s"${ev.value} = $c.isValidUTF8();")
+  }
+
+  override def prettyName: String = "is_valid_utf8"
+
+  override protected def withNewChildInternal(newChild: Expression): 
IsValidUTF8 = {
+copy(srcExpr = newChild)
+  }
+
+}
+
+/**
+ * A function that converts an invalid UTF8 byte sequences to a valid UTF8 
byte sequence,
+ * according to the UNICODE standard rules (Section 3.9-D86). Valid sequences 
stay unchanged.
+ */
+// scalastyle:off
+@ExpressionDescription(
+  usage = "_FUNC_(str) - Returns the original string if `str` is a valid UTF-8 
sequence, " +
+"otherwise returns a new string whose invalid UTF8 bytes sequences are 
replaced using the " +
+"UNICODE replacement character U+FFFD.",
+  arguments = """
+Arguments:
+  * str - a string expression
+  """,
+  examples = """
+Examples:
+  > SELECT _FUNC_(x'61');
+   a
+  > SELECT _FUNC_(x'80');
+   �
+  > SELECT _FUNC_(x'61C262');
+   a�b
+  """,
+  since = "4.0.0",
+  group = "string_funcs")
+// scalastyle:on
+case class MakeValidUTF8(srcExpr: Expression) extends UnaryExpression with 
ImplicitCastInputTypes
+  with NullIntolerant {
+
+  override def child: Expression = srcExpr
+  override def inputTypes: Seq[AbstractDataType] = Seq(StringTypeAnyCollation)
+  override def dataType: DataType = child.dataType
+  override def nullable: Boolean = true
+
+  override def nullSafeEval(srcEval: Any): Any = {
+srcEval.asInstanceOf[UTF8String].makeValidUTF8
+  }
+
+  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+defineCodeGen(ctx, ev, c => s"${ev.value} = $c.makeValidUTF8();")
+  }
+
+  override def prettyName: String = "make_valid_utf8"
+
+  override protected def withNewChildInternal(newChild: Expression): 
MakeValidUTF8 = {
+copy(srcExpr = newChild)
+  }
+
+}
+
+/**
+ * A function that validates a UTF8 string.
+ */
+// scalastyle:off
+@ExpressionDescription(
+  usage = "_FUNC_(str) - Returns the original string if `str` is a valid UTF-8 
sequence, " +
+"otherwise throws an exception.",
+  arguments = """
+Arguments:
+  * str - a string expression
+  """,
+  examples = """
+Examples:
+  > SELECT _FUNC_(x'61');
+   a
+  """,
+  since = "4.0.0",
+  group = "string_funcs")
+// scalastyle:on
+case class ValidateUTF8(srcExpr: Expression) extends UnaryExpression with 
ImplicitCastInputTypes
+  with NullIntolerant {
+
+  override def child: Expression = srcExpr
+  override def inputTypes: Seq[AbstractDataType] = Seq(StringTypeAnyCollation)
+  override def dataType: DataType = child.dataType
+  override def nullable: Boolean = true
+
+  override def nullSafeEval(srcEval: Any): Any = {
+srcEval.asInstanceOf[UTF8String].validateUTF8
+  }
+
+  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+nullSafeCodeGen(ctx, ev, c =>
+  s"""
+if (!$c.isValidUTF8()) {
+  throw new IllegalArgumentException("Invalid UTF-8 string");
+} else {
+  ${ev.value} = $c;
+}
+  """
+)
+  }

Review Comment:
   yup, removing UTF8String.validate and UTF8String.tryValidate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] blog(kaoto): Kaoto 2.0 GA Release [camel-website]

[via GitHub]

apupier commented on code in PR #1190:
URL: https://github.com/apache/camel-website/pull/1190#discussion_r1631165877


##
content/blog/2024/01/kaoto-release-2.0.0/index.md:
##
@@ -0,0 +1,109 @@
+---
+title: "Kaoto v2.0 release"
+date: 2024-06-06

Review Comment:
   reminder to update the date when ready



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] IGNITE-21957 Sql. Extend test coverage for SQL E021-10 (Character string types. Implicit casting among the character string types) [ignite-3]

[via GitHub]

zstan opened a new pull request, #3896:
URL: https://github.com/apache/ignite-3/pull/3896

   Thank you for submitting the pull request.
   
   To streamline the review process of the patch and ensure better code quality
   we ask both an author and a reviewer to verify the following:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. 
Also make sure to complete the following:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT was made, WHY and HOW.  
   \- The pull request title is treated as the final commit message. The 
following pattern must be used: IGNITE- Change summary where  - number 
of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the 
components it is added to.
   - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size 
must be reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer 
documentation is added if needed.
   - [ ] **Tests code quality:** test set covers positive/negative scenarios, 
happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [I] Add ability to receive an iterator over the inputs of a LogicalPlan instead of a Vec. [datafusion]

[via GitHub]

alamb commented on issue #10808:
URL: https://github.com/apache/datafusion/issues/10808#issuecomment-2154787910

   I believe @peter-toth  and @ozankabak  and I discussed this in 
https://github.com/apache/datafusion/pull/10543#discussion_r1614057653
   
   The new reference walking APIs added in 
https://github.com/apache/datafusion/pull/10543 (which I don't think are 
released yet) may also be related -- specifically `TreeNode::visit` can now 
return references that can be kepy of the underlying nodes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] [Feature][Transform-V2 Filter] support exclude columns in the filter transform [seatunnel]

[via GitHub]

hailin0 commented on code in PR #6960:
URL: https://github.com/apache/seatunnel/pull/6960#discussion_r1631165462


##
docs/en/transform-v2/filter.md:
##
@@ -43,6 +48,21 @@ transform {
 }
 ```
 
+Or we can delete the field named `age` by adding a `Filter` Transform with the 
mode field set to `DELETE` like below:
+
+```
+transform {
+  Filter {
+source_table_name = "fake"
+result_table_name = "fake1"
+fields = [age]
+mode = "DELETE"
+  }

Review Comment:
   remove mode field
   
   ```suggestion
 Filter {
   source_table_name = "fake"
   result_table_name = "fake1"
   
  include_fields = [...] // old name fileds
   exclude_fields = [...]
 }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] fix: Extra column in csv(or non-raw csv) get while sending on email [superset]

[via GitHub]

SkinnyPigeon commented on PR #23155:
URL: https://github.com/apache/superset/pull/23155#issuecomment-2154787008

   Hey folks, we have an account manager that has raised this as a concern. Do 
you think that there will be any updates on this going forward?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Re: [PR] [WIP][SQL] UTF8 string validation [spark]

[via GitHub]

uros-db commented on code in PR #46845:
URL: https://github.com/apache/spark/pull/46845#discussion_r1631165016


##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -686,6 +686,205 @@ case class EndsWith(left: Expression, right: Expression) 
extends StringPredicate
 newLeft: Expression, newRight: Expression): EndsWith = copy(left = 
newLeft, right = newRight)
 }
 
+/**
+ * A function that checks if a UTF8 string is valid.
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(str) - Returns true if `str` is a valid UTF-8 sequence, 
otherwise returns false.",
+  arguments = """
+Arguments:
+  * str - a string expression
+  """,
+  examples = """
+Examples:
+  > SELECT _FUNC_(x'61');
+   true
+  > SELECT _FUNC_(x'80');
+   false
+  > SELECT _FUNC_(x'61C262');
+   false
+  """,
+  since = "4.0.0",
+  group = "string_funcs")
+case class IsValidUTF8(srcExpr: Expression) extends UnaryExpression with 
ImplicitCastInputTypes
+  with NullIntolerant {
+
+  override def child: Expression = srcExpr
+  override def inputTypes: Seq[AbstractDataType] = Seq(StringTypeAnyCollation)
+  override def dataType: DataType = BooleanType
+  override def nullable: Boolean = true
+
+  override def nullSafeEval(srcEval: Any): Any = {
+srcEval.asInstanceOf[UTF8String].isValidUTF8
+  }
+
+  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+defineCodeGen(ctx, ev, c => s"${ev.value} = $c.isValidUTF8();")
+  }
+
+  override def prettyName: String = "is_valid_utf8"
+
+  override protected def withNewChildInternal(newChild: Expression): 
IsValidUTF8 = {
+copy(srcExpr = newChild)
+  }
+
+}
+
+/**
+ * A function that converts an invalid UTF8 byte sequences to a valid UTF8 
byte sequence,
+ * according to the UNICODE standard rules (Section 3.9-D86). Valid sequences 
stay unchanged.
+ */
+// scalastyle:off
+@ExpressionDescription(
+  usage = "_FUNC_(str) - Returns the original string if `str` is a valid UTF-8 
sequence, " +
+"otherwise returns a new string whose invalid UTF8 bytes sequences are 
replaced using the " +
+"UNICODE replacement character U+FFFD.",
+  arguments = """
+Arguments:
+  * str - a string expression
+  """,
+  examples = """
+Examples:
+  > SELECT _FUNC_(x'61');
+   a
+  > SELECT _FUNC_(x'80');
+   �
+  > SELECT _FUNC_(x'61C262');
+   a�b
+  """,
+  since = "4.0.0",
+  group = "string_funcs")
+// scalastyle:on
+case class MakeValidUTF8(srcExpr: Expression) extends UnaryExpression with 
ImplicitCastInputTypes
+  with NullIntolerant {
+
+  override def child: Expression = srcExpr
+  override def inputTypes: Seq[AbstractDataType] = Seq(StringTypeAnyCollation)
+  override def dataType: DataType = child.dataType
+  override def nullable: Boolean = true
+
+  override def nullSafeEval(srcEval: Any): Any = {
+srcEval.asInstanceOf[UTF8String].makeValidUTF8
+  }
+
+  override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+defineCodeGen(ctx, ev, c => s"${ev.value} = $c.makeValidUTF8();")
+  }
+
+  override def prettyName: String = "make_valid_utf8"
+
+  override protected def withNewChildInternal(newChild: Expression): 
MakeValidUTF8 = {
+copy(srcExpr = newChild)
+  }
+
+}
+
+/**
+ * A function that validates a UTF8 string.

Review Comment:
   modified a bit, although some more info is already found in expression 
description / usage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org