[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User msc changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from [EMAIL PROTECTED] Mon Jan 8 07:16:31 -0800 2007 --- Hi, this is fixed in the current master (SRC680 m198) . The current master should be available at http://download.openoffice.org/680/index.html I close this issue now. Bye Marc - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User fs changed the following: What|Old value |New value Target milestone|OOo 2.x |OOo 2.2 --- Additional comments from [EMAIL PROTECTED] Mon Dec 11 01:45:31 -0800 2006 --- targeting to 2.2, since the fix is part of a CWS aiming for this release - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Mon Dec 11 03:48:54 -0800 2006 --- Submitted issue 72457 to include support for more character sets in Calc's dBase import/export. This is something which originally slipped my attention, and which normally would belong to this issue here as well. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User msc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Thu Dec 7 01:04:10 -0800 2006 --- verified in CWS dba22ui find more information about this CWS, like when it is available in the master builds, in EIS, the Environment Information System: http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=SRC680%2Fdba22ui - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User fs changed the following: What|Old value |New value Assigned to|va|msc --- Additional comments from [EMAIL PROTECTED] Wed Dec 6 02:52:13 -0800 2006 --- fs-msc: please verify in CWS dba22ui that - dBase database can now use UTF-8 encoding - the pre-shipped bibliography has UTF-8 encoding - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User va changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Tue Dec 5 07:21:42 -0800 2006 --- Set encoding to UTF-8. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Tue Nov 7 03:37:20 -0800 2006 --- *** Issue 24901 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User tv changed the following: What|Old value |New value Assigned to|tv|va --- Additional comments from [EMAIL PROTECTED] Mon Oct 30 04:31:00 -0800 2006 --- TV-VA: Engage! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User fs changed the following: What|Old value |New value Assigned to|fs|tv --- Additional comments from [EMAIL PROTECTED] Wed Oct 25 03:49:55 -0700 2006 --- I checked in the patch in cws dba22ui (in a slightly modified form, with a longer error message, loaded from a localized resource file and not hard-coded in English). However, speaking strictly, this does not address the original supporter's problem: The pre-shipped database still has an encoding ibm850. fs-tv: is it possible to change the encoding of the shipped Bibliography to UTF-8? This would require a change in the biblio.dbf and the biblio.odb. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User fs changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |40027) updated/complete pa | |tch for UTF-8 support in d | |Base files --- Additional comments from [EMAIL PROTECTED] Tue Oct 24 04:53:50 -0700 2006 --- Created an attachment (id=40027) updated/complete patch for UTF-8 support in dBase files - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User fs changed the following: What|Old value |New value Assigned to|jianhuajiao |fs --- Additional comments from [EMAIL PROTECTED] Tue Oct 24 04:59:16 -0700 2006 --- The attached file i62664.diff enables UTF-8 support in dBase files. There's no change of the default field len so far, and no change of the connection's default encoding (which is overridden by the UI, anyway). Also, the biblio.dbf which is shipped with OOo is not changed by this, of course. I suggest to move those items into separate issues. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Mon Sep 4 03:12:54 -0700 2006 --- jianhuajiao-fs. I want. but I can not understand completed/fixed for this issue. could you tell me? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Mon Sep 4 05:20:47 -0700 2006 --- Well, it would be good to have one large attachment showing the *complete* patch. The previous attachments only contain fragments of the patch, and the last thing we agreed upon - checking getLength() - is not attached at all. So, please create a final attachment which incorporates *all* changes, and is ready to be checked in at once. Thanks. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Wed Aug 30 06:45:32 -0700 2006 --- ianhuajiao, do you plan to come up with a completed/fixed patch? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User pjanik changed the following: What|Old value |New value CC|'danohnesorg,fs,jianhuajia|'danohnesorg,fs,jianhuajia |o,pjanik,regina' |o,regina' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Thu Aug 24 06:47:51 -0700 2006 --- Please replace this with a simple check of _rDest.getLength() != It can not handle the CJK charactor correctly. It will get the array's whole length, not the charactor length. But isn't this sufficient? I mean, we want to convert a string with |n| Unicode characters into a byte string, with at most |k| bytes length. Now if after the conversion of the complete Unicode string to a byte string, if this byte string has more that |k| bytes - then it doesn't matter *how much* too long it is. It's irrelevant whether it's only half a CJK character, or 20 Unicode characters - too long is too long. And the consequence from too long is: throw an exception. So, in my opinion, a check of _rDest's length to be *smaller* than |_nToLength| should suffice. Maybe I miss something here, in this case please bare with me :) and elaborate. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Thu Aug 24 11:05:00 -0700 2006 --- So, in my opinion, a check of _rDest's length to be *smaller* than |_nToLength| should suffice. sal_Int32 nLen = convertUnicodeString (_rSource, _rDest, _eEncoding); you are right. the nLen just is _rDest's length. so nLen nToLength is what you said exactly. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User jianhuajiao changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |38714) Update --- Additional comments from [EMAIL PROTECTED] Wed Aug 23 01:52:25 -0700 2006 --- Created an attachment (id=38714) Update - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Wed Aug 23 01:52:57 -0700 2006 --- Jianhuajiao - fs: done - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Wed Aug 23 03:53:31 -0700 2006 --- fs-jianhuajiao: thanks for the update. Unfortunately, there's something left: if ( ::rtl::OUString( (sal_Unicode*)_rDest.getStr() ).getLength() != _rSource.getLength() ) That, sorry, is nonsense. It creates an Unicode string from a byte array which in real represents an encoded 8-bit-string, which will give every possible result, but certainly not the one desired. In particular, this will access unowned memory (and thus potentially crash) if the byte string is not terminated with 2 zeros, but only one, since in this case there is no terminating sal_Unicode in the array. Please replace this with a simple check of _rDest.getLength() != And please do not attach patches which make me think you only compiled, but never actually tried them. Thanks ;) Also, I asked you to remove adjustCharSets completely - at the moment, it's a dead corpse not doing anything useful, so we should get rid of it. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=62664
--- Additional comments from [EMAIL PROTECTED] Wed Aug 23 05:38:48 -0700
2006 ---
jianhuajiao-fs: thanks your check and patience.:)
if ( ::rtl::OUString( (sal_Unicode*)_rDest.getStr() ).getLength() !=
_rSource.getLength() )
It creates an Unicode string from a byte array which
in real represents an encoded 8-bit-string, which will give every possible
result, but certainly not the one desired. In particular, this will access
unowned memory (and thus potentially crash) if the byte string is not
terminated with 2 zeros, but only one, since in this case there is no
terminating sal_Unicode in the array.
yes, it's true.
Please replace this with a simple check of _rDest.getLength() !=
It can not handle the CJK charactor correctly. It will get the array's whole
length, not the charactor length. and I used:
sal_Int32 nLen = convertUnicodeString (_rSource, _rDest, _eEncoding);
if ( nLen _nToLength ) {
to instead of old coding.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Mon Aug 21 23:45:14 -0700 2006 --- confusion: the VARCHAR default value are two: 50 and 254. when you create a new VARCHAR field, the default max lenght is 50. but if you chang the datatype to LONGVARCHAR, and then check back to VARCHAR, the default max lenght is 254. The 50 for a newly created VARCHAR is an arbitrary fixed value. For LONGVARCHAR, the length is fixed to 65535. When then switching back to VARCHAR, the table designer tries to preserve as much of this as possible - which results in 254, since this is the maximum for VARCHAR. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Mon Aug 21 23:47:04 -0700 2006 --- 2. throw an error. That's the way to go. As said above, when doing this, please use an SQL-State of 22001. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Tue Aug 22 01:46:21 -0700 2006 --- Should we update the default VARCHAR length to 100 or so ? I know that will double the size of some DB's - but, well it's better for i18n wrt. UTF-8, and modern machines are 2x faster / bigger than 2 years ago anyway ;-) Wrt. the error - sounds great to me, as long as it just stops the user entering data that is too long, rather than impeeding export (or sim.). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Tue Aug 22 04:34:20 -0700 2006 --- I'm fine with the change to 100 instead of 50 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User jianhuajiao changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |38700) Update for throw an | | exception. --- Additional comments from [EMAIL PROTECTED] Tue Aug 22 05:58:58 -0700 2006 --- Created an attachment (id=38700) Update for throw an exception. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Tue Aug 22 06:43:34 -0700 2006 --- - please remove the unused #include stdio.h and the fprintf - the loop in convertUnicodeStringToLength is unnecessary, and expensive. Simply convert the OUString to an OString, and check the length afterwards. - don't use sprintf (which is prone to buffer overflows and the like), but O[U]String::valueOf - there's a typo in the exception message: It must be length, not lenght - another typo: exceeds instead of exceed - please remove adjustCharSets completely, instead of just commenting out. No need to keep the dead code. - instead of changing m_nTextEncoding in file::OConnection::construct (which is also used for the flat driver), please overwrite the construct method in ODbaseConnection, to minimize possible side effects here - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Mon Aug 21 21:10:03 -0700 2006 --- jianhuajiao - fs: The problem remains: If for a UTF-8 dBase data source, the user enters a too-long string in the UI, then this string is silently truncated. This is not because of encoding, it caused by the Database schema. When you create a database and using VARCHAR as field's datatype, at the same thime, it will set the max lenght of this field. so it cannot accept data that lenght over the max lenght. confusion: the VARCHAR default value are two: 50 and 254. when you create a new VARCHAR field, the default max lenght is 50. but if you chang the datatype to LONGVARCHAR, and then check back to VARCHAR, the default max lenght is 254. This should be easy to fix: Instead of silently ignoring the problem in convertUnicodeStringToLength, throw an error - that's it. convertUnicodeStringToLength solve the exception throwed by convertUnicodeString to get a accepted string. jianhuajiao - fs, mmeeks 1. using mmeeks's patch and popup an dialog to tell the change to user. 2. throw an error. but the current exception info is error for this problem. it will throw an encoding error infomation. We need to create an new brach to throw the truncated error. or the exception should be throw before convertUnicodeStringToLength or convertUnicodeString is called. I think it should be throw in convertUnicodeString function. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Wed Aug 2 01:07:52 -0700 2006 --- Hi, is 2.0.4 still realistic for this? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User fs changed the following: What|Old value |New value Assigned to|dbaneedsconfirm |jianhuajiao --- Additional comments from [EMAIL PROTECTED] Wed Aug 2 03:54:38 -0700 2006 --- given that code freeze is tomorrow, I doubt it - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User pjanik changed the following: What|Old value |New value Target milestone|OOo 2.0.4 |OOo 2.x --- Additional comments from [EMAIL PROTECTED] Wed Aug 2 09:24:34 -0700 2006 --- move target - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User jianhuajiao changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |38017) update the patch t | |o set the default encoding | | as utf8 --- Additional comments from [EMAIL PROTECTED] Tue Jul 25 05:30:02 -0700 2006 --- Created an attachment (id=38017) update the patch to set the default encoding as utf8 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Tue Jul 25 05:33:13 -0700 2006 --- I think that make the default encoding as utf8 will bring down the encoding error. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Tue Jul 25 05:44:41 -0700 2006 --- no, sorry, it doesn't. It doesn't matter whether you switch on the problem via UI, or in the code by default. The problem remains: If for a UTF-8 dBase data source, the user enters a too-long string in the UI, then this string is silently truncated. I continue to think that this is not the best way to handle user input, and so far nobody commented on this or tried to convince me of the opposite :) This should be easy to fix: Instead of silently ignoring the problem in convertUnicodeStringToLength, throw an error - that's it. Other than this: - if ( 0 ) is valid for a proof of concept, but not as a patch which is intended to be checked in - please remove the dead code in this branch. - fprintf is never a good idea, please use OSL_TRACE which has the same signature, and is removed in product builds - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User jianhuajiao changed the following: What|Old value |New value CC|'danohnesorg,fs,pjanik,reg|'danohnesorg,fs,jianhuajia |ina' |o,pjanik,regina' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Wed May 24 04:45:32 -0700 2006 --- And text files don't have any problems with fixed length values, encodings, are easy to transfer and easy to repair in case, that somethink goes wrong. Couldn't agree more - however; (unfortunately) the 'FLAT' database backend has exactly the same problem - it is special cased to not allow UTF-8, and unfortunately is also read-only :-) In some CWS (dba30 IIRC), the UTF-8-restriction for flat files is removed, so you can use UTF-8 for flat files then. However, read-only-ness in fact renders this format useless for a Bibliography database. (Anybody volunteering to implement write access for flat files? :) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 --- Additional comments from [EMAIL PROTECTED] Wed May 24 04:49:48 -0700 2006 --- Michael, I still think throwing an error in case the string doesn't fit is better then silently truncating it. You didn't comment on that, yet, but your patch does the truncation. (In theory, we could issue a warning, but in this case, we'd need to noticably extend our warnings framework in DBA, which is only rudimentary.) What do you think Frank should we do the same thing to the flat backend and remove detailpages.cxx's 'adjustCharSets' altogether ? [ I thought the FLAT backend was read-only hence this would be no problem here, but perhaps I'm confused ;-]. As said, for flat files, the restriction is already removed. [The original reasoning was exactly the length-issue, but it's nonsense to apply this to FLAT, since the issue doesn't really exist there.) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dba-issues] [Issue 62664] Bibliography database has fixed character encoding ibm850
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664 User mmeeks changed the following: What|Old value |New value Assigned to|va|dbaneedsconfirm Component|l10n |Database access Status|STARTED |NEW QA contact|[EMAIL PROTECTED] |[EMAIL PROTECTED] Subcomponent|code |none Version|OOo 2.0 |680m169 --- Additional comments from [EMAIL PROTECTED] Tue May 23 03:26:02 -0700 2006 --- This is at root in the database module IMHO. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
