[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2010-02-05 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Fri Feb  5 14:20:46 + 
2010 ---
Oops. Of course that should be "static method in class GraphicFilter".

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2010-02-05 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Fri Feb  5 13:28:12 + 
2010 ---
Forgot to mention:

svx/impgrf.hxx has been deleted. The GetGrfFilter() was a simple wrapper for
GraphicFilter::GetGraphicFilter() only and the LoadGraphic function now is a
static method in the class GraphicObject.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2010-02-03 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450


User mba changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from m...@openoffice.org Wed Feb  3 15:05:29 + 
2010 ---
As the repository shows: done.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2010-01-18 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450


User mba changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from m...@openoffice.org Mon Jan 18 14:37:17 + 
2010 ---
Finally I moved some more code to svl, unotools, svtools and sfx2 and so got rid
of svx/source/options and svx/source/svxlink.

That's it for now. In further steps we could think about where to put the GUI
code in dialog, stbctrls, tbctrls etc.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2010-01-08 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Fri Jan  8 17:29:05 + 
2010 ---
I decided to keep the items and the editeng code together.

Code is ready, builds, installs and runs on Linux. 

Now Windows.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-14 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Mon Dec 14 18:33:23 + 
2009 ---
Finally I've got the following content for a libediteng:

the whole editeng.lib 
the whole outliner.lib

from svx/source/accessibility:
(in case it makes sense to move that out also, it is not required as no
dependencies exist against this code)
AccessibleComponentBase.obj 
AccessibleContextBase.obj   
AccessibleEditableTextPara.obj  
AccessibleImageBullet.obj   
AccessibleParaManager.obj   
AccessibleSelectionBase.obj 
AccessibleStaticTextBase.obj
AccessibleStringWrap.obj

from svx/source/dialogs:
dialmgr.obj (to be replace by an own resource manager)
dlgutil.obj
impgrf.obj 
splwrap.obj
hangulhanja.obj
svxdlg.obj

from svx/source/items:
writingmodeitem.obj 
frmitems.obj 
paraitem.obj 
textitem.obj 
flditem.obj 
svxfont.obj 
paperinf.obj
itemtype.obj
bulitem.obj 
numitem.obj 
xmlcnitm.obj
charhiddenitem.obj

from svx/source/svdraw:
svdfield.obj

from svx/source/unodraw:
unonrule.obj
unoipset.obj
unofdesc.obj

from svx/source/xml:
xmltxtimp.obj
xmltxtexp.obj   

Some object files contain quite commonly used code (dlgutil.cxx, the items) and
so it makes sense not to place them into the new editeng module, but into 
svtools. 

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-14 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450


User mba changed the following:

What|Old value |New value

Target milestone|---   |OOo 3.3





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-11 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Fri Dec 11 12:32:28 + 
2009 ---
A lot of header cleanup was necessary; we include just too much.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-10 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Thu Dec 10 10:43:55 + 
2009 ---
SfxHelp::OpenHelpAgent allows to pass an SfxFrame* to give a context. At many
places this is just guessed by using SfxViewFrame::Current or so, so there it
doesn't hurt to omit the context (the problem is different: if context is
necessary but the code doesn't have it, this code probably isn't the right place
to execute the call, but that's another story to be told another time).

So for svx/source/editeng/svxacorr.cxx the fix is easy: add a virtual method
Help::StartHelpAgent in vcl and reuse the implementation in sfx2. Thus now all
sfx2 dependencies for libediteng are gone.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-10 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Thu Dec 10 09:23:56 + 
2009 ---
correction: HTMLParser is in svtools, not in svl (parhtml.hxx+cxx)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread thb
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450


User thb changed the following:

What|Old value |New value

  CC|''|'thb'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 17:13:07 + 
2009 ---
Trying to link the resulting library without sfx2 gives the following missing
symbols:

SfxViewFrame::Current, SfxHelp::OpenHelpAgent (svxacorr.cxx)
SfxHTMLParser (eehtml.cxx)
SvxSearchItem (impedit4.cxx)
SfxMedium, SfxObjectShell (frmitems.cxx)

The code in frmitems.cxx is converted to use utl::UcbStreamHelper instead.
SvxSearchItem is moved to svl
SfxHTML is not needed here, SvHTML is enough, with two methods moved from sfx to
svl (Get/SetEncodingByHttpHeader)






-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 16:21:25 + 
2009 ---
The code in svx/source/dialog/impgrf.cxx uses SfxMedium to download a stream. I
replace it by using unotools/ucbstreamhelper.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 16:19:32 + 
2009 ---
Code in both EditEngine/Outliner as well as in svdraw uses a function
CreateGraphicObjectFromURL, so it must be moved somewhere where it is accessible
to all. I made it a static method in class GraphicObject

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 16:18:05 + 
2009 ---
Correction: of course the new function is in unofield.hxx+cxx

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 16:15:16 + 
2009 ---
svx/source/xml/xmltxtexp.cxx uses SvxUnoDrawMSFactory::createTextField, but that
would be a dependency on svdraw. The code in this factory method is completely
unrelated to svdraw, so I moved it to a new function SvxCreateUnoField in
unonrule.hxx+cxx. This new function is now used in
SvxUnoDrawMSFactory::createTextField and xmltextexp.cxx.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 16:11:39 + 
2009 ---
In svx/source/xml/xmltxtexp.cxx code wants to create a numrule. All over the
code this is done by calling SvxCreateNumRule with an SdrModel* or with a NULL
pointer. The latter is used in the code relevant for EditEngine/Outliner,
causing a default rule to be created. So I separated these two implementations
and added a new method SvxCreateNumRule without parameter.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 16:06:17 + 
2009 ---
EditEngine uses some dialogs; when looking for code in svx/source/dialog that is
needed for the EditEngine lib, I discovered that the SvxHyphenWordDialog and the
SvxThesaurusDialog can be moved to cui. I added new abstract dialog interfaces,
factory methods and adjusted the client code. I also removed defines for help
ids and resource ids in svx that now are in cui.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 16:04:07 + 
2009 ---
There is horrible code that detects the "module field unit". It gets an
SfxItemSet* as parameter and retrieves its SID_ATTR_METRIC item. In case no
ItemSet is present (NULL pointer parameter), the "current SfxModule" is queried
and the item is retrieved from it.

I changed the method to get an SfxItemSet& and removed the code dealing with
SfxModule. I added a new method SfxModule::GetModuleFieldUnit() in sfx2 so that
every code that knows the module it is working with can use it directly. Only
code that does not know anything about its content must use
SfxModule::GetActiveModule() and so the same awful hack as now. But in future it
is easy to spot these occurences and fix them by properly handing over context
information to the code. Currently this hack is hidden behind an innocent 
interface.

Fortunately the EditEngine/Outliner code always has an ItemSet, so we get rid of
an sfx2 dependency here.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 15:59:06 + 
2009 ---
SVX has a function GetLanguageString() in dlgutil.hxx. It uses a static instance
of SvtLanguageTable. So it makes more sense to move it into this class.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 14:24:07 + 
2009 ---
svx/source/unodraw/unoprov.cxx is a mix of several implementations; amongst
others it contains a class SvxServiceInfoHelper that is used both in unodraw and
in unoedit, but all the other stuff is used only in unodraw. So I moved this
helper class into its own hxx+cxx so that it can be shared.

Perhaps it makes sense to move that class to another library much lower in the
build hierarchy.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 14:21:11 + 
2009 ---
svx/source/unofield.cxx references a class SdrMeasureField. Unofortunately this
class shares its cxx (not the hxx!) file with the class SdrMeasureObject that is
based on svdraw. SdrMeasureField also contains the TakeRepresentation method
that makes some changes on an SdrMeasureObject. I have split the cxx and moved
the "naughty" method to the other class SdrMeasureObject.

I assume that the dependency of unofield.cxx on SdrMeasurefield could be
resolved somehow, but for the time being I didn't go deeper.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 14:12:59 + 
2009 ---
SvxDummyTextSource in svx/source/unoedit also used the global draw item pool; I
changed it to use the EditEngine item pool.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450


User mba changed the following:

What|Old value |New value

  Status|NEW   |STARTED





--- Additional comments from m...@openoffice.org Wed Dec  9 14:12:09 + 
2009 ---
Another implicit connection of the EditEngine's UNO API and svdraw is that the
SvxOutlinerForwarder implementation has an SdrObject*. But it uses it only at a
single location and only to get some (boolean) information that can be handed
over at construction time anyway. So I changed that also.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-09 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450





--- Additional comments from m...@openoffice.org Wed Dec  9 14:07:21 + 
2009 ---
An EditEngine/Outliner library should contain at least the content of the
current svx/source/editeng and svx/source/outliner folders.

This automatically will also include the XML Im/Export in
svx/source/xml/xmltxtimp.cxx and svx/source/xml/xmltxtexp.cxx, this again will
pull in symbols from svx/source/unoedit and svx/source/unodraw. The latter
definitely contains a lot of stuff that shouldn't be included as it depends on
the svdraw code. So it is clear that as a first step we have to clean up the uno
mess.

An obvious problem is the SvxItemPropertySet implementation. Deep inside it uses
SdrObject::GetGlobalDrawObjectItemPool() and so binds itself to svdraw. If this
implementation shall be shared between EditEngine and svdraw, we must first have
a global item pool for the EditEngine and then initialize each
SvxItemPropertySet with the pool it shall use.

The first is easy as there already is a method to create an item pool for an
EditEngine. We just miss a static instance of it that can be created on demand
(like the global DrawObject item pool). 

Changing interface and implementation of SvxItemPropertySet is simple but needs
some work as it is also used in other modules (forms, reportdesign, sd, sc, sw).

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[framework-issues] [Issue 107450] split EditEngine/Outliner from huge svx library

2009-12-04 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=107450
 Issue #|107450
 Summary|split EditEngine/Outliner from huge svx library
   Component|framework
 Version|1.0.0
Platform|Unknown
 URL|
  OS/Version|All
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|TASK
Priority|P3
Subcomponent|code
 Assigned to|mba
 Reported by|mba





--- Additional comments from m...@openoffice.org Fri Dec  4 16:51:16 + 
2009 ---
EditEngine and Outliner are two parts of svx that basically should not have
dependencies on the largest svx part, the drawing layer code. As they
nevertheless are in the same module, a lot of unnecessary dependencies and
intertwinings have crept in. Removing them should enable us to move EditEngine
and Outliner to an own library and own module.

As it looks, it should also be possible to build this new library without
linking it against sfx2 (as the currently used parts of sfx2 are not genuine
framework/sfx2 code, rather something that could be in svtools or other modules
also), so that this library can be moved downwards in the build system 
hierarchy. 

This move will require some changes in other libraries, including at least sfx2,
vcl, svtools and goodies.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org