[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User mru changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from m...@openoffice.org Thu Jan 13 15:16:30 + 2011 --- Checked in DEV300m96. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value IssuesThisDependsOn| |116055 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User mru changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from m...@openoffice.org Tue Nov 23 16:20:24 + 2010 --- Verified fix in CWS os144. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from m...@openoffice.org Fri Nov 19 16:54:38 + 2010 --- @gang65: in principle i agree with your suggestion, but i think the CWS os144 is already in QA because it's urgent (it's not just this RTF crash, in m93 the DOC/RTF filters are completely disabled due to some merge problem on integration...) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112395
--- Additional comments from gan...@openoffice.org Fri Nov 19 15:21:00
+ 2010 ---
/editeng/source/rtf/svxrtf.cxx
Instead use of:
876 SvxRTFItemStackType* SvxRTFParser::_GetAttrSet( int bCopyAttr )
877 {
878 SvxRTFItemStackType* pAkt = aAttrStack.back();
879 SvxRTFItemStackType* pNew;
880 if( pAkt )
881 pNew = new SvxRTFItemStackType( *pAkt, *pInsPos,
bCopyAttr );
882 else
883 pNew = new SvxRTFItemStackType( *pAttrPool,
aWhichMap.GetData(),
*pInsPos );
We could use just:
876 SvxRTFItemStackType* SvxRTFParser::_GetAttrSet( int bCopyAttr )
877 {
879 SvxRTFItemStackType* pNew;
880 if( !aAttrStack.empty() ) {
+++ SvxRTFItemStackType* pAkt = aAttrStack.back();
881 pNew = new SvxRTFItemStackType( *pAkt, *pInsPos,
bCopyAttr );
882 } else
883 pNew = new SvxRTFItemStackType( *pAttrPool,
aWhichMap.GetData(),
*pInsPos );
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org
-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112395
--- Additional comments from gan...@openoffice.org Fri Nov 19 15:14:26
+ 2010 ---
What do you think about instead using notation (example):
SvxRTFItemStackTypePtr pTmp = aSaveStack.empty() ? 0 : aSaveStack.back();
if( pTmp && pTmp->GetSttNodeIdx() ==
pPam->GetPoint()->nNode.GetIndex() &&
pTmp->GetSttCnt() == nPos )
pTmp->GetAttrSet().ClearItem( RES_CHRATR_ESCAPEMENT );
use following:
if (!aSaveStack.empty())
{
SvxRTFItemStackTypePtr pTmp = aSaveStack.back();
if( pTmp && pTmp->GetSttNodeIdx() ==
pPam->GetPoint()->nNode.GetIndex() &&
pTmp->GetSttCnt() == nPos )
pTmp->GetAttrSet().ClearItem( RES_CHRATR_ESCAPEMENT );
}
I think it is a little more clear
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org
-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112395
--- Additional comments from m...@openoffice.org Fri Nov 19 13:50:07 +
2010 ---
indeed, we overlooked an implementation detail of the old stack:
AE Top() const {\
AE pRet = 0;\
if( SvPtrarr::Count() )\
pRet = GetObject( SvPtrarr::Count()-1 ); \
return pRet;\
}\
if the stack is empty, the Top and Pop methods will return a null pointer.
on an empty STL container, back() will return some uninitialized memory, which
causes the crash.
of course returning a null pointer here is bad design anyway,
because perhaps somebody wants to store an actual null pointer in the stack...
http://hg.services.openoffice.org/cws/os144?cmd=changeset;node=82690329d55e
(btw, wouldn't it have been better to create a new issue for this regression?)
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org
-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User os changed the following: What|Old value |New value Assigned to|gang65|mru --- Additional comments from o...@openoffice.org Fri Nov 19 13:48:16 + 2010 --- Reassinged for verification - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User os changed the following: What|Old value |New value Status|REOPENED |RESOLVED Resolution| |FIXED --- Additional comments from o...@openoffice.org Fri Nov 19 13:25:39 + 2010 --- Fixed in cws os144 in editeng\inc\editeng\svxrtf.hxx editeng\source\rtf\rtfitem.cxx editeng\source\rtf\svxrtf.cxx sw\source\filter\rtf\swparrtf.cxx - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User os changed the following: What|Old value |New value CC|'mav,mba,mst' |'mav,mba,mru,mst' Status|VERIFIED |REOPENED Resolution|FIXED | --- Additional comments from o...@openoffice.org Thu Nov 18 09:45:04 + 2010 --- While reanimating RTF (and doc) export and import I found that this fix broke RTF import. The SvxRTFParser (in editeng/source/rtf/svxrtf.cxx crashes while accessing it's member 'aAttrStack' which is a typedef std::deque< SvxRTFItemStackTypePtr > SvxRTFItemStack; that came with this issue in cws svarray. Reopening this issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User mst changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from m...@openoffice.org Mon Oct 25 11:02:15 + 2010 --- setting this one to verified for CWS svarray. this doesn't mean that all svarrays have been replaced; further work should happen on a new issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from gan...@openoffice.org Wed Oct 20 13:44:01 + 2010 --- set to fixed - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Assigned to|cd|gang65 --- Additional comments from gan...@openoffice.org Wed Oct 20 13:43:25 + 2010 --- Fixed in CWS "svarray": http://hg.services.openoffice.org/cws/svarray - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from gan...@openoffice.org Tue Oct 12 20:46:20 + 2010 --- I commit some new patches http://hg.services.openoffice.org/cws/svarray/rev/df7b4d57529a http://hg.services.openoffice.org/cws/svarray/rev/29a91d60907d http://hg.services.openoffice.org/cws/svarray/rev/ede08423780a I think I also resolved issue with the latest patch: http://www.openoffice.org/issues/show_bug.cgi?id=84159 Please check the solution - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from m...@openoffice.org Wed Oct 6 16:03:03 + 2010 --- everything up to revision 81f829e22ea3 looks good to me. except for this bit here: 7.50 @@ -947,7 +946,8 @@ 7.51 } 7.52 7.53 // remove invalid entries from kashida array 7.54 -aKashida.Remove( nCntKash, aKashida.Count() - nCntKash ); 7.55 +//FIXME Is it correct? 7.56 +aKashida.erase( aKashida.begin() + nCntKash, aKashida.end() - nCntKash ); 7.57 7.58 // 7.59 // TAKE CARE OF WEAK CHARACTERS: WE MUST FIND AN APPROPRIATE the second parameter to Remove is apparently the number of elements to remove. so "Remove ( n , Count() - n )" will remove elements from "n" up to "n + Count() - n", i.e. up to "Count()", i.e. until the end. the second parameter to erase should be just "aKashida.end()". - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Version|DEV300m83 |DEV300m84 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from gan...@openoffice.org Wed Oct 6 07:04:24 + 2010 --- I updated following svarrays: SvShorts, SvXub_StrLens, SvBytes, SvBools. All changes is available at: http://hg.services.openoffice.org/hg/cws/svarray/summary Please check this changes. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from m...@openoffice.org Wed Sep 22 10:37:01 + 2010 --- i've just looked at the new commits and they look good to me. you even answered the obvious question "why is that not a std::stack" with a comment :) oh, and don't worry too much about the german comments; if you know what they mean, you can translate them, if you don't know what they mean, just leave them alone. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from gan...@openoffice.org Wed Sep 22 06:47:47 + 2010 --- Please check the new commits in cws/svarray: http://hg.services.openoffice.org/hg/cws/svarray/rev/8fbef438de59 http://hg.services.openoffice.org/hg/cws/svarray/rev/6b2f8af09ac4 http://hg.services.openoffice.org/hg/cws/svarray/rev/0b7dcacae5bf I need also help with translating comments/messages to English near changed code. I would like translate all German strings which is belong to touched code. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from gan...@openoffice.org Fri Sep 17 17:09:45 + 2010 --- Link to CWS with this changes: http://hg.services.openoffice.org/cws/svarray - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from m...@openoffice.org Fri Jul 30 12:48:32 + 2010 --- not much of an improvement: now the CWS is "failed" because it contains an issue (this one) which is not fixed. really, the by far most frustrating part of CWS handling is EIS... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from m...@openoffice.org Fri Jul 30 12:34:41 + 2010 --- your cws is already created (so you must have done something right), and has a "outgoing" hg repository here (you can look at it with a browser): http://hg.services.openoffice.org/hg/cws/svarray/ basically you just need a HG checkout of this outgoing repository. if you already have a HG checkout of the OOo master, then you can just clone that locally. how to get a HG checkout of OOo DEV300 is described here: http://wiki.services.openoffice.org/wiki/Documentation/Building_Guide/Getting_the_source to clone it (assuming the directory is named DEV300) just do "hg clone DEV300 svarray" once it's done "cd svarray" and create the file ".hg/hgrc" with 2 lines: [paths] default = ssh://h...@hg.services.openoffice.org/cws/svarray this way hg pull/hg push will operate on the outgoing repository for your CWS. please give it another try, and let us know what doesn't work. but i can at least try to mess around in EIS a little, to fill out some fields... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from gan...@openoffice.org Thu Jul 29 15:06:12 + 2010 --- Thanks mst. I'm not experienced in CWS developing. The svarray CWS it is my first try to commit this changes, but without success. I think it will be much faster (and safer) to just create CWS by you Michael? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from m...@openoffice.org Thu Jul 29 11:18:25 + 2010 --- oops, completely forgot about this :) re: PTRARR_DEL: it seems that replacing with shared_ptr is indeed mostly straightforward, except in one case: if Remove() is called on a PTRARR_DEL, then it seems the removed object will NOT be deleted, while removing an object from an STL container would invoke the shared_ptr destructor. (but that case doesn't seem to occur in the current patch.) oh, and the implementation of Replace() also doesn't seem to invoke the destructor, but i'm hoping that Replace() is not used much (and guessing that whenever it's used on a PTRARR_DEL currently it's a memory leak ;) ). so i think the patch is good now, thanks for fixing the problems. you've created a cws "svarray"; please commit your patch there and push. oh, and you should add this issue to the CWS: log into EIS, click on "tasks", and then "add task". if you want the ugly STOP sign on the EIS CWS page (which our tooling people seem to think of as a great motivational tool that really makes a good impression on new developers...) to go away then you need to edit the CWS data in EIS (click on the "DEV300/svarray" link) and set the Release to "OOo 3.4". - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User mba changed the following: What|Old value |New value CC|'mav,mst' |'mav,mba,mst' --- Additional comments from m...@openoffice.org Wed Jul 28 16:43:57 + 2010 --- The final patch still needs a review. I'm especially concerned about the PTRARR_DEL stuff - introduction of shared_ptr and the like is never straightforward. So while I agree with Michael here, we should keep an eye on that. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |70229) SvArray replace pat | |ch (corrected) --- Additional comments from gan...@openoffice.org Fri Jun 25 19:34:44 + 2010 --- Created an attachment (id=70229) SvArray replace patch (corrected) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User cd changed the following: What|Old value |New value CC|'mst' |'mav,mst' Ever confirmed| |1 Status|UNCONFIRMED |NEW Target milestone|OOo 3.3 |OOo 3.4 --- Additional comments from c...@openoffice.org Thu Jun 24 13:17:47 + 2010 --- cd->gang65: Michael already mentioned what should be changed in your patch. I am sorry but it's too late for OOo 3.3. We are now in a show stopper phase. We cannot commit changes which are related to features, code rework or other bigger changes on the code base. I have to set the target to OOo 3.4 which will be the next version. cd: Set mav on CC, confirm issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from m...@openoffice.org Thu Jun 24 09:09:24 + 2010 --- > Where may I find information about the Mercurial Queues (MQ) extension? try Bryan O'Sullivan's book: http://hgbook.red-bean.com/read/managing-change-with-mercurial-queues.html the entire book is online, and it's good. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from gan...@openoffice.org Thu Jun 24 07:11:57 + 2010 --- Where may I find information about the Mercurial Queues (MQ) extension? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Version|DEV300m82 |DEV300m83 --- Additional comments from gan...@openoffice.org Thu Jun 24 07:00:24 + 2010 --- Thank you for comments to this patch. Of course svarray5_good.patch is the latest patch which includes/supercedes all previous patches. I will apply all comments issues to next patch. Is there any chance to commit this patch to the OpenOffice.org mercurial repo? I could stop removing the svarray in this step (I successfully removed SV OBJARR) and wait for commit this patch to OpenOfice.Org After that I will continue work with removing obsolete svArrays. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112395
User mst changed the following:
What|Old value |New value
CC|''|'mst'
--- Additional comments from m...@openoffice.org Wed Jun 23 17:43:39 +
2010 ---
finally some time to look at your work...
i'm looking at: svarray5_good.patch
(i presume it includes/supercedes all previous patches?)
some specific things:
+#ifndef INCLUDED_VECTOR
+#include
+#endif
please don't insert external header guards (the #ifndef/#endif around the
include).
you have probably seen some of these in the existing code base, but nowadays
they are obsolete.
last year or so thb ran a script on the entire code to remove them, but the
script was conservative and didn't remove all of them.
+ for ( USHORT i = 0; i < aPortions.size(); i++ )
(several places)
this is wrong: USHORT is the proper index type for SvArrays (they only hold 2^16
entries), but STL vectors use size_t as the index type, and can hold 2^32 (or
even 2^64, depending on implementation) entries.
you have to replace USHORT with size_t, otherwise this can loop infinitely.
postprocess/checkdeliver/checkdeliver.pl
surely this only got in the patch by accident?
+USHORT GetCount() const{ return aEntries.size(); }
same as above: must be size_t, not USHORT (you may need to investigate where
this is called, and update some more types...)
-* SV_DECL_OBJARR(nm, AE, IS, GS)
-* SV_IMPL_OBJARR( nm, AE )
so you've already eliminated one SvArray type? great!
-SV_DECL_PTRARR_DEL( SfxPoolVersionArr_Impl, SfxPoolVersion_Impl*, 0, 2 )
+typedef std::vector SfxPoolVersionArr_Impl;
i'm not sure what PTRARR_DEL does exactly...
if it does something like call delete on all entries in its destructor, you'll
need to use a vector instead.
please check this.
+typedef std::vector HighlightPortions;
it seems this one is duplicate, both in .hxx and .cxx?
#ifndef _SVSTDARR_ULONGS
#define _SVSTDARR_ULONGS
-#include
#endif
i guess you can remove the #define _SVSTDARR_ULONGS or similar as well, when you
remove the header (these are to select which SvArrays the header should declare,
and is part of the silliness of SvArrays...)
- ASSERT( pColTbl, "Wo ist meine Color-Tabelle?" );
+ ASSERT( pColTbl, "Where's table color?" );
translating german assertions is a good idea, but in this case it probably
should be "color table", not "table color", because it's actually a lookup table
for colors.
so it seems to me you're definitely going in the right direction here.
i just wonder how big your patch will become...
i'm afraid it will soon be so big that nobody wants to look at it :)
maybe it makes sense to split up the changes somehow?
mabe by SvArray type? maybe by code module?
it should be possible to have several small patches because most of the uses of
the SvArrays are independent of each other.
but one patch for each array will result in thousands of patches, that's also
bad.
do you know about the Mercurial Queues (MQ) extension?
makes managing multiple patches easier...
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org
-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |70151) SvArray replace pat | |ch next version --- Additional comments from gan...@openoffice.org Tue Jun 22 17:01:09 + 2010 --- Created an attachment (id=70151) SvArray replace patch next version - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |70065) SvArray replace pat | |ch --- Additional comments from gan...@openoffice.org Thu Jun 17 22:26:18 + 2010 --- Created an attachment (id=70065) SvArray replace patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Target milestone|--- |OOo 3.3 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |70039) Patch which replace | | SvArray of Objects by the | | STL --- Additional comments from gan...@openoffice.org Wed Jun 16 18:05:06 + 2010 --- Created an attachment (id=70039) Patch which replace SvArray of Objects by the STL - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 User gang65 changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |70038) Patch which replace | | SvArray of Objects by the | | STL --- Additional comments from gan...@openoffice.org Wed Jun 16 18:03:02 + 2010 --- Created an attachment (id=70038) Patch which replace SvArray of Objects by the STL - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from gan...@openoffice.org Wed Jun 16 18:02:49 + 2010 --- Created an attachment (id=70037) Patch which replace SvArray of Objects by the STL - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from gan...@openoffice.org Mon Jun 14 21:14:55 + 2010 --- Created an attachment (id=69998) Extended patch to replace svarray. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 --- Additional comments from gan...@openoffice.org Mon Jun 14 17:26:47 + 2010 --- Created an attachment (id=69997) Patch to replace svarray with STL containers in highlight - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 112395] svl: replace svarray with STL containers
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 Issue #|112395 Summary|svl: replace svarray with STL containers Component|framework Version|DEV300m82 Platform|All URL|http://svn.services.openoffice.org/opengrok/xref/DEV30 |0_m82/svl/source/memtools/svarray.cxx OS/Version|All Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P4 Subcomponent|code Assigned to|cd Reported by|gang65 --- Additional comments from gan...@openoffice.org Mon Jun 14 17:18:45 + 2010 --- There are lots of SvArray containers defined in the files: http://svn.services.openoffice.org/opengrok/xref/DEV300_m82/svl/inc/svl/svarray.h xx http://svn.services.openoffice.org/opengrok/xref/DEV300_m82/svl/source/memtools/s varray.cxx these are defined as a bunch of ugly macros, and were designed in the early 90ies when STL did not exist. The svarray must be replaced with STL containers. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
