[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-09-22 Thread dtardon
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208


User dtardon changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from dtar...@openoffice.org Wed Sep 22 08:31:14 
+ 2010 ---
integrated in DEV300_m81

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-05-26 Thread msc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208


User msc changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from m...@openoffice.org Wed May 26 10:49:48 + 
2010 ---
verified in CWS dba33f

find more information about this CWS, like when it is available in the master
builds, in EIS, the Environment Information System:
http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fdba33f

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-04-19 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208


User fs changed the following:

What|Old value |New value

 Assigned to|fs|msc





--- Additional comments from f...@openoffice.org Mon Apr 19 19:29:49 + 
2010 ---
fs-msc: please verify in CWS dba33f

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-04-19 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208





--- Additional comments from f...@openoffice.org Mon Apr 19 19:31:01 + 
2010 ---
fs-msc: how to reproduce in m76:
- open a text document
- add an arbitrary form control
- switch off form design mode
= the said assertion pops up

In the CWS, this assertion is gone.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-04-19 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208


User fs changed the following:

What|Old value |New value

Target milestone|OOo 3.x   |OOo 3.3





--- Additional comments from f...@openoffice.org Mon Apr 19 20:03:02 + 
2010 ---
targeting to 3.3, since the fix is part of a CWS which aims for this release

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-04-17 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208


User fs changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from f...@openoffice.org Sat Apr 17 21:01:49 + 
2010 ---
fix committed to CWS dba33f. Thanks.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-03-23 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208





--- Additional comments from f...@openoffice.org Tue Mar 23 08:34:48 + 
2010 ---
 Having code relying on a fixed order of IDs that are given by #define-s
 is a contradiction

Cannot but agree. Next time I encounter this assertion, I'll happily change the
place where it is raised to simply sort the array, instead of complaining :)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-03-23 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208





--- Additional comments from m...@openoffice.org Tue Mar 23 11:15:33 + 
2010 ---
Basically that's the point. But that's just my personal POV. Maybe instead of
sorting another access would be better, I don't know. Perhaps we should have a
discussion about that?!

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-03-23 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208





--- Additional comments from f...@openoffice.org Tue Mar 23 11:44:30 + 
2010 ---
I don't know enough about the internals of SFX, what those slots maps are used
for, what usage patterns are most frequent, and the like to discuss this in
depth ...

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-03-22 Thread mba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208





--- Additional comments from m...@openoffice.org Mon Mar 22 20:32:07 + 
2010 ---
As I was guilty of breaking this: usually I'm working with nonpro versions,
unfortunately I switched to a pro after the final resync because the Linux
nonpro of the milestone (m69) was broken somehow (smoketest failed on all build
bots). So some changes didn't get the additional testing provided by our
debugging abilities in nonpro build s and I didn't catch that error. Sorry for
that. I promise to go the extra mile next time and rather fix the broken nonpro
version than doing without it.

BTW: having code relying on a fixed order of IDs that are given by #define-s
is a contradiction. I know that this stone old code in sfx2 was written that way
to get the best performance (sorted IDs allow for a binary search), but IMHO we
wouldn't lose a lot of performance by using unsorted arrays. At the end we are
talking about integer arrays with a number of IDs between 5 and 20 or so and the
code is not used for performance critical stuff, only for UI interactions that
will work fast enough even without such peephole optimizations.

BTW II: For the same reasons I consider the API of ItemSets with sorted
WhichRanges as broken by design.

Nevertheless thanks for spotting (and fixing) this problem. Until we haven't
fixed the broken APIs, we still must fix problems like this one by changing code
each time when a #define is changed. 

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-03-18 Thread dtardon
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208
 Issue #|110208
 Summary|svx: [nonproduct] pIds unsorted assertion on start o
|f writer
   Component|Drawing
 Version|DEV300m74
Platform|All
 URL|
  OS/Version|All
  Status|UNCONFIRMED
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|fs
 Reported by|dtardon





--- Additional comments from dtar...@openoffice.org Thu Mar 18 07:57:28 
+ 2010 ---
It's because SID_ATTR_CHAR_OVERLINE was redefined by changeset dd34bf62faf9 (CWS
svxsplit, I suppose). Patch attached.

dtardon-fs: Forms are yours, aren't they?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-03-18 Thread dtardon
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208


User dtardon changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |68410)
fix it






--- Additional comments from dtar...@openoffice.org Thu Mar 18 07:58:22 
+ 2010 ---
Created an attachment (id=68410)
fix it


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[graphics-issues] [Issue 110208] svx: [nonproduct] pIds u nsorted assertion on start of writer

2010-03-18 Thread fs
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110208


User fs changed the following:

What|Old value |New value

  Ever confirmed|  |1

  Status|UNCONFIRMED   |NEW

Target milestone|---   |OOo 3.x





--- Additional comments from f...@openoffice.org Thu Mar 18 08:15:11 + 
2010 ---
Argh. Really, this happens everytime somebody tampers with the slot IDs.
Especially SID_ATTR_CHAR_OVERLINE has been is re-defined the second time now, I
just fixed it a year ago (issue 98350), and now it broke again.

I really wish the people doing those changes would use a non-product version,
and play around a little bit with it ...

Anyway, thanks for the patch, will commit as soon as I have a CWS based on at
least m74.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org
For additional commands, e-mail: issues-h...@graphics.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org