[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 User cd changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from [EMAIL PROTECTED] Thu Mar 13 15:01:22 + 2008 --- cd: Closed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 User jsk changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Wed Dec 19 11:25:42 + 2007 --- Not much i can do here, developer task. Verified. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 User cd changed the following: What|Old value |New value Target milestone|OOo 2.3 |OOo 2.4 --- Additional comments from [EMAIL PROTECTED] Fri Oct 12 06:40:08 + 2007 --- cd: Update target. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 User mmeeks changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Fri Jul 13 17:43:58 + 2007 --- nice; so I'll remove the debug commit this lot to a CWS: I suspect we will accumulate a number of similar toolkit/ fixes. And yes - the patch for review contains the debug to show the property verification :-) Committed to cws awtfixes1 with the relevant fixes. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 User cd changed the following: What|Old value |New value CC|''|'fs' --- Additional comments from [EMAIL PROTECTED] Mon Jun 25 08:03:42 + 2007 --- cd-fs: You are much more familiar with the toolkit code. Could please give your comments to this patch from Michael. From my point of view this patch looks good. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 --- Additional comments from [EMAIL PROTECTED] Mon Jun 25 08:28:28 + 2007 --- fs-mmeeks: architecture-wise, the patch looks okay to me. I especially like the fact :) you did not introduce redundancies in the property lists, but implemented the model property list by using the peer's property list. If it were me to review the patch otherwise, I'd insist on you replacing the fprintfs with OSL_TRACE calls. There ain't no places in the OOo code where we explicitly printf, instead, OSL_TRACE is the choice for console traces. We shouldn't silently change this habit. In particular, release versions of OOo are not expect to trace to the console, so the unconditional printfs should definitely be removed, IMO. For the combo box not being derived from the edit: well this makes sense. Partially, at least. For one, it's consistent with the respective models. And for the models, the approach was probably chosen because a combo box facilitates a specialized edit, but isn't really one itself. Some of the properties which you cite show this - multi line edits don't make much sense for a combo box. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 --- Additional comments from [EMAIL PROTECTED] Mon Jun 25 09:04:12 + 2007 --- cd-fs: Thanks for your comments. You're right that fprintf statements are not acceptable for OpenOffice.org. I wanted to convert them to OSL_TRACE before the patch is integrated. cd-mmeeks: Please don't use fprintf within a patch. There are some macros to support debug output (e.g. OSL_TRACE, OSL_ASSERT, ...). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 User cd changed the following: What|Old value |New value Target milestone|--- |OOo 2.3 --- Additional comments from [EMAIL PROTECTED] Thu Jun 21 10:47:05 + 2007 --- cd: Try to check this patch for OOo 2.3. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78291
Issue #|78291
Summary|awt property introspection ...
Component|gsl
Version|680m211
Platform|All
URL|
OS/Version|Linux
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|code
Assigned to|pl
Reported by|mmeeks
--- Additional comments from [EMAIL PROTECTED] Mon Jun 11 09:03:05 +
2007 ---
So :-) imagine my surprise to discover awt widgets have a property-set like
interface but no XPropertySetInfo to discover what properties they support.
Interestingly, running the first pass of the new code seemed to reveal a number
of missing properties at the unocontrols.cxx level, that should (probably) come
from the underlying inheritance in the awt implementations eg.
It seems that things like UnoControlComboBoxModel are missing some derived
properties: EchoChar (etc.) UnoControlDateFieldModel likewise - is that
deliberate ? [ though they ultimately inherit from bases with these - I had to
cut that chain:
+void VCLXFormattedSpinField::ImplGetPropertyIds(...
+{
+// Interestingly in the UnoControl API this is
+// - not derived from XEdit ultimately, (correct ?) - so cut this here ...
+//VCLXSpinField::ImplGetPropertyIds( rIds );
+VCLXWindow::ImplGetPropertyIds( rIds );
+}
Similarly the ComboBox also seems to be missing a number of VCLXEdit related
properties - is that deliberate ?
layout container - start child 'combobox'
missing property 46 (EchoChar)
missing property 48 (HardLineBreaks)
missing property 12 (HScroll)
missing property 104 (LineEndFormat)
missing property 10 (MultiLine)
missing property 13 (VScroll)
Having said that - running the xmlscript test - which instantiates most (all?)
awt controls - seems to show no other issues: which should allow us to prune the
(larger code-size-wise) ImplRegisterProperty call blocks [ and eliminate the
VERIFY_PROPS blocks ].
So - other questions:
* is it ok to aggregate an XPropertySetInfo interface
+ as you see it has little cost (beyond loosing *pDummy2 -
I assume it is ok to steal that ? ;-)
* would it be better to implement an XPropertySet interface instead ?
presumably there is some rational behind a custom get/setProperty
interface ?
Thanks.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 User mmeeks changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |45796) patch --- Additional comments from [EMAIL PROTECTED] Mon Jun 11 09:03:41 + 2007 --- Created an attachment (id=45796) patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 User pl changed the following: What|Old value |New value Assigned to|pl|cd --- Additional comments from [EMAIL PROTECTED] Mon Jun 11 12:19:26 + 2007 --- pl-cd: sounds reasonable to me, can you please have a look ? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[gsl-issues] [Issue 78291] awt property introspection ...
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=78291 User cd changed the following: What|Old value |New value Status|NEW |STARTED --- Additional comments from [EMAIL PROTECTED] Mon Jun 11 13:25:35 + 2007 --- cd: Thanks for your patch. I will check it as soon as possible. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
