[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[sba]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User sba changed the following:

What|Old value |New value

  CC|'aziem,cedricbosdo,kr,sb' |'aziem,cedricbosdo,kr,sb,s
|  |ba'

 Assigned to|sb|cedricbosdo

  Status|REOPENED  |NEW





--- Additional comments from s...@openoffice.org Fri Sep 17 10:17:03 + 
2010 ---
Correction: Set Target to OOo 3.4
sba -> cedricbosdo: As discussed today in IRC, back to you.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[sba]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User sba changed the following:

What|Old value |New value

  Status|RESOLVED  |REOPENED

  Resolution|FIXED |

Target milestone|OOo 3.3   |OOo 3.4





--- Additional comments from s...@openoffice.org Fri Sep 17 10:10:54 + 
2010 ---
Reopening issue.
According to Release Status Meeting this week (see
http://wiki.services.openoffice.org/wiki/ReleaseStatus_Minutes#2010-09-13)
setting target to OOo 3.3.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[sb]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496





--- Additional comments from s...@openoffice.org Fri Sep 10 11:05:35 + 
2010 ---
Have they?  Funny "start here" and dubious extern "C" are still there, and why
re-include apparently non-needed rtl/allocator.hxx?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[cedricbosdo]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User cedricbosdo changed the following:

What|Old value |New value

 Assigned to|cedricbosdo   |sb





--- Additional comments from cedricbo...@openoffice.org Fri Sep 10 10:32:16 
+ 2010 ---
sb: Those have been fixed in


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[sb]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User sb changed the following:

What|Old value |New value

 Assigned to|sb|cedricbosdo





--- Additional comments from s...@openoffice.org Thu Sep  9 15:36:05 + 
2010 ---
@cedricbosdo: 

- still contains #if 0 and "start here" cruft (see <#desc6>)

- still drops precompiled_sal.hxx (see <#desc6>)

- adds extern "C" at various places for no apparent reason (and this was not in
the originally attached sal-strintern-speed.diff); if functions shall be local
to the compilation unit, mark them "static"

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[cedricbosdo]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User cedricbosdo changed the following:

What|Old value |New value

 Assigned to|mmeeks|sb





--- Additional comments from cedricbo...@openoffice.org Thu Sep  9 14:49:28 
+ 2010 ---
sb: could you verify it in cbosdo06?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[cedricbosdo]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User cedricbosdo changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |69752)
Patch adapted to DE
|  |V300






--- Additional comments from cedricbo...@openoffice.org Tue Jun  1 14:17:21 
+ 2010 ---
Created an attachment (id=69752)
Patch adapted to DEV300


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[cedricbosdo]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User cedricbosdo changed the following:

What|Old value |New value

  CC|'aziem,kr,sb' |'aziem,cedricbosdo,kr,sb'

  Status|NEW   |RESOLVED

  Resolution|  |FIXED

Target milestone|---   |OOo 3.3





--- Additional comments from cedricbo...@openoffice.org Tue Jun  1 14:16:25 
+ 2010 ---
integrating in cbosdo06:
http://hg.services.openoffice.org/cws/cbosdo06/rev/dad2c5cc9342

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[aziem]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User aziem changed the following:

What|Old value |New value

  CC|'kr,sb'   |'aziem,kr,sb'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[mmeeks]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496





--- Additional comments from [EMAIL PROTECTED] Wed Dec  5 16:32:36 + 
2007 ---
Created an attachment (id=50131)
fix previous patch ;-)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[sb]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496





--- Additional comments from [EMAIL PROTECTED] Thu Nov 22 16:19:13 + 
2007 ---
Sorry, I have no CWS open or planned where we could put this into (done with OOo
2.4).  Either find somebody else who has, or create one yourself.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[mmeeks]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496





--- Additional comments from [EMAIL PROTECTED] Thu Nov 22 15:54:02 + 
2007 ---
Stefan - is there any chance we can get this included into some other CWS, to
reduce test-tool, building thrash ?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[sb]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User sb changed the following:

What|Old value |New value

 Assigned to|sb|mmeeks





--- Additional comments from [EMAIL PROTECTED] Mon Jun 25 12:41:23 + 
2007 ---
The review already happened, I would say.  Micheal, feel free to integrate.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[mh]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User mh changed the following:

What|Old value |New value

 Assigned to|mh|sb





--- Additional comments from [EMAIL PROTECTED] Mon Jun 25 12:25:43 + 
2007 ---
reassign for review.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[mmeeks]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496





--- Additional comments from [EMAIL PROTECTED] Fri Jun 15 09:46:27 + 
2007 ---
> If the patch is worthwhile (considering the tradeoff between increased code

Sure - so, in raw %age terms; the hash is around 30% faster; and also somewhat
smaller. Clearly in more 'intern'-heavy code, that should result in >3% wins -
as we use intern more across the code-base, that should work nicely. The code
size increase is 188 lines instead of 84.

>commenting out #include "precompiled_sal.hxx" breaks the Windows build, I think

Good good ;-)

>why leave the old stuff in #if 0?

Makes the patch easy for you to read & on merge should be easy to cut the old
stuff out.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[sb]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496





--- Additional comments from [EMAIL PROTECTED] Fri Jun 15 09:26:27 + 
2007 ---
@mmeeks:

- [std::hash_map, despite the name, is a kind of extension available in STLport,
but not Standard C++]

- If the patch is worthwhile (considering the tradeoff between increased code
complexity/refraining from reuse on the one hand and improved space/time
efficiency on the other hand---don't take me wrong, I'm just stating that here
neutrally):

 - commenting out #include "precompiled_sal.hxx" breaks the Windows build, I 
think

 - why leave the old stuff in #if 0?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[mmeeks]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User mmeeks changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |45956)
updated patch






--- Additional comments from [EMAIL PROTECTED] Fri Jun 15 09:07:58 + 
2007 ---
Created an attachment (id=45956)
updated patch


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[mmeeks]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496





--- Additional comments from [EMAIL PROTECTED] Fri Jun 15 08:23:45 + 
2007 ---
sb: no idea if stl::hash_set suggests a hash or not, a chestnut there ?
sb: the saving is on startup time - during which the intern hash is mostly
populated.
Did I mention it saves 170kb as well ? ;-)
Oh, and now I look, I didn't implement the simple prime table, so I'll do that &
re-measure the performance win.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[sb]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496





--- Additional comments from [EMAIL PROTECTED] Fri Jun 15 07:11:37 + 
2007 ---
@mmeeks:  First of all (apart from the usual nitpicking that the STL hash of
course is not rather inefficient, as there is no such thing as the STL hash): 
*What* takes 56million pseudo-cycles less and thus becomes ~3% faster? --- That
is, is it worth it at all?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[mmeeks]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496


User mmeeks changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |45939)
patch






--- Additional comments from [EMAIL PROTECTED] Thu Jun 14 16:50:16 + 
2007 ---
Created an attachment (id=45939)
patch


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[porting-issues] [Issue 78496] sal-strintern - speedup .. .

[mmeeks]

To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=78496
 Issue #|78496
 Summary|sal-strintern - speedup ...
   Component|porting
 Version|680m211
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|mh
 Reported by|mmeeks





--- Additional comments from [EMAIL PROTECTED] Thu Jun 14 16:48:41 + 
2007 ---
So; the STL hash is rather inefficient. This patch replaces it with a simple C
implementation that saves a total of 56million pseudo-cycles ~3% faster.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]