[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 User cmc changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from c...@openoffice.org Tue Dec 1 12:00:35 + 2009 --- testtools now passes correctly in m66 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 User kendy changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from ke...@openoffice.org Fri Oct 30 10:36:56 + 2009 --- cmc: Ah, great, thanks for the explanation! Verified. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 --- Additional comments from c...@openoffice.org Fri Oct 30 10:22:30 + 2009 --- cmc->sb: "UNO structs map to C++ structs/classes, but also other UNO types like string (rtl::OUString in C++), sequences". Yeah, same logic in one sense given the pass by reference in the UNO ABI. But IIRC those types are sufficiently complex (and/or large) that even if they weren't passed by reference they don't get passed in through registers anyway in the C++ ABI. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 User sb changed the following: What|Old value |New value CC|'kendy,pjanik'|'kendy,pjanik,sb' --- Additional comments from s...@openoffice.org Fri Oct 30 09:29:49 + 2009 --- @cmc: Be aware that not only UNO structs map to C++ structs/classes, but also other UNO types like string (rtl::OUString in C++), sequences (com::sun::star::uno::Sequence<> in C++) etc. However, as UNO [in] parameters they are also all passed as const reference in C++ (if I do not miss anything right now), so the same reasoning as for UNO structs would apply. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98028
--- Additional comments from c...@openoffice.org Fri Oct 30 08:47:07 +
2009 ---
"we are unable to obtain the small structs through registers (I mean, to
reconstruct the original small struct from gpreg and fpreg)."
Here's my thinking: This bit of code would be used for handling passed by value
small structs as "in" arguments to a method. Now the thing is that I believe
that this can't happen in uno because idlc, when given an idl which has a method
that has an "in" struct argument, will always generate c++ code which passes
"in" structs by reference and never by value.
While small struct *return* arguments of course do get returned in registers if
they fit, they never get passed in registers *into* a method.
In that cws's testtools module, have a look at the bridgetest.idl, e.g.
struct SmallStruct
{
hyper a;
hyper b;
};
SmallStruct echoSmallStruct( [in] SmallStruct aStruct );
the c++ api for this is therefore
virtual SmallStruct SAL_CALL echoSmallStruct(const SmallStruct& rStruct);
e.g. passed by reference
the bridgetest in testtools should be run during the build there, and
echoSmallStruct is one of the new tests which should demo it.
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org
-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 --- Additional comments from ke...@openoffice.org Thu Oct 29 21:39:44 + 2009 --- cmc: I would believe that by not having the cpp2uno.cxx part you killed, we are unable to obtain the small structs through registers (I mean, to reconstruct the original small struct from gpreg and fpreg). OTOH, what used to be there couldn't work either, CppArgs[nPos]/pCppStack was filled with a pointer to temporary. I wonder - does it work now by 2 bugs actually eliminating each other, or is it too late, and my brain is already asleep? ;-) I suppose something that passes a small struct from c++ to Java through UNO would answer, but... uno2cpp.cxx and call.s changes look correct to me. Not sure about the abi.cxx change, that was mostly copied from ffi.c so if the change is there too, then I suppose all is fine :-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 User cmc changed the following: What|Old value |New value Assigned to|cmc |kendy --- Additional comments from c...@openoffice.org Tue Oct 27 16:37:20 + 2009 --- Want to give this a sanity test once over look for verification, the tests are now part of the testtools build and would crash with the original bridge, and fly through with the new bridge. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 User cmc changed the following: What|Old value |New value OtherIssuesDependingOnTh| |105680 is| | - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 User cmc changed the following: What|Old value |New value Status|NEW |RESOLVED Issue type|DEFECT|PATCH Resolution| |FIXED Target milestone|--- |OOo 3.3 --- Additional comments from c...@openoffice.org Tue Oct 6 15:13:16 + 2009 --- done in cmcfixes64 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 --- Additional comments from c...@openoffice.org Thu Jan 29 08:43:58 + 2009 --- Yeah, I don't think its critical. If these constructs were common we'd be seeing a lot of crashes on x86_64 so we must be getting lucky and they're uncommon. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 --- Additional comments from ke...@openoffice.org Thu Jan 29 01:48:28 + 2009 --- cmc: Still having this in my queue, but did not look yet, sorry :-( Will do the next week, hopefully it's OK. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 --- Additional comments from c...@openoffice.org Fri Jan 16 15:42:02 + 2009 --- cmc->kendy: Any opinions on this ? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 User cmc changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |59361) a bit rough and rea | |dy, but it should do the r | |ight thing I think --- Additional comments from c...@openoffice.org Tue Jan 13 17:09:36 + 2009 --- Created an attachment (id=59361) a bit rough and ready, but it should do the right thing I think - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 --- Additional comments from c...@openoffice.org Tue Jan 13 16:30:05 + 2009 --- We need to fill in rdx on return of such a struct anyway Also when *passing in* such an entity we always in UNO pass the address of a struct, not the struct itself. So the foo in cpp2uno.cxx for measuring the size of a passed in struct is misguided, as that's for if it was passed by value, which never happens. We still have a bit of a problem wrt xmm0 xmm1 for the case of returning a struct of floats which is passed around either completely in xmm0/xmm1 or split between etc - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 User cmc changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |59358) stage 1 anyway --- Additional comments from c...@openoffice.org Tue Jan 13 16:26:46 + 2009 --- Created an attachment (id=59358) stage 1 anyway - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[porting-issues] [Issue 98028] x86_64 doesn't pass SmallS tructs and AllFloats testcppu tests
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=98028 Issue #|98028 Summary|x86_64 doesn't pass SmallStructs and AllFloats testcpp |u tests Component|porting Version|DEV300m38 Platform|Opteron/x86_64 URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|cmc Reported by|cmc --- Additional comments from c...@openoffice.org Tue Jan 13 13:19:01 + 2009 --- When I did the ia64 port I added some new tests to cppu/test_di.cxx. I see that it turns out that x86_64 fails two of these, the SmallStruct test, and the AllFloats test - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
