[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User oc changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from [EMAIL PROTECTED] Thu May 11 01:15:44 -0700 2006 --- closed because fix available in OpenOffice.org Developer Snapshot Build src680_m167 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User oc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Wed May 3 06:41:19 -0700 2006 --- verified in internal build calc36 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User er changed the following: What|Old value |New value Attachment data| |Created an attachment | |(id=36047) Test cases. --- Additional comments from [EMAIL PROTECTED] Wed Apr 26 04:10:30 -0700 2006 --- Created an attachment (id=36047) Test cases. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User er changed the following: What|Old value |New value Assigned to|er|oc Status|REOPENED |NEW --- Additional comments from [EMAIL PROTECTED] Wed Apr 26 04:13:39 -0700 2006 --- reassign to [EMAIL PROTECTED] - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User er changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Wed Apr 26 04:13:44 -0700 2006 --- reset resolution to FIXED - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User er changed the following: What|Old value |New value Status|RESOLVED |REOPENED Resolution|FIXED | --- Additional comments from [EMAIL PROTECTED] Wed Apr 26 04:13:34 -0700 2006 --- Reassigning to QA. re-open issue and reassign to [EMAIL PROTECTED] - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 --- Additional comments from [EMAIL PROTECTED] Mon Apr 24 04:15:30 -0700 2006 --- As I wrote in my previous comment, I committed the change to sc/source/core/tool/interpr1.cxx 1.37.104.1, so cd sc/source/core/tool cvs diff -pu -r1.37 -r1.37.104.1 interpr1.cxx to obtain the patch. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User er changed the following: What|Old value |New value Status|STARTED |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Fri Apr 21 08:04:41 -0700 2006 --- In CWS calc36 sc/source/core/tool/interpr1.cxx 1.37.104.1 Also added handling of svMatrix cases. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 --- Additional comments from [EMAIL PROTECTED] Fri Apr 21 21:00:01 -0700 2006 --- er, It will be greate if you can attach the final patch here (or the location of where I can find it). I'll be able to know what I missed (and ofcourse learn from it). Thanks, muthusuba - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User er changed the following: What|Old value |New value Issue type|ENHANCEMENT |PATCH Target milestone|OOo Later |OOo 2.0.3 --- Additional comments from [EMAIL PROTECTED] Wed Jan 18 04:18:42 -0800 2006 --- Correct, pCell is not NULL in this case when a single cell is referred, since a dummy note cell exists for broadcasting purposes. Thanks for being patient, I think we got that going now :-) Changing issue type to PATCH and retargeting to OOo2.0.3. Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User muthusuba changed the following: What|Old value |New value Attachment is patch| |Created an attachment | |(id=33305) Up-Updated | |patch --- Additional comments from [EMAIL PROTECTED] Tue Jan 17 09:33:47 -0800 2006 --- Created an attachment (id=33305) Up-Updated patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 --- Additional comments from [EMAIL PROTECTED] Tue Jan 17 09:41:53 -0800 2006 --- When cell is empty pCell-HasValueData and pCell-HasStringData are (both) false. checking pCell == NULL when cell is empty doesn't seem to work. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35483
--- Additional comments from [EMAIL PROTECTED] Mon Jan 16 09:42:59 -0800
2006 ---
Hi Muthu,
You're nearing it ;-) Note that it isn't necessary to implement the
same logic twice for svSingleRef and svDoubleRef, as we have a helper
method PopDoubleRefOrSingleRef() for use in higher level functions. And
while at it, we could already differentiate between string and numeric
values, instead of converting numeric values to string and back. The
resulting path would be something like (untested)
switch (GetStackType())
{
case svDouble:
PushDouble( PopDouble());
return;
break;
case svSingleRef:
case svDoubleRef:
{
ScAddress aAdr;
if (!PopDoubleRefOrSingleRef( aAdr))
return;
ScBaseCell* pCell = GetCell( aAdr);
if (!pCell)
{
PushDouble(0.0);
return;
}
else if (pCell-HasValueData())
{
PushDouble( GetCellValue( aAdr, pCell));
return;
}
GetCellString( aInputString, pCell);
}
break;
default:
aInputString = GetString();
}
Btw, when creating String objects it isn't necessary to assign them
EMPTY_STRING, the default ctor already initializes them as empty.
EMPTY_STRING is a static String object and is used when you want to
avoid the creation of a temporary String object. Btw2, StackVar
stackType is an unused variable.
Eike
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User muthusuba changed the following: What|Old value |New value Attachment is patch| |Created an attachment | |(id=33236) Updated patch. --- Additional comments from [EMAIL PROTECTED] Sun Jan 15 09:49:44 -0800 2006 --- Created an attachment (id=33236) Updated patch. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 --- Additional comments from [EMAIL PROTECTED] Thu Jan 5 07:18:14 -0800 2006 --- Hi Muthu, Thanks for the try, but this is not sufficient. Your patch evaluates any empty string as 0, also empty strings of formula results, e.g. =. Excel evaluates empty strings as #VALUE errors, only real empty cells result in 0. In case of an empty string you'd have to check if it resulted from a cell reference by comparing the remembered GetStackType() with svSingleRef and svDoubleRef. Btw, please always _attach_ diffs instead of placing them in the comment, which changes whitespace and may lead to unintentional line breaks so that the patch doesn't apply anymore. Thanks Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 --- Additional comments from [EMAIL PROTECTED] Mon Dec 19 09:00:32 -0800 2005 --- Patch for it. --- sc/source/core/tool/interpr1.cxx2005-11-13 23:30:11.0 +0530 +++ sc/source/core/tool/interpr1.cxx2005-12-19 22:04:52.0 +0530 @@ -2387,6 +2387,8 @@ void ScInterpreter::ScValue() double fVal; if (pFormatter-IsNumberFormat(aInputString, nFIndex, fVal)) PushDouble(fVal); +else if(aInputString.Len() == 0) +PushDouble(0.0); else SetIllegalArgument(); } - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 35483] Function VALUE() returns error if targeted cell is empty. Excel return s 0 in same case.
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=35483 User er changed the following: What|Old value |New value Status|NEW |STARTED Summary|Function VALUE() returns |Function VALUE() returns |error if targeted cell is |error if targeted cell is |null. Excel returns 0 in |empty. Excel returns 0 in |same case.|same case. --- Additional comments from [EMAIL PROTECTED] Wed Dec 14 17:06:37 -0800 2005 --- Accepted. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
