[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-03-27 Thread amy2008
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User amy2008 changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from amy2...@openoffice.org Fri Mar 27 09:09:40 
+ 2009 ---
Verified in DEV310m7 on Fedora.
Closing.
Li Meiying

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-02-14 Thread mechtilde
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User mechtilde changed the following:

What|Old value |New value

   Status whiteboard|RM-S4 |RM-S4 fwk102





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-02-13 Thread oc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User oc changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from o...@openoffice.org Fri Feb 13 09:01:52 + 
2009 ---
verified in internal build cws_fwk102

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-02-12 Thread mav
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User mav changed the following:

What|Old value |New value

 Assigned to|mav   |oc





--- Additional comments from m...@openoffice.org Thu Feb 12 10:33:03 + 
2009 ---
mav-oc: Please verify the issue.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-02-08 Thread mav
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User mav changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Issue type|DEFECT|PATCH

  Resolution|  |FIXED





--- Additional comments from m...@openoffice.org Mon Feb  9 07:40:53 + 
2009 ---
integrated in cws fwk102

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-02-06 Thread ul
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User ul changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |95768
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-02-05 Thread mh
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User mh changed the following:

What|Old value |New value

   Status whiteboard|  |RM-S4





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-25 Thread mav
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User mav changed the following:

What|Old value |New value

 Assigned to|spreadsheet   |mav

Priority|P3|P2

Target milestone|---   |OOo 3.1





--- Additional comments from m...@openoffice.org Sun Jan 25 23:07:44 + 
2009 ---
Generally the caller should be ready that SfxMedium::GetStorage() deletes the
current stream provided by the SfxMedium. Although it makes probably sense to
add the check for the format in GetStorage() method before creation of temporary
file, since the temporary file should be created only for storage-based
documents in this method.

The patch from npower looks good. From my point of view it is OK that
SfxObjectShell::ImplGetSignatureState() does the check for the format. That
makes the usage simple.

Am I right with my understanding that this is reproducible while loading any
.xls document containing basic macros? If yes, I would say that the target
should be at least 3.1.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-25 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240





--- Additional comments from c...@openoffice.org Sun Jan 25 23:24:44 + 
2009 ---
this is reproducible while loading any.xls document containing basic macros?
yeah, its a fairly gruesome unexpected result. Thanks for caring :-)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-20 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240





--- Additional comments from c...@openoffice.org Tue Jan 20 16:36:32 + 
2009 ---
*** Issue 92666 has been marked as a duplicate of this issue. ***

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-19 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240
 Issue #|98240
 Summary|.xls crash after GetBasic called on Shell
   Component|Spreadsheet
 Version|OOO300m9
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|DEFECT
Priority|P3
Subcomponent|open-import
 Assigned to|spreadsheet
 Reported by|cmc





--- Additional comments from c...@openoffice.org Mon Jan 19 13:16:41 + 
2009 ---
The attached .xls crashes on load for me. Attached is the valgrind trace.

basically we have...

pDocShell-GetBasic();
which triggers a sequence of events which ends with 
SvStream::~SvStream() (stream.cxx:513)
SfxMedium::CloseInStream_Impl() (docfile.cxx:579)
SfxMedium::CreateTempFile() (docfile.cxx:3504)
SfxMedium::GetStorage() (docfile.cxx:1196)
the medium referred to is the same one used as the excel filter RootStorage, so
it gets invalidated if GetBasic is called, so the following
sfx2::LoadOlePropertySet used deleted stuff.

As a hackaround attached is a workaround patch that ensures that GetBasic is
called before getting the RootStorage

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-19 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240





--- Additional comments from c...@openoffice.org Mon Jan 19 13:17:15 + 
2009 ---
Created an attachment (id=59484)
sample excel document


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-19 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240





--- Additional comments from c...@openoffice.org Mon Jan 19 13:17:32 + 
2009 ---
Created an attachment (id=59485)
valgrind log


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-19 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |59486)
quick-and-dirty wor
|  |karound patch






--- Additional comments from c...@openoffice.org Mon Jan 19 13:18:15 + 
2009 ---
Created an attachment (id=59486)
quick-and-dirty workaround patch


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-19 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User cmc changed the following:

What|Old value |New value

  CC|''|'npower'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-19 Thread npower
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240





--- Additional comments from npo...@openoffice.org Mon Jan 19 16:30:17 
+ 2009 ---
hmm this looks familiar, does this really happen in upstream builds ? I saw this
( and fixed it ) in ooo-build and assumed it was due to a combination of
 
a) I changed the order of when basic gets loaded to access things early
b) an upstream change to SfxObjectShell::ImplGetSignatureState which calls
GetStorage() ( which you can see from the trace triggers delete of the stream (
later accessed which causes the core )

anyway here is my alternative patch - ( which prevents
SfxObjectShell::ImplGetSignatureState from doing any nastiness ) really though
SfxObjectShell::ImplGetSignatureState should never get called for an alien
document right? ( but belt and braces prevention here does no harm ) 

which is the right patch?, is either of them correct? the world of the object
shell etc. is a mystery to me, lets hope some wise person will make the right 
choice

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-19 Thread npower
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User npower changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |59494)
alternative patch






--- Additional comments from npo...@openoffice.org Mon Jan 19 16:31:46 
+ 2009 ---
Created an attachment (id=59494)
alternative patch


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 98240] .xls crash after GetBasic called on Shell

2009-01-19 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=98240


User cmc changed the following:

What|Old value |New value

  CC|'npower'  |'mav,npower'





--- Additional comments from c...@openoffice.org Mon Jan 19 16:42:10 + 
2009 ---
no idea either :-) maybe mav might be able to help us to at least know what's
the first thing that's going wrong in this scenario

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org