[sw-issues] [Issue 110771] sw: deferenced pointer an d then checking it for NULL

2010-04-12 Thread mst
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110771


User mst changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |DUPLICATE





--- Additional comments from m...@openoffice.org Mon Apr 12 09:28:08 + 
2010 ---
hi cmc,

i'm afraid you're repeating yourself :)

i've already committed your other, different fix for this problem :)

*** This issue has been marked as a duplicate of 109921 ***

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 110771] sw: deferenced pointer an d then checking it for NULL

2010-04-12 Thread mst
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110771


User mst changed the following:

What|Old value |New value

  Status|RESOLVED  |CLOSED





--- Additional comments from m...@openoffice.org Mon Apr 12 09:32:26 + 
2010 ---
.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 110771] sw: deferenced pointer an d then checking it for NULL

2010-04-10 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110771
 Issue #|110771
 Summary|sw: deferenced pointer and then checking it for NULL
   Component|Word processor
 Version|DEV300m76
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|PATCH
Priority|P3
Subcomponent|code
 Assigned to|ama
 Reported by|cmc





--- Additional comments from c...@openoffice.org Sat Apr 10 19:49:51 + 
2010 ---
in sw/source/core/frmedt/feshview.cxx we have...

SdrObject *pTmpObj = rMrkList.GetMark( i )-GetMarkedSdrObj();
BOOL bForget = pTmpObj-ISA(SwVirtFlyDrawObj);
if( bForget )
{   
  pDView-UnmarkAll();
  if ( pTmpObj )
pDView-MarkObj( pTmpObj, Imp()-GetPageView(), bAddSelect, bEnterGroup );
  else  
pDView-MarkObj( rPt, MINMOVE );

it clearly doesn't make sense to do that if (pTmpObj) seeing as we already
deferenced pTmpObj. So either the else branch can go, or we should be checking
for a null pTmpObj earlier

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 110771] sw: deferenced pointer an d then checking it for NULL

2010-04-10 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110771


User cmc changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |106602
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 110771] sw: deferenced pointer an d then checking it for NULL

2010-04-10 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110771


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |68861)
e.g. like so, if th
|  |e else branch remains






--- Additional comments from c...@openoffice.org Sat Apr 10 19:50:30 + 
2010 ---
Created an attachment (id=68861)
e.g. like so, if the else branch remains


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org