[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text - appr oved

2009-04-27 Thread sba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User sba changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from s...@openoffice.org Mon Apr 27 11:05:08 + 
2009 ---
OK in OOO310_m10. Closed.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text - appr oved

2009-03-04 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from h...@openoffice.org Wed Mar  4 09:36:11 + 
2009 ---
*** Issue 86170 has been marked as a duplicate of this issue. ***

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text - appr oved

2008-04-28 Thread fredrikh
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Mon Apr 28 14:47:02 + 
2008 ---
Automation possible.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text - appr oved

2008-04-28 Thread ul
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User ul changed the following:

What|Old value |New value

 Summary|Vista: Incorrect placing o|Vista: Incorrect placing o
|f Hebrew characters with j|f Hebrew characters with j
|ustified text |ustified text - approved





--- Additional comments from [EMAIL PROTECTED] Mon Apr 28 10:51:28 + 
2008 ---
added "approved" to the title, because it will be easier to work with the 2.4.1 
meta issue 
during release status meetings.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-17 Thread sba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User sba changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from [EMAIL PROTECTED] Thu Apr 17 13:06:53 + 
2008 ---
SBA: Verified in 2.4.1 CWS rtl4vista.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-15 Thread ul
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User ul changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |88258
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-15 Thread sba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User sba changed the following:

What|Old value |New value

Target milestone|OOo 3.0   |OOo 2.4.1





--- Additional comments from [EMAIL PROTECTED] Tue Apr 15 10:43:10 + 
2008 ---
Verified in DEV300_m6 on Windows Vista. Thus OK for OOo 3.0 Beta.

Not setting to verified because fix must be re-verified in 2.4.1 CWS rtl4vista.
Target set to OOo 2.4.1


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-15 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Tue Apr 15 09:19:14 + 
2008 ---
@sba: please verify in CWS rtl4vista too

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-14 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User hdu changed the following:

What|Old value |New value

  Status|REOPENED  |RESOLVED

  Resolution|  |FIXED





--- Additional comments from [EMAIL PROTECTED] Tue Apr 15 06:58:43 + 
2008 ---
Applied the fix into CWS rtl4vista for OOo 2.4.1
Winlayout.cxx's revision 1.108.206.2 was an even match better for OOo 2.4.1. 
Thanks for the feedback!



-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-14 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User hdu changed the following:

What|Old value |New value

  Status|VERIFIED  |REOPENED

  Resolution|FIXED |





--- Additional comments from [EMAIL PROTECTED] Tue Apr 15 06:57:27 + 
2008 ---
Reopening for the backport to 2.4.1

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-14 Thread hennerdrewes
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Mon Apr 14 18:54:42 + 
2008 ---
@hdu: Haven't had time to check with winlayout.cxx DEV300_m6 yet. 

I built OOo 2.4 with winlayout.cxx 1.108.206.2 and have been using that for
quite a while, and that works fine.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-14 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Mon Apr 14 14:11:09 + 
2008 ---
Will do.

@hennerdrewes: Have you had a chance to check these changes in winlayout.cxx 
DEV300_m6? My plan is 
to pull this revision into 2.4.1.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-14 Thread kaplan
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Mon Apr 14 13:42:29 + 
2008 ---
kaplan -> SBA, HDU:

Cool (:

Thanks for the extra effort on this.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-14 Thread sba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Mon Apr 14 13:29:30 + 
2008 ---
SBA-> Kaplan: I just talked to HDU and I got the approval from MH to get this
fixed for 2.4.1. too.
So after re-verification in OOo 3.0 Beta master build, I will set the target
accordingly and reassign this one to HDU.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-13 Thread kaplan
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User kaplan changed the following:

What|Old value |New value

  CC|'ayaniger,fme,hdu,yba,yifa|'ayaniger,fme,hdu,kaplan,y
|t'|ba,yifat'





--- Additional comments from [EMAIL PROTECTED] Sun Apr 13 13:49:47 + 
2008 ---
Any chance to see this fixed also in 2.4.1? (we already have the fix for the
problem, so that should take much time).

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-01 Thread sba
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User sba changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from [EMAIL PROTECTED] Tue Apr  1 11:54:10 + 
2008 ---
Verified in CWS vcl87.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-04-01 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User hdu changed the following:

What|Old value |New value

 Assigned to|hdu   |sba





--- Additional comments from [EMAIL PROTECTED] Tue Apr  1 07:10:41 + 
2008 ---
reassigning for verification

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-03-18 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Tue Mar 18 15:17:24 + 
2008 ---
@sba: please verify in CWS vcl87
Testing hints:
- load the bugdoc on XP and Vista
- check the display, the printout and PDF export on each platform

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-03-05 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User hdu changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from [EMAIL PROTECTED] Wed Mar  5 12:13:36 + 
2008 ---
Now also added the change mentioned above for UniscribeLayout::GetNextGlyphs() 
(winlayout.cxx 1.108.206.2)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-02-18 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Mon Feb 18 14:41:32 + 
2008 ---
Applied the patch to CWS vcl87. Need to adjust UniscribeLayout::GetNextGlyphs() 
to adjust PDF export to 
the changes.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-02-04 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Tue Feb  5 07:58:36 + 
2008 ---
Thanks! This seems to be ready to get into mainline soon...

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-02-03 Thread hennerdrewes
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Sun Feb  3 16:40:49 + 
2008 ---
@hdu: some corrections to my previous patch, now checked on XP and Vista.
The changes are relevant for the kashida issue on older usps.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-02-03 Thread hennerdrewes
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Sun Feb  3 16:26:54 + 
2008 ---
Created an attachment (id=51331)
corrections to patch


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-01-16 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User hdu changed the following:

What|Old value |New value

Target milestone|OOo 2.x   |OOo 3.0





--- Additional comments from [EMAIL PROTECTED] Wed Jan 16 15:27:11 + 
2008 ---
Retargeting to next release after 2.4, which is on its way.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-01-14 Thread hennerdrewes
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Mon Jan 14 13:25:41 + 
2008 ---
As far as I could see new and old USP behave pretty much the same regarding
Arabic. They return different suggestions for uJustification, though.
But I will double check again.

You should respect the minimal kashida width in some respect. Either it should
be done in sw, or compensate in a way, that just minimally disrupts sw's
character placing. Like remove the kashida width (which is small anyway) from
the glyph and add it to the following space. 

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-01-14 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Mon Jan 14 13:01:46 + 
2008 ---
Thanks for checking that it works for Hebrew. To get PDF export right in the 
new scheme of things UniscribeLayout::GetNextGlyphs() needs to adjust the glyph 
positions. I'll do it soon.

The kashida justification in OOo is decided by sw/source/core/text/porlay.cxx. 
Unfortunately this is a 
one way decision which doesn't consult the suggestion by the platform's layout 
engine. Probably the 
inconsistencies are caused by this. VCL overriding SW's placement of kashidas 
would cause many 
problems with cursor movement, background colors, text measurements etc.

Looking back I don't remember the exact details of replacing some 
uJustification values with kashidas 
either :-/ I could find out with a long investigation though. It was probably 
massaged to work with 
several old USP versions. I'd be happy to get rid of this hack entirely for new 
enough USPs and made it 
conditional to bManualCellAlign. Your suggestion to replace just 
SCRIPT_JUSTIFY_NONE sounds good, 
did you try it on both newer and older USP versions?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-01-12 Thread hennerdrewes
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Sat Jan 12 15:19:00 + 
2008 ---
@hdu: After applying your patch, everything seems to be working fine with the
Hebrew output, except for the PDF, as stated before. What solution do you have
in mind for that?

I also tried to have a look at Arabic justification. (Emphasis is on "tried", as
unfortunately I cannot be sure on my findings, as I don't read the language).
But nevertheless, I encountered some phenomena, which were mentioned in some
issues on Arabic text justification.

1. Words seem to break apart. Cause: a glyph cell gets expanded by value less
than the iKashidaWidth value returned by ScriptGetFontProperties. You should
call ScriptGetFontProperties in ApplyDxArray and correct mpJustification Values
if necessary.

2. Kashidas are appended to words, instead of connecting letters within the
words. Cause: The OOo Kashida algorithm decides to expand characters, which
receive a SCRIPT_JUSTIFY_NONE  uJustification Value by ScriptShape. 
I attached a patch, where I replaced the SCRIPT_JUSTIFY_NONE, with
SCRIPT_JUSTIFY_KASHIDA. This fixes the problem. 
But maybe important to note: OOo puts Kashidas at different places than USP. I
don't know how serious that is regarding Arabic typography, but maybe you should
check into that, too.

There was this previous hack replacing uJustification values with 
SCRIPT_JUSTIFY_KASHIDA. Never understood that really, but if it was aimed at
this problem, it should concentrate (or at least include) SCRIPT_JUSTIFY_NONE.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-01-12 Thread hennerdrewes
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Sat Jan 12 14:58:18 + 
2008 ---
Created an attachment (id=50824)
patch changes


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-01-10 Thread hennerdrewes
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976





--- Additional comments from [EMAIL PROTECTED] Thu Jan 10 17:37:23 + 
2008 ---
Just had a quick glance at the patch.

Questions:

1. You haven't related to the problem in PDF export, when using usp's right 
align.

2. Did you verify, exactly which usp version (out of the many) behaves in 
which way? If there is any doubt in that, it would be safer to leave the 
a.fRTL=false hack active, when bManualCellAlign = true. This way you can make 
sure, that right aligning does not happen twice.

I still have some thoughts on possible impact for Arabic justification, but 
I'll have to think about that a little longer...

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 77976] Vista: Incorrect placing o f Hebrew characters with justified text

2008-01-10 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=77976


User hdu changed the following:

What|Old value |New value

 Summary|Incorrect placing of Hebre|Vista: Incorrect placing o
|w characters with justifie|f Hebrew characters with j
|d text|ustified text





--- Additional comments from [EMAIL PROTECTED] Thu Jan 10 17:05:10 + 
2008 ---
Thanks for analyzing the root problem and identifying the USP behaviour change 
as the culprit. The 
analysis made it clear that the "manual glyph alignment" we had to do was a 
workaround for missing 
functionality in older USP versions.

I like the a.fRTL=false hack, because it is minimally invasive against the code 
base. On the other hand 
having to rely on a hack to keep an obsoleted workaround working would probably 
make maintenance in 
the future more difficult. So I've rewritten your patch to enable/disable the 
workaround depending on the 
USP version and get rid of the hack altogether. Please review the patch I 
attached above. Does it still fix all 
the symptoms?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]