[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2009-03-27 Thread amy2008
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User amy2008 changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from amy2...@openoffice.org Fri Mar 27 06:42:40 
+ 2009 ---
In issue 97069, it's about Disable Insert menu entries if cursor is positioned 
in hidden text. So, for reproducing this issue, I have entered some characters 
in Writer and  checked this issue following the steps. Indeed it has been 
verified in DEV310m7.

Closing
Li Meiying

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2009-01-28 Thread mru
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User mru changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from m...@openoffice.org Wed Jan 28 11:42:59 + 
2009 ---
Verified fix in CWS sw31bf02.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2009-01-23 Thread fme
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User fme changed the following:

What|Old value |New value

 Assigned to|fme   |mru





--- Additional comments from f...@openoffice.org Fri Jan 23 12:47:13 + 
2009 ---
Ready for QA.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-12-09 Thread fme
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483





--- Additional comments from [EMAIL PROTECTED] Tue Dec  9 13:52:10 + 
2008 ---
For now I'll take the patch as is. We should still check if we want to disable
more 'Insert' menu entries in case the cursor is located in hidden text. I set
up a follow-up task for this issue: 97069.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-12-09 Thread fme
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User fme changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from [EMAIL PROTECTED] Tue Dec  9 13:54:37 + 
2008 ---
Applied patch to textsh.cxx, cws sw31bf02.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-09-10 Thread fme
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User fme changed the following:

What|Old value |New value

 Assigned to|lijian|fme





--- Additional comments from [EMAIL PROTECTED] Wed Sep 10 07:31:22 + 
2008 ---
fme-lijian: Thank you for your patch. Please find my comments below:

[...] In fact, I think the perfect solution is to make the inserting of the OLE 
objects just like text frames/images even the cursor is in hidden paragraph.
But I think one solution is to avoid the calling of CalcAndSetScale( xObj ) 
and pClient-DoVerb( SVVERB_SHOW ) if the cursor is in hidden paragraph in 
function SwWrtShell::InsertObject in file wrtsh1.cxx. Maybe od could give help 
on this, right ? [...] 

Well, that's the crucial point. I also prefer the perfect solution. But as I
already on 2008-09-01, there's also an infinite loop in crsrsh.cxx in a current
version. So there's more obviously more left to consider than simply avoiding
the crash. Please switch your workspace to a more recent version and you'll see.
And that's the reason why I think we might be better of with the 'simple'
solution, since this issue actually only shows under some pretty rare 
circumstances.

Your patch works fine, I'll have a look if we should also disable some other
(possibly all) items in the text shell. Thank you for your good work.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-09-09 Thread lijian
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483





--- Additional comments from [EMAIL PROTECTED] Tue Sep  9 06:35:37 + 
2008 ---
Created an attachment (id=56340)
patch 2 for this issue


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-09-09 Thread lijian
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User lijian changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|84291 |72764
  is|  |





--- Additional comments from [EMAIL PROTECTED] Tue Sep  9 06:46:14 + 
2008 ---
lijian-fme  od:
Hi frank, I have disabled the insertion of crash-cause objects in the UI if 
the cursor is located in hidden paragraphs with the second patch. Please have 
a look and tell me if there is something incorrect.
I didn't disable text frame/images in this case because I think they will not 
cause crash anyway.
In fact, I think the perfect solution is to make the inserting of the OLE 
objects just like text frames/images even the cursor is in hidden paragraph.
But I think one solution is to avoid the calling of CalcAndSetScale( xObj ) 
and pClient-DoVerb( SVVERB_SHOW ) if the cursor is in hidden paragraph in 
function SwWrtShell::InsertObject in file wrtsh1.cxx. Maybe od could give help 
on this, right ?
Looking forward to your reply. Thank you!

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-09-02 Thread fme
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483





--- Additional comments from [EMAIL PROTECTED] Tue Sep  2 07:07:17 + 
2008 ---
fme-lijian: Anyway: I think we should simply suppress the insertion if the
cursor is currently located in a hidden paragraph. Additionally we can check if
we can disable these functions in the UI in this case.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-09-01 Thread fme
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483





--- Additional comments from [EMAIL PROTECTED] Mon Sep  1 15:26:06 + 
2008 ---
First thing I notice is that there's an infinite loop in crsrsh.cxx (close to
the call of CalcLayout()). Looks like your patches do not address this. I
observed this in DEV300m29. 

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-08-31 Thread lijian
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483





--- Additional comments from [EMAIL PROTECTED] Mon Sep  1 02:51:44 + 
2008 ---
Hi all,
I have some findings on this issue:
An OLE object is a Flyfrm whose pLower is a SwNoTxtFrm.
If the SwFrm the OLE ahchors at is hidden, pLower of FlyFrm
will be deleted. Method SwWrtShell::CalcAndSetScale will 
calculate the rect area of the object and call the method
SwFEShell::FindFlyFrm to get the proper SwFlyFrm. If the SwFrm
anchored is hidden, pLower will be NULL. And function SwFEShell::GetAnyCurRect
will return an not exsited Rect which will cause crash.

I have just got a rough solution with the attached patch, but there are still
some other problems such as undo strings incorrect. But I don't know what 
it should be like when the anchored SwFrm is hidden when inserting an OLE 
object. It seems that OOo has a big defect on this.

Hope someone will have a look at the patch and give some suggestions.

Comments from Lijian.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-08-31 Thread lijian
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483





--- Additional comments from [EMAIL PROTECTED] Mon Sep  1 02:55:28 + 
2008 ---
Created an attachment (id=56127)
patch file


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-08-28 Thread lijian
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User lijian changed the following:

What|Old value |New value

 Assigned to|ama   |lijian





--- Additional comments from [EMAIL PROTECTED] Fri Aug 29 01:42:00 + 
2008 ---
lijian-ama:
I am working on this issue. Assigned to me.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-08-28 Thread lijian
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User lijian changed the following:

What|Old value |New value

  CC|'chengxz,fme,liutao,pj'   |'ama,chengxz,fme,liutao,od
|  |,pj'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-07-31 Thread lijian
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User lijian changed the following:

What|Old value |New value

  CC|'fme' |'chengxz,fme,liutao,pj'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-07-31 Thread lijian
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User lijian changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |84291
  is|  |

Keywords|  |crash





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-07-09 Thread mru
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483


User mru changed the following:

What|Old value |New value

 Assigned to|mru   |ama

Target milestone|---   |OOo 3.1





--- Additional comments from [EMAIL PROTECTED] Wed Jul  9 08:09:39 + 
2008 ---
MRU-AMA: as described, when inserting an OLE into hidden text, OO crashes.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sw-issues] [Issue 91483] Writer crashes when insert ing ole if text is hidden

2008-07-08 Thread lijian
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=91483
 Issue #|91483
 Summary|Writer crashes when inserting ole if text is hidden
   Component|Word processor
 Version|OOo 3.0 Beta
Platform|All
 URL|
  OS/Version|Windows XP
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|DEFECT
Priority|P2
Subcomponent|code
 Assigned to|mru
 Reported by|lijian





--- Additional comments from [EMAIL PROTECTED] Wed Jul  9 02:00:15 + 
2008 ---
Here is the description for a crash bug.
1.New a writer document;
2.Format-Character, and select Font Effects tab page;
3.Check the checkbox Hidden;
4.Insert-Object-OLE Object, and Click OK in the poped up dialog.
Writer crashes.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]