[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 User pjanik changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Sat Apr 15 01:42:58 -0700 2006 --- Verified in 64-05. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 User kendy changed the following: What|Old value |New value Target milestone|--- |OOo 2.0.3 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 User kendy changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Fri Apr 14 06:11:32 -0700 2006 --- Eike, thank you for the review! Changed the names of the methods & committed to CWS sixtyfour05. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 User er changed the following: What|Old value |New value Assigned to|er|kendy --- Additional comments from [EMAIL PROTECTED] Thu Apr 13 13:28:26 -0700 2006 --- Hi Kendy, buildfix-streamdatetime.diff is absolutely fine, that DateTime things always assumed long/ULONG being 32-bit. bigint-datetime.diff code looks ok as it just factors out the duplicated code. I had to lookup though why on earth it even existed.. ok, that's about the Win32 file date, which is based on a 1601-01-01 epoch. I assume that calculating it previously was done correctly. However, to reflect the fact that using these methods for file dates is valid for Win32 timestamps only, I suggest to rename the methods to DateTime::GetWin32FileDateTime() and DateTime::CreateFromWin32FileDateTime() And no, I don't know of a testcase for this other than Matthias already mentioned: lookup where it is used.. which in the case of the PropItem seems to be the Impress PowerPoint export of the document properties CreationDate and PrintDate. The SfxPSDateTimeProperty_Impl seems to handle the same properties for MS storages. So this is a "go ahead" from me. Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 User kendy changed the following: What|Old value |New value Assigned to|kendy |er --- Additional comments from [EMAIL PROTECTED] Mon Apr 10 11:18:27 -0700 2006 --- er: Reassigning to you so that it stays on your radar ;-) Please assign back after review, I'll improve the patches, or commit them to a sixtyfourXY CWS if OK. Thank you! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 --- Additional comments from [EMAIL PROTECTED] Mon Apr 3 05:43:59 -0700 2006 --- Hi Kendy, I was on vacation and am now wading through the pile of things to work off.. I'll need some more days until I can start with this issue and take a look at the patches. Please be patient. Thanks Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 User kendy changed the following: What|Old value |New value Attachment is patch| |Created an attachment | |(id=35166) Additional | |patch to the previous one | |to solve the DateTime | |problems for good... --- Additional comments from [EMAIL PROTECTED] Thu Mar 23 04:15:49 -0800 2006 --- Created an attachment (id=35166) Additional patch to the previous one to solve the DateTime problems for good... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 User kendy changed the following: What|Old value |New value Attachment data| |Created an attachment | |(id=35165) Additional | |patch to the previous one | |to solve the DateTime | |problems for good... --- Additional comments from [EMAIL PROTECTED] Thu Mar 23 04:15:31 -0800 2006 --- Created an attachment (id=35165) Additional patch to the previous one to solve the DateTime problems for good... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 --- Additional comments from [EMAIL PROTECTED] Wed Mar 22 07:29:07 -0800 2006 --- er: Eike, please is it OK for you as well? ;-) Scheduling for commit to sixtyfour04... - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 User mhu changed the following: What|Old value |New value Assigned to|hro |kendy --- Additional comments from [EMAIL PROTECTED] Mon Jan 16 02:42:55 -0800 2006 --- Hi Jan, Pavel, I've now (quickly) reviewed the attached patch, but also don't know of a test to verify it. Someone would need to lookup places where the using classes (e.g. sd's PropItem) are itself used, and than see whether a test exists. OTOH, as the patch only factors out duplicate code from 'sfx2' and 'sd' (afaics), and moves it into class DateTime, I don't really see a problem with this patch => approved. As usual, please integrate into a cws of your choice. If there are still doubts whether this datetime crunching is correct at all, please ask Eike ([EMAIL PROTECTED]) for an additional review. HTH, Matthias - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 --- Additional comments from [EMAIL PROTECTED] Sun Jan 15 12:02:43 -0800 2006 --- Matthias: can you please look at it or assign to other developer for review? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[util-issues] [Issue 59407] 64bit: tools, sfx2, sd: B igInt -> sal_Int64 for DateTime handling
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=59407 User kendy changed the following: What|Old value |New value Attachment is patch| |Created an attachment | |(id=32464) The patch. --- Additional comments from [EMAIL PROTECTED] Thu Dec 15 08:49:01 -0800 2005 --- Created an attachment (id=32464) The patch. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
