Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-22 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/#review14981
---


This review has been submitted with commit 
92fe9ac171b9920ba65adf244c7dbe23d694d209 by Matěj Laitl to branch master.

- Commit Hook


On June 11, 2012, 3:14 p.m., Matěj Laitl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105221/
 ---
 
 (Updated June 11, 2012, 3:14 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 MediaDeviceCache: remove polling, solid events should suffice
 
 This fixes a bug where Amarok (very probably needlessly) polls solid
 for all devices every single second (!!!) just to detect whether some
 unmounted paths become mounted or vice versa. This should not be needed
 at all, solid should notify us about everything.
 
 However, I am not sure, so this is definitely not a material for 2.6
 final but rather 2.7 if no problems show up.
 
 BUG: 289462
 FIXED-IN: 2.7
 REVIEW: 105221
 
 
 This addresses bug 289462.
 https://bugs.kde.org/show_bug.cgi?id=289462
 
 
 Diffs
 -
 
   src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52 
   src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991 
 
 Diff: http://git.reviewboard.kde.org/r/105221/diff/
 
 
 Testing
 ---
 
 little
 
 
 Thanks,
 
 Matěj Laitl
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-21 Thread Matěj Laitl 


 On June 21, 2012, 10:27 p.m., Mark Gaiser wrote:
  Has this been shipped? Just asking since the review is beginning to get 
  somewhat old by now.

Not yet, we're waiting for feedback on the bug and for 2.6 to get released - 
this is too dangerous without long testing.


- Matěj


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/#review14972
---


On June 11, 2012, 3:14 p.m., Matěj Laitl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105221/
 ---
 
 (Updated June 11, 2012, 3:14 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 MediaDeviceCache: remove polling, solid events should suffice
 
 This fixes a bug where Amarok (very probably needlessly) polls solid
 for all devices every single second (!!!) just to detect whether some
 unmounted paths become mounted or vice versa. This should not be needed
 at all, solid should notify us about everything.
 
 However, I am not sure, so this is definitely not a material for 2.6
 final but rather 2.7 if no problems show up.
 
 BUG: 289462
 FIXED-IN: 2.7
 REVIEW: 105221
 
 
 This addresses bug 289462.
 https://bugs.kde.org/show_bug.cgi?id=289462
 
 
 Diffs
 -
 
   src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52 
   src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991 
 
 Diff: http://git.reviewboard.kde.org/r/105221/diff/
 
 
 Testing
 ---
 
 little
 
 
 Thanks,
 
 Matěj Laitl
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-21 Thread Matěj Laitl 


 On June 21, 2012, 10:27 p.m., Mark Gaiser wrote:
  Has this been shipped? Just asking since the review is beginning to get 
  somewhat old by now.
 
 Matěj Laitl wrote:
 Not yet, we're waiting for feedback on the bug and for 2.6 to get 
 released - this is too dangerous without long testing.

In theory, it could make it into 2.6 if enough people test, se my previous 
comments.


- Matěj


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/#review14972
---


On June 11, 2012, 3:14 p.m., Matěj Laitl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105221/
 ---
 
 (Updated June 11, 2012, 3:14 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 MediaDeviceCache: remove polling, solid events should suffice
 
 This fixes a bug where Amarok (very probably needlessly) polls solid
 for all devices every single second (!!!) just to detect whether some
 unmounted paths become mounted or vice versa. This should not be needed
 at all, solid should notify us about everything.
 
 However, I am not sure, so this is definitely not a material for 2.6
 final but rather 2.7 if no problems show up.
 
 BUG: 289462
 FIXED-IN: 2.7
 REVIEW: 105221
 
 
 This addresses bug 289462.
 https://bugs.kde.org/show_bug.cgi?id=289462
 
 
 Diffs
 -
 
   src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52 
   src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991 
 
 Diff: http://git.reviewboard.kde.org/r/105221/diff/
 
 
 Testing
 ---
 
 little
 
 
 Thanks,
 
 Matěj Laitl
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-21 Thread Mark Gaiser 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/#review14972
---


Has this been shipped? Just asking since the review is beginning to get 
somewhat old by now.

- Mark Gaiser


On June 11, 2012, 3:14 p.m., Matěj Laitl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105221/
 ---
 
 (Updated June 11, 2012, 3:14 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 MediaDeviceCache: remove polling, solid events should suffice
 
 This fixes a bug where Amarok (very probably needlessly) polls solid
 for all devices every single second (!!!) just to detect whether some
 unmounted paths become mounted or vice versa. This should not be needed
 at all, solid should notify us about everything.
 
 However, I am not sure, so this is definitely not a material for 2.6
 final but rather 2.7 if no problems show up.
 
 BUG: 289462
 FIXED-IN: 2.7
 REVIEW: 105221
 
 
 This addresses bug 289462.
 https://bugs.kde.org/show_bug.cgi?id=289462
 
 
 Diffs
 -
 
   src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52 
   src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991 
 
 Diff: http://git.reviewboard.kde.org/r/105221/diff/
 
 
 Testing
 ---
 
 little
 
 
 Thanks,
 
 Matěj Laitl
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-11 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/#review14622
---

Ship it!


Testing done: mounted an external HDD via Plasma's Device Notifier.  This made 
an item corresponding to it appear in the Local Music pane of Amarok.  
Unmounting it by the same method made it go away again.

- Alex Merry


On June 11, 2012, 3:14 p.m., Matěj Laitl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105221/
 ---
 
 (Updated June 11, 2012, 3:14 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 MediaDeviceCache: remove polling, solid events should suffice
 
 This fixes a bug where Amarok (very probably needlessly) polls solid
 for all devices every single second (!!!) just to detect whether some
 unmounted paths become mounted or vice versa. This should not be needed
 at all, solid should notify us about everything.
 
 However, I am not sure, so this is definitely not a material for 2.6
 final but rather 2.7 if no problems show up.
 
 BUG: 289462
 FIXED-IN: 2.7
 REVIEW: 105221
 
 
 This addresses bug 289462.
 https://bugs.kde.org/show_bug.cgi?id=289462
 
 
 Diffs
 -
 
   src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52 
   src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991 
 
 Diff: http://git.reviewboard.kde.org/r/105221/diff/
 
 
 Testing
 ---
 
 little
 
 
 Thanks,
 
 Matěj Laitl
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: MediaDeviceCache: remove polling, solid events should suffice

2012-06-11 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105221/#review14624
---


From the code:
297 if ((*it)-mountType() == nfs || (*it)-mountType() == nfs4 
|| 
298 (*it)-mountType() == smb || (*it)-mountType() == 
cifs) {(...)

This was supposedly just for the network filesystems. Can anybody test with a 
collection folder on one of those network fs's? With positive results, we could 
even push to 2.6 final.

- Matěj Laitl


On June 11, 2012, 3:14 p.m., Matěj Laitl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105221/
 ---
 
 (Updated June 11, 2012, 3:14 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 MediaDeviceCache: remove polling, solid events should suffice
 
 This fixes a bug where Amarok (very probably needlessly) polls solid
 for all devices every single second (!!!) just to detect whether some
 unmounted paths become mounted or vice versa. This should not be needed
 at all, solid should notify us about everything.
 
 However, I am not sure, so this is definitely not a material for 2.6
 final but rather 2.7 if no problems show up.
 
 BUG: 289462
 FIXED-IN: 2.7
 REVIEW: 105221
 
 
 This addresses bug 289462.
 https://bugs.kde.org/show_bug.cgi?id=289462
 
 
 Diffs
 -
 
   src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52 
   src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991 
 
 Diff: http://git.reviewboard.kde.org/r/105221/diff/
 
 
 Testing
 ---
 
 little
 
 
 Thanks,
 
 Matěj Laitl
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel